[{"id":3681578,"web_url":"http://patchwork.ozlabs.org/comment/3681578/","msgid":"<8397646A-F442-4BEB-A414-D329EF0FC2DF@unpredictable.fr>","list_archive_url":null,"date":"2026-04-23T17:09:02","subject":"Re: [PATCH 10/16] target/arm: Use generic hwaccel_enabled() to check\n 'host' cpu type","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"content":"> On 23. Apr 2026, at 19:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:\n> \n> We should be able to use the 'host' CPU with any hardware accelerator.\n> \n> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>\n> ---\n> target/arm/arm-qmp-cmds.c | 5 +++--\n> target/arm/cpu.c          | 5 +++--\n> 2 files changed, 6 insertions(+), 4 deletions(-)\n> \n[…]\n> diff --git a/target/arm/cpu.c b/target/arm/cpu.c\n> index ccc47c8a9ad..4f98121be0b 100644\n> --- a/target/arm/cpu.c\n> +++ b/target/arm/cpu.c\n> @@ -1629,8 +1629,9 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)\n>      * this is the first point where we can report it.\n>      */\n>     if (cpu->host_cpu_probe_failed) {\n> -        if (!kvm_enabled() && !hvf_enabled() && !whpx_enabled()) {\n> -            error_setg(errp, \"The 'host' CPU type can only be used with KVM, HVF or WHPX\");\n> +        if (!hwaccel_enabled()) {\n> +            error_setg(errp, \"The 'host' CPU type can only be used with \"\n> +                             \"hardware accelator such KVM/HVF/WHPX”);\naccelerator such as\n\n>         } else {\n>             error_setg(errp, \"Failed to retrieve host CPU features\");\n>         }\n> -- \n> 2.53.0\n> \n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=f5haz+dJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1jLl5JZVz1yDD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 03:11:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFxa5-0000kn-NH; Thu, 23 Apr 2026 13:11:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFxZs-0000jO-GC\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:11:00 -0400","from qs-2001a-snip4-8.eps.apple.com ([57.103.87.11]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFxZr-0000jw-1e\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:11:00 -0400","from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-0 (Postfix) with ESMTPS id\n 93AAA18752A7; Thu, 23 Apr 2026 17:10:57 +0000 (UTC)","from smtpclient.apple (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-0 (Postfix) with ESMTPSA id\n 2940C18747F9; Thu, 23 Apr 2026 17:09:15 +0000 (UTC)"],"X-ICL-Out-Info":"\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJA01fDl4fBBdGGVUERx5dVkIeGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVAAFQAXQZGeFV1WQNZH0R7PXFAdl8DRBQ8AF8OLnRAfzsBKXErRx5JClYJXghGEVsUVkNRGQxQTQFDCAoIRwNNF14yUwRfEVAW","Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776964258; x=1779556258;\n bh=HL1h/PxzAsbYksx2lRRPNSACLWEE9R23VAT67j2+jro=;\n h=Content-Type:Mime-Version:Subject:From:Date:Message-Id:To:x-icloud-hme;\n b=f5haz+dJFgu3MtF4k8Y9gZvlpKfszTwh/n/xhlw4e4Kh68HBqnHmPNhn0qOueNm4Dsi5PPw+QtkpAfkZ0X/Aa//lPFpZdFaYUERnO60KTQqRA7l6IM9iGyLOJg195eg6+IeD+QQ/pcLW/U5NkidB6iUN9GHcOsn3Jfo8nG4yHxfj6+Cs27mseZhvclD6vSzhCP0dtrwmoDI7ATJU0b3dB2Rx8sVX4apz1nSjmDSqkdp4AOITWxWBqA0e1ADvy664KLaszzPQJYHSj6u0mvAhcco5UhU7ZJDpWbkQqeCWsNuhzm0OXH5I18zNimmMmSur1IY17SnkIMa2vSZvCX7aKQ==","mail-alias-created-date":"1752046281608","Content-Type":"text/plain;\n\tcharset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH 10/16] target/arm: Use generic hwaccel_enabled() to check\n 'host' cpu type","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","In-Reply-To":"<20260423170229.64655-11-philmd@linaro.org>","Date":"Thu, 23 Apr 2026 19:09:02 +0200","Cc":"qemu-devel@nongnu.org, Roman Bolshakov <rbolshakov@ddn.com>,\n Jonathan Cameron <jonathan.cameron@huawei.com>,\n Mads Ynddal <mads@ynddal.dk>, qemu-arm@nongnu.org,\n Peter Maydell <peter.maydell@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@csgraf.de>","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<8397646A-F442-4BEB-A414-D329EF0FC2DF@unpredictable.fr>","References":"<20260423170229.64655-1-philmd@linaro.org>\n <20260423170229.64655-11-philmd@linaro.org>","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","X-Mailer":"Apple Mail (2.3864.500.181)","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDE3MCBTYWx0ZWRfX73EsA7XU3Y2O\n +aZk7bjoZbU6l0ZVeyc3dkgj23L+eaqBebHog45z6qgk4pjjqeq/BpaHenyn6PPG9ffLLu1AJzp\n RfGGRh0XMhGppV4Dl6r0JUqqTon42d1YTqfIOBymAWeXQN364aQldl4BBbIvNx6QLrIbJ5PLKae\n xlsNAyfe/OMtS+W35Kk+AaAm/YBYUz6SmEc0oGxKBzJVBHbEGj69sWeb+KemAsfR50DWqWVe9Dv\n T8X5HeUq8EtbSS4ayz9MhhWsyIEul0NccbmEQQ2JyLiRdYWrluId6nqkc8/NbalFEghzCLkHKN/\n ukIgcymZ0yWJXntJ5ggIpQZ0QSXBUfGnMUIBzHBDF+s+hz1maB4ZkiFexM7gno=","X-Authority-Info-Out":"v=2.4 cv=Dbcaa/tW c=1 sm=1 tr=0 ts=69ea52a1\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=c9H9iVsSBL8j0jD_ca4A:9\n a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-GUID":"wXGSCDe0c4Df88tLz5Q_EoVJLpRDn_Zd","X-Proofpoint-ORIG-GUID":"wXGSCDe0c4Df88tLz5Q_EoVJLpRDn_Zd","Received-SPF":"pass client-ip=57.103.87.11;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]