[{"id":3681575,"web_url":"http://patchwork.ozlabs.org/comment/3681575/","msgid":"","list_archive_url":null,"date":"2026-04-23T17:05:27","subject":"Re: [PATCH 08/16] accel/hvf: Enforce host alignment when calling\n hv_vm_protect()","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"content":"> On 23. Apr 2026, at 19:02, Philippe Mathieu-Daudé wrote:\n> \n> Suggested-by: Richard Henderson \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> accel/hvf/hvf-all.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c\n> index 5f357c6d198..82cb3717750 100644\n> --- a/accel/hvf/hvf-all.c\n> +++ b/accel/hvf/hvf-all.c\n> @@ -56,6 +56,8 @@ static void do_hv_vm_protect(hwaddr start, size_t size,\n> intptr_t page_mask = qemu_real_host_page_mask();\n> hv_return_t ret;\n> \n> + start &= qemu_real_host_page_mask();\n> + size = REAL_HOST_PAGE_ALIGN(size);\n\nHi,\n\nI think the patches to support 4K IPAs (which are already\nout there) should go first and then an adaptation of this\nwith that in mind afterwards.\n\nWith HVF 4KB page size IPAs are supported so the check in\nthis form would have to be altered anyways when that gets\nmerged so...","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=fTwyBzC7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1jFj2Gd0z1y2d\n\tfor ; Fri, 24 Apr 2026 03:07:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFxWU-00089V-DM; Thu, 23 Apr 2026 13:07:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFxWR-00088k-AQ\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:07:27 -0400","from qs-2005i-snip4-8.eps.apple.com ([57.103.86.219]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFxWP-0007aQ-Gi\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:07:27 -0400","from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-10-percent-0 (Postfix) with ESMTPS id\n 795543001520; Thu, 23 Apr 2026 17:07:21 +0000 (UTC)","from smtpclient.apple (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-10-percent-0 (Postfix) with ESMTPSA id\n 43E4730013A3; Thu, 23 Apr 2026 17:05:40 +0000 (UTC)"],"X-ICL-Out-Info":"\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAk1fDl4fBBdGGVUERx5dVkIeGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQU6di4AUgZEeFVxWg8qH0R9PXBAdlkLSBQ+AytyKnFIf0kBXgMrRx5JClYJXghGEVsUVkNRGQxQTQFDCAoIRwNNF14yUwRfEVAW","Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776964044; x=1779556044;\n bh=S08Un2xA+itCNP7vCYVQ0sfBYmjC8fvQ1G2P6f8f0r0=;\n h=Content-Type:Mime-Version:Subject:From:Date:Message-Id:To:x-icloud-hme;\n b=fTwyBzC7xEcuOxfbJh0yZLo6c6HzF1Z45LcY9nGGxkYOxVtDMWpRKjLOP3KlUL5QkG83eHIzczQU459CaX+Q4smA9HCmX976iL9dJ6YgiWWIqx3YAC95mJJx5/5gg0GVwwaajJAFCm2JifDezweCtqfsjKn6VD0ys1iHJklOE4+MuUMhDdx84rdZwbbZTNG3wkhlZZxORQTq1lryIh3VTFQi8GSFVhS6vvWKtKbRfxxD4a/n4gT0MPrO6fGc0/3gOmY3JhWdglWiyhNa3TE1OJ0F+42zDsepQoSr86To3FXLaUCjxN47tnoDpR3H+5Z+fRUWhGChIB3711/82Qn7oA==","mail-alias-created-date":"1752046281608","Content-Type":"text/plain;\n\tcharset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH 08/16] accel/hvf: Enforce host alignment when calling\n hv_vm_protect()","From":"Mohamed Mediouni ","In-Reply-To":"<20260423170229.64655-9-philmd@linaro.org>","Date":"Thu, 23 Apr 2026 19:05:27 +0200","Cc":"qemu-devel@nongnu.org, Roman Bolshakov ,\n Jonathan Cameron ,\n Mads Ynddal , qemu-arm@nongnu.org,\n Peter Maydell ,\n Richard Henderson ,\n Paolo Bonzini , Alexander Graf ,\n Phil Dennis-Jordan ","Content-Transfer-Encoding":"quoted-printable","Message-Id":"","References":"<20260423170229.64655-1-philmd@linaro.org>\n <20260423170229.64655-9-philmd@linaro.org>","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Mailer":"Apple Mail (2.3864.500.181)","X-Proofpoint-ORIG-GUID":"DaUHq3QovYBVZaE-EkqrzOCPdyohTogM","X-Proofpoint-GUID":"DaUHq3QovYBVZaE-EkqrzOCPdyohTogM","X-Authority-Info-Out":"v=2.4 cv=OvNCCi/t c=1 sm=1 tr=0 ts=69ea51ca\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=9vKZ5dOS0OzRSC8b9IcA:9\n a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDE2OSBTYWx0ZWRfXzXYYZpv52cCZ\n kLRMMHfHwVDhWJ4ln0qi3js353IRcYyw8tyY+pqCrF7OfR1DcumO7c44KcgzFIvlyXgpTrXpg2X\n Bq2EPoHQL3b2vGgP1jiokEXBqbStlYh78DUX+Z63YlklxipM5UkD2LfwJEjWiH3gdZ8nprRB5LQ\n 9Hv0AHLLJLcCJhpTmPm6lMIsa1XpCr2e1PxHPftP09bTkf+CvMByXXgh5eBKxxXeFAzHOJnCsf6\n gR1HDz3UbihuvZIuBuKu8oBgF2XTe22d9/1G3a34iG3s7pew4f2K3k6o6qcNmls7XegVFy/qkIh\n VNi2XqzytTjlIDq3wh4cWYLAOu8Kvy0d0Mx9iefyLakS0Rf6/rOCLxNALmwwsg=","Received-SPF":"pass client-ip=57.103.86.219;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681701,"web_url":"http://patchwork.ozlabs.org/comment/3681701/","msgid":"<0f4e46f8-ab06-4d1c-bfe6-6ba89a94ee60@linaro.org>","list_archive_url":null,"date":"2026-04-23T22:34:47","subject":"Re: [PATCH 08/16] accel/hvf: Enforce host alignment when calling\n hv_vm_protect()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/24/26 03:02, Philippe Mathieu-Daudé wrote:\n> Suggested-by: Richard Henderson \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> accel/hvf/hvf-all.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c\n> index 5f357c6d198..82cb3717750 100644\n> --- a/accel/hvf/hvf-all.c\n> +++ b/accel/hvf/hvf-all.c\n> @@ -56,6 +56,8 @@ static void do_hv_vm_protect(hwaddr start, size_t size,\n> intptr_t page_mask = qemu_real_host_page_mask();\n> hv_return_t ret;\n> \n> + start &= qemu_real_host_page_mask();\n> + size = REAL_HOST_PAGE_ALIGN(size);\n\nWe have read the page mask into a local variable.\nUse that instead of reading it twice more.\n\nAlso, the existing uses of page_mask are to assert what you're now enforcing. So, you can \nremove those asserts.\n\nr~\n\n> trace_hvf_vm_protect(start, size, flags,\n> flags & HV_MEMORY_READ ? 'R' : '-',\n> flags & HV_MEMORY_WRITE ? 'W' : '-',","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hMrFuwZO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1rX86GKlz1y2d\n\tfor ; Fri, 24 Apr 2026 08:35:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wG2dX-0001Oh-5J; Thu, 23 Apr 2026 18:35:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG2dT-0001NS-Ao\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 18:35:03 -0400","from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wG2dQ-0004ar-AM\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 18:35:02 -0400","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-2aae146b604so48388435ad.3\n for ; Thu, 23 Apr 2026 15:34:59 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fa9ff729sm255218135ad.15.2026.04.23.15.34.52\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 15:34:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776983699; x=1777588499; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=6NiFZcaqLf5kzrt3369joPX9QrLDlvn7xZaRpzE+u9I=;\n b=hMrFuwZOy2AkwKO8L1sHIpguFIYchIuLLhOVcYk6OSWVAfyEdgX2CJjLkmSw+0GPDC\n W8uPWM17vADyA4b2i1b/RI1QIyr+ofP1ih9GHnub9B4gbZxKKAbIv7M77vIwREpkACck\n tAhdQetNeuhI8cEGW3iuJNY7Eir/MerBZUtpy6vM8GNN6jqYmTC1uT1eWPywR9WM6U2G\n kAfI1pUnK38n1SVVAbQ+XVrLB2D5dRaIxOTs8Bby9nKfmYYchUJarjc6wuLeq01JD2RF\n HUXPQmD3D5YmyG8j3OCRIeQmQZ+gbCQxwuuGwct1vnUVvQwbSGQxONdJCsNQmp1sNqQc\n xtIA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776983699; x=1777588499;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=6NiFZcaqLf5kzrt3369joPX9QrLDlvn7xZaRpzE+u9I=;\n b=GtenOdzdihXz1mrn4gO8dJjNWIuQC9DpfRYFmBk8qM/gORcHvDLF3/JeN1B3oE/RKr\n lBWTYd4qaz87r8ZPPT4q101CwpbkBXGX3wgoncFfuBZnPYIBCbVgdZtQcMMXUs8myImZ\n 2L2uh3mLIdxBWzFSt9vBJONjByyp5wwiaF/JLuexzGNiTj/Tvi7eYw0LCGrT5tyzvOMS\n QW+WhMjbos1pzHMqPKR7pPXWFi7ruJmYVv3GM1lkvSw3hEmedOIwIugJ01uTIo3f+2i4\n L8DBe/TXar+xiyKFu+kEi2s7R2J34jnIQ5rzL6Iv8ZGAbFcClzuNea8b9T2AMbzvqgnH\n 2egg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ99ce2yOKG4widP42dpo724A1k0G9VgMAsp/Mty+SS5WMdAySI48YB4T6qOuFe6bCov9F05fUFHnMs4@nongnu.org","X-Gm-Message-State":"AOJu0Yye0/oBB2buxdzAjN0hxMw1+yCFkMfj3ko/Qk5qzCWlE8h7kKwD\n 3hvYg724P8sJgNreYp1SfNFg3PvSXnHnYtVqZ7hi2WVO8zuQRkvnR0zkt00BwbTn8AQ=","X-Gm-Gg":"AeBDiesGsZXywbJj8x0w4KJmJiNuQDAyO0Og7bbfqmHBfel1jQ6b4R7WiekrJzvRKBq\n ZxSnff+TguyYgB3BKZRvQMT/mPJ+OlsE3qgga+Z5qdCtqz49YPcOzW28o85RA+9np32u/4j1YAW\n obY9igjCVZCEyJrIJ0IrFzWO3Vu6419y5mBK+bFqdVtu2flpV65mm/Z/ZqeC4pKI0zLkcwCyAHW\n G78IIiPHbGj04umc65SfZDA4+CQQPiJv6g+0DAHyXu3rPO6uoAlJNb3I2ku6uFPSj3mfgcHc3jf\n Re3CWEYmbdYUFgugpoKi7bfpJk2rUScvmmRe2jto5wtLRkmbk+32irbtTckaAb/Kf8nxazn9p2A\n 5ePY8vwli6rV7n7sa8m26N9WFBWX2PF4bz+6xe7cpMFMzDIqKvojzjnorQCfdciFch4OxHaVoQG\n K//PvrY1JhgzHiwqMq11rEAC4O9PP37QSZ+VXdJchKDCweqZbQQA==","X-Received":"by 2002:a17:902:ce0c:b0:2b7:88f9:9c3d with SMTP id\n d9443c01a7336-2b788f9a2bcmr148120205ad.12.1776983698546;\n Thu, 23 Apr 2026 15:34:58 -0700 (PDT)","Message-ID":"<0f4e46f8-ab06-4d1c-bfe6-6ba89a94ee60@linaro.org>","Date":"Fri, 24 Apr 2026 08:34:47 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 08/16] accel/hvf: Enforce host alignment when calling\n hv_vm_protect()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Roman Bolshakov ,\n Jonathan Cameron , Mads Ynddal\n , qemu-arm@nongnu.org,\n Mohamed Mediouni ,\n Peter Maydell , Paolo Bonzini\n , Alexander Graf ,\n Phil Dennis-Jordan ","References":"<20260423170229.64655-1-philmd@linaro.org>\n <20260423170229.64655-9-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423170229.64655-9-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]