[{"id":3681699,"web_url":"http://patchwork.ozlabs.org/comment/3681699/","msgid":"","list_archive_url":null,"date":"2026-04-23T22:29:52","subject":"Re: [PATCH 05/16] hw/core/cpu: Expose CPUState::start_powered_off\n docstring","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/24/26 03:02, Philippe Mathieu-Daudé wrote:\n> The comment about @start_powered_off is buried within the\n> CPUState structure. Hoist it to the structure docstring\n> comment.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/hw/core/cpu.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h\n> index 04e1f970caf..bc719d51b3a 100644\n> --- a/include/hw/core/cpu.h\n> +++ b/include/hw/core/cpu.h\n> @@ -419,6 +419,7 @@ struct qemu_work_item;\n> * QOM parent.\n> * Under TCG this value is propagated to @tcg_cflags.\n> * See TranslationBlock::TCG CF_CLUSTER_MASK.\n> + * @start_powered_off: Indicates whether the CPU starts in powered-off state.\n> * @tcg_cflags: Pre-computed cflags for this cpu.\n> * @nr_threads: Number of threads within this CPU core.\n> * @thread: Host thread details, only live once @created is #true\n> @@ -502,7 +503,6 @@ struct CPUState {\n> bool stop;\n> bool stopped;\n> \n> - /* Should CPU start in powered-off state? */\n> bool start_powered_off;\n> \n> bool unplug;\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hNaP5KqY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1rQD64rbz1yDD\n\tfor ; Fri, 24 Apr 2026 08:30:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wG2Yj-0007q6-4x; Thu, 23 Apr 2026 18:30:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG2Yh-0007pJ-KB\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 18:30:07 -0400","from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wG2Ye-0002lu-DX\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 18:30:07 -0400","by mail-pl1-x62b.google.com with SMTP id\n d9443c01a7336-2b0afa0210bso33220695ad.2\n for ; Thu, 23 Apr 2026 15:30:03 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5faa3073asm195590255ad.27.2026.04.23.15.29.55\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 15:30:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776983402; x=1777588202; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=a9yf2bdZlrlEqK426BBr4P79p8ux3CYHJhDpa7YxTZA=;\n b=hNaP5KqY0wK/XT1OdSR3f0heZqHt3uaqBSe1gUEOArYggL06gCW+obRihX57ZCEePf\n fhWksnX2HLGSumwwEXjM5HPih+YvM7MSvzVQV0QRdeyx0ltCAUDZ5prxLFIen2lqEWwx\n 3r1oQlQMtZIuTVeYtyqFct7ImmROD2Rw5NDWZcQjvyw0CYWVKXFNPQMIXAmiB1pa5ysS\n eOk7/tczri6aWCbAa6UCf4icjVnvK31hvwelXYWoV2+I9bZysDQZTHhAiQMHAnqgFg0D\n O4dW2CmdKwmPu3oRs+gDWWwsp1ZsxYy7KulylDhPlUS23fy5i2v9j04mFMIUWvtCY5Pq\n 1h+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776983402; x=1777588202;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=a9yf2bdZlrlEqK426BBr4P79p8ux3CYHJhDpa7YxTZA=;\n b=dlSrWR68wMogjWjc5wPiyK6h0ksgJ8VMuFzbC68gA8sTXDxuvV/N4aXcKBQeN0DhNv\n /FUiYzHPWRbmfrpvi0F4lrnKBw5aL5MGFGTF0rYDo6FZXid5b3XvVkr4CWd5qF99GDW8\n c+TdBdQpoo9tMbD/jWd2AEIxsQB2MxexAkjvqOfoUCpBHQgmfDkezWZQ/VMzO8SAQPOc\n 0p25LU1fZ8qZ5obFZL0Eeaka4a9ghHuFqlwKQaGN4q+ArRSQKvPx08fb84yD1pbOo0du\n 7OTLtWCNq8q71Rv3z7gxtTFg+dYre1a+Hiw5HCDZDy+RVj17biedd5DKHE1MFGUBqfBg\n X1Nw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9qR9CpAhhZDtMOzxILCuR3chIBKq62xeurKEYx0/lHgkSM+ZlMbZ9EhJsHXWSeCc1n8HgRF4SPK0jx@nongnu.org","X-Gm-Message-State":"AOJu0YzbCbFO5OYU46uwywJbiu8VMuKzWFfXfVz6tk2bhRop6YjQgY9y\n sPE7JdoSaHAsya03NFG+qRY0dEimxBjED3ZTMwM3w3qLFhJBQdn8pgYTekAD6wRmsHQ=","X-Gm-Gg":"AeBDietKqZKMbLtV4WW9jarrpQDtDkZ4TlrgRisKdMTJlTiEmgBDuyppN6GaoEFIG0Y\n +cm1hz3R49AiptL9n8x+uUpIj7YLUI/TzbWt/dwsZi5fC1VhM0JSxU8V9YWKWEVs6TZWabiK1Xt\n ZCt7SVkaEUk+mRIezD7h7nEvJvnqADnbgcrjwvlQqGZ9wOhAoMWWvdw9w16GsLhQgnE/Khfhj5H\n wnoSdezPSu8bcsuUvkgf3G/NbEk50aH1XvacmGmAe7Jgp+W5Dj/5i2E0QGrFBwVBW283qugK5rV\n OyAUqCWPHQilYOGozpc0g5dcElsG/S1w0fZoDAbSsmS+rLh86caUk5wXNwLoJpcAElFmR+DAUlW\n GvGnKtgUSnBPgvb+XKU2UJQdcYBlVdCJvZZyfxk+irpGnJRu2hECee16zdzq9TjBsyjKmjgov8F\n P3mfHc/7zlcgkESZN49QH0pweokWwgRw4AjJJf0fPvIyq/VHtxtw==","X-Received":"by 2002:a17:903:2ac4:b0:2b0:41bf:ca83 with SMTP id\n d9443c01a7336-2b5f9f3c616mr298137805ad.23.1776983402197;\n Thu, 23 Apr 2026 15:30:02 -0700 (PDT)","Message-ID":"","Date":"Fri, 24 Apr 2026 08:29:52 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 05/16] hw/core/cpu: Expose CPUState::start_powered_off\n docstring","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Roman Bolshakov ,\n Jonathan Cameron , Mads Ynddal\n , qemu-arm@nongnu.org,\n Mohamed Mediouni ,\n Peter Maydell , Paolo Bonzini\n , Alexander Graf ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ","References":"<20260423170229.64655-1-philmd@linaro.org>\n <20260423170229.64655-6-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423170229.64655-6-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62b;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]