[{"id":3681540,"web_url":"http://patchwork.ozlabs.org/comment/3681540/","msgid":"<c7960fa3-4f8c-43a6-83af-406affbb83ac@linux.ibm.com>","list_archive_url":null,"date":"2026-04-23T15:37:47","subject":"Re: [PATCH 8/9] target/s390x: Compile crypto_helper.c as common unit","submitter":{"id":74525,"url":"http://patchwork.ozlabs.org/api/people/74525/","name":"Ilya Leoshkevich","email":"iii@linux.ibm.com"},"content":"On 4/23/26 14:50, Philippe Mathieu-Daudé wrote:\n> In order do build crypto_helper.c as a common unit we need to\n> replace:\n>\n>    \"accel/tcg/cpu-ldst.h\" -> \"accel/tcg/cpu-ldst-common.h\"\n>\n> and update the cpu_ld/st_be_data_ra() API by cpu_ld/st_mmu() one.\n>\n> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n> ---\n>   target/s390x/tcg/crypto_helper.c | 39 +++++++++++++++++---------------\n>   target/s390x/tcg/meson.build     |  2 +-\n>   2 files changed, 22 insertions(+), 19 deletions(-)\nReviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=OJxdyARa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1gH53YQ5z1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 01:38:39 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFw7x-0003Ij-8R; Thu, 23 Apr 2026 11:38:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <iii@linux.ibm.com>)\n id 1wFw7r-0003Hl-1y; Thu, 23 Apr 2026 11:37:59 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <iii@linux.ibm.com>)\n id 1wFw7p-0001ue-0u; Thu, 23 Apr 2026 11:37:58 -0400","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63N8Z7283229299; Thu, 23 Apr 2026 15:37:53 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dpeu29e8u-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 15:37:52 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63NFZXN1015230;\n Thu, 23 Apr 2026 15:37:52 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dpjky766h-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 15:37:51 +0000 (GMT)","from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com\n [10.20.54.104])\n by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63NFbmdd52101476\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 23 Apr 2026 15:37:48 GMT","from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 398362004B;\n Thu, 23 Apr 2026 15:37:48 +0000 (GMT)","from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id B101920043;\n Thu, 23 Apr 2026 15:37:47 +0000 (GMT)","from [0.0.0.0] (unknown [9.111.71.73])\n by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 23 Apr 2026 15:37:47 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=7aOC7E\n qbRfzv2Dj8iv3tcTu8cX0Ghev2v7UH7/oKvCI=; b=OJxdyARaID0X+eCPWT4wMN\n OBcebbqPt8C6kTQwYlQFvY8Tl80zOY8U7Wy1GacFNwJIJoxrlHCgEi2//pQ8f4Y+\n IGBfMXUlm0cvWkIyud4YoLlPdB9AxkkPdhA+HP3aLoD711tmm0T/HHUxb7Z9G5l7\n SJ1tZTI61dqz6Y1SdW7uz7Y2W7iXiBtUJD/+6Ld2yXDXkNl3ItdacAa0QalqCKN4\n sskrolV2BR2cMPznajYGcbMhxdW4II3gxLfvn2U1ucXQTfkG+783GfqmFFdt86ep\n 3pFcXeeVqMLStxTeJ2YBTVhDuloowK2ORsJeJvIlsJQGMhUGQbfkVUfwPFfwptrA\n ==","Message-ID":"<c7960fa3-4f8c-43a6-83af-406affbb83ac@linux.ibm.com>","Date":"Thu, 23 Apr 2026 17:37:47 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 8/9] target/s390x: Compile crypto_helper.c as common unit","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n qemu-devel@nongnu.org","Cc":"Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n qemu-s390x@nongnu.org, Matthew Rosato <mjrosato@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>,\n Eric Farman <farman@linux.ibm.com>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Anton Johansson <anjo@rev.ng>","References":"<20260423135035.50126-1-philmd@linaro.org>\n <20260423135035.50126-9-philmd@linaro.org>","Content-Language":"en-US","From":"Ilya Leoshkevich <iii@linux.ibm.com>","In-Reply-To":"<20260423135035.50126-9-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-GUID":"e81VvW2t8CsxKMKLbjCHbHrxhqbKJXbI","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDE1MyBTYWx0ZWRfX4nz2howzVewt\n w4DCLeHfHpScjg+EuKLvoDleL82aHUJ6BWlp1j0b/6EqSjzWRlmTqsF5c7TI2BLBMWBjm3YdyH6\n iVAPSJrIjP+Qjp4axR0Ou2uAzlYSs3lo9ZEjre+3+lM7knwDIWJvxc1IRAZ2SJAcSUORFbn7mBZ\n tPWV241il9f8HQ7sk9Ea2HukctM5bGwx4wdoOeHumCpIL0afPyK+xefaR4EVZkVCMmWgXpyqkif\n jThmCj+MzyrrPY1h19tpLCtTLyJpSdNRicRt9THjvZK3WEJE57+OPIbZjNu31uV1WD3um+9jVeL\n f+8MmpTjy+cjgwZ3lz5XtFCk8QNHrAWdzySHt8IUiwqPKDtFkh07+Hb4Xs/xVmyc2ZR/Gb014XV\n wmHpEf7AawFCRyy3AivKYJM8cXpNL8qUwUsXVDbLq+6xyiz5FgzA78YDoRLA1J/Vi3ijjTVpCcC\n SmBjFVjyJaS5pXjUiWg==","X-Authority-Analysis":"v=2.4 cv=C8LZDwP+ c=1 sm=1 tr=0 ts=69ea3cd1 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=KKAkSRfTAAAA:8\n a=VnNF1IyMAAAA:8 a=cpm-LVsFm7EI_RuZZpAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-ORIG-GUID":"e81VvW2t8CsxKMKLbjCHbHrxhqbKJXbI","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 suspectscore=0 priorityscore=1501 malwarescore=0\n lowpriorityscore=0 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0\n phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604230153","Received-SPF":"pass client-ip=148.163.156.1; envelope-from=iii@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]