[{"id":3681510,"web_url":"http://patchwork.ozlabs.org/comment/3681510/","msgid":"<e720de3f-01ca-48f8-a06a-133865bafb0f@linux.ibm.com>","list_archive_url":null,"date":"2026-04-23T14:54:00","subject":"Re: [PATCH 1/9] tcg: Include missing 'tcg/tcg-op-common.h' header in\n 'tcg-op-mem.h'","submitter":{"id":74525,"url":"http://patchwork.ozlabs.org/api/people/74525/","name":"Ilya Leoshkevich","email":"iii@linux.ibm.com"},"content":"On 4/23/26 14:50, Philippe Mathieu-Daudé wrote:\n> \"tcg-op-mem.h\" uses methods declared in \"tcg/tcg-op-common.h\".\n> Include the latter to avoid when including the former:\n>\n>    include/tcg/tcg-op-mem.h:34:5: error: call to undeclared function 'tcg_gen_qemu_ld_i32_chk'\n>     34 |     tcg_gen_qemu_ld_i32_chk(v, tcgv_va_temp(a), i, m, TCG_TYPE_VA);\n>        |     ^\n>\n>    $ git grep -w tcg_gen_qemu_ld_i32_chk\n>    include/tcg/tcg-op-common.h:328:void tcg_gen_qemu_ld_i32_chk(TCGv_i32, TCGTemp *, TCGArg, MemOp, TCGType);\n>    include/tcg/tcg-op-mem.h:35:    tcg_gen_qemu_ld_i32_chk(v, tcgv_va_temp(a), i, m, TCG_TYPE_VA);\n>    tcg/tcg-op-ldst.c:286:void tcg_gen_qemu_ld_i32_chk(TCGv_i32 val, TCGTemp *addr, TCGArg idx,\n>\n> Cc: qemu-stable@nongnu.org\n> Fixes: a8af0fb24da (\"include/tcg/tcg-op: extract memory operations to tcg-op-mem.h\")\n> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n> ---\n>   include/tcg/tcg-op-mem.h | 2 ++\n>   1 file changed, 2 insertions(+)\nReviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=CRFJZfMq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1fJb0Fzrz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 00:54:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFvRs-0005Sw-Sh; Thu, 23 Apr 2026 10:54:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <iii@linux.ibm.com>)\n id 1wFvRT-0005OH-Ox; Thu, 23 Apr 2026 10:54:12 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <iii@linux.ibm.com>)\n id 1wFvRR-0007ty-Dk; Thu, 23 Apr 2026 10:54:11 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63N8Sxp73944125; Thu, 23 Apr 2026 14:54:05 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dpeu3rmk5-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 14:54:05 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63NEoQ9J032509;\n Thu, 23 Apr 2026 14:54:04 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dpjkxy1fn-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 14:54:04 +0000 (GMT)","from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com\n [10.20.54.100])\n by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63NEs1ft52756862\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 23 Apr 2026 14:54:01 GMT","from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0B88F2004B;\n Thu, 23 Apr 2026 14:54:01 +0000 (GMT)","from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 495D520040;\n Thu, 23 Apr 2026 14:54:00 +0000 (GMT)","from [0.0.0.0] (unknown [9.111.71.73])\n by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 23 Apr 2026 14:54:00 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=1w8rPk\n N68Hllhmji8xPINkudHjYhpvkVaAp8UVIsi08=; b=CRFJZfMqWHESBpAI8pZAXk\n 1D+3lGSvWxQh69MYlW4eHHYj1WKCmibA4EwdC+J0SJc/te8kdJJEoaMx6RTn355v\n 3MIGT85YTUkmzlrur8j9Y3WIFvEL3RZwVWj9LSC2KlSPQ4NvSRIm1105DBwhqcLV\n PRds8CUHXlkbZeJv/tP4zt06uESevKat6zR+dRxrZZb8GoquSspTedh4jJ2IUx1A\n Bm8cEcW81mv+RdqTsUNtHAtvXmkvAVs7mhli7yqEPvGUS0QwlNqjDZSZnA1pU9XP\n TTQnngPQ1EUWFaGuoFNDyh5UsBUKjLbhunEKDCCxSjDapuIJ2e/FWNo5qwyWmeZA\n ==","Message-ID":"<e720de3f-01ca-48f8-a06a-133865bafb0f@linux.ibm.com>","Date":"Thu, 23 Apr 2026 16:54:00 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/9] tcg: Include missing 'tcg/tcg-op-common.h' header in\n 'tcg-op-mem.h'","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n qemu-devel@nongnu.org","Cc":"Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n qemu-s390x@nongnu.org, Matthew Rosato <mjrosato@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>,\n Eric Farman <farman@linux.ibm.com>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Anton Johansson <anjo@rev.ng>, qemu-stable@nongnu.org,\n Paolo Bonzini <pbonzini@redhat.com>","References":"<20260423135035.50126-1-philmd@linaro.org>\n <20260423135035.50126-2-philmd@linaro.org>","Content-Language":"en-US","From":"Ilya Leoshkevich <iii@linux.ibm.com>","In-Reply-To":"<20260423135035.50126-2-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-GUID":"NJjCKvjbi-4HwQO70vqccRPVho-RGbNf","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDE0OCBTYWx0ZWRfXy5fSp7ICTlW9\n 2RV0zgqFTFgTRS8QAm+dRp7leb3/sf04VkmeA+VytWLjzMVXYLNWVcL1UDldu3N0Ng4doITJxYh\n 2+a5K5E6pEFiH/PqOOSoFQdu5CHMFqQOuph5JUbknUZk6aLj5ivr00X+Xbn1i58kN2F08q0n+om\n z/Jdhgea/kJnLsHl7Vc2Pc+6QwpQrnRhBiaI496ac8z8xy8qXW+f7INs6TGVwWuINwmNiRXgcWt\n Qo9NB6jR/Sneudre7p+UU1SYhPIZWVM7dMpy9vHLHL0EQ7MuRWBABk3ZtV1gfJllw68jJZMnN4l\n +mtIDWW8957S4SNQM1pXftzQQ5tyDLpyI1cCIBp8gPeutfu0HCcHQUxHWWp0tT79Ze/w+mLTwW/\n If2+RdyG65VUUqAbi7ngxhIHaWtwsFCKWwJ46ii7Pfou6Czt7rfM1FPDn8VLs9BYXzMil/EErvd\n FrH012943QNd+Crh5YA==","X-Authority-Analysis":"v=2.4 cv=a6kAM0SF c=1 sm=1 tr=0 ts=69ea328d cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=69wJf7TsAAAA:8\n a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=oxOZ8elYhvzyzEPtyTMA:9 a=3ZKOabzyN94A:10\n a=QEXdDO2ut3YA:10 a=Fg1AiH1G6rFz08G2ETeA:22 a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-ORIG-GUID":"NJjCKvjbi-4HwQO70vqccRPVho-RGbNf","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0\n lowpriorityscore=0 impostorscore=0 clxscore=1011 phishscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604230148","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]