[{"id":3681473,"web_url":"http://patchwork.ozlabs.org/comment/3681473/","msgid":"<2026042330-recopy-corner-07d9@gregkh>","list_archive_url":null,"date":"2026-04-23T13:40:26","subject":"Re: [PATCH v2 03/13] gpu: host1x: Migrate to generic dma context bus","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg KH","email":"gregkh@linuxfoundation.org"},"content":"On Thu, Apr 23, 2026 at 06:59:32PM +0530, Vishnu Reddy wrote:\n> --- a/include/linux/host1x.h\n> +++ b/include/linux/host1x.h\n> @@ -462,7 +462,7 @@ struct host1x_memory_context {\n> \tstruct pid *owner;\n> \n> \tstruct device_dma_parameters dma_parms;\n> -\tstruct device dev;\n> +\tstruct device *dev;\n\nAh, nice try, but no. You can't use a \"generic\" device for this type of\nthing (i.e. your dma context bus device), as that's not what this device\nreally is. Add the needed logic to the bus this real device lives on,\ndon't try to work around it.\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org\n header.a=rsa-sha256 header.s=korg header.b=d51b2ao5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13933-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linuxfoundation.org\n header.i=@linuxfoundation.org header.b=\"d51b2ao5\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1chW5Y7Vz1yD5\n\tfor ; Thu, 23 Apr 2026 23:42:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 40D5C3021E50\n\tfor ; Thu, 23 Apr 2026 13:40:30 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 03F482D12F3;\n\tThu, 23 Apr 2026 13:40:30 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id AA04626E173;\n\tThu, 23 Apr 2026 13:40:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B7DEBC2BCAF;\n\tThu, 23 Apr 2026 13:40:28 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776951629; cv=none;\n b=lQ7VSDRCKTNwbo/n6yfj81vmnwwXP3KKAcqhOe5czHSK34jmApT0marDEl9QWy3dFv3C2mpBbMWmzws26O9K8nyAyyFcypPSrZznqvcl/vMcQ/BIs/0nnYHNnd+JPI/XZ3GBMxzxcAJ8NGDS/F/qO947cN8m2eZskaf1Y/KXlog=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776951629; c=relaxed/simple;\n\tbh=3KP4UVdXkAjUCLuoO/Zngx5JujLIt1ZAmsr3rv4yp5M=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=l/JRcLrJqFTLi/8W2HALgjlTFJqix7lh5b0jNf10175wOJAE8DghWyQfS3SuM8L3ri0DfdB5tkvEp///uUGmgYCxNL2hC9SKps5HKOLRX41Hzbk0bg/ep8rHIhFnnV8ZfprXpxW07+iZAEFtDIFP6ifibAI0Z1A9ByTFldJ7tc8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (1024-bit key) header.d=linuxfoundation.org\n header.i=@linuxfoundation.org header.b=d51b2ao5;\n arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;\n\ts=korg; t=1776951629;\n\tbh=3KP4UVdXkAjUCLuoO/Zngx5JujLIt1ZAmsr3rv4yp5M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d51b2ao5sf7XgHmfz7iMq57cj2OZF6xGfimWjCfRuSY0cxJxIeeynX8T6+uuCsAwQ\n\t QelMwuEkg4FlvKEstXscM6rkCKvWKSJS/rsmkYU1wU7PB/pRdg3xHq5U1ViGvA+c5o\n\t 2ESF5wtWpLmggMSwRMhFBfaffFSNbnd27dGEbD6o=","Date":"Thu, 23 Apr 2026 15:40:26 +0200","From":"Greg Kroah-Hartman ","To":"Vishnu Reddy ","Cc":"Bryan O'Donoghue ,\n\tVikash Garodia ,\n\tDikshita Agarwal ,\n\tAbhinav Kumar ,\n\tMauro Carvalho Chehab ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , Joerg Roedel ,\n\tWill Deacon , Robin Murphy ,\n\tBjorn Andersson ,\n\tKonrad Dybcio ,\n\tStefan Schmidt ,\n\tHans Verkuil ,\n\t\"Rafael J. Wysocki\" ,\n\tDanilo Krummrich ,\n\tThierry Reding ,\n\tMikko Perttunen ,\n\tDavid Airlie , Simona Vetter ,\n\tJonathan Hunter , linux-media@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, iommu@lists.linux.dev,\n\tdriver-core@lists.linux.dev, dri-devel@lists.freedesktop.org,\n\tlinux-tegra@vger.kernel.org,\n\tEkansh Gupta ","Subject":"Re: [PATCH v2 03/13] gpu: host1x: Migrate to generic dma context bus","Message-ID":"<2026042330-recopy-corner-07d9@gregkh>","References":"<20260423-glymur-v2-0-0296bccb9f4e@oss.qualcomm.com>\n <20260423-glymur-v2-3-0296bccb9f4e@oss.qualcomm.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260423-glymur-v2-3-0296bccb9f4e@oss.qualcomm.com>"}}]