[{"id":3681458,"web_url":"http://patchwork.ozlabs.org/comment/3681458/","msgid":"","list_archive_url":null,"date":"2026-04-23T13:17:21","subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Jose Ignacio Tornos Martinez \n> Sent: Thursday, April 23, 2026 3:04 PM\n> To: netdev@vger.kernel.org\n> Cc: intel-wired-lan@lists.osuosl.org; Kitszel, Przemyslaw\n> ; Loktionov, Aleksandr\n> ; Keller, Jacob E\n> ; horms@kernel.org;\n> jesse.brandeburg@intel.com; Nguyen, Anthony L\n> ; davem@davemloft.net;\n> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Jose Ignacio\n> Tornos Martinez \n> Subject: [PATCH net v4 4/4] ice: skip unnecessary VF reset when\n> setting trust\n> \n> Similar to the i40e fix, ice_set_vf_trust() unconditionally calls\n> ice_reset_vf() when the trust setting changes. While the delay is\n> smaller than i40e this reset is still unnecessary in most cases.\n> \n> Additionally, the original code has a race condition: it deletes MAC\n> LLDP filters BEFORE resetting the VF. During this deletion, the VF is\n> still ACTIVE and can add new MAC LLDP filters concurrently,\n> potentially corrupting the filter list.\n> \n> When granting trust, no reset is needed - we can just set the\n> capability flag to allow privileged operations.\n> \n> When revoking trust, we need to:\n> 1. Clear the capability flag to block privileged operations 2. Disable\n> promiscuous mode if it was enabled (trusted VFs can enable it) 3. Only\n> reset if MAC LLDP filters exist (to clean them up)\n> \n> When we do reset (MAC LLDP case), we fix the race condition by\n> resetting first to clear VF state (which blocks new MAC LLDP filter\n> additions), then delete existing filters safely. During cleanup, vf-\n> >trusted remains true so\n> ice_vf_is_lldp_ena() works properly. Only after cleanup do we set\n> vf->trusted = false.\n> \n> When we don't reset, we manually handle capability flag and\n> promiscuous mode via helper function.\n> \n> The ice driver already has logic to clean up MAC LLDP filters when\n> removing trust. After this cleanup, the VF reset is only necessary if\n> there were actually filters to remove (num_mac_lldp was non-zero).\n> \n> This saves time and eliminates unnecessary service disruption when\n> changing VF trust settings in most cases, while properly handling\n> filter cleanup.\n> \n> Fixes: 2296345416b0 (\"ice: receive LLDP on trusted VFs\")\nFor me it looks like cc: stable@vger.kernel.org must be added\n\n> Signed-off-by: Jose Ignacio Tornos Martinez \n> ---\n> v4:\n> - Address AI review (sashiko.dev) from Simon Horman:\n> vf->trusted ordering bug\n> - Fix upstream race condition when comparing with i40e code\n> - Apply capability flag and promiscuous mode fixes from i40e AI\n> review\n> - Add helper function ice_setup_vf_trust() for non-reset path\n> - Export ice_vf_clear_all_promisc_modes() for code reuse\n> v3: https://lore.kernel.org/all/20260414110006.124286-5-\n> jtornosm@redhat.com/\n> \n> drivers/net/ethernet/intel/ice/ice_sriov.c | 41 +++++++++++++++++++-\n> - drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +-\n> drivers/net/ethernet/intel/ice/ice_vf_lib.h | 1 +\n> 3 files changed, 39 insertions(+), 5 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c\n> b/drivers/net/ethernet/intel/ice/ice_sriov.c\n> index 7e00e091756d..d0da7f6adc23 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_sriov.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c\n> @@ -1364,6 +1364,34 @@ int ice_set_vf_mac(struct net_device *netdev,\n> int vf_id, u8 *mac)\n> \treturn __ice_set_vf_mac(ice_netdev_to_pf(netdev), vf_id, mac);\n> }\n> \n> +/**\n> + * ice_setup_vf_trust - Enable/disable VF trust mode without reset\n> + * @vf: VF to configure\n> + * @setting: trust setting\n> + *\n> + * Manually handle capability flag and promiscuous mode when changing\n> +trust\n> + * without performing a VF reset.\n> + * When reset is performed, this is not necessary as the reset\n> +procedure\n> + * already handles this.\n> + **/\n> +static void ice_setup_vf_trust(struct ice_vf *vf, bool setting) {\n> +\tstruct ice_vsi *vsi;\n> +\n> +\tif (setting) {\n> +\t\tset_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);\n> +\t} else {\n> +\t\tclear_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);\n> +\n> +\t\tif (test_bit(ICE_VF_STATE_UC_PROMISC, vf->vf_states) ||\n> +\t\t test_bit(ICE_VF_STATE_MC_PROMISC, vf->vf_states)) {\n> +\t\t\tvsi = ice_get_vf_vsi(vf);\n> +\t\t\tif (vsi)\n> +\t\t\t\tice_vf_clear_all_promisc_modes(vf, vsi);\nYou declare ice_vf_clear_all_promisc_modes() returning int, but ignore the return value.\nLooks suspicious isn't it?\n\nReviewed-by: Aleksandr Loktionov \n\n> +\t\t}\n> +\t}\n> +}\n> +\n> /**\n> * ice_set_vf_trust\n> * @netdev: network interface device structure @@ -1399,11 +1427,16\n> @@ int ice_set_vf_trust(struct net_device *netdev, int vf_id, bool\n> trusted)\n> \n> \tmutex_lock(&vf->cfg_lock);\n> \n> -\twhile (!trusted && vf->num_mac_lldp)\n> -\t\tice_vf_update_mac_lldp_num(vf, ice_get_vf_vsi(vf),\n> false);\n> -\n> +\t/* Reset only if revoking trust with MAC LLDP filters */\n> +\tif (!trusted && vf->num_mac_lldp) {\n> +\t\tice_reset_vf(vf, ICE_VF_RESET_NOTIFY);\n> +\t\twhile (vf->num_mac_lldp)\n> +\t\t\tice_vf_update_mac_lldp_num(vf,\n> ice_get_vf_vsi(vf), false);\n> +\t} else {\n> +\t\tice_setup_vf_trust(vf, trusted);\n> +\t}\n> \tvf->trusted = trusted;\n> -\tice_reset_vf(vf, ICE_VF_RESET_NOTIFY);\n> +\n> \tdev_info(ice_pf_to_dev(pf), \"VF %u is now %strusted\\n\",\n> \t\t vf_id, trusted ? \"\" : \"un\");\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> index c8bc952f05cd..81bbf30e5c29 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> @@ -623,7 +623,7 @@ ice_vf_get_promisc_masks(struct ice_vf *vf, struct\n> ice_vsi *vsi,\n> *\n> * Clear all promiscuous/allmulticast filters for a VF\n> */\n> -static int\n> +int\n> ice_vf_clear_all_promisc_modes(struct ice_vf *vf, struct ice_vsi\n> *vsi) {\n> \tstruct ice_pf *pf = vf->pf;\n> diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> b/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> index 7a9c75d1d07c..a3501bd92311 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> @@ -310,6 +310,7 @@ bool ice_is_any_vf_in_unicast_promisc(struct\n> ice_pf *pf); void ice_vf_get_promisc_masks(struct ice_vf *vf, struct\n> ice_vsi *vsi,\n> \t\t\t u8 *ucast_m, u8 *mcast_m);\n> +int ice_vf_clear_all_promisc_modes(struct ice_vf *vf, struct ice_vsi\n> +*vsi);\n> int\n> ice_vf_set_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8\n> promisc_m); int\n> --\n> 2.53.0","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=pUfECXI9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1c8N2db7z1yCv\n\tfor ; Thu, 23 Apr 2026 23:17:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 05B3540FC9;\n\tThu, 23 Apr 2026 13:17:39 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qeQLGb69zP_5; Thu, 23 Apr 2026 13:17:34 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 9495E40FCD;\n\tThu, 23 Apr 2026 13:17:34 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id EB3BC24D\n for ; Thu, 23 Apr 2026 13:17:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id DC3D683BA3\n for ; Thu, 23 Apr 2026 13:17:32 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Xa6Dcb-u0gjA for ;\n Thu, 23 Apr 2026 13:17:28 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 2C09683BA7\n for ; Thu, 23 Apr 2026 13:17:27 +0000 (UTC)","from fmviesa001.fm.intel.com ([10.60.135.141])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 06:17:27 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 06:17:27 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 23 Apr 2026 06:17:26 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 23 Apr 2026 06:17:26 -0700","from PH8PR06CU001.outbound.protection.outlook.com (40.107.209.4) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 23 Apr 2026 06:17:25 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by PH3PPF383C22AA3.namprd11.prod.outlook.com (2603:10b6:518:1::d17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Thu, 23 Apr\n 2026 13:17:21 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9846.014; Thu, 23 Apr 2026\n 13:17:21 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9495E40FCD","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2C09683BA7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776950254;\n\tbh=fKPXQPMSktDDXWZmTsBgIq+Qtjg+4Ryn+IN+Hj6cPRY=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=pUfECXI9FH7y/eItkdPhGrWgTLdbPdBsCXGLe0CvtGcCJqfFFyTnnNZIh3nu0KTIf\n\t eEODGr/5OF91FopF4BFo75wtAdCQhOPgPYTK+QMnkpyZTxIfyUdWRvEqXOIpseUrCL\n\t pPLa5iryV68W03y7VgFNU6cjJQEuPL3XQberyuyVhwlLmSJxIFYNescOAMRPCVzCPO\n\t 1Oh9Vdqa3uLmE1/YEiAnJt3VTefM+13boTC0JlgaAG5fthW0Ez7r8xm88ADWyFMg8F\n\t gTtpQAWgYURKYJzaEtFqnj/osLdJBHcMkJih+d5J4EhRy3ZVJHx6eViPcfkgqIceiS\n\t VnT4C8VqsRAKw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.17;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 2C09683BA7","X-CSE-ConnectionGUID":["Q7YIWj5XTqqE2N/fTIhgOA==","wgpdXsrDSumAKgWuitkXsQ=="],"X-CSE-MsgGUID":["xbl2YbkDRcGNcYY29O+ouA==","QZ8uTZTwQPyybP50Q0JOig=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11764\"; a=\"77797677\"","E=Sophos;i=\"6.23,194,1770624000\"; d=\"scan'208\";a=\"77797677\"","E=Sophos;i=\"6.23,194,1770624000\"; d=\"scan'208\";a=\"256146918\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=NdpF+lsKxAkH/eJ8i/97iYLhGjJub0Tzv6p0ia5WfinbDY/vzkiHribiGeUzliAzoWxVoPqTaIVWhsIlxoQeyRarTYeAtk3jGAzJG8z1+sDgzgFBCn5UfPS9p9bfLk8Se0kijhJL5VX3Txb2ymjvGbknLzsieibT5o/elu/lNgiEwk8Cml4i3r2Yrdr1bvaBfuO3oiGbsHLfNLELqTIeDPZGB8XG5uXDtpcaiMaACdzAMgiQznUsSetSotPn5HF8LX+CuqZ6YRxkEUmn5HSYn9HGLAKfIcostqR6QiGIuuK9UvJ2leJyv5/J6ElvnEg+R+fRp3P/+Y2Y+txMp4H62w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=fKPXQPMSktDDXWZmTsBgIq+Qtjg+4Ryn+IN+Hj6cPRY=;\n b=BvbTJvXIlvYf82t7N7wJY5E/X3DImzTexjxQ1aS7GlAIcPXl62wE8SxgJEdPf3lmtwWijYZkPWhV+LMb5klD2fDpOc0Cs565uEFOOv2hCtkS9E9uNS9HLPHlInu0OqvvAeByWWDEetWlmubPAtPrPDDOaarr+g+i5j52b1ywKe2oz8CHXUO+UsMTXZYW1a/a6XjteRs+78BiACY6hp0COxCOezZ5JpqhgPeN1F/qnj1si8mqvlOho5wX6kaf+Kr4LRQiC84o/y7SsSIfUKlMVz6ODmHKk8phd4FiUJcqm0hcH/5Ba6dtb7ncdc87WW5wcKG5XbIqTjrvrFWECjnLUw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"Jose Ignacio Tornos Martinez ,\n \"netdev@vger.kernel.org\" ","CC":"\"intel-wired-lan@lists.osuosl.org\" ,\n \"Kitszel, Przemyslaw\" , \"Keller, Jacob E\"\n , \"horms@kernel.org\" ,\n \"jesse.brandeburg@intel.com\" , \"Nguyen, Anthony\n L\" , \"davem@davemloft.net\" ,\n \"edumazet@google.com\" , \"kuba@kernel.org\"\n , \"pabeni@redhat.com\" ","Thread-Topic":"[PATCH net v4 4/4] ice: skip unnecessary VF reset when setting\n trust","Thread-Index":"AQHc0yHPL3usVtJTakKErPoC2Bf5x7XsoCew","Date":"Thu, 23 Apr 2026 13:17:21 +0000","Message-ID":"\n ","References":"<20260423130405.139568-1-jtornosm@redhat.com>\n <20260423130405.139568-5-jtornosm@redhat.com>","In-Reply-To":"<20260423130405.139568-5-jtornosm@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|PH3PPF383C22AA3:EE_","x-ms-office365-filtering-correlation-id":"1870311d-8126-4fa6-cf6f-08dea13aa6ce","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|56012099003|22082099003|18002099003|38070700021;","x-microsoft-antispam-message-info":"\n A8DIpiM7IAOKhrhCAk5gCzd4VBDd/6ALKLG2Irm83Hdw9oCqaW8vkOWZ5wgHblg0MoO68gy6Ezz8kCUvGzlOijgv0/M7xiTf18kpS2rbMEyE3yf+drsPI2puDA7D9qMzPdr7+zJhOjudtgXFA88Ybl4ORRPP0glMvGtDWI0cSvJkBwrndAfxolPGFNNEcpcGGQj1aD8621pGIZ820Iq42yMwEmOomEB5cAW/G6wILTNbofJcaNNBIr2N7vICLYEExE2DhSG60BkjgXpar0xPCrCEvI21MGlKJ0ySf4asfqZD4M0xiA64yCay/kY1VphjNiAcAUayfHnvrqlpOZT0slGLzM4TVrX+Zwbe1IYUCzNUCuea3pn5jKLfwLiQ8QJ4s/FyWCCGgr8gScM+DeWWNYII/f5IiDsegSgtUawdC+yh/Gf9VGK9eDlhbCsmFoOsTc36fdGWbk+CTQ15FM2Ji+e+z7wEyKsxPj+DpRMbCcL60qDPjRPMbpNwQku4ig98qC2PI1pC9m4t8TmVi3/XYMRdLId5+1EJGojhA4HvNo6a36IoDDA/9MUlxSsAI+ozwrytwAW2BfkxT3w1WgjVZjZBS060J27jOGnJJJWRkm8KEwzQJZQZcT5qW4usvo+DTCT/A8z/zRTiDbMjmfaVa89KkelBAyK950F3wXaxZnLp/fFjjpRDkNugGhNpQ8pa12LLoQVyjpzObWk64xSIT1nuyUOPMfATlG5UmqTEiHytq0eNlf84MIkx7JN6v0QV3sIt2RKxNrLgXt7IF6WzJVlerOhvhKPydpZFCD1fcr4=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(56012099003)(22082099003)(18002099003)(38070700021);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n RcyDtwb7BwY2YSp1swI3gXNWOEPlxlJkPGaOBHEjJaXrZu6MVZ3D9cgb7o4VX/OnKIra/jRSd1H45f07USubcx/vzbkfxME3O4b/ETsyRLwHa36L+1xRs1cYgZqvi47X9cwzxFMJuNreZzH1KpDDZyQHQj7W0yV8tbZ4rL8fG4yvM8VU19gCVCx0bLvNcmr+V30fy7Cm5Ip9SHBs5rQXEWfUOsrTTX3xRbp6/FFluGurKmA/I6RkGnljHGhUerYLEtQy0rqY9eLLJBy3/E8fjDVDV+kAkbY3Jd4qa6Xq44dTRGRw5IDPwiNKTXMu7OVKkwW0MROsPH75zM0r1TSE0LlZZ1rgEQz9APLoEgf7JMP04RbhTctAMJl5GPq558395slCfJD8XFMNTD7R2fqUThiisqKykbTwiGgh9lT3EbOYzu9TwKGjMK/ZjWra1QWpXaMPAM8cwxn1z8j7OnluStOjUTxM75ffMwhUPAK2SP3ViDOFirNboC+IQqSJU6VMl7B8LVNWUJbTJ7ulquTr/u2TZOtZM3p4R4IGPSigaJEdkW/y/xBNqnxai6DJCXG56shCGM2JheJGGqHXDgjQRSj2AE/VFtsnNKEyST5XbTn5WszeIiNXDIZ+NFcniX1YcCtgwbxNVMKvbVGt0DNsiFu45VWlPI1PnQMpZAEplYFQWskjVLeN8A+bxsbdz4O7KMDjIrcJWURyUamDlGBYsQb/FE/bB/0ChvmjiJZYNtNHtFT+ap5s0WSBZKZ6F1nGawMi4aWpggsIstSqDSe2A0Mom1ezfaL180uIIoCJ27Wk4UgXL+i6VbJlmcBo/QAdjzoNAveot1OqXdK/goCKq465jn3AMQ1PAtCG4BpcBAm/Q0VRZUDWZMbgsFdxASs6wlEUlaXX8kK7mHXX42V77EOfw+HaJQZlX9mEHWtB6S3oFxeaOOGou8qcY3OHNt1eP1BE+B63M0WbQvxcawuwuXsVklBfUJ9tenO7mFjEk+bLof6xPG/qP83FjT4mLe5S1Pk1x2xgzMsWLm1iAiX/KzV26uMbjhjL1b+OhHz/0e+Lgd6A1YaOkxKcNi2dRvEF8wfv/FZqrTQ/QEYjx2IPNiMubfwgUV/E2XvMtvdBfn3c4bNt/LEu34dw7cRy55TTedVcI6KkMjJNqLGjvVPlfegnPVVsACPQfOWdq8g3oagA8H6K1LPwcZJLaBcTsd3CkXixjdW9tvUTGlRHFQ16WDbptrZgJxomLJCLLLpgFHpdeEnm2lRysV4TYWQ6x0BDQV5cpEh6NGIXZvWBOFDEdz7OOtJ7Z/AiAhvA4TGlUVpQqPGrSs7zp7Gb05Tr6aQ7T161WnFzU+/LPQk+MtepcbTXJ4hVOLZ9viNMmLGSHcIUy/wtdIvelEECwP4ZeEzyhPdlyKnTKS8FfqqvtsOYKC8qddQnQk8T+MUTVOeE601VRoQ3asIhkR2LdCCnfrQDRsASLe7iyMHRSKC6utthyQ50aCXC6kmP+62tNn7ER+Sl5GStuLDL35uHd+2oVebCaCZYFB36gxwl1SkJV6u57EeHFhGAACHrj1ZUVL20sSvAj5Bdita95FDFfYgXqogpsVitUo0CMtIt2j+ryHixkMMXF4T9TUK4lVcToGhjH9Ckao9CFcZbNr1mRKEH8XKVwcBljqGU0YrdNjAtZCsJZtmbuuLAxlQ43QthiZoJeZOnpLJCuhcH17+y/+dGID4RFP7xRqdel7QFGcZmNMjEeEAoPhmLWbWMr+A38QAE4Pk=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n LIO23jYgsgXoiBY3HN4IWau0lhnYv/HM5npCANgfKsQNxTt4tqcvDwGoKYjVUYPW/JpVC3C2mWtBVLctXBVk+yIeIbQ+ypQIA27VUT9ybuZ02Ua+ywOIU9EM2G3IErXqwRqJot4ID03sBHnpS4RS42qr5VVz0qO4sRBnceAeII/F9r4hS0CYHWXrgYVRt9Q8aHvSoO+JrTtrp4rA1YO3+whRGVOY/r7sseY8CifcOEOBOvc7ro0Xkj68p2Vtcwg67512Rfm/XuHazS2Ia3NkgSKv6q4kBMKWDSCWYYq6QN36NnJ3VIRv9fv1hMLvSi89V8jAyoSmqdtrTRRj2hLekw==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1870311d-8126-4fa6-cf6f-08dea13aa6ce","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Apr 2026 13:17:21.1478 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n fvaHQ+LNyAXIhtdc6P1B7YC0Uc9qFXw963oanubFNvEJo2EzNmJBAzpIpC1HR5ePrGffIp0g/o8oFfV/REL18cxtz/OFHYC+kQg/YK9Mb7Y=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH3PPF383C22AA3","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776950248; x=1808486248;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=rq9LLFKLdd7e8k4RsBxHGElwLH65MyYS1V+D20871VU=;\n b=gaUxxh5zzBSf9cm9+qx+vZ5td3M5jMwvsapKm5C0HJk6Kdzf2QNMAwJM\n htWVvSDsG9wA5WSFnr+1CY/PFBFSS8V0UCQReu+m5af4Nuy/Pm6BFv7UW\n b6XlPk/5cGu6o4IWoPwLMpIUPjoZzTxj6gvRx+zsQIj1rcVJb5p3kKxbK\n 2f0el+cRCrH/ih8VMbdjDHE+iq498Qr5oIPRp8byIBSNpthj36H+uX5F2\n GFt/R3TWUlBtGOTy5GCWiJNB4eae6Q0rD3mshh9fjXkbiUZJa3MNKD4QF\n 8w32Dr2G6iTb6vAIMv2KZgM6sFnZmHCnTdpDlY+YJ7W5LkJxb1GY16SY+\n w==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=gaUxxh5z","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3681958,"web_url":"http://patchwork.ozlabs.org/comment/3681958/","msgid":"<20260424103233.622318-1-jtornosm@redhat.com>","list_archive_url":null,"date":"2026-04-24T10:32:33","subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/people/93070/","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"content":"Hello Aleksandr,\n\n> For me it looks like cc: stable@vger.kernel.org must be added\nI am not sure about that, because the bugs fixed here (vf->trusted\nordering and race condition) only trigger when MAC LLDP filters exist,\nwhich is an uncommon scenario.\nAnd most users will benefit from the performance improvement that is an\noptimization rather than the bug fixes.\nI mean, I included the commit fixed as a reference but due to optimization\nas the main reason, I didn't dare to request this for older versions.\n\n> You declare ice_vf_clear_all_promisc_modes() returning int, but ignore\n> the return value.\n> Looks suspicious isn't it?\nWell, it is used like that when the funciton is called locally (the\nfunction is not modifiedi, just made public), and really my intention was\nto clean as much as possible (so error checking is not necessary).\nIn my opinion it would be enough to warn about the possible problems\n(already done in the existing function).\n\nAnyway, if, despite the reasons I have tried to explain, you still think\nthe same way, please let me know so I can adjust them (if you don't mind,\nI would wait for more reviews to include them in a next version).\n\nThanks\n\nBest regards\nJose Ignacio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=siu6gEDp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g28Rm6SyQz1yDD\n\tfor ; Fri, 24 Apr 2026 20:32:50 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E8E1F8488F;\n\tFri, 24 Apr 2026 10:32:48 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 7oSX63HAuS7J; Fri, 24 Apr 2026 10:32:48 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 30CC28488A;\n\tFri, 24 Apr 2026 10:32:48 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 9061A231\n for ; Fri, 24 Apr 2026 10:32:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 761B5425DC\n for ; Fri, 24 Apr 2026 10:32:47 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZEesYMPSTmUM for ;\n Fri, 24 Apr 2026 10:32:46 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 60632425DB\n for ; Fri, 24 Apr 2026 10:32:45 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-Bb_4hFO_PMqekvjZMqwVzw-1; Fri,\n 24 Apr 2026 06:32:41 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3576E19560AF; Fri, 24 Apr 2026 10:32:39 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.32.29])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0D9631800348; Fri, 24 Apr 2026 10:32:34 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 30CC28488A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 60632425DB"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777026768;\n\tbh=j8BpQcTU/HrFkQ0+UuHlyLaR2zAA5vDMBO2MGcO/oD4=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=siu6gEDpOp38OS8C4DYJm5KQ7maU1WhyAnIXORMvsnyVhsNutbzLNXeba2OC0VcAB\n\t 5LlR+fYZVg511uuegVmBFwwei4vMZEgj/thPtHQurbL1hAVgDqlXGiNorD1T/x8RwN\n\t mJu6k3q/03M+PSAQRzVNGgcGMD+rYeRLj/LjfFRfHYj9WYRc+EjDJneLRr9OIj/0bE\n\t HEVbXCX6qO5fOxeSFiRI50IjxXcLXEu7gllgCU7i6gN4n021WfI99aNo4sadZ0l0y1\n\t 8m4FL266upelwLvmS2ENWrNcXkbz/rOJD41VzXIeArrOJ5n1/twDUyE79Z7CtcXWLR\n\t RRP6DXvp0C8HA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 60632425DB","X-MC-Unique":"Bb_4hFO_PMqekvjZMqwVzw-1","X-Mimecast-MFC-AGG-ID":"Bb_4hFO_PMqekvjZMqwVzw_1777026759","From":"Jose Ignacio Tornos Martinez ","To":"aleksandr.loktionov@intel.com","Cc":"anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n horms@kernel.org, intel-wired-lan@lists.osuosl.org,\n jacob.e.keller@intel.com, jesse.brandeburg@intel.com, jtornosm@redhat.com,\n kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,\n przemyslaw.kitszel@intel.com","Date":"Fri, 24 Apr 2026 12:32:33 +0200","Message-ID":"<20260424103233.622318-1-jtornosm@redhat.com>","In-Reply-To":"\n ","References":"\n ","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-MFC-PROC-ID":"vCfGEAvgW58uJPUEPRYVcBWNNcrv49Jb27livm0IXE8_1777026759","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1777026764;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=j8BpQcTU/HrFkQ0+UuHlyLaR2zAA5vDMBO2MGcO/oD4=;\n b=Coyb/oFK7Br5U2AiG+8wWcKzVJ/oKE1nenOt7RHKrMxexDoruv8eYUg0nhaPG/dl3PQWhQ\n bfXLZ4Ovuk4oolIHDVyIY4lR/HkkXMDN3WcE/L+9aY6UB3IxF/ZgzLv7LJ8WV9Xb9JpoXB\n eORo4svU4RloqTZGfI3vz0ssO+qt3EY=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Coyb/oFK"],"Subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3681963,"web_url":"http://patchwork.ozlabs.org/comment/3681963/","msgid":"","list_archive_url":null,"date":"2026-04-24T10:37:56","subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Jose Ignacio Tornos Martinez \n> Sent: Friday, April 24, 2026 12:33 PM\n> To: Loktionov, Aleksandr \n> Cc: Nguyen, Anthony L ;\n> davem@davemloft.net; edumazet@google.com; horms@kernel.org; intel-\n> wired-lan@lists.osuosl.org; Keller, Jacob E\n> ; jesse.brandeburg@intel.com;\n> jtornosm@redhat.com; kuba@kernel.org; netdev@vger.kernel.org;\n> pabeni@redhat.com; Kitszel, Przemyslaw \n> Subject: RE: [PATCH net v4 4/4] ice: skip unnecessary VF reset when\n> setting trust\n> \n> Hello Aleksandr,\n> \n> > For me it looks like cc: stable@vger.kernel.org must be added\n> I am not sure about that, because the bugs fixed here (vf->trusted\n> ordering and race condition) only trigger when MAC LLDP filters exist,\n> which is an uncommon scenario.\n> And most users will benefit from the performance improvement that is\n> an optimization rather than the bug fixes.\n> I mean, I included the commit fixed as a reference but due to\n> optimization as the main reason, I didn't dare to request this for\n> older versions.\nOk I see your point. As it's optimization, you are right.\n\n\n> \n> > You declare ice_vf_clear_all_promisc_modes() returning int, but\n> ignore\n> > the return value.\n> > Looks suspicious isn't it?\n> Well, it is used like that when the funciton is called locally (the\n> function is not modifiedi, just made public), and really my intention\n> was to clean as much as possible (so error checking is not necessary).\n> In my opinion it would be enough to warn about the possible problems\n> (already done in the existing function).\nCan you go extra mile and add error code handling?\nOr at least document it in the code why you don't do it?\n\n> \n> Anyway, if, despite the reasons I have tried to explain, you still\n> think the same way, please let me know so I can adjust them (if you\n> don't mind, I would wait for more reviews to include them in a next\n> version).\n> \n> Thanks\n> \n> Best regards\n> Jose Ignacio\n\nThank you\nAlex","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=fIgpCoKR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g28Yq4Pqfz1yD5\n\tfor ; Fri, 24 Apr 2026 20:38:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id CED8A848AF;\n\tFri, 24 Apr 2026 10:38:05 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id E-tijNch1oS8; Fri, 24 Apr 2026 10:38:03 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id A3473848A9;\n\tFri, 24 Apr 2026 10:38:03 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id D2090206\n for ; Fri, 24 Apr 2026 10:38:02 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id C3DCF42221\n for ; Fri, 24 Apr 2026 10:38:02 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ntufciMr-f2X for ;\n Fri, 24 Apr 2026 10:38:02 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by smtp2.osuosl.org (Postfix) with ESMTPS id D46A7421F6\n for ; Fri, 24 Apr 2026 10:38:01 +0000 (UTC)","from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2026 03:38:01 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2026 03:38:01 -0700","from ORSMSX903.amr.corp.intel.com (10.22.229.25) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 24 Apr 2026 03:38:00 -0700","from ORSEDG903.ED.cps.intel.com (10.7.248.13) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 24 Apr 2026 03:38:00 -0700","from PH7PR06CU001.outbound.protection.outlook.com (52.101.201.68) by\n edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 24 Apr 2026 03:37:58 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by SA3PR11MB7611.namprd11.prod.outlook.com (2603:10b6:806:304::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr\n 2026 10:37:56 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026\n 10:37:56 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org A3473848A9","OpenDKIM Filter v2.11.0 smtp2.osuosl.org D46A7421F6"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777027083;\n\tbh=iO1sYbcn/msW/Ul7ce3AFMDMBhI6wYUhUo/j2L9C2H0=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=fIgpCoKRj0imjXSa0teFvu0xbfnhU2QYW5PohjGz7FQVULIZSg9FynwYQCC+wlpRG\n\t H2/LZ1SeG+Q/6i1MpwyIciuLqv4SrbN3XUHDomGfDhWOs49Y/54pUDDYrCatmQjv9D\n\t emZ3LvA0E/9unl/zcbrgYz4XKEqxAZsluVEOjnreV9PI6Wu+0/6AX5QKY0BlYltCla\n\t UbPOwrwdmADpKp4Wgt7azTnkxCnXCCY5T0Z2ZqMiOzdcQSvyuDlX0/ezGgZKUZeP41\n\t lOTKAmvU11z07eN3Qt0g6HvCYQo4l52FTKDeY05L9OguipmuWnVOEyDMAD6JRUspT7\n\t V8VLarSa9Qokw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org D46A7421F6","X-CSE-ConnectionGUID":["zUM4a3/mTpKMB6BKbrF45w==","sDWvKO7TRKSiuwtMZMwyxg=="],"X-CSE-MsgGUID":["mAFhe43jRDyLLVnaMtV9xg==","OMAtQWBzT4KLUUwPY7KXsA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11765\"; a=\"88313978\"","E=Sophos;i=\"6.23,196,1770624000\"; d=\"scan'208\";a=\"88313978\"","E=Sophos;i=\"6.23,196,1770624000\"; d=\"scan'208\";a=\"237976089\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=XDM+wOz8DcANprKGZPAAPKdlW+5rpLtjyI6+iK98V8tFJrp0yNg7dcSdDLSBL29PwqtXhl6tGa1iyvuPaHgTnm8abfyNXBOn5S0jtDvZO1cy38XiDSOFljs614A0hMtFgZNi4ZjS82r/2P1merom8CJycgt7IRItGoW6+BlAJh8CNkoSWskHP7CLma+Pez/AoMQpjmxjqnC4mDroEkAu5aff0mnPIClszXs63RO+ZPWqNmuL79RsmLzBQSWIk3soahNo2FODPZ6OSEJaeXXa222V7yxtFZ4xRsNG/76Lwy/oYxpbPAvJXTOyRRPa3T2NaiBkKGy5c3VSL0+TPmCkmQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=iO1sYbcn/msW/Ul7ce3AFMDMBhI6wYUhUo/j2L9C2H0=;\n b=UVI7h592z7VvMMJmJiUE9xzH+MbwFwuR+w0KKAOPm2tJKg88vULkkO4ixzaVqSjeo5jAyC+q0FTlJrJaZ5AxFOeIWfBVcMiAONJdF252WOR+U4CcSnEdbvMyTKGWEpcmTeCLxfkqeL3YIRF36x1nMSZ7dlP7SgqTFuTpROkvJjXXt01lbX5WYe+WG72XJJ0W+xoxKB5CK4khXYB8R2aCYJUOCyo6ZVBHCuM8+gUnEOY/M3imsDqHgpzwFomCiS4Kzmhl5xeAwMtqCE5Z8+qzP0JtQq4c2cnzzcU56TBJgf1LYb73jqwXx7kzoyc8ThjSgH4S+zVxdhmg4KLTr7M3Og==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"Jose Ignacio Tornos Martinez ","CC":"\"Nguyen, Anthony L\" , \"davem@davemloft.net\"\n , \"edumazet@google.com\" ,\n \"horms@kernel.org\" , \"intel-wired-lan@lists.osuosl.org\"\n , \"Keller, Jacob E\"\n , \"jesse.brandeburg@intel.com\"\n , \"kuba@kernel.org\" ,\n \"netdev@vger.kernel.org\" , \"pabeni@redhat.com\"\n , \"Kitszel, Przemyslaw\" ","Thread-Topic":"[PATCH net v4 4/4] ice: skip unnecessary VF reset when setting\n trust","Thread-Index":"AQHc0yHPL3usVtJTakKErPoC2Bf5x7XsoCewgAFk54CAAADToA==","Date":"Fri, 24 Apr 2026 10:37:56 +0000","Message-ID":"\n ","References":"\n \n <20260424103233.622318-1-jtornosm@redhat.com>","In-Reply-To":"<20260424103233.622318-1-jtornosm@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|SA3PR11MB7611:EE_","x-ms-office365-filtering-correlation-id":"eb756e35-0379-4165-d5ed-08dea1ed8c03","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|1800799024|376014|366016|38070700021|56012099003|22082099003|18002099003;","x-microsoft-antispam-message-info":"\n vWvzTTc7WlUvHATo91tglhVivkgTierlakRFX5GUtZaU/fBJegKvsbWP+KtoTbdehFTlhhAnrhkFdam75Ej4E9QV1egLZIArvvM+gUF9vZUMU/KoQn9rNReFDOFk8P/THoe2VPYhx+jgxZ03ooBAyapjzJ7jQppiA+LXAatPdGAV3DtMg8jfk3UEJNHKbD9nLGJTSsGe8RYRZw/P4LoKv3eQOkVkon3jGoQmqbI+jr0jznMqKDJStJQySXZH/GUNk581pSXWDtZxw7+3/VzQpvQwmv8ErTbF/r03nXFMl/PG4neXXNc5V+WBbpkevhsdvjjmd4m7EYBjZQRZzk9p8uH3tgeavlAXUF97uVCPkc6GOm7nwbNcw0KyUqx5CJUiUo+co/dOFpBA1jQYP+CYRfpmI3YoX1mDK8v/O1AN+cn4X6HjrOYjmU74lQnkJkTCdwoN8AK7BVhXsthXuXhUSb9/QxaGDpQrCMuMp3zRX8MzM2hh2AhdB6m3dvbQKhNyj4uXQEuydFailORfiXBug3gLsSa1ucColDhANm2+5znDC/pIYOibF1+ZZW5wcqQlvCfSqTKrdDfNIZ11jXvpmBnClBGXQa9JCz5yjoayF7JY3A4W+dTprSHaL7BBWHpOpUXymD0QuMV7bkYryrP2jrOlaSVCaD0D/dOGNbkSvDwHHi1gBU+/PG5LToD1zaS8NdkfRmLkPQlgFTjSCp8UHNjTvwKqL5CLvuK8bhPSV2OgpBSw4cK/XcXY5xwf1i5amH0RZn/JiTMxI/M6d7fKVXSh8m45MZ2Z9G2D82g+xmc=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(366016)(38070700021)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n j7ofIKbbnzaP/rHIsPVte0Ou0rLqNMURSzT4PJmDcZxT/nekmcQaavl/YCG6TA68aGIrGAjw0k+R1JE+Os2OyfCEIVIBMKKzqmRa4t2HIz1qwwUvfuQBLW/PxxPw2ra33EEDf1Qp5kN+FqrGY5AIp6zm4pH9XoyKlPEvhIgVlCcNIRClu8QEmt+P9j6+EHKhKxUYFR+HZ1wiCfrjoqXdRQKfuQoRMnE/VzxMJbDfQ0v4iRTnuIP9ZUxJB/qYtlcXMPpB+Wv60qqdUZyj1KZJzD7t81/s22qtFfTV6nqiSU+K5M8tS3tBE9KNThAs+cArJOn5jtZZmCmKdZqlqWRqyGgX8qKLx0nkJn79b0CMLdXBbCCgTayKt9yOBIQdHYfBoo1ksZTSLFruKHpN3LDm5/UWHhzkOJwUWbDRBuIEC8PkR7Rj16dmZa7MUxA4LXHKqq+idtiyRGkPfbTyZZyWYPgWlc68NYEtTcNb4DTPXhyYzYijnR9nM/9sz9Y0vy7eIWv/M3B5m99YWMyaSe63PAUQItHRjEojVlW4re6H6Daif9IfsF8JLboozoVykM3wdEUFHA849uo/NxR0Bh36sToJF9KQq8BnhLtBF5giNEuDCOq/GzwhNAC5e7uaS8NlndLB2I3P+RT/MeMGFPBYSV0C8ZbuSvyOvCOcv8cZwi0zDLRlNi4UYRmSQ7gyM91NsGljcuk527Im57W5gKWi+8J0LgbmYGIAzF2ClPGdmJ+BFz/WNrXSpSGU4bvwnOm6RGCFsg2n7lR0oDzHhU9fgOlU2epz0sFDBlMkMSvJYPWNf3IH6UYiGsrhllMpnacOz8wn8wqqH2vSKH3ci08k/N0mtR1Q+fVUgtQxfqHQ2n7djCOSD1fS1pgxewoNnJg4eiwTVbPcgpd+lz9idOVTQNHJGr2C2lcqJV9KI9TObDcfZyy6aNzSarHyasatewlDAca71vHnGehZGY/o9QyS4gF/ntNYj6hBwuVQO6PLxHMIamHvcPEOmO9H5hNWeXrVaG27o6uHoUw08vnDgf95h0ef8frHdPMdOhP4ompx1H66LFGmlv24m3IItG/zipxdjVegrsml68NlrkS6K4N6nBG13cdV0tuwAVStrrBpwkX4ISPSPqtYAbvKbQ7oujYael+jWC8wCo7BdRx8rLzExHSvLbfokmB5hUENbJ3uTkXOnLm1MTXG82RshKf6FqQtxtpaX9p4DxMcg8tJC0fET8+2nzvFmK/ToT8oY6L68anrC5O1L0ShGQwq1Nj/vjnVgTM9gYBlUrOGbjf2lKpQpLAQM9emtQ1t8wz8SsdDEUFMC/mA6xAi/rzBOP13OzSgdUYTZlzvynL8trBTitkf7AIlZBSDh90MmpQY2Ek+zFtOjvyHVA80cetxZWyhNsm0UKydoEo7Z2k0cFhysS3tm8UrNiPFU5zfQhuKWfrRnDr2ydKVWOox++xkn+H5hR7l2CssxQX7V/C8RAR494v5FyW6xmuQowP6zkMQhtsTeWXrJen8LU4C739DNVhboF55NVgR0wMUftYdziGKeRYWnvQG4wz7be4ydD5/+Yme0c4tDBIIUbp8FDo9B71azRXf6TmL9bugbu2guWkxaGarHsLJQ6i1naIWVGu/00iUoabPf5GZKJpaue/hrz8fQ/7qt1zIcY7LmkEDZ4LyDScQTXXA1ubfOLfYWW7cXpS7VYnVxC9dbITo2mx1Iw6ZQXFXhmSrAwWczVLgLQ3ygv8qFMMZDLPANE30ERSYCSv9fLY=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n qvcQiX7KSDuR/H583uNpfIWkdCWiN2z/cc19MrtiKa8QRVMD44Uv2dTncn2bQs8WudYUkOb8CUnMPOOgYYIkTBBapAndIShmmmx+qh3vyinILM+huZZxfthCfCCXU4qdjP89tQqrFI7rNmqgwXeTjAGkQ2Gz3M/O8wV7vTGcMwB/c+Wh0ioUtfoXJz4/K0a/a8EFj8VnIqbr+XQ4ut0+XH7Cg3fZPSMnRmfotiGlyOMIwetUpzxMokvC+0CGF5AinU+1YtWrIeg7ZLN852hFAtaZspXNuG8wHrZ0PMi8bvl69iRqhuN/KO1Nkbfm/JkeX4iRdclnuvz9S+HcLPQkRQ==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n eb756e35-0379-4165-d5ed-08dea1ed8c03","X-MS-Exchange-CrossTenant-originalarrivaltime":"24 Apr 2026 10:37:56.1531 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n 0T20kNMTqNlR/Q5YcZjDK2yQ4lPYrUgEY+JeSRUbMdKtJH9DOel2bNlVSbJEaHwtsWfR3c84se339seGkWSDOEBibfHEBDTf/n2UKHJTqNc=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA3PR11MB7611","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777027082; x=1808563082;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=viexRPkEMzzAsgxEiY54QT4qmUYtZ08d79C5mi5J9cw=;\n b=j5zMLylfG+sEKaN1dHCZqheIXSsiJKLk3zGYboUFDlqIdCjG44Ojjjv1\n sm0uBrEkzKC6b+CLBcvyAHj1o6ZZqk0lj3EzwELQMB2tynViWbbA7DNiB\n JwinBAZTpuiqJSw28sYB7lcj6Oa1+5J7TQ278TeWexw1cvYkz5ooCMfO9\n xGJQfGF1HqIwcjLP7n9g0JoV6TcDUzcltUUAAF+F2QYFK04wZ+Nhc+wsZ\n QYSEIUuw2c8ddKiINERjBc9Y31CL1w2e7ZETVNLIbjGou1oNs87QizujC\n VITb4QnFcGKwFDUjjw6z4caBFUxaSWQWLc5gU0F7ls8VSQCn3STaUylE1\n Q==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=j5zMLylf","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3682014,"web_url":"http://patchwork.ozlabs.org/comment/3682014/","msgid":"<20260424124031.834241-1-jtornosm@redhat.com>","list_archive_url":null,"date":"2026-04-24T12:40:31","subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/people/93070/","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"content":"Hello Aleksandr,\n\n>>> You declare ice_vf_clear_all_promisc_modes() returning int, but\n>>> ignore the return value.\n>>> Looks suspicious isn't it?\n>> Well, it is used like that when the funciton is called locally (the\n>> function is not modifiedi, just made public), and really my intention\n>> was to clean as much as possible (so error checking is not necessary).\n>> In my opinion it would be enough to warn about the possible problems\n>> (already done in the existing function).\n> Can you go extra mile and add error code handling?\n> Or at least document it in the code why you don't do it?\nOk, I can add the error handling in ice_setup_vf_trust and an extra warning\nto indicate that promiscuous mode clear failed when revoking trust.\nJust let me wait a bit longer for more possible reviews to create the next\nversion of the series.\n\nThanks\n\nBest regards\nJose Ignacio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=CGEsLwjV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2CHS13kvz1xvV\n\tfor ; Fri, 24 Apr 2026 22:40:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id AFC7584A42;\n\tFri, 24 Apr 2026 12:40:49 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id shJY4KFpHj4m; Fri, 24 Apr 2026 12:40:49 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id DF51584A26;\n\tFri, 24 Apr 2026 12:40:48 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 6624B231\n for ; Fri, 24 Apr 2026 12:40:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 4B70E422AC\n for ; Fri, 24 Apr 2026 12:40:47 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MUm72BCuTZCA for ;\n Fri, 24 Apr 2026 12:40:46 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 3813840194\n for ; Fri, 24 Apr 2026 12:40:45 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-KXYT9KXtN8O36aMG-Drc7w-1; Fri,\n 24 Apr 2026 08:40:40 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 84E00180034F; Fri, 24 Apr 2026 12:40:38 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.32.29])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5FFE519560AB; Fri, 24 Apr 2026 12:40:32 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org DF51584A26","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3813840194"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777034448;\n\tbh=Os6slKuiLGxBWiHsIraIVXqi+PiGactCEycWMtcaDv8=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=CGEsLwjVdRbkG07CE7r2/2npo8vqREBJybaO50f5O/mjxK7eQwsgP4jxJBGhVCwC3\n\t 08i9Jw1TlGxYiU689fvNqN/nHADXawJ1R+PnxTIrKkzPOxSXgEoe1fefIrIUIsx2ET\n\t /Oj1A5YYIdDlXq0FO7rP5k51KGpozX3BkT56U7Nl4MDexvQpIvqz6yAKkyMYVzIXxQ\n\t PwbnIjyZVRc8byE5+spmkTvQo4w1Wm5RIV9p1D8ZHP4zMjIOjp5SKSW6/NkVhjovFh\n\t rWTEI+YFh7Gs4vHxcq4VR8V0hcPw6yEATM/LP6JRnrpqljtawTc8xtTeUh3BhxEi/C\n\t 0hAUwNYc8D0xA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 3813840194","X-MC-Unique":"KXYT9KXtN8O36aMG-Drc7w-1","X-Mimecast-MFC-AGG-ID":"KXYT9KXtN8O36aMG-Drc7w_1777034438","From":"Jose Ignacio Tornos Martinez ","To":"aleksandr.loktionov@intel.com","Cc":"anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n horms@kernel.org, intel-wired-lan@lists.osuosl.org,\n jacob.e.keller@intel.com, jesse.brandeburg@intel.com, jtornosm@redhat.com,\n kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,\n przemyslaw.kitszel@intel.com","Date":"Fri, 24 Apr 2026 14:40:31 +0200","Message-ID":"<20260424124031.834241-1-jtornosm@redhat.com>","In-Reply-To":"\n ","References":"\n ","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-MFC-PROC-ID":"DMrccyLsOTTYYXsb6rdGa0a40r7Ecs31HHGjeD79mdA_1777034438","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1777034444;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Os6slKuiLGxBWiHsIraIVXqi+PiGactCEycWMtcaDv8=;\n b=ZJU0KSzpJdfLiKq2HD5QvDPb50JR5k82l+8zYYAEdbpQuw6xWNwg3ko/yQBSCNupRLH8+t\n 5kQXbHt4aDPNFvvpHhFvUZrbRnI7uFMdRHmBcr0JPrruvGKUE2PB6EjWAUqoNmrSlz/ivc\n BS0EFNMfVZIwyzlbDnSpTXgL7ft8Prw=","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZJU0KSzp"],"Subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3682092,"web_url":"http://patchwork.ozlabs.org/comment/3682092/","msgid":"","list_archive_url":null,"date":"2026-04-24T16:05:12","subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf\n> Of Loktionov, Aleksandr\n> Sent: Thursday, April 23, 2026 3:17 PM\n> To: Jose Ignacio Tornos Martinez ;\n> netdev@vger.kernel.org\n> Cc: intel-wired-lan@lists.osuosl.org; Kitszel, Przemyslaw\n> ; Keller, Jacob E\n> ; horms@kernel.org;\n> jesse.brandeburg@intel.com; Nguyen, Anthony L\n> ; davem@davemloft.net;\n> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com\n> Subject: Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip\n> unnecessary VF reset when setting trust\n> \n> \n> \n> > -----Original Message-----\n> > From: Jose Ignacio Tornos Martinez \n> > Sent: Thursday, April 23, 2026 3:04 PM\n> > To: netdev@vger.kernel.org\n> > Cc: intel-wired-lan@lists.osuosl.org; Kitszel, Przemyslaw\n> > ; Loktionov, Aleksandr\n> > ; Keller, Jacob E\n> > ; horms@kernel.org;\n> > jesse.brandeburg@intel.com; Nguyen, Anthony L\n> > ; davem@davemloft.net;\n> > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Jose\n> Ignacio\n> > Tornos Martinez \n> > Subject: [PATCH net v4 4/4] ice: skip unnecessary VF reset when\n> > setting trust\n> >\n> > Similar to the i40e fix, ice_set_vf_trust() unconditionally calls\n> > ice_reset_vf() when the trust setting changes. While the delay is\n> > smaller than i40e this reset is still unnecessary in most cases.\n> >\n> > Additionally, the original code has a race condition: it deletes MAC\n> > LLDP filters BEFORE resetting the VF. During this deletion, the VF\n> is\n> > still ACTIVE and can add new MAC LLDP filters concurrently,\n> > potentially corrupting the filter list.\n> >\n> > When granting trust, no reset is needed - we can just set the\n> > capability flag to allow privileged operations.\n> >\n> > When revoking trust, we need to:\n> > 1. Clear the capability flag to block privileged operations 2.\n> Disable\n> > promiscuous mode if it was enabled (trusted VFs can enable it) 3.\n> Only\n> > reset if MAC LLDP filters exist (to clean them up)\n> >\n> > When we do reset (MAC LLDP case), we fix the race condition by\n> > resetting first to clear VF state (which blocks new MAC LLDP filter\n> > additions), then delete existing filters safely. During cleanup, vf-\n> > >trusted remains true so\n> > ice_vf_is_lldp_ena() works properly. Only after cleanup do we set\n> > vf->trusted = false.\n> >\n> > When we don't reset, we manually handle capability flag and\n> > promiscuous mode via helper function.\n> >\n> > The ice driver already has logic to clean up MAC LLDP filters when\n> > removing trust. After this cleanup, the VF reset is only necessary\n> if\n> > there were actually filters to remove (num_mac_lldp was non-zero).\n> >\n> > This saves time and eliminates unnecessary service disruption when\n> > changing VF trust settings in most cases, while properly handling\n> > filter cleanup.\n> >\n> > Fixes: 2296345416b0 (\"ice: receive LLDP on trusted VFs\")\n> For me it looks like cc: stable@vger.kernel.org must be added\n> \n> > Signed-off-by: Jose Ignacio Tornos Martinez \n> > ---\n> > v4:\n> > - Address AI review (sashiko.dev) from Simon Horman:\n> > vf->trusted ordering bug\n> > - Fix upstream race condition when comparing with i40e code\n> > - Apply capability flag and promiscuous mode fixes from i40e AI\n> > review\n> > - Add helper function ice_setup_vf_trust() for non-reset path\n> > - Export ice_vf_clear_all_promisc_modes() for code reuse\n> > v3: https://lore.kernel.org/all/20260414110006.124286-5-\n> > jtornosm@redhat.com/\n> >\n> > drivers/net/ethernet/intel/ice/ice_sriov.c | 41\n> +++++++++++++++++++-\n> > - drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +-\n> > drivers/net/ethernet/intel/ice/ice_vf_lib.h | 1 +\n> > 3 files changed, 39 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c\n> > b/drivers/net/ethernet/intel/ice/ice_sriov.c\n> > index 7e00e091756d..d0da7f6adc23 100644\n> > --- a/drivers/net/ethernet/intel/ice/ice_sriov.c\n> > +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c\n> > @@ -1364,6 +1364,34 @@ int ice_set_vf_mac(struct net_device *netdev,\n> > int vf_id, u8 *mac)\n> > \treturn __ice_set_vf_mac(ice_netdev_to_pf(netdev), vf_id, mac);\n> }\n> >\n> > +/**\n> > + * ice_setup_vf_trust - Enable/disable VF trust mode without reset\n> > + * @vf: VF to configure\n> > + * @setting: trust setting\n> > + *\n> > + * Manually handle capability flag and promiscuous mode when\n> changing\n> > +trust\n> > + * without performing a VF reset.\n> > + * When reset is performed, this is not necessary as the reset\n> > +procedure\n> > + * already handles this.\n> > + **/\nOne more nit, kdoc should end with '*/' not '**/'\n\nWith the best regards\nAlex\n\n\n> > +static void ice_setup_vf_trust(struct ice_vf *vf, bool setting) {\n> > +\tstruct ice_vsi *vsi;\n> > +\n> > +\tif (setting) {\n> > +\t\tset_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);\n> > +\t} else {\n> > +\t\tclear_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);\n> > +\n> > +\t\tif (test_bit(ICE_VF_STATE_UC_PROMISC, vf->vf_states) ||\n> > +\t\t test_bit(ICE_VF_STATE_MC_PROMISC, vf->vf_states)) {\n> > +\t\t\tvsi = ice_get_vf_vsi(vf);\n> > +\t\t\tif (vsi)\n> > +\t\t\t\tice_vf_clear_all_promisc_modes(vf, vsi);\n> You declare ice_vf_clear_all_promisc_modes() returning int, but ignore\n> the return value.\n> Looks suspicious isn't it?\n> \n> Reviewed-by: Aleksandr Loktionov \n> \n> > +\t\t}\n> > +\t}\n> > +}\n> > +\n> > /**\n> > * ice_set_vf_trust\n> > * @netdev: network interface device structure @@ -1399,11 +1427,16\n> > @@ int ice_set_vf_trust(struct net_device *netdev, int vf_id, bool\n> > trusted)\n> >\n> > \tmutex_lock(&vf->cfg_lock);\n> >\n> > -\twhile (!trusted && vf->num_mac_lldp)\n> > -\t\tice_vf_update_mac_lldp_num(vf, ice_get_vf_vsi(vf),\n> > false);\n> > -\n> > +\t/* Reset only if revoking trust with MAC LLDP filters */\n> > +\tif (!trusted && vf->num_mac_lldp) {\n> > +\t\tice_reset_vf(vf, ICE_VF_RESET_NOTIFY);\n> > +\t\twhile (vf->num_mac_lldp)\n> > +\t\t\tice_vf_update_mac_lldp_num(vf,\n> > ice_get_vf_vsi(vf), false);\n> > +\t} else {\n> > +\t\tice_setup_vf_trust(vf, trusted);\n> > +\t}\n> > \tvf->trusted = trusted;\n> > -\tice_reset_vf(vf, ICE_VF_RESET_NOTIFY);\n> > +\n> > \tdev_info(ice_pf_to_dev(pf), \"VF %u is now %strusted\\n\",\n> > \t\t vf_id, trusted ? \"\" : \"un\");\n> >\n> > diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> > b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> > index c8bc952f05cd..81bbf30e5c29 100644\n> > --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> > +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n> > @@ -623,7 +623,7 @@ ice_vf_get_promisc_masks(struct ice_vf *vf,\n> struct\n> > ice_vsi *vsi,\n> > *\n> > * Clear all promiscuous/allmulticast filters for a VF\n> > */\n> > -static int\n> > +int\n> > ice_vf_clear_all_promisc_modes(struct ice_vf *vf, struct ice_vsi\n> > *vsi) {\n> > \tstruct ice_pf *pf = vf->pf;\n> > diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> > b/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> > index 7a9c75d1d07c..a3501bd92311 100644\n> > --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> > +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.h\n> > @@ -310,6 +310,7 @@ bool ice_is_any_vf_in_unicast_promisc(struct\n> > ice_pf *pf); void ice_vf_get_promisc_masks(struct ice_vf *vf,\n> struct\n> > ice_vsi *vsi,\n> > \t\t\t u8 *ucast_m, u8 *mcast_m);\n> > +int ice_vf_clear_all_promisc_modes(struct ice_vf *vf, struct\n> ice_vsi\n> > +*vsi);\n> > int\n> > ice_vf_set_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8\n> > promisc_m); int\n> > --\n> > 2.53.0","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=lbxyas+L;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2HqY5L3cz1yD5\n\tfor ; Sat, 25 Apr 2026 02:05:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5681C84D21;\n\tFri, 24 Apr 2026 16:05:28 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id AjjhmhPzL0jZ; Fri, 24 Apr 2026 16:05:27 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 578ED84BCD;\n\tFri, 24 Apr 2026 16:05:27 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 73D69206\n for ; Fri, 24 Apr 2026 16:05:25 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 5A0C884BCD\n for ; Fri, 24 Apr 2026 16:05:25 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZrxeBclPU0_f for ;\n Fri, 24 Apr 2026 16:05:24 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.10])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 3D92784B90\n for ; Fri, 24 Apr 2026 16:05:23 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2026 09:05:17 -0700","from orsmsx902.amr.corp.intel.com ([10.22.229.24])\n by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2026 09:05:16 -0700","from ORSMSX903.amr.corp.intel.com (10.22.229.25) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 24 Apr 2026 09:05:16 -0700","from ORSEDG902.ED.cps.intel.com (10.7.248.12) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 24 Apr 2026 09:05:16 -0700","from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.10) by\n edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 24 Apr 2026 09:05:16 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by PH8PR11MB7141.namprd11.prod.outlook.com (2603:10b6:510:22f::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.20; Fri, 24 Apr\n 2026 16:05:13 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026\n 16:05:12 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 578ED84BCD","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3D92784B90"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777046727;\n\tbh=7tu7aM+MO3DjqboGvcjliEB5LSK7ux5pXVVfXocHqXU=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=lbxyas+L6Qb0NrlK7rWQ9e/AGOrSADFASqGG/z2ZRbIxmHSiinbv/WgsUQI1UrSkc\n\t XPt6w1JWppzqr5N6YWPWgNJD25Hl0BTWJiuyHgvZXZXVcY4ZwH5H1qUhDdp4Yv9qSS\n\t uPcO3pGsAwleIqn/IToo4XC1i6PuzGmyhDYRhPNWp+vOYFTWsJpqxFdFNFbvBmXYeA\n\t 87gUOUVprrx9FJ0PdG3IODsqAdyJWyJPbM4NSZxOvEcJ1JSscC5WjF/iIPryvjvgh4\n\t AkXT/AejyRVrkVPHAil+eD23s4yj+3MwihSnrJPTKcMOBefvV+9tawtskzS3ffr77I\n\t fb+kQX7S61+Sg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.10;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 3D92784B90","X-CSE-ConnectionGUID":["1u9Bqq51S62JDAd1pxAU5g==","RxeC76ENQQ6ma/cXhVf4yw=="],"X-CSE-MsgGUID":["Sct4xHvHTVq9I9xhwiOX+w==","/h4JMixUQmOF4cUQu9ICpA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11766\"; a=\"89412681\"","E=Sophos;i=\"6.23,196,1770624000\"; d=\"scan'208\";a=\"89412681\"","E=Sophos;i=\"6.23,196,1770624000\"; d=\"scan'208\";a=\"228648119\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=WZ00tKMzhS7BHUOYBoIFuL0Ulyd1p/JVLDjwrXGs+NHSX+Q9njj3wgbVrpoi0/nYjBGx02RVPxjKwl7IlxrJAX+V+V4FOhMGgkb79sV/78hfx9RWNFcjAjjyRQK1zSHmUzJOtZWJ+MhDuT0JhwcD3OMfX0nGpF6DcR/NMImVtsQQnhXIgNFFBfNdUaLSP2/GekJwoTq/U/UxjH/iabwxqcZ59NZL8ntmsgsFsHIq19HFAo/gw3fED4YUkRh8BGmxFOzURH7tL5cZ2wIwyFBgqMFhoz0IznJx7Ff3iDFjUSIvEPSt95KeelkDYwNfBr6bZZqZOTiXiZWfATWKYFoqtg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=7tu7aM+MO3DjqboGvcjliEB5LSK7ux5pXVVfXocHqXU=;\n b=F+dQXVfnQcQhMLpKB7lvCnaBB20tb784BLIXz69BAOlo8pgPVvsapLZOEfYZ77gc8uobrL0FiBF8bHZEuO5IxVcd/DTsY6Glaozr+LqVNef5uyzOGVV7PLWEHFiHPk4htPb75rO16NkzVZ/OtDl4NjEgXo+kuUv9p1khxj3DwqGvAx4TynKWT/fJ/n3skX/txp7SayNoT/wdGAzEd0MuKDYGMAyGH/hZS7cAz0vtfyOUAl65vsfyGN3pgncZwN3R7NbWKs7wTZ38NUJMSngHmjbCVEyWpzgRBNNoXvTMMxfW5ZcIDGHYJQu1vOnqIh7kTI83WuALWJYLNIdQJKMmSw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"\"Loktionov, Aleksandr\" , \"Jose Ignacio\n Tornos Martinez\" , \"netdev@vger.kernel.org\"\n ","CC":"\"intel-wired-lan@lists.osuosl.org\" ,\n \"Kitszel, Przemyslaw\" , \"Keller, Jacob E\"\n , \"horms@kernel.org\" ,\n \"jesse.brandeburg@intel.com\" , \"Nguyen, Anthony\n L\" , \"davem@davemloft.net\" ,\n \"edumazet@google.com\" , \"kuba@kernel.org\"\n , \"pabeni@redhat.com\" ","Thread-Topic":"[PATCH net v4 4/4] ice: skip unnecessary VF reset when setting\n trust","Thread-Index":"AQHc0yHPL3usVtJTakKErPoC2Bf5x7XsoCewgAHBkWA=","Date":"Fri, 24 Apr 2026 16:05:12 +0000","Message-ID":"\n ","References":"<20260423130405.139568-1-jtornosm@redhat.com>\n <20260423130405.139568-5-jtornosm@redhat.com>\n ","In-Reply-To":"\n ","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|PH8PR11MB7141:EE_","x-ms-office365-filtering-correlation-id":"907c5e9d-d3d6-44b1-2fb7-08dea21b445a","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|1800799024|366016|38070700021|18002099003|22082099003|56012099003;","x-microsoft-antispam-message-info":"\n NpI1I/nsq4C7w6uG+I7PK5PShzVo9aVWFmGQx0zE4VohZxP+3auMDoxbw9zooEEy4g0n5BAF+BM68EdrujlnmmIIiKpYJqU6ZFh7ipKU68Ul5QzCEWH4aJnrhVQUfO9JvJT3xcY5wcJRqe81SLt0uUgbYdUsPkwoh1AYncHLFOGlNPd3woSUNO8bKFno7T0D2+Kx8JvIO3QpTPupNmEihfJSiun51TNL1sd/P/Eq3sklXeIeBtW/Mcojhs36eQ2qjoAPmLQ7rxe6mOhQol3kIwiX6E3VbSLezGA2Ooxv3nXiu6stbo8dLXBVuGra8iIXI1Gl8j9wwBvPq34/PQxnj8+URrbnv4VUX830fFL1eqJ2mGN75gHLewEeH9Fjx8ERXXXuuXH8I5R1xQpFEY1lvtRD9qEAM2m/K0rLe0Eq3o0foQDDGsjS+N/6R3HuScc+eES9mSOd5F9sqY0YbPxD5aSyrJb+NuDH8qiucOgHFJdKkFdGZy7bsEeNWqXPquCW/Kg/QVxLJGyumPSq9SujN1ffYbX47VGK1WG6JniZW/E3tph/YTKr6rJeTTViR0ZiZGVHOz4rM3WCelWlmwYb/p9mEakyTGRrpcZxYUzo6vw0vhEH4/umfHpSNQ4PQXAbJ/BKEAsNJ1pqGr/wpHVnU5io0I4JTfYpP3I8u7fc05IJbWRlhaGN40FYF8feZifbE0VxEDDgP9LJqEMJXbPfSh0n9jh4j1bR0RP6vZBNtou8KpIFegtKH158E/jXEHuTPyvlb4CGh9ULQWLcapuf+BFIZ2yw5bvWO4GHofFd6GI=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(1800799024)(366016)(38070700021)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n BXac2LqX6lFG7rCXRUAdJSi0gY7EO5EQ1FR/iviO/+y12had70cF4d3dcV/duAT6ErIkloXQDap+PLq3Xpn/XNyHldMKheBAIvBEmXg/4GgvfV2VeEYr1enJEtsykyVMGve+9N/rHsV+1i6rhM1I2iLPDnDP0KFy3hrJ0b1slVncueXMULsy7XrHYlbRuj8tcoLOCNHy9PNOl8DllWWD03jCnD5BQKXW85jDkocdxNehRux3YCU7x6lNpAt0bVa9tccPDTGz/Kc/ZU2xChbphShNZs9kFJeK2Tf46ceX0IIvPMJiQBImw38r4L2Wbb4C7WCcpgy6O2d0wF4jetRhFCoJ4m17s9dZO10XmEy62+oA1865z9tcq/Jl7iITXJbpRZnCz9h6Oa0OOwlHOviCtUPwwA6oWthWLbngiLeHu4C0aTRBuCsIB3Dr62wIkyeK2NCN5GocMaRVN5TIhRucqjwdDO/SGJVeRWkE//afXwcTGM6yF/gbK5WK8arhhgPsDQdzqcA2JK8vzDxskkIpy9o83tRPw5HuxaCaEV6m3O19iauEV+nMscq4yOcmLQH/j0EqETh1fQVIWwQJqAqgeiZ5aGeD+vGCS15QJV0XHEV5TC2xVM6C5R0Pt08mxPCb7eaf1sbzb+JK1smMIviTO/zaskS6H2SUo1PejC10OLVuLPTfP096Z0HTl3X14dN0ivfJF6+VGA5cyISTiGw0sLcxGB2heBbTO3ygn6/Rl11+PUpFhvoXsrnsyNlh0qLby42aNyB1zKN4JXghC6CRikpDuPKGjvwV7kX9tQjX+zwsCsSdA/8pp9bED5K09YmRVop9DZOy1Hk8r5xHxxJwx8T7K/lyK1iTiJ+6Otv9ArUslbn6KZFICFn9FpgURat8cygKySJ1Fi4iGY7Ljh8FzOoYqo2okWJw+M+n6UimA03/th16QVyZ6YPPD6QyHU191ww5XImmjACA42F/698JtY1DTFsG8qUIENB2LH+G8El9XBKYzSC9xBD+QUQf1KQcgc7h9diqCP0uJPy9+jV/SvyjDUvFzFZd/X39dA7hkthV+TjskE59JWNY2d9MculRZ4yr53R/0ZR9eCMnw01c4b2Y0PvwYIPfm7LNs3/DO78ID1pxHS64KcmM2lx1aXy2GRQp+iRkHbWSmKxiuH2VI48wQWPun7E/otYvEFGXiLPqRezHnXulJfir+QK6Aiqq7y9OwIeuUCsmRwISzWB/pZCWpZS6S4K81w1iFJBmYr0oLjvMoqWIoFGmZTRJ7LJGXK3+YFGznJQlbHPquRHDIo6un8xqL0s38cuZu9I/duFRxAKmIJh+IKselKVkCRhuhdqkmsYFKJB4o8hfW0QYYSn+f30qWfpj+Op+AbSuURvPlRixjxUis29MhgorvdFv6iWFGCjZX6BVSj6aEySUORMzUgo2V3MmOz4PdUUkgbMbe1iScaYEAIp7T8OipmMnGzyvm+El/+GETUyODJ6lSCLV7UimFlyw1r1MLI2kxk78IKEr2cPIRh+lRQgLOylM3n+CJdGCkM59Ha3sFlTSHB7ZZ6GXcZEnEBu5EsSF0YOWAyBJhoOkf/0eRrwkinEh1et4rJ2mbof2oHAacbY8kLbnxV4qM0vOYNDr1Xp3pSQxWoQtj9jGqlVX2seDN/pXSW/D/LqVLuwPun3jOrOLBia4e4RrO05e11R8uPx4oEBBBeF9JSGpOtn3YNIZ8UqzVqett2FjKIIYU64wmklTj7S4aocF8iXUKsbyjSSU2qU=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n oS961Ham+9BmpwCpekRCTMNxrGEQ9FuqtHd2e68xz+1JqGJc0Wzdq7fjIM4VDnZdtJo+jU3zOg/C3Y0Swq05R6yc02U/UMPtSrmYdE5SPn9XAU3j27PJEnqXbmkOtniiVHbXYvwfuEU/T+rOWdBhTveEygdi6bJHe5fgiNx0IUxi44cCDBPModxxIDChW4leIGm9yeYV01gVR/aXaab8nFr07h+ACrasU+IkZS5HGjarb25iKOaXy2l2MFsThrgarw6IyAsQwFPDzoFhL5G+PpVUr5ZJhBuJMoiVmTSdXOnmdoHutoyqUQT5bEBb/ONkP38MesH16YrTnpM6RPaDuw==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 907c5e9d-d3d6-44b1-2fb7-08dea21b445a","X-MS-Exchange-CrossTenant-originalarrivaltime":"24 Apr 2026 16:05:12.7280 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n h8NM4WnOp7KdXJnR/TSx6ZhzJkkamUtqUGu5E1F5kJj+lq4wNNgMgMpaQp4NQ9gQ1ILfAVLhNWKuXRj43Hu4ULPXuIxWHB2kwW/1cLolel4=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH8PR11MB7141","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777046724; x=1808582724;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=tLRlenOljrKy3iMdn06AwdeABpO7b8HBkmlxDbvQiqg=;\n b=ARpAzeSR+R82H0vodHcL1A5DQR1/tHGvo2EtZxlNiUidGHY61YGkZhgc\n g8zxCjZj/NvSydX0CeduYH0828F2u795UxCNtgG+L3qtSnHvcfXKEThgJ\n bSWqt006YCdfOwL6kYPt0E+OSsxzKd1f0EunNC1SffJIj1rTWxTHWFIBM\n dzd99BzQjoX7DSQK3OH9R1S+3CWM4bPYAQIdPZPI3K/AjUt8lLu6dv5lk\n W+SYHFVTs+ZNSmIClcGOiNZpYcOgAnkR4gjUy4UlMOgA7N2qPwOBAqw9F\n Km1pm9wN31Hjpl4bWkrlLWSv5Xv2Ng7X45oS4GjB1XRzn/UzQ/06NpAmc\n A==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=ARpAzeSR","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3682532,"web_url":"http://patchwork.ozlabs.org/comment/3682532/","msgid":"<20260427075948.870208-1-jtornosm@redhat.com>","list_archive_url":null,"date":"2026-04-27T07:59:48","subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/people/93070/","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"content":"Hello Aleksandr,\n\n> One more nit, kdoc should end with '*/' not '**/'\nOk, in the current code there are already some functions with headers\nending in '**/' and others with '*/' , the functions I have added or\nchanged the prototype in the series will all end in '*/' as you say,\nin the next version.\n\nThanks\n\nBest regards\nJose Ignacio","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=emdHkRMZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3wwK72kBz1yJX\n\tfor ; Mon, 27 Apr 2026 18:00:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 0D39980F88;\n\tMon, 27 Apr 2026 08:00:16 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id PnjttQyV8ZKB; Mon, 27 Apr 2026 08:00:12 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5F9D980EF7;\n\tMon, 27 Apr 2026 08:00:12 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 60EA31B8\n for ; Mon, 27 Apr 2026 08:00:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id D1A9961579\n for ; Mon, 27 Apr 2026 08:00:03 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DFAeMiRF-BG1 for ;\n Mon, 27 Apr 2026 08:00:03 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 1791F6132D\n for ; Mon, 27 Apr 2026 08:00:02 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-QMhenUDpPoqrWVabTYQnhg-1; Mon,\n 27 Apr 2026 03:59:56 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6C6221956046; Mon, 27 Apr 2026 07:59:54 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.32.96])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AF372180047F; Mon, 27 Apr 2026 07:59:49 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5F9D980EF7","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1791F6132D"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777276812;\n\tbh=8muKc8/uv8ZwFs1HhIEKd2DGHtuHL4YiGE08g4+DiMc=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=emdHkRMZduq6IcCRpEuAFUhEXYNtSVWknX8hP94jLVyG12lgJgG3E7L5x16g/pOR0\n\t mWwIlsVvzXfu0jvrmJ5WXCeZTw9lMXcuT6cdeluTM9qO6KAzafQKPZKMJ/mcK/dVe0\n\t K6LtcS8i7/AcqOEWkRTy60lDIDwVvoaATcW0vKn+ubEcfaxEdWByjmzsOW3JoSzKDw\n\t EwIqqKbIDfAMPi0tAKPSEEw11KSRHzp+WvWO2+CkXHZ74Ksi8eRvA6LHMXiU/Cl9Vf\n\t c4iQN/dj354t+AL7kTQjb0X9Q/N3AL/atjStbTb8G+zBXiNbzIpEihUsdLjhTH69xL\n\t ZQGQu/Lk4CUUQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1791F6132D","X-MC-Unique":"QMhenUDpPoqrWVabTYQnhg-1","X-Mimecast-MFC-AGG-ID":"QMhenUDpPoqrWVabTYQnhg_1777276795","From":"Jose Ignacio Tornos Martinez ","To":"aleksandr.loktionov@intel.com","Cc":"anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n horms@kernel.org, intel-wired-lan@lists.osuosl.org,\n jacob.e.keller@intel.com, jesse.brandeburg@intel.com, jtornosm@redhat.com,\n kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,\n przemyslaw.kitszel@intel.com","Date":"Mon, 27 Apr 2026 09:59:48 +0200","Message-ID":"<20260427075948.870208-1-jtornosm@redhat.com>","In-Reply-To":"\n ","References":"\n ","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-MFC-PROC-ID":"QsrTqtHCvqQEHQL9ndU5nkfop6e-YjvhFJgtSaqk-6E_1777276795","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1777276800;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8muKc8/uv8ZwFs1HhIEKd2DGHtuHL4YiGE08g4+DiMc=;\n b=Xq3QQQ+Jw3nWYRGtyqdnWSxphmF2Pf2Dt+C9ZJoubc/F0MzfHC2i14U30TINr+Nm3m6QlC\n nTUnw1y5ZuMtYFtW09++24YCmw3kH1G/LTvP8KtLHfKhii73kJMMecN3rUN1RHhkUu52aQ\n 3Pb7xFdD2D2yKvQF6AyfBY6S6X1RoFw=","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=Xq3QQQ+J"],"Subject":"Re: [Intel-wired-lan] [PATCH net v4 4/4] ice: skip unnecessary VF\n reset when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]