[{"id":3681442,"web_url":"http://patchwork.ozlabs.org/comment/3681442/","msgid":"<kxltg2wx2zwuliguszipn3hldalok36finlqwxe4qh3e2mr3hv@ymc7gwkozlzo>","list_archive_url":null,"date":"2026-04-23T12:43:15","subject":"Re: [PATCH v2 41/41] drm: renesas: shmobile: remove now-redundant\n call to drm_connector_attach_encoder()","submitter":{"id":90483,"url":"http://patchwork.ozlabs.org/api/people/90483/","name":"Dmitry Baryshkov","email":"dmitry.baryshkov@oss.qualcomm.com"},"content":"On Thu, Apr 23, 2026 at 01:55:50PM +0200, Luca Ceresoli wrote:\n> shmob_drm_connector_create() can init the connector in two ways, based on\n> the 'if (sdev->pdata)':\n> \n>  1. manually in shmob_drm_connector_create(), or\n>  2. delegating to drm_bridge_connector_init()\n> \n> Whichever branch is taken, drm_connector_attach_encoder() is called\n> immediately after to attach the connector to the encoder.\n> \n> Now drm_bridge_connector_init() calls drm_connector_attach_encoder() on the\n> connector so it is not needed anymore in case 2 and should be removed, but\n> it is still needed in case 1. Move drm_connector_attach_encoder() from the\n> common path to inside shmob_drm_connector_create() in order to get back to\n> a single drm_connector_attach_encoder() in both cases.\n> \n> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>\n> \n> ---\n> \n> Changes in v2:\n> - rewrote completely, fixing potential ERR_PTR deref and ending up with\n>   a cleaner patch\n> - also wrote more extensive commit message\n> ---\n>  .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c    | 16 +++++++---------\n>  1 file changed, 7 insertions(+), 9 deletions(-)\n\nLGTM now.","headers":{"Return-Path":"\n <linux-tegra+bounces-13914-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=kz7jLeBz;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=XBzNxx68;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13914-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"kz7jLeBz\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"XBzNxx68\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1bQR6VVlz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 22:44:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 978523006122\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 12:43:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DC90D3EE1C4;\n\tThu, 23 Apr 2026 12:43:23 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 922C13EDAA2\n\tfor <linux-tegra@vger.kernel.org>; Thu, 23 Apr 2026 12:43:21 +0000 (UTC)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63N8tq3d028801\n\tfor <linux-tegra@vger.kernel.org>; Thu, 23 Apr 2026 12:43:21 GMT","from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n [209.85.160.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqdjm1jde-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-tegra@vger.kernel.org>; Thu, 23 Apr 2026 12:43:20 +0000 (GMT)","by mail-qt1-f199.google.com with SMTP id\n d75a77b69052e-50d890580e1so69890311cf.3\n        for <linux-tegra@vger.kernel.org>;\n Thu, 23 Apr 2026 05:43:20 -0700 (PDT)","from umbar.lan\n (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi.\n [2001:14ba:a073:af00:264b:feff:fe8b:be8a])\n        by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a4187e12d5sm5133222e87.41.2026.04.23.05.43.17\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Thu, 23 Apr 2026 05:43:17 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776948203; cv=none;\n b=tOPcADqJoLaRUQSd7Z+jPXAXDFm7WxwgscFdUnRyy04dX1V5P8FG8dNrpFfruZ2xgUf+3S+aw+D9gSyMNkceSa/J+k3ll4hngzrAtvUGhQ0eLWAvXD7rClcXOw1e7RKjrqp8uoCIMu/sdbUKahDJz9S77dlZ5By7iMTrX8MZ8c0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776948203; c=relaxed/simple;\n\tbh=invPGYQ7NdzxSWBArDuv9hg22Fo9hiwrNySrMfHzM1E=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=tVE72nOmMyi91n5T1GovphEAOkhp9gPXvFTalGLefw7BqvB5LdJwwem/INoKdCIrdEzreWaHF9fUWg8zwALDLvD+6EFVFqFHqIG/0OoPGPL20H0VBwuadEv4i0qtgvrN5x3FcYges8wTjdNmu+TN8FDw7da4ZkQR6SrzOdYywAU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=kz7jLeBz;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=XBzNxx68; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to; s=qcppdkim1; bh=BWsj0dSc6URl6GzhKqtvvsA5\n\tlvMVdCA8oRPUY5tXRI4=; b=kz7jLeBzJhutORDVFx2iCKLx6BbKBMv6ZD/OAzXy\n\tA0y9fL8VJ5azBC4WAyY4ur8i751/Cb6BI3cUXuKQsmwXwY34+fQJImLA7H/88D4v\n\t1BG5/aKfbFE/R3yiLswxqHx22LbWVldKcz8Z7n+9vvLF6H0umWX04940IYnC18qK\n\ttqpEoazA4Gx/aTQtT+TClBki1rUGdP2FhQ9RJS7+TJ/lTUY5IZeO+dCzFtwCvg78\n\tNWGFar9sZDj1b7ftpz2facMTIbdcJTW1sSKycWLMr7MmGIEbOm3qQC3OGbd5TyaF\n\t4WBlrARrtwmAMfi0rdEMVIqZqVfGqYskKA29CbPTq0GlIQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=oss.qualcomm.com; s=google; t=1776948200; x=1777553000;\n darn=vger.kernel.org;\n        h=in-reply-to:content-disposition:mime-version:references:message-id\n         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n        bh=BWsj0dSc6URl6GzhKqtvvsA5lvMVdCA8oRPUY5tXRI4=;\n        b=XBzNxx68BMtEqy5eaEmme7eGtn+S/wAJiiOv1lbEEZK0ga+USBKWku6fuFlzN7YGUu\n         OSJ8VB8I56ceD87LJmDjncGto5TaxoRr3hHSuUxohS5ZJzSO4jq/A/NH6gIDd4hy/5UP\n         AQHNUGnl8QuNFeqPyCDeWEsbO8XrVjvylbo40tmXfLHxLdX0xCmhUDIKxbT3/SF3O+NC\n         PFXFskwGcBKRMmIp1KI2GdTcIvj/U/NbJIDvVIy6OgtQHFYutHwfsVQREKZfxWghJVtk\n         WBkNLCyy48/mHS3XrD7pey+H9i3enf/+73+k7BpLRn6sv+iQIg4z6To0sFLp9lsXNWBv\n         1fcg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776948200; x=1777553000;\n        h=in-reply-to:content-disposition:mime-version:references:message-id\n         :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n         :subject:date:message-id:reply-to;\n        bh=BWsj0dSc6URl6GzhKqtvvsA5lvMVdCA8oRPUY5tXRI4=;\n        b=DpBekU6tYEkMH3ttP+jwBn26BsL5z/Cfb7f3ixxpE3+CTQT+bjNCrXswRC/F6HFYcT\n         4bwnJDvkFg80/nH1LaePIsl0JXf989OBKtyCONKb2HbaCxiPgT+EUgepWkpDquse2xed\n         vDxv4kNLKuXk/if0uPudSK95ori7wlAuHVi19wwfXo1YI5ZOp1AvbbAmt/+F4Rl7VuFv\n         juUYjqfG5Vuahy7xkjj8g+UVkppDPvp9gJXawZkp6EvymwMxYLbL0cXZRrs0GWP2GEsn\n         olHZ0E3g5eLmy6GqrAFfVAR58avMLGTmNqroZqdLqKIkVYgN7q+PJDcGXTYlwsbHmiXB\n         dWnQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+LBqL0TOHIx35od9QweNMkhSZe4vhvcA3HrqFujZtlEq9mzeakv7Asu+XeZzr65JLfEpr5hw8gsEAt0A==@vger.kernel.org","X-Gm-Message-State":"AOJu0Ywfo5oM0WnGQJ3VI0oAIuZt2i+YG+hLO2lFVzwzFSs39K11gEwv\n\tNKJsS/8bccOvHgzeDvFaMbr+/SOsw6Hi0KGTJkHilMP5mktljFoBFRALuEjpgpPf6JuSW9IHRYX\n\tc6sxdBSm1AjJs6yOP94Ko6DteQsVZMYvyXI2afBdZOwTPQnzBgx/tPImxihvo5oOhnA==","X-Gm-Gg":"AeBDieu1diX/8u1s2LcVN4KgaBBxuQYwO9yc4Q4ny6gCpL9Phnz6VNCv52tLmO00YK6\n\txcr5DqFBdELStvLxejgdpw8D9m0mGfdIKAqAE7ek21Dq/7j+/0VfvofQzylHEXKZgvFtHatqCxp\n\tf72F6SQWpr5EmKJo+ZYFz+8sJ3b2QJ9S/T4bSHzWy8EQDBIiDr/wJMfCBMzHTWq61LCJHqL5dFI\n\tvSW6wntbojPl9RRKzrWB4Wr/bl2sE+MHbxVYO8uWxulDK6RjJL5l5pWkGjMdryNwVY/5wQQii+A\n\tMRDzG82GFtOkdJ2wDApsRC4RpnB+kt8oO76U9NJwOsfz0858a1zdrFwPfBf8kc/dcBMg3l7LFFm\n\t8dYTXEsif28vl48cwYJXxEPt7pagCRvirelc894RW7Yz6ncgueY7mYdY59+vUdVNIJxzbTSM6d2\n\txwIuBSfUtmjYywoQVp+TWnxgWAMO9dU/G7waLKz/qB231rSw==","X-Received":["by 2002:ac8:57c1:0:b0:50f:b6ef:e10b with SMTP id\n d75a77b69052e-50fb6f016cemr157722311cf.27.1776948199572;\n        Thu, 23 Apr 2026 05:43:19 -0700 (PDT)","by 2002:ac8:57c1:0:b0:50f:b6ef:e10b with SMTP id\n d75a77b69052e-50fb6f016cemr157720991cf.27.1776948198942;\n        Thu, 23 Apr 2026 05:43:18 -0700 (PDT)"],"Date":"Thu, 23 Apr 2026 15:43:15 +0300","From":"Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>","To":"Luca Ceresoli <luca.ceresoli@bootlin.com>","Cc":"Andrzej Hajda <andrzej.hajda@intel.com>,\n Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,\n Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,\n Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,\n Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,\n Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,\n David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,\n Sasha Finkelstein <fnkl.kernel@gmail.com>, Janne Grunau <j@jannau.net>,\n Liu Ying <victor.liu@nxp.com>, Douglas Anderson <dianders@chromium.org>,\n Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,\n Lucas Stach <l.stach@pengutronix.de>, Frank Li <Frank.Li@nxp.com>,\n Sascha Hauer <s.hauer@pengutronix.de>,\n Pengutronix Kernel Team <kernel@pengutronix.de>,\n Fabio Estevam <festevam@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>,\n Paul Cercueil <paul@crapouillou.net>,\n Anitha Chrisanthus <anitha.chrisanthus@intel.com>,\n Chun-Kuang Hu <chunkuang.hu@kernel.org>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,\n Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>,\n Martin Blumenstingl <martin.blumenstingl@googlemail.com>,\n Rob Clark <robin.clark@oss.qualcomm.com>,\n Dmitry Baryshkov <lumag@kernel.org>, Abhinav Kumar <abhinav.kumar@linux.dev>,\n Jessica Zhang <jesszhan0024@gmail.com>, Sean Paul <sean@poorly.run>,\n Marijn Suijten <marijn.suijten@somainline.org>,\n Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,\n Sandy Huang <hjc@rock-chips.com>,\n Heiko =?utf-8?q?St=C3=BCbner?= <heiko@sntech.de>,\n Andy Yan <andy.yan@rock-chips.com>,\n Thierry Reding <thierry.reding@gmail.com>,\n Mikko Perttunen <mperttunen@nvidia.com>,\n Jonathan Hunter <jonathanh@nvidia.com>,\n Icenowy Zheng <zhengxingda@iscas.ac.cn>, Jingoo Han <jingoohan1@gmail.com>,\n Inki Dae <inki.dae@samsung.com>, Seung-Woo Kim <sw0312.kim@samsung.com>,\n Kyungmin Park <kyungmin.park@samsung.com>,\n Krzysztof Kozlowski <krzk@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>,\n Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,\n Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,\n Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,\n Geert Uytterhoeven <geert+renesas@glider.be>,\n Magnus Damm <magnus.damm@gmail.com>, Biju Das <biju.das.jz@bp.renesas.com>,\n Marek Vasut <marex@denx.de>, Stefan Agner <stefan@agner.ch>,\n Jyri Sarha <jyri.sarha@iki.fi>, Michal Simek <michal.simek@amd.com>,\n Hui Pu <Hui.Pu@gehealthcare.com>, Ian Ray <ian.ray@gehealthcare.com>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,\n asahi@lists.linux.dev, imx@lists.linux.dev,\n linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,\n linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org,\n linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,\n linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,\n linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org","Subject":"Re: [PATCH v2 41/41] drm: renesas: shmobile: remove now-redundant\n call to drm_connector_attach_encoder()","Message-ID":"<kxltg2wx2zwuliguszipn3hldalok36finlqwxe4qh3e2mr3hv@ymc7gwkozlzo>","References":"\n <20260423-drm-bridge-connector-attach_encoder-v2-0-2ae6ca69b390@bootlin.com>\n <20260423115550.444930-7-luca.ceresoli@bootlin.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260423115550.444930-7-luca.ceresoli@bootlin.com>","X-Authority-Analysis":"v=2.4 cv=EZn4hvmC c=1 sm=1 tr=0 ts=69ea13e8 cx=c_pps\n a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=P-IC7800AAAA:8\n a=W9-MdjkIhrGOmg5mk6gA:9 a=CjuIK1q_8ugA:10 a=kacYvNCVWA4VmyqE58fU:22\n a=d3PnA9EDa4IxuAV0gXij:22","X-Proofpoint-GUID":"YiNi-i2VzXTQeu1kHY-_T-ePkJD-He0e","X-Proofpoint-ORIG-GUID":"YiNi-i2VzXTQeu1kHY-_T-ePkJD-He0e","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDEyNiBTYWx0ZWRfXx7ZH5nHa+ZCq\n taSq1i4V/e02Bp0if6/qYRwXWQzjsgej/rP25jn+MDrLkCPJ2KPbUYUO2DLDdwoRverfPSjQKgS\n 3bOxVK6cm/0c+8obibRwaMPygdYX0VnuziJdpKnRGxQttGh54bP1EvaCC71bNY42usOAk3uz60A\n CpILcL22h4QGNgmIdmACBZQkn0MJDqIC44stGbYyNAsaC4vlzJeJ/XgGN0x0xrT835Aanl2TFO6\n hN1HMDKE49ro3slF/cpT5Rx7gWN/q6OLno88uqouh/E4KJZbAY3jLLm9e4HJgdStiU0mtXgiNcy\n qSKnuHsFcpl5iQAZ3rmK+2cUZLjiTgnXZ57PaOQXAZPFEFDPgWS+LpRKjAZxyJjUhmMmfKwRyJe\n yXhCb0DqM2017zUkhG5Yx39C2tmSivQ96hpBxJXxQNCRpM/XX9uvKVu16dR45Vr/8wL2pSIYE1b\n 75m3hPTk0au8OuVv43Q==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0\n spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230126"}},{"id":3681843,"web_url":"http://patchwork.ozlabs.org/comment/3681843/","msgid":"<CAMuHMdVbEV0b+MwCjqyc9Q0EjasD2hoN0rqWtjfmPPotZ19Lrw@mail.gmail.com>","list_archive_url":null,"date":"2026-04-24T07:50:10","subject":"Re: [PATCH v2 41/41] drm: renesas: shmobile: remove now-redundant\n call to drm_connector_attach_encoder()","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Luca,\n\nOn Thu, 23 Apr 2026 at 13:59, Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:\n> shmob_drm_connector_create() can init the connector in two ways, based on\n> the 'if (sdev->pdata)':\n>\n>  1. manually in shmob_drm_connector_create(), or\n>  2. delegating to drm_bridge_connector_init()\n>\n> Whichever branch is taken, drm_connector_attach_encoder() is called\n> immediately after to attach the connector to the encoder.\n>\n> Now drm_bridge_connector_init() calls drm_connector_attach_encoder() on the\n> connector so it is not needed anymore in case 2 and should be removed, but\n> it is still needed in case 1. Move drm_connector_attach_encoder() from the\n> common path to inside shmob_drm_connector_create() in order to get back to\n> a single drm_connector_attach_encoder() in both cases.\n>\n> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>\n\nFor case 2:\nTested-by: Geert Uytterhoeven <geert+renesas@glider.be>\n\nAs none of the old SH platform have been converted from\nsh_mobile_lcdc_fb to shmob-drm yet, case 1 cannot be tested.\n\nGr{oetje,eeting}s,\n\n                        Geert","headers":{"Return-Path":"\n <linux-tegra+bounces-13936-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13936-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.160.41","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g250W0lvnz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 17:57:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 709E73003D39\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 07:57:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E6638378D78;\n\tFri, 24 Apr 2026 07:57:26 +0000 (UTC)","from mail-oa1-f41.google.com (mail-oa1-f41.google.com\n [209.85.160.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D78C4364055\n\tfor <linux-tegra@vger.kernel.org>; Fri, 24 Apr 2026 07:57:22 +0000 (UTC)","by mail-oa1-f41.google.com with SMTP id\n 586e51a60fabf-42c0b0ffac1so2664724fac.2\n        for <linux-tegra@vger.kernel.org>;\n Fri, 24 Apr 2026 00:57:22 -0700 (PDT)","from mail-oo1-f41.google.com (mail-oo1-f41.google.com.\n [209.85.161.41])\n        by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-42fbe8a0bcbsm7435585fac.2.2026.04.24.00.57.20\n        for <linux-tegra@vger.kernel.org>\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Fri, 24 Apr 2026 00:57:20 -0700 (PDT)","by mail-oo1-f41.google.com with SMTP id\n 006d021491bc7-682fce74c06so6021223eaf.3\n        for <linux-tegra@vger.kernel.org>;\n Fri, 24 Apr 2026 00:57:20 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777017445; cv=none;\n b=m4MSrb8M89ESYXV9RsSOmk/9RAuQfSkbCwAAiGGa1L2fHm9MUy/IXopE0pjKoU7/Yufv+Vy2NMOa4++zkmd+FTc9Uk+QBI646Ejwg51v7tVTu8EgI7chG/di0m38j3zspaFfDCF7638+i98BmjMePCkdgPdNnDal1AnYRnUHyq8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777017445; c=relaxed/simple;\n\tbh=BZaZ3g7ZBPkjQoz8nLCka6ZxevyTyp8FYNkCXs7p8Ww=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=XoVZobdvUgZ79lTsd9NGg588L3kPXrMOdV9iUk/KYr3U3Hc4tuDxjK9XuOQiGTCIE4Okb/D993xpCJYJY718/Q1zX3LyfHcfMFscXaYP3n3vt6mnKoCPwcaGLyM6lDZyBIm7yVMbwF16mE6MLncm+Vpa8SY/DTo6OEpqq1sPcq0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org;\n spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.160.41","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777017441; x=1777622241;\n        h=cc:to:subject:message-id:date:from:in-reply-to:references\n         :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=+k21mzy1Q8IyL290m/XCuURamP2UyoHvl1hWQE5Pk/w=;\n        b=UoOB+9HT6cp0icDnXhNzqa9iA0YWAV4uXwj1i29p5/6dkkZY3Yxmk9fu+Va3HXYTl3\n         aFbY2cstC/Su1duZvoIBk2mhkHz/wHBcpLWR/2Qh9Adg3NXpqS2zVAUAJuQsLNvDmpCb\n         1nDuCfd04nYlgujp48GeqmI2Fc43XxVW5g3T269iIf+pgV5Jr7FnKnRIkkuWONrVng6U\n         ZDo4/RW3Lx+YpjAvq6zRjLNHv0UuACtJg6Z4oOeEcE0NBsrUBZSuDrBUCl/cbJpCvSG6\n         cdqD3tPWDr8cJV8Om6coKvntINYBXVnlIrl2ai5KSuP5yAtGhW0lPKJAe7aXhWci715/\n         aNMg==","X-Forwarded-Encrypted":["i=1;\n AFNElJ/6yAcB/C3h/L4TRunKPwNet53cbQzSI90o2M9kMkXQpjy45QKOn+O1Lvfb6tRV8JMIZ/qhTWTxEBzwFA==@vger.kernel.org","i=1;\n AFNElJ9m/5oGKRfmw23mwn4cgPv3c7Phic6F2wkOMw0CCn8UloKrjTQRqFq+GLsYkGjJ3qFYRCEbgmMyMWxxDg==@vger.kernel.org"],"X-Gm-Message-State":"AOJu0YxFR1GOIrhPhJT5eaxIYriLml3kj4HgLuRacu62FlfSAkZSSqhC\n\tEHqBmoM+DzRS+5yp4+j5x+JRtNTBLNeDpG9vS9elbN3gjdFmDmCmNjSyMuuvXDwA0Hs=","X-Gm-Gg":"AeBDietobgdNH5lvbTwjgpCM99eL7plJ58Eg7V4XRz2GHBZHTm0bNimDh2HyQtjY/cA\n\tiSCRVJy1ZTT/ta1+HzFkBXYFr6fUjdIt4/GybfPMbZAZ9oIq9SRn8aKagZ51ZZbM6Y65r8FwZ+7\n\tD37bJOrnwEkTgtVXHaYrg98KsXkl9V0HDrpzlBMVgZZBCakuvBVYqPfWe4VqPftFZudg9+atSG3\n\tQF/W4O511wVMEERwO8UvowevROVCLtYS7hZbODyNFpd64LjXFtspkAx6pfC2wIG1Ca8TioHfG5I\n\t8/Ns8KfgnxxFDW3T7LsRV0g3Z163Fo+y9B7GLYoVArZHUifGSTkvIsInIQ3XWxOek69QwzcKmjh\n\tNXU01s7vkQ7BOHrWZnhow+IWQXh9SO/3ywZBdPLVYxpA5v0yk4G/37IU+YMZ1BixjM4Exxbso4j\n\tg/EmJNR2jOF0BGHWM6sPyyQBlk9r/ip6In7BxTLifGnr0WuOdMF3JWmJYCEmnL0O9MfTHsYHk=","X-Received":["by 2002:a05:6870:9a8b:b0:417:22e:e2d1 with SMTP id\n 586e51a60fabf-42abf23c02fmr19908387fac.2.1777017441448;\n        Fri, 24 Apr 2026 00:57:21 -0700 (PDT)","by 2002:a05:6102:38cb:b0:5e8:1d93:921a with SMTP id\n ada2fe7eead31-616f772e968mr14645934137.15.1777017023068; Fri, 24 Apr 2026\n 00:50:23 -0700 (PDT)"],"Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"\n <20260423-drm-bridge-connector-attach_encoder-v2-0-2ae6ca69b390@bootlin.com>\n <20260423115550.444930-7-luca.ceresoli@bootlin.com>","In-Reply-To":"<20260423115550.444930-7-luca.ceresoli@bootlin.com>","From":"Geert Uytterhoeven <geert@linux-m68k.org>","Date":"Fri, 24 Apr 2026 09:50:10 +0200","X-Gmail-Original-Message-ID":"\n <CAMuHMdVbEV0b+MwCjqyc9Q0EjasD2hoN0rqWtjfmPPotZ19Lrw@mail.gmail.com>","X-Gm-Features":"AQROBzASdrVB_Aky8lNaIViGqa4fIOoRKTkBEjNLF-nFJbKyYgy5oQezNNnYjKM","Message-ID":"\n <CAMuHMdVbEV0b+MwCjqyc9Q0EjasD2hoN0rqWtjfmPPotZ19Lrw@mail.gmail.com>","Subject":"Re: [PATCH v2 41/41] drm: renesas: shmobile: remove now-redundant\n call to drm_connector_attach_encoder()","To":"Luca Ceresoli <luca.ceresoli@bootlin.com>","Cc":"Andrzej Hajda <andrzej.hajda@intel.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,  Robert Foss <rfoss@kernel.org>,\n Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,\n  Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,\n  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,\n Maxime Ripard <mripard@kernel.org>,  Thomas Zimmermann <tzimmermann@suse.de>,\n David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,\n  Sasha Finkelstein <fnkl.kernel@gmail.com>, Janne Grunau <j@jannau.net>,\n Liu Ying <victor.liu@nxp.com>,  Douglas Anderson <dianders@chromium.org>,\n Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,\n  Lucas Stach <l.stach@pengutronix.de>, Frank Li <Frank.Li@nxp.com>,\n  Sascha Hauer <s.hauer@pengutronix.de>,\n Pengutronix Kernel Team <kernel@pengutronix.de>,\n  Fabio Estevam <festevam@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>,\n  Paul Cercueil <paul@crapouillou.net>,\n Anitha Chrisanthus <anitha.chrisanthus@intel.com>,\n  Chun-Kuang Hu <chunkuang.hu@kernel.org>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,\n  Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>,\n  Martin Blumenstingl <martin.blumenstingl@googlemail.com>,\n  Rob Clark <robin.clark@oss.qualcomm.com>,\n Dmitry Baryshkov <lumag@kernel.org>,\n  Abhinav Kumar <abhinav.kumar@linux.dev>,\n Jessica Zhang <jesszhan0024@gmail.com>,  Sean Paul <sean@poorly.run>,\n Marijn Suijten <marijn.suijten@somainline.org>,\n  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,\n Sandy Huang <hjc@rock-chips.com>,\n =?utf-8?q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,\n  Andy Yan <andy.yan@rock-chips.com>,\n Thierry Reding <thierry.reding@gmail.com>,\n  Mikko Perttunen <mperttunen@nvidia.com>,\n Jonathan Hunter <jonathanh@nvidia.com>,\n  Icenowy Zheng <zhengxingda@iscas.ac.cn>, Jingoo Han <jingoohan1@gmail.com>,\n  Inki Dae <inki.dae@samsung.com>, Seung-Woo Kim <sw0312.kim@samsung.com>,\n  Kyungmin Park <kyungmin.park@samsung.com>,\n Krzysztof Kozlowski <krzk@kernel.org>,\n  Alim Akhtar <alim.akhtar@samsung.com>,\n  Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,\n  Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,\n  Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,\n  Geert Uytterhoeven <geert+renesas@glider.be>,\n Magnus Damm <magnus.damm@gmail.com>,  Biju Das <biju.das.jz@bp.renesas.com>,\n Marek Vasut <marex@denx.de>,  Stefan Agner <stefan@agner.ch>,\n Jyri Sarha <jyri.sarha@iki.fi>, Michal Simek <michal.simek@amd.com>,\n  Hui Pu <Hui.Pu@gehealthcare.com>, Ian Ray <ian.ray@gehealthcare.com>,\n  Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n dri-devel@lists.freedesktop.org,  linux-kernel@vger.kernel.org,\n asahi@lists.linux.dev, imx@lists.linux.dev,\n  linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,\n  linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org,\n  linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,\n  linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,\n  linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]