[{"id":3681437,"web_url":"http://patchwork.ozlabs.org/comment/3681437/","msgid":"<20260423124115.GA450362@pevik>","list_archive_url":null,"date":"2026-04-23T12:41:15","subject":"Re: [LTP] [PATCH v2 1/8] syscalls: Add epoll_create03","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Cyril,\n\nLGTM, thanks!\nReviewed-by: Petr Vorel \n\n> +\n> +/*\\\n> + * Verify that epoll_create() fails with EMFILE when the per-process limit on\nnit (please fix before merge):\n:manpage:`epoll_create(2)`\n\nto have link to the man page in the test catalog\nhttps://man7.org/linux/man-pages/man2/epoll_create.2.html\n\nhttps://github.com/linux-test-project/ltp-agent/pull/4\n\nKind regards,\nPetr","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=Nj6yCKrA;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=y+PPJ3Eg;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=uyL8CSRb;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=CL5JDdsm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1bLd5VCRz1y2d\n\tfor ; Thu, 23 Apr 2026 22:41:29 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 6E5EF3E28D9\n\tfor ; Thu, 23 Apr 2026 14:41:27 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 63DC83E1CCD\n for ; Thu, 23 Apr 2026 14:41:24 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 9866460057D\n for ; Thu, 23 Apr 2026 14:41:23 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 331116A86C;\n Thu, 23 Apr 2026 12:41:21 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1CFBF593A3;\n Thu, 23 Apr 2026 12:41:21 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id edchBnET6mm4fQAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 12:41:21 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776948082;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=LNLKLYqXcDwouZbel1ImNlQUlpAwAwy6Qo5hUPx1BPs=;\n b=Nj6yCKrAI/Yztt3rQ+Oczoe7FF+N5FaYOzSgH+itHo2961PnECKlIRkW5M8jcH4tiaBTqp\n WY1/LLV8+BCRGhbp0zwuylBar7RnT17aFV6eudOVhTfUUtHVeJd/tiApokwQ9rseYvpkpx\n glYF6VsHNmmnQDbySIqicFl1fp7JS+c=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776948082;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=LNLKLYqXcDwouZbel1ImNlQUlpAwAwy6Qo5hUPx1BPs=;\n b=y+PPJ3EgbiL3a79/DYckExKooPd4PMSKkUzIRdhwwWFKLTfr1oU2/65Df7fmD3w/pRq3ji\n rhv4F4v7OPSJ3eCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776948081;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=LNLKLYqXcDwouZbel1ImNlQUlpAwAwy6Qo5hUPx1BPs=;\n b=uyL8CSRbd7fT/lBWaoN8nh+k2COjMIDfn08pCehwe2/h/K4PHnK88QujWL689ZbQSTpP4S\n KOM6KZrpE6PwVl8iaeuIE52Eob5YAXESZVbSJonhvq8NpdBWvAfjIuorumMAAYDMRCKGX3\n 4NtMc1Prwb42dylNPxlBURSM/nI8MSw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776948081;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=LNLKLYqXcDwouZbel1ImNlQUlpAwAwy6Qo5hUPx1BPs=;\n b=CL5JDdsmxSIuSV630XVad3KCXyaGC+lwJahJEWkVIwxl+CPQ3XyHEYYbPkqjuOkvxV9ot+\n dKft14IESOZCyrCA=="],"Date":"Thu, 23 Apr 2026 14:41:15 +0200","From":"Petr Vorel ","To":"Cyril Hrubis ","Message-ID":"<20260423124115.GA450362@pevik>","References":"<20260423120309.18049-1-chrubis@suse.cz>\n <20260423120309.18049-2-chrubis@suse.cz>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260423120309.18049-2-chrubis@suse.cz>","X-Spamd-Result":"default: False [-7.50 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[man7.org:url,suse.cz:replyto,suse.cz:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]","X-Spam-Score":"-7.50","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v2 1/8] syscalls: Add epoll_create03","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3681474,"web_url":"http://patchwork.ozlabs.org/comment/3681474/","msgid":"<20260423134324.4268-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-23T13:43:23","subject":"Re: [LTP] syscalls: Add epoll_create03","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Cyril,\n\n--- [PATCH 2/8] ---\n\nOn 2026-04-23, Cyril Hrubis wrote:\n> syscalls: Add epoll_wait08\n\n> + * - Create an epoll instance and register a socket fd for EPOLLIN.\n> + * - Fork a child that waits for the parent to enter epoll_wait, then sends\n> + * SIGUSR1 to interrupt it.\n\nThe algorithm comment is wrong on two counts. No fd is registered with the\nepoll instance — setup() only calls SAFE_EPOLL_CREATE1(). And it is the\nchild that blocks in epoll_wait, not the parent; the parent sends SIGUSR1.\n\n--- [PATCH 6/8] ---\n\nOn 2026-04-23, Cyril Hrubis wrote:\n> syscalls: Add epoll_wait11\n\n> + * - The child's epoll_wait should return with EPOLLHUP and the child reports\n> + * the result via its exit code.\n\nThe child reports via tst_res(TPASS/TFAIL, ...) before exit(0), not via\nthe exit code. Fix the comment accordingly.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://patchwork.ozlabs.org/project/ltp/list/?series=501188\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bylCWBqN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1ckH6tmNz1yD5\n\tfor ; Thu, 23 Apr 2026 23:43:35 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 79A313E5378\n\tfor ; Thu, 23 Apr 2026 15:43:33 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 5F4E13E28DB\n for ; Thu, 23 Apr 2026 15:43:28 +0200 (CEST)","from mail-dy1-x1342.google.com (mail-dy1-x1342.google.com\n [IPv6:2607:f8b0:4864:20::1342])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id D92AA60065D\n for ; Thu, 23 Apr 2026 15:43:27 +0200 (CEST)","by mail-dy1-x1342.google.com with SMTP id\n 5a478bee46e88-2c156c4a9efso9137392eec.1\n for ; Thu, 23 Apr 2026 06:43:27 -0700 (PDT)","from\n runnervmeorf1.tl2v0rktc0guzlcbunsqswfqba.yx.internal.cloudapp.net\n ([128.24.161.84]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2e53d9b056fsm36233124eec.29.2026.04.23.06.43.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 06:43:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776951806; x=1777556606; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=eBV0rAoOrvmd7SPzQdQITt7sbfT9BtMepHSQaJgORQU=;\n b=bylCWBqNc6ntv3Z4qNqyZYkOo+qwDex9AA+91UMRe3NWkUPuC5AGMMo0CxS8/APObE\n XPyr7DYEfs3OI09LeOuxZA18ebY9K4ww29cQ7baugQPztHz5N1NpKMG0SGyZ4luxsCQL\n 3u4/BEuuo0VycHBrb9n1JcoIw3/xxqzyYP4LwyD2MKf6x9AjHvph5QuMhf6Pv7tbmJHW\n u4VcuUwUP/3tj9K7TMVlMDvfYgMj2Ty6wDxWXGIGwbC116We/3ONbuNCp+ymPhLC8kZO\n Gl2JzngZhWFlr63540GiTApuxjjY6eqa1mVIwZcIWURLoTb4peKoCUWuXpe9sZfaV2fh\n aUhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776951806; x=1777556606;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=eBV0rAoOrvmd7SPzQdQITt7sbfT9BtMepHSQaJgORQU=;\n b=AW6qvSIuNUIYPwkm9IrikO8BihhU6liGz21nuaKpBgL34ISp9JxTuxs/Loqu0yQ3Sy\n p/UWnmBggsN7qtW8B2gQ1D8FGQi7s7zNhIRGDh6e5x6tlwtKJsxZoiac6wDcA86Jpy9o\n rHMxLCM3crAD5uPda9y5Eu9rtxBx1VDMXlpymDD6CaMJeJxtm4886lnv4iqP/OniQgkA\n EsDm70E5sfKzsd80u3aY16e5Ah4yItU5QhxMAM3F/6THCWpeg6o3PQ0Ll93idvzPEXXQ\n HpIYuooYzW4H13k/DUpftJYYK5IOUO4Ku1oYKdoqx3tg6fiwjX5LF9AED8VQ8qXecUdr\n L1pg==","X-Gm-Message-State":"AOJu0Yzmax4K/voEfASq72Yxj+nA2yJKHG0EG6jxzoVV4O87XvOBV66L\n IClsYefJDh7q1zU+L0CK9OIuu7kHYwZRweZHO4dAj4cNo7NwcbRwmLg3","X-Gm-Gg":"AeBDietC3WM9Os70FfqA26GM9npxLozCooDDYs7+H3ABKpzXDHPll1ThNAvFjwwHp5F\n CilY1QF49VDh2QvMd+xX++Ie8xVKYrh4OxSUvrcLJfR8krknu59BRoxM8W/tatC/vN4Uv4nrP68\n PJa1ebUTPE/QjuAha069zgDKay/RLfu92q3Q1NJQT2fNZJKaZfkmd6xjeNYgdPgE5+NX3nUPrII\n IAz9ZSEopXb9anK0i7xaTX1fo3b3v3yrnawEQjYbdIuOsdY8mu5PFIybxVkBEHD7T2eLeNLz6IK\n 8N6aKIn0LHbrI6VTjyE576ilT8Werr5Fv082MUB+XNv0+FYAQ1mNOBu3hGTO+7yQJyzrPsrJtaI\n 6PvOKps1F3+Kbmo8Ju4nkcMGHhhoZz/byIZblaUE8fxg43t+G9K1E9On+hGadbRQrlV04cRAXZa\n F/DZD8P2cztD+v4Va3UrM+bzh5/jyCrRNpcRXMjJEqJG0qyNIW39IgEWVJiBfIfxTBhbM9dYGju\n fMveNMNDcI1BvTv0/lxHcvsS+IsuEMH2JoZZCRwgg0+ml2GUA==","X-Received":"by 2002:a05:7300:6d23:b0:2de:aafb:fef3 with SMTP id\n 5a478bee46e88-2e464eaa418mr16067015eec.1.1776951805961;\n Thu, 23 Apr 2026 06:43:25 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Cyril Hrubis ","Date":"Thu, 23 Apr 2026 13:43:23 +0000","Message-ID":"<20260423134324.4268-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260423120309.18049-2-chrubis@suse.cz>","References":"<20260423120309.18049-2-chrubis@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] syscalls: Add epoll_create03","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]