[{"id":3681410,"web_url":"http://patchwork.ozlabs.org/comment/3681410/","msgid":"<580b84b4-7ec9-4029-a9e1-8e94e4770a06@linaro.org>","list_archive_url":null,"date":"2026-04-23T11:56:59","subject":"Re: [PATCH 9/9] target/microblaze: Compile translate.c as common unit","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/23/26 20:06, Philippe Mathieu-Daudé wrote:\n> In order do build translate.c as a common unit we need to\n> replace:\n> \n> \"accel/tcg/cpu-ldst.h\" -> \"accel/tcg/cpu-ldst-common.h\"\n> \n> and:\n> \n> #include \"tcg/tcg-op.h\" -> #include \"tcg/tcg-op-common.h\"\n> -> #include \"tcg/tcg-op-mem.h\"\n> \n> taking care to define TCG_ADDRESS_BITS, which is fixed\n> for these 32-bit targets.\n> \n> Remove the now empty microblaze_ss[] source set.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> target/microblaze/translate.c | 6 ++++--\n> target/microblaze/meson.build | 7 +------\n> 2 files changed, 5 insertions(+), 8 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=u9eVSztF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1ZNR5xGdz1y2d\n\tfor ; Thu, 23 Apr 2026 21:57:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFsgQ-0004jC-0I; Thu, 23 Apr 2026 07:57:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFsgG-0004iw-RN\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:57:17 -0400","from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFsgF-0005bg-4L\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:57:16 -0400","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2b4650d5f5cso24512495ad.0\n for ; Thu, 23 Apr 2026 04:57:14 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fa9ff71esm200501255ad.8.2026.04.23.04.57.09\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 04:57:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776945433; x=1777550233; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=BItlYy4eiKi0sXPc6O/2gVgCVAt5dzwDIo9XmRZFQi8=;\n b=u9eVSztF25A9GPZwhpLNww4bFSWDv91SoSGmeUqtCACSkNIvHFeC5fUZL6yjAJ1LY8\n kFtZscSbGHDQ973MRXWgSpbMu8CtClwTQGBq5tDyfSxpwEf74mRzPzESTEJbYnMUsDcm\n Mql957hJFr3ay1hEXEEsq1oWcIDdQ7nparzd6vGLTJFOpTSAkMHSv/h7OTWpobFmAV2s\n wKzFJ+SKFFlpjXNmS8bXuTq+GYRLXOR58b+dDblWqerA/J9MyjUtZ34FujlOukstY2c6\n Ct1FZFk2lmFp/H+oDKjBgRMGrUPlp6omFKLzS4rVnQ6P1cdAFeDTM5xnI8sFUgv6a9Q8\n KWxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776945433; x=1777550233;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=BItlYy4eiKi0sXPc6O/2gVgCVAt5dzwDIo9XmRZFQi8=;\n b=Og3+2w3MOVUtvo3Sbw5Kqq8WvHl+dLf52yi9ZGvzbtoCn0HGELu4PRs7u50dtpL74V\n OC02FRtwnwqze1CTCmUdUqfRK3IE+1qflLTL3Q5Pkla0OAbt3TKNJRkhlDRQP0d6rdTv\n hvbffMaV1c5hqou+1YKsMLP4ScRuzNJ6pp/QwgriVDQ+s6YM6NzCp34qx0FpUfmxn0S4\n wqK9zduuRv6i1v/6HQfa5222uyg4WVq7rFOTTfkYx5dGW8IL8deNSO+gHlmE9hSBH8Tt\n 8E3D0ffeJJn+1WHEp2y4UlcAEiA6mXRqqLFYOLLGWyleBG9sHbkWp8a4w2itJwB6cs9C\n PZdA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9cC+c0mswhDssTLJIyY3xQKZKzG9ORBJ5/ROADTWlMq6zwlX9qSbH0UxrFWbmR78vKpDQ7pSVA2tGz@nongnu.org","X-Gm-Message-State":"AOJu0YwozsS/gJRnJeXosz3wgoX0Mk+tipCf26fWRPdBygp2IG8iRaSR\n fwLku/ipSTvr4Jz6k4RmvwUK9aN8ztxNPV6NTbjSv8mJ6XGZAL0U1ui73FwiU3k/feY=","X-Gm-Gg":"AeBDievjuT2ufs6HSwLyWd6i9ihXPxAXIT1Ut7Wsk+XgIIbXsnJHF2RdFhgeRJcFtH1\n N98OV2KEZdxINTmHlLQ37t/Ebiwf7g5Q4x5Til9qHxfEPLFbJJD4rGFmqlZJ9V7VKcTGsBE6GzQ\n TZZ1H1JCr2ep5HAFX+uFHz7PZn1dJD389cSmMjOnww+BLSOqFJ8E4UuJSJY5dWlpbxBiWruGO4Q\n WQKPO7I6xz8qQHqsuxKfMcauBwbfCu/g6d7QteGQICR+a62uujZ7hzXLONxLYRK9QIaA35Kt4AG\n A2Z3V7Hj6VxRHNUshsFaVHV7aM9EF8L5NLhr3sUbpixNPAT85QTSrGLBH8jgXcEftq3zuFwZz4c\n xcJ6WsdnAaKuHrU+FaG4bszD6ym2RmXBQGUCEUW50dcNuz0uxgVe6wfeelRAXoUHPjRtzwwEzGj\n wyFL1MUaBA6eNiQyeA+LpvL0GJGaUSFhME8AhFI+bw/klyQtydVw==","X-Received":"by 2002:a17:903:1446:b0:2b2:42b1:ad95 with SMTP id\n d9443c01a7336-2b5f9ee2835mr314616295ad.16.1776945433047;\n Thu, 23 Apr 2026 04:57:13 -0700 (PDT)","Message-ID":"<580b84b4-7ec9-4029-a9e1-8e94e4770a06@linaro.org>","Date":"Thu, 23 Apr 2026 21:56:59 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 9/9] target/microblaze: Compile translate.c as common unit","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson ","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-10-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423100612.27278-10-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::629;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]