[{"id":3681395,"web_url":"http://patchwork.ozlabs.org/comment/3681395/","msgid":"","list_archive_url":null,"date":"2026-04-23T11:42:25","subject":"Re: [PATCH 2/9] target/microblaze: Fix endianness used to disassemble","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/23/26 20:06, Philippe Mathieu-Daudé wrote:\n> MicroBlaze CPU model has a \"little-endian\" property, pointing to\n> the @endi internal field. Commit c36ec3a9655 (\"hw/microblaze:\n> Explicit CPU endianness\") took care of having all MicroBlaze\n> boards with an explicit default endianness (similarly with\n> commit 91fc6d8101d for linux-user binaries), so later commit\n> 415aae543ed (\"target/microblaze: Consider endianness while\n> translating code\") could infer the endianness at runtime from\n> the @endi field, and not a compile time via the TARGET_BIG_ENDIAN\n> definition. Doing so, we forgot to propagate that runtime change\n> to the disassemble_info structure. Do it now to display the\n> opcodes in correct endianness order.\n> \n> Cc:qemu-stable@nongnu.org\n> Fixes: 415aae543ed (\"target/microblaze: Consider endianness while translating code\")\n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> target/microblaze/cpu.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IG1JUREr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Z3N1CdHz1y2d\n\tfor ; Thu, 23 Apr 2026 21:43:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFsS9-0004En-SB; Thu, 23 Apr 2026 07:42:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFsS5-0004Dg-40\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:42:37 -0400","from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFsS2-0004G0-O7\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:42:35 -0400","by mail-pg1-x532.google.com with SMTP id\n 41be03b00d2f7-c7961d7bc09so2468306a12.1\n for ; Thu, 23 Apr 2026 04:42:34 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c797701b1a3sm15181239a12.19.2026.04.23.04.42.29\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 04:42:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776944553; x=1777549353; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=IgJt+GYeQJmyLhpLEvINdIx/oi2SxTXXacSjZwEWqQk=;\n b=IG1JURErNHigqTinWwJsM8a5ZCNQwjeHvcT/knvagTUO+Neu5vL+Ak1diu6z8mOsZy\n EKSg5ea1BfUs0x4dbYDzJo8MX1KMrFpXbsPSVJbH9ovoJW2AgB+WXbnnm/XmV29SkBRw\n 0sjuHZvsDieyPkDdsHIHSCxGNmm5oE5oWE9ap4f1f2TXBDtTzqyQSIaZS1YYv38IERy1\n tlxTVgPwH91EjTlEP6Z8x6M+Y9Ed/qq8ynf5XqvkdhaQU0r+ojosS2jLRiJhO0ZAHjYt\n qYnW0Z6TPZIPYLQhWKvX5hi9cc/iomMTO7y60ZzasfK6wXzLR7+i0YPCY1YLUifqohSD\n AplQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776944553; x=1777549353;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=IgJt+GYeQJmyLhpLEvINdIx/oi2SxTXXacSjZwEWqQk=;\n b=O4BNELgaHbik0y9z5yjNfehB7HNcezM5LqzN8h3ezj6N82d2TBx6k/7Umu3Mg7UmzD\n ab+xIyE6Bfodkoehx+ASCZkHew+uKnaL1GCJw3lanOXBM3htU92dmmD+vX+iQBxSQ7sp\n xAb8P79f5s2kyU5OF0hS9KkfPPs5jWLrH3IBVJJTW52xWzFt7ejsk2bm3kV8Xrn738xo\n xxBDUcYUBJ0DaoRDk07poijsgkkhMCIgxzhMdbMTsTUbGews/AtMJVKxIHtnnox1ZuRf\n vY6EzVe6eotcsTZK2bk+IOfSj2OsNWe3WZV9rzyGgILpeOTaXsZgksjnLmMEUkT+RslG\n e/fA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ91a7hopiKLI4p79Qs+raHu+Q0BHEkI3Lh8RZGzzxJJZuoFgH47I7kBT/jsRxxmkS+7QKlNnb2Y+4rB@nongnu.org","X-Gm-Message-State":"AOJu0YypteRSg4lQ0JMImEFgTDQ2C3hq+p49VauMQ+/PzCWyH7ov69Sw\n D2lCFtZxqARqdLKKW5zCuOaCCRuIqHhU7EsKGncaMNJ+Bj0tthGAMOfUqiTSBodtHWc=","X-Gm-Gg":"AeBDiesP8rxgGffCJgUagpD4eseKN9rJQtRCgWUD38DMsBfSwXuQsD1TsWM3LljvfgG\n +5ZaC1asbupcQk5Hi/n8nnFHX9WFWZOhIznsLpMtiDGXv7RqYwYbdirTTHZ+GBUUx5ZJOoVD4IY\n oTd/BWTl+8CVqv+yQz7gnM4KbxXtGn1DW/9MOowwlq5tVdfrUuLw1puD0e8FbBVrSONyM2Efh73\n PB4cLNK+MEBzPVFL9VkCec1+i/ak1dZUVmsOyX5OJI9/rGs7pDSFIk3VzRHhaT94zk28WG07xGa\n BjOI/bN0TVhDOB6XyIQuyV6yVNVg7ChLyPXK9obexRezb3EmQ8x4VCTbOjGoVqX1L9vIDfV7GML\n M8z4Y9iBHn05oJhlN6TWLL/Uc+FOomdTIF9oielmuGEUaRqSLFQa6RkRiz/9oX7+dveDnfgyqIu\n PRplqXASLxiPTY7yyU8Zr8ZTnXUexzu71SorigQcsDyKZN5dJpcg==","X-Received":"by 2002:a05:6a20:a12b:b0:3a2:dafd:3c02 with SMTP id\n adf61e73a8af0-3a2dafd4cd8mr18768175637.19.1776944553034;\n Thu, 23 Apr 2026 04:42:33 -0700 (PDT)","Message-ID":"","Date":"Thu, 23 Apr 2026 21:42:25 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/9] target/microblaze: Fix endianness used to disassemble","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson , qemu-stable@nongnu.org","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-3-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423100612.27278-3-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::532;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]