[{"id":3681405,"web_url":"http://patchwork.ozlabs.org/comment/3681405/","msgid":"<157fc016-e7bb-4e36-85bc-a73c9039830a@linaro.org>","list_archive_url":null,"date":"2026-04-23T11:52:54","subject":"Re: [PATCH 8/9] target/microblaze: Include missing cpu-mmu-index.h\n header in translate.c","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/23/26 20:06, Philippe Mathieu-Daudé wrote:\n> translate.c calls cpu_mmu_index(), itself defined in\n> \"accel/tcg/cpu-mmu-index.h\". This header is pulled in\n> indirectly via \"accel/tcg/cpu-ldst.h\", but since we'll\n> remove the latter in the next commit, make the inclusion\n> explicit, otherwise we'd get:\n> \n> ../target/microblaze/translate.c:1620:21: error: call to undeclared function 'cpu_mmu_index'\n> 1620 | dc->mem_index = cpu_mmu_index(cs, false);\n> | ^\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/microblaze/translate.c | 1 +\n> 1 file changed, 1 insertion(+)\n\nAnother solution would be to expose mb_cpu_mmu_index. Anyway,\n\nReviewed-by: Richard Henderson \n\nr~\n\n> \n> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c\n> index af6a30b7760..6321b739ab4 100644\n> --- a/target/microblaze/translate.c\n> +++ b/target/microblaze/translate.c\n> @@ -21,6 +21,7 @@\n> #include \"qemu/osdep.h\"\n> #include \"cpu.h\"\n> #include \"accel/tcg/cpu-ldst.h\"\n> +#include \"accel/tcg/cpu-mmu-index.h\"\n> #include \"tcg/tcg-op.h\"\n> #include \"exec/helper-proto.h\"\n> #include \"exec/helper-gen.h\"","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=lab634AQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1ZHL1k9Fz1yCv\n\tfor ; Thu, 23 Apr 2026 21:53:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFscG-0003Lj-8J; Thu, 23 Apr 2026 07:53:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFscD-0003LB-Kt\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:53:05 -0400","from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFscA-00031F-BG\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:53:03 -0400","by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-35fb166b0c6so3788014a91.0\n for ; Thu, 23 Apr 2026 04:53:01 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-361419739dfsm20986453a91.13.2026.04.23.04.52.57\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 04:53:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776945181; x=1777549981; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=doYdWC4A4Gb2eiHvPcEGmKPVqNIR7fKnURBPKpG67h4=;\n b=lab634AQG9njkuux9sizRTpBM5CrtmW09yrPRVc/9vrchjkafNDq9eaMVjUpIo5Zxb\n xoFVBt+ZDuLFPKvqCf3hinNvLPL37OSSI+PV2ieMB/eSYsfQ/DKmEFiouO5jqEydzvFG\n poIcT0R5LTYZpdleOW5bp09M3DBKF52GPPR8SEcCVBhbYkD5JVoqaBFdxKldl8YO5XeS\n ne78jpLo3D1bFstU6ujHxPz7B2M2XdBaF47V7BP+EG6ukMMh7XYk/keKkK1+qMxmtyW2\n Lnpkfe5fI5AVTg3LsBFmUdlozoUIGnVW+hAthL2jyp3xZxoZ9I/B6Fh92HHsooVpghqn\n S8wA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776945181; x=1777549981;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=doYdWC4A4Gb2eiHvPcEGmKPVqNIR7fKnURBPKpG67h4=;\n b=O0fQaoXCt/KLieU9xDr1X1Lq2f8ZBK8pWQNBeTRIJmqKIAIH5w+LxKO3acds9eqSFd\n SdZYPa+fEw/yyGzNAxOX4w+D76P0uuvFtsCj1iP1hg6QeWxnEJFWIWt5PPTq1NIhJ5RH\n VvwMTroaZt0rPgihzBBqGsNo/gU4paKpDS5vGzXWJTRzbBM7ms3uA863U1/gzABSyNlI\n jJgDUCDsEC4OgrUMLWaFev/6W/85YLK1Ak1dYobw0qvlJOva2fc9CWQ+17VuBcnJFvR8\n ajjslMt6O7GJ70ItWWz6gLZGWSO0IVYi5qZ6xKyCGMZsLNgRzoRG5ZcERnI1Wi1zOAW3\n cW8Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9RqOd2uGVc0W1rEXvu3DpqFcqjNnoR5zOJ9GJQKW2bb/VqQi84tU8/uTkgU74JmheCK6lmRJTa7xIS@nongnu.org","X-Gm-Message-State":"AOJu0Yx4oKUaU7oGv/RdJo3YXdjBns5wOwVHbIwb3870/jfJojqISjKM\n SqnlCFWtYW/k+UCOMiU/p1WGubr6pFKg+lniAK63nG9b/o/rRblaVApT7lCjyhrrvKE=","X-Gm-Gg":"AeBDievxLF0wBc1k85lBJz7UqSyF7wJaXb88JeyECy1XuvFOWROYxLWV+xiCHJqYPHz\n SXsSI1auDbkbWtxPjo2Nf9x9CBatS0ngC9HgZN9elH29IJj5NemWyvo8RavodmH616fK4oE/HiR\n 6IY+dOmSp5j4QfWINXvKN2BtJDDnDUlEZxB0voEmMcfnajgrUISaPUEw9pEictNn0bNAb1isfxo\n hzJbcXf5jo+9C1K3ZSqjhrQTEHBoI7+GKtyq/edPcA7Cm1UDSKWikrWE2xBOSDQe79t9KsVpJs/\n uTgL8OD2gyNyCwBicLpaktaKm6BmfGRu3k4QFdaS+zuycsoiV6ivVYM//uOoZx+qu/wBtll/Wei\n Rj1O3iICY0ZDdalQldbDzMnzeg+lJiFxuwpJVEGk3DvHjXnsbrSowKJKowPSgLfwsAu1KWoVYe3\n 8SXefS929R++BBUPhA/mo02+uiXRistMT7GACYoiXhvCRUZYsL5w==","X-Received":"by 2002:a17:90b:17cb:b0:35d:aa02:d776 with SMTP id\n 98e67ed59e1d1-3613ffce5admr21136719a91.2.1776945180645;\n Thu, 23 Apr 2026 04:53:00 -0700 (PDT)","Message-ID":"<157fc016-e7bb-4e36-85bc-a73c9039830a@linaro.org>","Date":"Thu, 23 Apr 2026 21:52:54 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 8/9] target/microblaze: Include missing cpu-mmu-index.h\n header in translate.c","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson ","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-9-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423100612.27278-9-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]