[{"id":3681360,"web_url":"http://patchwork.ozlabs.org/comment/3681360/","msgid":"<5c0ed009-dc77-4807-8981-f66bdd8c3f62@linaro.org>","list_archive_url":null,"date":"2026-04-23T10:11:06","subject":"Re: [PATCH 3/9] target/microblaze: Replace translator_ldl_swap() ->\n translator_ldl_end()","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 23/4/26 12:06, Philippe Mathieu-Daudé wrote:\n> In preparation of removing the translator_ld[uw,l,q]() methods,\n> inline them for the microblaze targets, using mo_endian(ctx) --\n> which we introduced in commit 2c9e8ddd7699 -- instead of MO_TE.\n\n\"Remove mb_cpu_is_big_endian() which is now unused.\"\n\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/microblaze/cpu.h | 7 -------\n> target/microblaze/translate.c | 4 ++--\n> 2 files changed, 2 insertions(+), 9 deletions(-)\n> \n> diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h\n> index 5765786e6dc..ad5a4a8e7bf 100644\n> --- a/target/microblaze/cpu.h\n> +++ b/target/microblaze/cpu.h\n> @@ -412,13 +412,6 @@ void mb_translate_code(CPUState *cs, TranslationBlock *tb,\n> /* Ensure there is no overlap between the two masks. */\n> QEMU_BUILD_BUG_ON(MSR_TB_MASK & IFLAGS_TB_MASK);\n> \n> -static inline bool mb_cpu_is_big_endian(CPUState *cs)\n> -{\n> - MicroBlazeCPU *cpu = MICROBLAZE_CPU(cs);\n> -\n> - return !cpu->cfg.endi;\n> -}\n> -\n> #if !defined(CONFIG_USER_ONLY)\n> bool mb_cpu_tlb_fill(CPUState *cs, vaddr address, int size,\n> MMUAccessType access_type, int mmu_idx,\n> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c\n> index 5e8bb4ed77b..af6a30b7760 100644\n> --- a/target/microblaze/translate.c\n> +++ b/target/microblaze/translate.c\n> @@ -1646,8 +1646,8 @@ static void mb_tr_translate_insn(DisasContextBase *dcb, CPUState *cs)\n> \n> dc->tb_flags_to_set = 0;\n> \n> - ir = translator_ldl_swap(cpu_env(cs), &dc->base, dc->base.pc_next,\n> - mb_cpu_is_big_endian(cs) != TARGET_BIG_ENDIAN);\n> + ir = translator_lduw_end(cpu_env(cs), &dc->base, dc->base.pc_next,\n> + mo_endian(dc));\n> if (!decode(dc, ir)) {\n> trap_illegal(dc, true);\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KVEpAL8A;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1X1y5qFwz1yCv\n\tfor ; Thu, 23 Apr 2026 20:11:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFr22-0005qP-5D; Thu, 23 Apr 2026 06:11:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFr1c-0005lM-93\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:11:15 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFr1a-00060v-Ij\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:11:12 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so52287895e9.2\n for ; Thu, 23 Apr 2026 03:11:09 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1c0354sm477902545e9.11.2026.04.23.03.11.06\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 03:11:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776939068; x=1777543868; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=9JB6XyoZ11qMXnbaAOLlXhXHCzkkYFk33rxmp3yvr9g=;\n b=KVEpAL8Ax1D7qEpNFAo6x+0ZvurIhFR3XmUbVRhg+HqC+owttHcHXSETLCNuYTjlqH\n 9bwcJmX7GCiOKICmjKl3sYQ6LAw0qbQBnGfdgBDf2YWIK5lZDZY+3WzqbRsVUbuKV+OC\n YwrJl/qpSXU/IOYB6aJTqH5UkCze2AyoXWtANViaNgNGhYfKbKycahL+Zd3SRTX8ak/m\n a834vGRiJ1OfBaq0/nIMt3LNXj76b709hxcjA9NspZZEIuBM8IROIQZNfIH5BCl6I12P\n JDDtLS5pl8CJTE2f14BLgNU99yQLABbJ7MutYyb65aVL2ORItT7TadIhxsPJai78QzHI\n cKcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776939068; x=1777543868;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=9JB6XyoZ11qMXnbaAOLlXhXHCzkkYFk33rxmp3yvr9g=;\n b=iK/KnJstka/M3kOT8sY8TYmGGNuE0t9aJhFIw8LJkPVloPen/XWRItUtCmZxWxEnAa\n 9wsNXrxoGAQbvf7DzI/m0g+WCRobcJbV887fFiE0vqUkmzZmEJ3chXzThsRWsaIgbeqU\n o6PiBOIDsErbTglUVdjk4fdoDC1IW065VqOKoihhL9ZVXxfrtGMXyXMIaqN6gTPfXOSL\n 8gQSTGR3EmGmlUek4Hm0MGLy0Vgyjfy9Z+FjY6AiD0PhQxGrd6JVD3cvjstScNGOtOyc\n +k7q6g3CEEjGmLO1Jok4kqe3ytz2k4LZxktcqgvtdvBDCblHgG0I7RjfjYNQltBVoUvE\n mPxg==","X-Gm-Message-State":"AOJu0YzVIc2lit3fdBEb0UcFrGYFnawpu5U99IsehWro6mpO2s3b9vb9\n JB5hWYnfN8Lg442eiwyg4e8UOLI5q9NTxj1bw9hrib+40HUp9MdAc0Zs2Fe+k6PCkJnRLKmKrw+\n 7DVdIQkM=","X-Gm-Gg":"AeBDievG3UmmTLUN8neUBhr+A+aQtbyUgK4OuYMC9WbMTdTp1MTm3WHuhIieRpu99KU\n ftgxd+65PYiWgi8C6/qksL5jgWrnlSSaIHEcdpqAmMGliwnrOG144/RJ0mrO7mgyFuJQIqT8P10\n NluOAh6gH7wM4ysaqBXaHZU6kT5PC/KEr4gt8gIb/MITwIfGigmGosxv9aqV8hCh26zU5ZHHdM3\n 6Ol6hlLhNXAMDZEOXdJdza1y8IIFSBBLpBWCexYytuz7RgV1LRZQT11tMhjzqbnt6dj8XLQYb8V\n 7OIOb+c7b5cnKoc2X13bkGNBeQmTr6jyqOMAwdDqj0ifFWdD+9LQx+qnAnH857k66HT9vdPVtIX\n MPcsztVtlFmoCt1rB0tMlFQ4/qRTEAIlefTiPijvAGPDSsKI2ag6F6vos9SieLEOdJhm7WISj2V\n 9lya3XRiZWpWy2HruEef3e/2LQEf4B0DCL18lcQcinYc492K7jAkzpvTufNSLSfAoVE6X05R+3z\n gP6F5WswbxwOCw=","X-Received":"by 2002:a05:600c:c0c8:b0:471:700:f281 with SMTP id\n 5b1f17b1804b1-488fb78b8c5mr281292965e9.25.1776939067883;\n Thu, 23 Apr 2026 03:11:07 -0700 (PDT)","Message-ID":"<5c0ed009-dc77-4807-8981-f66bdd8c3f62@linaro.org>","Date":"Thu, 23 Apr 2026 12:11:06 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/9] target/microblaze: Replace translator_ldl_swap() ->\n translator_ldl_end()","Content-Language":"en-US","To":"qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson ,\n Richard Henderson ","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-4-philmd@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260423100612.27278-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681396,"web_url":"http://patchwork.ozlabs.org/comment/3681396/","msgid":"<271f2665-7d03-47f9-b795-23ae1d44340d@linaro.org>","list_archive_url":null,"date":"2026-04-23T11:45:06","subject":"Re: [PATCH 3/9] target/microblaze: Replace translator_ldl_swap() ->\n translator_ldl_end()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/23/26 20:06, Philippe Mathieu-Daudé wrote:\n> In preparation of removing the translator_ld[uw,l,q]() methods,\n> inline them for the microblaze targets, using mo_endian(ctx) --\n> which we introduced in commit 2c9e8ddd7699 -- instead of MO_TE.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> target/microblaze/cpu.h | 7 -------\n> target/microblaze/translate.c | 4 ++--\n> 2 files changed, 2 insertions(+), 9 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=nc10NTU4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Z7r2Pcvz1yGs\n\tfor ; Thu, 23 Apr 2026 21:47:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFsVA-00078B-5L; Thu, 23 Apr 2026 07:45:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFsUf-0006Vm-36\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:45:17 -0400","from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFsUc-00069q-N6\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:45:16 -0400","by mail-pl1-x630.google.com with SMTP id\n d9443c01a7336-2b24fdac394so63364685ad.3\n for ; Thu, 23 Apr 2026 04:45:14 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab0d0f8sm181138375ad.47.2026.04.23.04.45.10\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 04:45:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776944713; x=1777549513; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=MczHLxhuOcwSUdIHttHOA1r7HnYO6NFpnnqUMnKb6yM=;\n b=nc10NTU4ts2BiPKAteMSgQsWIzlNqNXllEgjZQ/Vkg3a2xVrt+7QfEakBk57Pppofu\n OhA7G426rLNybMTawhzCwvWG6c5PwZd+hVLIhc6S8D9nDCDgPAIPodmRd/ewGlsNggbA\n jcFUma0dz4pSezigSSpchTulQHAr4ZTHMTCQWN4/SYZwm64ncqTwsz+1a0xnR2KYFFvu\n YLrpI28kUjlOffBYgg+Ek0MA21x4ETTT1SPO7L+p8U0qtUX8R6DEPoQ2g/BstQDABFO+\n vPFzs+lNnI03L7sBx7xErDYFt2liLfU3jFdk566yqD2bGfrSKIhLajjpXDTgU57jjWcr\n Nrlg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776944713; x=1777549513;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=MczHLxhuOcwSUdIHttHOA1r7HnYO6NFpnnqUMnKb6yM=;\n b=qkB2TxbCWhVJPO/DtfiGkf+PMKRCjzmmOx57UslHNuj5TKw+Dw8nO/Qfil+MQDo3X/\n DGyw0/MSF7r1+wZ1eKQPr4lPCmn5ta1cyjaKG80XzihVsR2l8KIL7v+3YtmcEnHowdR+\n ALrlaJKtOtgby5FI/ePhuDx/+1BejNhEBbPiB1HaQQoGQhvLDsO4MMSRD72kWGJ5PPhg\n Rdvv/t7vSka63HGUXSHDTqoMtYDsDVk14kcR0QrTZc+R+ckdt62ZSjqnq/gCVR2LbZGi\n 6Qg42q7MxFKBXnUQr5PXoav9USnWNMReXaQdDmH93JVMYV6z+oHElhzF3AF1n0LV0xRn\n hPlQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+jbELizO6MzsrpP5WLF6UKUa6v6vu/G3wzxWnSorCqiIvNImpmXsmHl64MgnV6efww37Vly7DJMv/w@nongnu.org","X-Gm-Message-State":"AOJu0YxLoLQsotkFQnmzWuKI25quxvw5Q/TI8aZw5tNWXxKHSwCeWk37\n wOUpBRQOYlqlsgFb9vyhMx9XPraU9Qe9qOUbsmwvN8gCiA2B/IrmRi1hXK8IMZI0898=","X-Gm-Gg":"AeBDiesa9CVFWpEFAXvPtbruqAg4RUPK436kD8eM+msM42N2Q3Oy74RGMmTFdz+6JoZ\n lN74QVZtgHkFCz+rJ50EbTrvB9gXZq/pBPS79toRWg6coVvn5M9HgqJRQvP8/650RUMbicZXA+f\n US4/Mm0bbPZeeTlKjoQkGj3rAa8RxbzxD6JZqGYbWeU7Mnumckg2XH9S1/U8c89QxlNC2/G983U\n UR2pf7u1JSeI94ZG/AkR9FmYXFvadQ6E4t7zVprYYoe3aXO7YSXrPEhGIc/SeTdVYjrd/Trg8Ur\n KFecnWTGNn/YLB5lOlBmbsQJMKv+nzYWBbZDzIjm7j8fzrP95YXwO1ZSA/V5z6ByRoX12eEcZsZ\n /cjwvPvmFZzySOxMY7QtNOo44BCfqluXkZsmB2UnVUpiAzBshbX8pq2gD9NjkXRWmbG7fvLftW3\n WOyJUNyLVwm6AmLrdxTMUrZqITh4d/qMP2SIrgnSA+ZXHneN+80w==","X-Received":"by 2002:a17:902:f551:b0:2b7:9ed0:4f92 with SMTP id\n d9443c01a7336-2b79ed0505amr31090975ad.32.1776944712962;\n Thu, 23 Apr 2026 04:45:12 -0700 (PDT)","Message-ID":"<271f2665-7d03-47f9-b795-23ae1d44340d@linaro.org>","Date":"Thu, 23 Apr 2026 21:45:06 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/9] target/microblaze: Replace translator_ldl_swap() ->\n translator_ldl_end()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson ","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-4-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423100612.27278-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::630;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]