[{"id":3681394,"web_url":"http://patchwork.ozlabs.org/comment/3681394/","msgid":"<6fc61e19-dca0-4d76-8b8e-f8a81c1515bf@linaro.org>","list_archive_url":null,"date":"2026-04-23T11:41:01","subject":"Re: [PATCH 1/9] tcg: Include missing 'tcg/tcg-op-common.h' header in\n 'tcg-op-mem.h'","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/23/26 20:06, Philippe Mathieu-Daudé wrote:\n> \"tcg-op-mem.h\" uses methods declared in \"tcg/tcg-op-common.h\".\n> Include the latter to avoid when including the former:\n> \n> include/tcg/tcg-op-mem.h:34:5: error: call to undeclared function 'tcg_gen_qemu_ld_i32_chk'\n> 34 | tcg_gen_qemu_ld_i32_chk(v, tcgv_va_temp(a), i, m, TCG_TYPE_VA);\n> | ^\n> \n> $ git grep -w tcg_gen_qemu_ld_i32_chk\n> include/tcg/tcg-op-common.h:328:void tcg_gen_qemu_ld_i32_chk(TCGv_i32, TCGTemp *, TCGArg, MemOp, TCGType);\n> include/tcg/tcg-op-mem.h:35: tcg_gen_qemu_ld_i32_chk(v, tcgv_va_temp(a), i, m, TCG_TYPE_VA);\n> tcg/tcg-op-ldst.c:286:void tcg_gen_qemu_ld_i32_chk(TCGv_i32 val, TCGTemp *addr, TCGArg idx,\n> \n> Cc: qemu-stable@nongnu.org\n> Fixes: 69cdc5babf9 (\"include/tcg/tcg-op: extract memory operations to tcg-op-mem.h\")\n\nPardon? This isn't in master.\n\nI recall this is one of Pierrick's patches, but we should fix it before committing.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=LzdRolLc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Z2C3pYKz1y2d\n\tfor ; Thu, 23 Apr 2026 21:42:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFsQz-0003p8-4j; Thu, 23 Apr 2026 07:41:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFsQu-0003oi-Ea\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:41:25 -0400","from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFsQs-0003af-NR\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 07:41:24 -0400","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-2b24fede2acso42418595ad.3\n for ; Thu, 23 Apr 2026 04:41:22 -0700 (PDT)","from [192.168.1.134] ([110.239.0.232])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab20695sm191328935ad.56.2026.04.23.04.41.12\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 04:41:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776944481; x=1777549281; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=21DY5Fy7XvfIF3Ys9J8NGPXpgRm3LUjiZSova9ugCAg=;\n b=LzdRolLcREA6c50fuzZa7oEQ2rqh+rS2fksyzMlb9mAkMqO0q6+NDXaKDQMmEDAdYl\n Kq76BxtLAzTIF3JWDPO5AXW1HpB2yE8qhqjEJLiAMuP47JcOWrvg41p1aLFyB7XNAEkk\n H4g4DIMjgR09EDwsRQLOm2KIJ3e6PyUPOc6e850LZvZjpfYlJU8MPT8v7b+IzZcFUX9X\n +CvPwGcZO59IpVjnoWD9IXDMo3RtwWvUdlpbOfd17DPE2bh7VfD8VSjqfXhjaRORWgkG\n COSeT7newfE6KU7wi5MSzBOY0luYkp/YYAAs6Xz2Zc/0TtbyrDjb3bPJZ3sfJssJ2gGN\n fQ0Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776944481; x=1777549281;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=21DY5Fy7XvfIF3Ys9J8NGPXpgRm3LUjiZSova9ugCAg=;\n b=J3YelPrsxiBpdpInnaQh/e+ipvToT0cKq+G57zDK4kvqtTTCLHLTGkQZVtbJBxSBnG\n MM3OxrvN8UppX3cUauaPbF6WdKgLVsa70029d65QZvSuwxnqseMX1Xe+na3XCrRLnQcy\n vQcD0SImP04LOmFsxixqhFrA5iFvTGCxHuL4EdjiFmrIxwnQnDNCebsPCfCmoC3zNATu\n 0ISvOLAj+oMHW+JBmi0fOsj6yilymYmYSymAQs0VAiHCxgAhkj4BUCaKFoOt/6yNLWLK\n OmAc6FcVKU6przP31X0/IDYZlj/PL/kjGU+oZWcnn6cTdtwHwUhRX++4uG4QVUCjF6No\n i2/g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ83OTZ5UFiJ6Jf8ADHnT11+cfc3AQLAKHU8kgNF+gz9Tac/WzVPBDxgo9nz+n7CfxuHPy4jyM8Yg1xS@nongnu.org","X-Gm-Message-State":"AOJu0YyXJT56ro2aIudnNEk7fL8z+HNIJ1wmtEfPJUQAoXuhfX/tiB7U\n HC588MRptPvwIipffeBtabe+2YLXesSZhbp9hBierLl2WrlZ7kl8spsZ21/bNcU4H+M=","X-Gm-Gg":"AeBDietC6bQIU5+AHxoax0+fV6l/LLPBpBqzo+N0aA2kWJvbC8eMYJsV47rVOSCzrne\n xGmJc8UA08deftLGO8CZ+h/H7GkZNzrsY8dpMxjeV6ZMgk1prV5ZuKWtn/o/97N0QRz5nvPz3Af\n SPMEXNlv9DdcsSEc/nOTRw2UvhtVZB3ujuxEBixubPjzNKntpWWfbAc+PJZCEeIn8etllGzzL5r\n pK0ZykH9S1HSrqbyfcH9R/LwRqPOUSV65EhLzXyf6C8a6dUHSBA1R2vdFYGGnhdiUlzPTXiY/4l\n YkN8H5atO0R5VMCKkmTI+e4sctm0HDHUz9aRsTF4O9u4QzMH3OUgL/EDSy1/QjONCPpRP/Rgfem\n AWZZggIQZQxLUnKeORvJUIFo0fYYQT6dL8g2eJLmemeoSaQLeecSOr69JwSqOi0IqmXMtD/hsJr\n YBCpWYx8BtHT05ZhGc50cJvMGA/hVxGYTio/B99GbPt+6LF5Py4w==","X-Received":"by 2002:a17:903:3c24:b0:2b0:445a:8c7b with SMTP id\n d9443c01a7336-2b5f9edf973mr289251725ad.15.1776944480970;\n Thu, 23 Apr 2026 04:41:20 -0700 (PDT)","Message-ID":"<6fc61e19-dca0-4d76-8b8e-f8a81c1515bf@linaro.org>","Date":"Thu, 23 Apr 2026 21:41:01 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/9] tcg: Include missing 'tcg/tcg-op-common.h' header in\n 'tcg-op-mem.h'","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson , qemu-stable@nongnu.org,\n Paolo Bonzini ","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-2-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260423100612.27278-2-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681432,"web_url":"http://patchwork.ozlabs.org/comment/3681432/","msgid":"<7fdb9701-0245-4872-9d5c-157f6b80b340@linaro.org>","list_archive_url":null,"date":"2026-04-23T12:34:28","subject":"Re: [PATCH 1/9] tcg: Include missing 'tcg/tcg-op-common.h' header in\n 'tcg-op-mem.h'","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 23/4/26 13:41, Richard Henderson wrote:\n> On 4/23/26 20:06, Philippe Mathieu-Daudé wrote:\n>> \"tcg-op-mem.h\" uses methods declared in \"tcg/tcg-op-common.h\".\n>> Include the latter to avoid when including the former:\n>>\n>>    include/tcg/tcg-op-mem.h:34:5: error: call to undeclared function \n>> 'tcg_gen_qemu_ld_i32_chk'\n>>     34 |     tcg_gen_qemu_ld_i32_chk(v, tcgv_va_temp(a), i, m, \n>> TCG_TYPE_VA);\n>>        |     ^\n>>\n>>    $ git grep -w tcg_gen_qemu_ld_i32_chk\n>>    include/tcg/tcg-op-common.h:328:void \n>> tcg_gen_qemu_ld_i32_chk(TCGv_i32, TCGTemp *, TCGArg, MemOp, TCGType);\n>>    include/tcg/tcg-op-mem.h:35:    tcg_gen_qemu_ld_i32_chk(v, \n>> tcgv_va_temp(a), i, m, TCG_TYPE_VA);\n>>    tcg/tcg-op-ldst.c:286:void tcg_gen_qemu_ld_i32_chk(TCGv_i32 val, \n>> TCGTemp *addr, TCGArg idx,\n>>\n>> Cc: qemu-stable@nongnu.org\n>> Fixes: 69cdc5babf9 (\"include/tcg/tcg-op: extract memory operations to \n>> tcg-op-mem.h\")\n> \n> Pardon?  This isn't in master.\n\nHmm I meant a8af0fb24da in Peter's tree:\nhttps://lore.kernel.org/qemu-devel/20260423100229.2941820-11-peter.maydell@linaro.org/\n\n> \n> I recall this is one of Pierrick's patches, but we should fix it before \n> committing.\n\nI'll mention it in the other thread then.\n\nThanks,\n\nPhil.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zDqlgMNj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1bCb3gJCz1yCv\n\tfor ; Thu, 23 Apr 2026 22:35:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFtGM-0006xy-JM; Thu, 23 Apr 2026 08:34:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFtGL-0006xi-IW\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 08:34:33 -0400","from mail-wr1-x429.google.com ([2a00:1450:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFtGJ-00007G-U8\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 08:34:33 -0400","by mail-wr1-x429.google.com with SMTP id\n ffacd0b85a97d-43d75312379so4863475f8f.1\n for ; Thu, 23 Apr 2026 05:34:31 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4412150a092sm18663068f8f.23.2026.04.23.05.34.28\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 05:34:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776947670; x=1777552470; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=/vreumd6uaXfkirV4hg5sUAs7q0q0XtLTmucrxedRsQ=;\n b=zDqlgMNjMOzjM/dO6W0tDLjdwEfh03J4b29wGLSKxGDR+Q4MWabxWjjjfjiR3s+zXe\n T3YyPp2votE7j8v2efUvIlp6s59r5Uy5vt7I/Y3tRpo29WGotQxWrftbTLHtuFGExHyy\n eYwx2brn7uf7huI3xOY43V3kWVaRzMeAr2sZqIVurQXtGmYa+PK/KitTL21hIEjI6eb4\n O8qHOxJ4N540f1VgV1xRiwf2379Ulj/dS5jNBJX/xXwRHmARNEm1555yLuZiDFuaDc2z\n OCulTXfICsBx98IXsmzW/yO+Z0ngfpTk0JkSqLwIhdBJgWm/ktxawnof5O9f8JzBnqa2\n /cgg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776947670; x=1777552470;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=/vreumd6uaXfkirV4hg5sUAs7q0q0XtLTmucrxedRsQ=;\n b=Dy3CgW4wwI0esOaRH1gd9wjL3tTzmEAi541AGwGrAA0vsYgxFLG9I0uuxVC2SwagMQ\n kTYnyGH9HoN+KyUCYjXOwEkt08+NDhYDH7SL6NUmKHjr1fGv76ZktnlnxtMA/kz+PCyU\n uV4D7Cj/a+xtRF8DlJteKCPMe0/fY+mMcCHwVQX7rcfqfEvDwTAxBTp5VpgZOOFI52EX\n 1nx+lp+9AKS6HPMHiJIGVCkH+RS179JeCFcqmWUxzUDWOjb3QUsyyk1+IIEF0DKzZxVj\n 2GqMlkkN1yjTybhgmoQlZwCltE2JI0eTfav3Y2n7HqCF47kCM/pB40DyBCiKtMX/w8x4\n mnrg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9Voi1pMYsfr/QFNX9EcO+DPTk7ca0ZYZFiYVC5OrgTkgMjCH6uFeXL8gui19IQSEaBzffS/vRTJDVR@nongnu.org","X-Gm-Message-State":"AOJu0Yxbas9sBe0EFnOTo1Kz3ze5E1kU58aMtYJc9yCTVwIKS2HeFQ5i\n 5444Jd6z6z8Ad+hJ72G1FoffkQDqgnCLEM/jJMphGTwMFrsZ+fBiLUyIz8tolhZy16NI5+jd7IA\n boBd+d0s=","X-Gm-Gg":"AeBDieuZCkgJRar/M89R5Pwh+A63+aQMcl/SK3ueCU6kmIntToV/9Le3dl7kWYaeKSw\n TY9Wb2tLodk4tfA3KT4zbtg7ogz3BR15QQfrFFiCdj3Yygh9DKf1jnDy8TnoazhFy/P27csG87F\n uNzThNY1cAhi/25OnPJprXlAdNlOyZOUMSSepRSeOuA0cp6K03fsKJu9ppp3GwgTO2TQfP972+t\n W/lNRqtYt1PyLIJTvqnlRw2Xh7L2WWYvns9UKaJjuWRQpLHBoXMo51YNa11KfAyjfr6cerOawn/\n ddUz+FT1G8tiyVtEQ2ZR4enJuoh5DFUX2uObTvAscBElPJU265WDavKawpjJsBsmb3ms/FvmpN1\n 09syVlFdaSAmL7H9GAyFQRD8odmfsF5N3TRfutVufzpEF6CYt0JB05bqyvbGTU5VvxmNBT39DCV\n 8Xu9YtQFKB/b/63N+a35Mup5yy1gZhHSF5BH8rY3PukrZpY3rOshAwZv+WxqmmWNxiFH0AFwWq7\n 7To","X-Received":"by 2002:a5d:64c9:0:b0:43d:2d34:8963 with SMTP id\n ffacd0b85a97d-43fe407ae53mr44463067f8f.17.1776947670004;\n Thu, 23 Apr 2026 05:34:30 -0700 (PDT)","Message-ID":"<7fdb9701-0245-4872-9d5c-157f6b80b340@linaro.org>","Date":"Thu, 23 Apr 2026 14:34:28 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/9] tcg: Include missing 'tcg/tcg-op-common.h' header in\n 'tcg-op-mem.h'","Content-Language":"en-US","To":"Richard Henderson , qemu-devel@nongnu.org,\n Peter Maydell ","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson , qemu-stable@nongnu.org,\n Paolo Bonzini ","References":"<20260423100612.27278-1-philmd@linaro.org>\n <20260423100612.27278-2-philmd@linaro.org>\n <6fc61e19-dca0-4d76-8b8e-f8a81c1515bf@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<6fc61e19-dca0-4d76-8b8e-f8a81c1515bf@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::429;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]