[{"id":3681642,"web_url":"http://patchwork.ozlabs.org/comment/3681642/","msgid":"","list_archive_url":null,"date":"2026-04-23T19:12:54","subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Thu, Apr 23, 2026 at 03:14:38PM +0530, Pranav Tyagi wrote:\n> The package_loaded event is not set in case MIG_RP_MSG_PONG does not\n> arrive on the source from the destination in the return path thread. The\n> migration thread would then be blocked waiting for package_loaded event\n> indefinitely in POSTCOPY_DEVICE state. Where as, in such a condition the\n> source VM can safely resume as the destination has not yet started. The\n> pong message can get lost in case of a network failure or destination\n> crash before sending the pong.\n> \n> This patch removes the package_loaded event and uses rp_sem, instead of\n> kicking multiple events. The error is detected in case of network\n> failure or destination crash and rp_sem is set in the out path of the\n> return path thread. This will kick the migration thread out from a\n> condition of indefinitely waiting for rp_sem. The migration thread then\n> fails early and breaks from the migration loop to resume the vm on the\n> source side.\n> \n> Fixes: 7b842fe354c6 (\"migration: Introduce POSTCOPY_DEVICE state\")\n> Signed-off-by: Pranav Tyagi \n\nReviewed-by: Peter Xu \n\nI assume Juraj has looked at this already internally, in that case you can\nalways attach his R-b directly when post / repost.\n\nIf not, then it becomes a sincere request.. :-D\n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PhZ6hGxt;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=evO1caVk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1m3Q6dPzz1yDD\n\tfor ; Fri, 24 Apr 2026 05:13:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzU5-0000eR-Dx; Thu, 23 Apr 2026 15:13:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzU0-0000dX-Ew\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:13:04 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzTy-0007V2-8S\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:13:04 -0400","from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-451-yfLV5qSXPQGeG98njBRNlA-1; Thu, 23 Apr 2026 15:12:58 -0400","by mail-qt1-f197.google.com with SMTP id\n d75a77b69052e-50da529ff48so165899931cf.3\n for ; Thu, 23 Apr 2026 12:12:58 -0700 (PDT)","from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50e40aab60dsm157183021cf.18.2026.04.23.12.12.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 12:12:56 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776971579;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=zSPMVIsETMCCRcRnLlbQIG+Fw+GAkSsMNcI9CpUPrxc=;\n b=PhZ6hGxtQgvnwrMsAQJ+wZ798MgretG+jeHaN8ll6aF5GGCeZlIbInceQ4ZpSh3Kd7bBRc\n TFMPl5J7Wrz0GHXOUvuSNLz78rsE7ztEs6zZSYnf44XcVGUrnZlIU/Kbryew9BRFAQ2Gw5\n 0jjZ+QbPYKmV25HSb0cwK/CWU2ramag=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776971578; x=1777576378; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=zSPMVIsETMCCRcRnLlbQIG+Fw+GAkSsMNcI9CpUPrxc=;\n b=evO1caVkwBBt9UycwRScZbr1dyWZmCbzoRQhdu9+WPljvw1JEnMfB1h7titVFURi0v\n iTjEIbgsSGoNANwm/EW4KXklZRTXe8N0g5aClwlk1blTnBhPiFf1dHYF/+Dy3YogI1RE\n QxjmgY3r53p6P8uf5oBE8M5cvfT8d2HToyPuU1TDjAvCSztMJ7/zdPOsLgEv9yi5dHds\n 2/ixcwjQdT7hmW5zjN2S0XwO7dsAEZyZPctpAu9I7Rzof5iGkQZYTBjQ4bmZHfQ59mMb\n M0I+210aZH9An/Iq3rzcES6DtnH9XzHGhkCM/DXKSbRfY6WeNHXPb25HdMWrBkGUFbku\n wl1g=="],"X-MC-Unique":"yfLV5qSXPQGeG98njBRNlA-1","X-Mimecast-MFC-AGG-ID":"yfLV5qSXPQGeG98njBRNlA_1776971578","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776971578; x=1777576378;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zSPMVIsETMCCRcRnLlbQIG+Fw+GAkSsMNcI9CpUPrxc=;\n b=UMpPvqW6Y3xavxLJO0JAbbs4lSJkf9dxk3a7hiUoKK9PRkFytDs9zrceIse7zuLRII\n qN1534UXV8B28FO3FOmIt5C1RkxZ6XvFeBkuH5iIQwK6i8E/aiX8yrIYAlqWRxJRB4v9\n FzQD/IGT+3GK0mrudsOXR/D0rOyzrEozlHxR0b6ktBgMudTXEuu9zPEPKgMmFsYAxdw7\n SWDyIGnxZr2Hwar5Aca5vactsuAvvAibdqKAZg/ieyMHeWa1Ij4GXmJ6Bx9ytShsecGQ\n +Hz8pyLC8lhLskoyGXMLRwAmqlxdozIu6JoKaPkN3dWSx+eP99FV1kwhtcTtpFfPY2q/\n C0yg==","X-Gm-Message-State":"AOJu0YzIpDQIQfNBh1BRz+VCF/qACQFbljncCfIcSppEayTHdCYzb6Ll\n zTskt0hqgZbbddWi1YrXeWNSw0WAnY6TU7SMywJA0FIG0avbccwbcfcYc/rWTkfKgfCkHCsQLgH\n QuqQate+rIw3AnVlVsiGuLZiV3tFfTgOBmcsC0OGpoJ22IdQIno5ZOwrM","X-Gm-Gg":"AeBDiet+lsCWusx+Wc/39BsQClp+gS3LS6/WWpJ5JhSpJdEL49Sz8ZVnNkXuMp8V828\n IKeMMBApC3WfV8LKBcp8Ba72uittB0GgFPK5LbdkYupA1v0FDfEM2p7g56mi0ib1pWWSStxJKm4\n D3KmfdIRHLhJ3HXVa/WF5Lj1/wC2mfZvZWb8YuTgG/sgoT/cpFAAVyn8X8r21MHQ6DkaBu/8WtU\n 48SuvZHbqKBVTooIDXXr18/8wDH8AXjOCpYAMq2+blIgEW7X6oLVxb25fBFGyDQKcFYNPRvZ0hD\n IlCkVYmy4ce5lONWQpb0lj/AxYqXB0HQHEfQAAHnYQQzTA0e2IWyBBfkhY9CrWsqj39Uq+JIFwe\n 5E0kuztIjHXI0LRNdHUjNvnBKG4JBbfqVC1UdlH0YmFnmXfiiOkFHX8gqBA==","X-Received":["by 2002:ac8:5a02:0:b0:50d:a6a0:8f04 with SMTP id\n d75a77b69052e-50e36c4189dmr418057951cf.42.1776971577668;\n Thu, 23 Apr 2026 12:12:57 -0700 (PDT)","by 2002:ac8:5a02:0:b0:50d:a6a0:8f04 with SMTP id\n d75a77b69052e-50e36c4189dmr418057461cf.42.1776971577150;\n Thu, 23 Apr 2026 12:12:57 -0700 (PDT)"],"Date":"Thu, 23 Apr 2026 15:12:54 -0400","From":"Peter Xu ","To":"Pranav Tyagi ","Cc":"qemu-devel@nongnu.org, Fabiano Rosas ,\n Juraj Marcin , Prasad Pandit ","Subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","Message-ID":"","References":"<20260423094438.43556-1-prtyagi@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260423094438.43556-1-prtyagi@redhat.com>","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681771,"web_url":"http://patchwork.ozlabs.org/comment/3681771/","msgid":"","list_archive_url":null,"date":"2026-04-24T04:48:29","subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","submitter":{"id":93199,"url":"http://patchwork.ozlabs.org/api/people/93199/","name":"Pranav Tyagi","email":"prtyagi@redhat.com"},"content":"On Fri, Apr 24, 2026 at 12:43 AM Peter Xu wrote:\n\n> On Thu, Apr 23, 2026 at 03:14:38PM +0530, Pranav Tyagi wrote:\n> > The package_loaded event is not set in case MIG_RP_MSG_PONG does not\n> > arrive on the source from the destination in the return path thread. The\n> > migration thread would then be blocked waiting for package_loaded event\n> > indefinitely in POSTCOPY_DEVICE state. Where as, in such a condition the\n> > source VM can safely resume as the destination has not yet started. The\n> > pong message can get lost in case of a network failure or destination\n> > crash before sending the pong.\n> >\n> > This patch removes the package_loaded event and uses rp_sem, instead of\n> > kicking multiple events. The error is detected in case of network\n> > failure or destination crash and rp_sem is set in the out path of the\n> > return path thread. This will kick the migration thread out from a\n> > condition of indefinitely waiting for rp_sem. The migration thread then\n> > fails early and breaks from the migration loop to resume the vm on the\n> > source side.\n> >\n> > Fixes: 7b842fe354c6 (\"migration: Introduce POSTCOPY_DEVICE state\")\n> > Signed-off-by: Pranav Tyagi \n>\n> Reviewed-by: Peter Xu \n>\n> I assume Juraj has looked at this already internally, in that case you can\n> always attach his R-b directly when post / repost.\n>\n> If not, then it becomes a sincere request.. :-D\n>\n> Thanks!\n>\n> --\n> Peter Xu\n>\n> Hello Peter, thanks for the review. Juraj had already reviewed the patch.\nIn such a case, I'll remember to attach the R-b tag directly from next time.\n\nRegards\nPranav Tyagi","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PAEDG9rf;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=abqCJSDX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g20qy3kV7z1yDD\n\tfor ; Fri, 24 Apr 2026 14:49:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wG8TF-0000RU-VJ; Fri, 24 Apr 2026 00:48:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG8TB-0000R8-6m\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 00:48:50 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG8T9-0000OX-7K\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 00:48:48 -0400","from mail-ej1-f72.google.com (mail-ej1-f72.google.com\n [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-592-ChNYXtzsNEa3npkneJM6Lw-1; Fri, 24 Apr 2026 00:48:42 -0400","by mail-ej1-f72.google.com with SMTP id\n a640c23a62f3a-ba661b6c550so631438966b.0\n for ; Thu, 23 Apr 2026 21:48:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777006124;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=UaW8VfN7qeKGcyj5LjkfQGFN0MBHwTh30QwNNITkG84=;\n b=PAEDG9rftIHa9W77ffeF14tvfyNdxkoJUIRTTJejIr0Xg8nUXUkcgiVSMflK3zYOs0g07y\n 7AqZK502eZ8o8xUGoylt3HeGaa4OgcDXI7E+KQVr6dmbYGwT8jto+doQA8NNdl1lN6GLXs\n 1K9q5TU8CS6d0W9+mEO3hIhV7+cz/iE=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777006121; x=1777610921; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=UaW8VfN7qeKGcyj5LjkfQGFN0MBHwTh30QwNNITkG84=;\n b=abqCJSDXG8ZlQDXFGJvxiGe3cZBuBvqFa29Is4LNruqhktkGpSgPPDl+xJb6x468uM\n Kh4ZE3CRXRVqhPVBClxQLUIU+HKnjSEWjmTaI5CvO4f+LPCpdKeO994BmNxBFeDoOThi\n lHNaUNVpb8/q0DR6E60Tr2qHTaXAOrmlEd+pVoL6EMsEndmeAumaXql5zahh8mfxALXJ\n F3Su1hOFC6rQ89BYyfrAiaKqAzWBQesx9zyP+gxWCBffrdL9sJtl0mEPh8erjTIo2Lr+\n JjSu+EhtveAYChHtF90HMAQBwVexwc+yswxpJ3hrUK+2gwdeLBZ4+AfHA4R9T4Ceu3bs\n SX4Q=="],"X-MC-Unique":"ChNYXtzsNEa3npkneJM6Lw-1","X-Mimecast-MFC-AGG-ID":"ChNYXtzsNEa3npkneJM6Lw_1777006121","ARC-Seal":"i=1; a=rsa-sha256; t=1777006121; cv=none;\n d=google.com; s=arc-20240605;\n b=dgpYmaKjEc9+MnTClG6VI9nWPHR8SShwBF78uejRXLx+y8KLxNr7AqEJPTTb/cxcoT\n 0V/K20BU245JsqZhSIpz/UDRE5MdJR02t20FitTzDySpJBlrKpXBI+fO0qGQ4mZuJ0lu\n MvCkO4stHvll9oP9PuvKCKVX2SxGAeXFgw3JWDkd8k5nhp3CiC81j79AsIKMN6fUfIpC\n ZPhLM2n+acH1I/jP8NuKbbFYfMD+Od2DQ4JSqhy5GrkV0P4ERU4WHOe8AGlc45PUOOQl\n LKvdnxAYP/LPM+MJEoNJ5eobZ77Y1SJ3TfHiFbVR88jRUubMNYfXSoBnkLBDwhZQ0ucY\n WZWQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=UaW8VfN7qeKGcyj5LjkfQGFN0MBHwTh30QwNNITkG84=;\n fh=tqeddvYnnfVFRES8/MufanmBVJwlsV6HFTbK+mWQ8lQ=;\n b=By+iN/JfYA2rsIABV4k85I8HiODV/reI/tO7XRxfe+4fexWBJECdsj4c8Uv+CSiGPz\n 2U98OH2og+KtliHyZJZZwnVPsLN0VZNEabZSCi4FtjGMEqq8OYA4FXYv6EGIYt9pBNqf\n w/qt1Md8vXcvhipzwLmDKc6eWIAvkEAY+4LjMvHtqcejQvSFqfsddkuH8JaJ5W0Vbxru\n hML3zli6XIYI7GOh/IJgL4Tuw1h/pU2KfWKLwgnabt1cpl+Rc9Mk5eV49HgELPvDSnSz\n RW6f8RmnNUwmFBAreKpF3glp2WrXhtoUnnlyZpQqzb4zjx6wGUT1xG3bMWIPHxwwuRe6\n WVOA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777006121; x=1777610921;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UaW8VfN7qeKGcyj5LjkfQGFN0MBHwTh30QwNNITkG84=;\n b=DBiDSqEFx+IKSVxU82L4fQNz/Ik0BNZnALikTFycfahxWfPj7pkJEE33jnQQvdIONm\n OFi3xJr+I9Bhm6jLaye37ZpTp2+fXbdsQ7gP7SqzvW6U7rqmHoBXypNYQDs9vh7myjTC\n /4vZ+DpmS++bGtjMAAZuP+yWCUWyulEV5x99kARvFDD7D2bu7bnjFND8WIW3fGbcdjH6\n zsoI+I+v9rWVaFwQslHTHe/Zwb5VzHz2vVuFw91HbFjBQeLM6I6UR27KwuRzWXZ0e9fc\n bExd4/IDFfsoVUmXwiCqG/q6yLgcFFfFlppKiE3yEWfnsYbZ4RFvLeJHGuabzDVdhG9j\n ufsA==","X-Gm-Message-State":"AOJu0YyGKqFU7eXal3gB3oT8kWwNL0LVrco3JXXvwDZATqgcJkhJA2dw\n 4qCehTRX1bKzrRCkmOWDcBiQ9Y85r+RLVER/UwlA+6Jof9HjTsYIdqfQ7QUmv4rquJPDAFp0pl+\n e9p34dRSlAmv5i7eK7Cj6ozBKcx3iPpOS1wuhRgEQw/QelEL02C4XVATBUStRvku/Vf67F0ky3b\n 3/wqYt7pBRShsjhIiytqEwE4fVvp+cG7w=","X-Gm-Gg":"AeBDievpeNDR1Xyd+39vDnLbyVQBEejrKsdUeG7uAsq3w/FboD1LTBmOAATNuuCWOPD\n F+/pgi1tPqBDCC80U2RJTPG5nocIAZv4DqTJfMS/tOONmhbcgg/1ilpuL65r2aaCC8IS2QWVpJj\n NQSQ1uTb/MHxJ/Q8Bvlvd7XrJf7w1joyMjzh0qLYylmBXq2bwJZYBFJbUuCpjJlN2se4JYdeUkE\n qBxziO+1vvsGKb/1wk=","X-Received":["by 2002:a17:907:940a:b0:bab:af3:1008 with SMTP id\n a640c23a62f3a-bab0af31068mr532233066b.8.1777006121279;\n Thu, 23 Apr 2026 21:48:41 -0700 (PDT)","by 2002:a17:907:940a:b0:bab:af3:1008 with SMTP id\n a640c23a62f3a-bab0af31068mr532231766b.8.1777006120674; Thu, 23 Apr 2026\n 21:48:40 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260423094438.43556-1-prtyagi@redhat.com>\n ","In-Reply-To":"","From":"Pranav Tyagi ","Date":"Fri, 24 Apr 2026 10:18:29 +0530","X-Gm-Features":"AQROBzAEB_Hz1efkhcLLmgAEf1e_kifmz3BS_7CVG87so6_tZeNo61wmpgeHlgs","Message-ID":"\n ","Subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","To":"Peter Xu ","Cc":"qemu-devel@nongnu.org, Fabiano Rosas ,\n Juraj Marcin , Prasad Pandit ","Content-Type":"multipart/alternative; boundary=\"000000000000963df406502d7a61\"","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=prtyagi@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001,\n RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681957,"web_url":"http://patchwork.ozlabs.org/comment/3681957/","msgid":"","list_archive_url":null,"date":"2026-04-24T10:32:29","subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","submitter":{"id":89058,"url":"http://patchwork.ozlabs.org/api/people/89058/","name":"Juraj Marcin","email":"jmarcin@redhat.com"},"content":"Hi Peter,\n\nOn 2026-04-23 15:12, Peter Xu wrote:\n> On Thu, Apr 23, 2026 at 03:14:38PM +0530, Pranav Tyagi wrote:\n> > The package_loaded event is not set in case MIG_RP_MSG_PONG does not\n> > arrive on the source from the destination in the return path thread. The\n> > migration thread would then be blocked waiting for package_loaded event\n> > indefinitely in POSTCOPY_DEVICE state. Where as, in such a condition the\n> > source VM can safely resume as the destination has not yet started. The\n> > pong message can get lost in case of a network failure or destination\n> > crash before sending the pong.\n> > \n> > This patch removes the package_loaded event and uses rp_sem, instead of\n> > kicking multiple events. The error is detected in case of network\n> > failure or destination crash and rp_sem is set in the out path of the\n> > return path thread. This will kick the migration thread out from a\n> > condition of indefinitely waiting for rp_sem. The migration thread then\n> > fails early and breaks from the migration loop to resume the vm on the\n> > source side.\n> > \n> > Fixes: 7b842fe354c6 (\"migration: Introduce POSTCOPY_DEVICE state\")\n> > Signed-off-by: Pranav Tyagi \n> \n> Reviewed-by: Peter Xu \n> \n> I assume Juraj has looked at this already internally, in that case you can\n> always attach his R-b directly when post / repost.\n\nI did indeed check it, you can include by R-b!\n\n> \n> If not, then it becomes a sincere request.. :-D\n> \n> Thanks!\n> \n> -- \n> Peter Xu\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Q68Pdg+6;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=GmU0qtdt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g28Rn35KPz1yHv\n\tfor ; Fri, 24 Apr 2026 20:32:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGDq2-00085G-Tj; Fri, 24 Apr 2026 06:32:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGDq1-00084z-4h\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 06:32:45 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGDpy-0008Fi-R3\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 06:32:44 -0400","from mail-pl1-f198.google.com (mail-pl1-f198.google.com\n [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-554-YDIUuBUKOEG_S-BudGQXWw-1; Fri, 24 Apr 2026 06:32:40 -0400","by mail-pl1-f198.google.com with SMTP id\n d9443c01a7336-2adef9d486bso70765635ad.2\n for ; Fri, 24 Apr 2026 03:32:39 -0700 (PDT)","from fedora ([213.175.37.14]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab4bf7bsm221195045ad.81.2026.04.24.03.32.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Apr 2026 03:32:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777026761;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=FweiYUionAf0G+sWG6apDYixDLEKkon1MR2bzb5I5Wk=;\n b=Q68Pdg+6sneyoqkwA7Y8iAL+qOTGIgo2RqlhC3yj5AR6u3Lz25fy4jM+RTRPwQXOvItk8M\n 6t/Kci/r+P+FYYbZQwjODj7sKw1sHEhbqdAdMcOHLwbLHLH3R+///M9ieS3uN+hgTINs5l\n L3TNuW/IdJO2Lg0f11W0AJjRJtdCHwQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777026759; x=1777631559; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=FweiYUionAf0G+sWG6apDYixDLEKkon1MR2bzb5I5Wk=;\n b=GmU0qtdtE71xoeM3pBll6CCbTTrU5bd4tiznqmXCvD7mfaFNGTDWknjrRO28pFxuqD\n nSFwKZUbDrxisitw2VGq06UwRxIirtL1AoQNgoV7vQIR8RQuyu7eqPQK4X+l7ANOFGoM\n 2zZwTzKoLYG9iQ1iLBHzte7L3AAM9eBAR878FahtQaUTIY1wCmvx7E9MMAbkofyiLjnQ\n qaB76DmlWhEsXy9OBkn0s6ZKVv9Sqf88CNHrCCbEboO/1gz0SCR4KS1sOMfhDoQxLlOV\n 2DLT7RPmILNvbJE+iWdeihR0VmlUElbCumJOvWSeHV8KJ3ZoTdGLEaQWNvC6noDi9sjD\n ptEg=="],"X-MC-Unique":"YDIUuBUKOEG_S-BudGQXWw-1","X-Mimecast-MFC-AGG-ID":"YDIUuBUKOEG_S-BudGQXWw_1777026759","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777026759; x=1777631559;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FweiYUionAf0G+sWG6apDYixDLEKkon1MR2bzb5I5Wk=;\n b=a6tFHKFKuDRW4Xw0x5ABH+jBYi2TDjCFDLkETbMWjpOedrWrJgAtz+MalWYP+d5N0g\n VS6qi01wCsHSkOIiokqgDz0sYuDOQ+5ryzdPDA1IrWfvtmlIX8silIVuQE8sryayXlqM\n /j7KJGcqC8e8xAUO98NZXOxFMcm2rcZqPNQn3+2QF2LF8afcvnNr4IQjQLRK6Q8f9LPI\n MY6q5bwHI6e5nZqj2AMNMWCvfauuVVtLSfJJ20bLuO6k8QpRMk46cngNQAxYc2LSbX7y\n IriG77oR2Sabpxx/Obf1irF0DtWu1HxRh3esB1rPxzkxP+vxS9QygfA8eAwHsqVcZnz5\n S1IQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8yVWaV1UktvSBD25K0YgjQYcbsOuuc9ZY/mdtIE42hLTdM309ibakiIgFFoQ8JqG5T9W32S5AtyXCY@nongnu.org","X-Gm-Message-State":"AOJu0YzL3eZ5ASTeHtaDe86ZQ0fQuT6xJyO3kt4aNAQzL/vE3469R0Lm\n eay3X5Pa/3IssM2JJNlWBspdbMn2uk/RpQEnLH58yM0E3yFv8SRaSM9unnwNxQ+CLFxXHrHPGSx\n 9IjE+hsH3lh6IN0F2GE2YgPdJr5IkIYNorhxlCEQDAiTxwTOOA5IEwIDA","X-Gm-Gg":"AeBDiesVg+gTFHTnObeKZo8Hhqzh/TYVfIbq0VDaKm1Dm8ZeYjYsAZB2cednUTl4TNf\n ymHHffYbwcVXtjgry1AsmN/efXVSKSIjq7mtQ8iMLMMgJC4KHwzhnRlBNXoxwrUdRIPBVw44Ihy\n Mfi771KoJyzjPYd+xZk51HKEZvBfBHaS0jc0rYtlMrmVr0ZHH9v+I42Ht5FahumXUCVCEI0d3Na\n SmqSfIlluvGHthe5YMhLnTBhPmyaiElkw8gPc/0cYZPM/4MfcgZHu0PuuMuZUbzBksZniAZxidN\n 7xdQ8hU8d9bK4V88rz8F5CQQjh47RpMfKhTg0IWrs+GoxMHR4DieXZAFdusIX0mhLdfLQAqz+IC\n YLzHRQSto3S2V","X-Received":["by 2002:a17:903:17c5:b0:2b7:a08d:9e42 with SMTP id\n d9443c01a7336-2b7a08d9f73mr81016865ad.32.1777026758960;\n Fri, 24 Apr 2026 03:32:38 -0700 (PDT)","by 2002:a17:903:17c5:b0:2b7:a08d:9e42 with SMTP id\n d9443c01a7336-2b7a08d9f73mr81016545ad.32.1777026758530;\n Fri, 24 Apr 2026 03:32:38 -0700 (PDT)"],"Date":"Fri, 24 Apr 2026 12:32:29 +0200","From":"Juraj Marcin ","To":"Peter Xu ","Cc":"Pranav Tyagi , qemu-devel@nongnu.org,\n Fabiano Rosas , Prasad Pandit ","Subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","Message-ID":"","References":"<20260423094438.43556-1-prtyagi@redhat.com>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=jmarcin@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681959,"web_url":"http://patchwork.ozlabs.org/comment/3681959/","msgid":"","list_archive_url":null,"date":"2026-04-24T10:33:02","subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","submitter":{"id":89058,"url":"http://patchwork.ozlabs.org/api/people/89058/","name":"Juraj Marcin","email":"jmarcin@redhat.com"},"content":"On 2026-04-23 15:14, Pranav Tyagi wrote:\n> The package_loaded event is not set in case MIG_RP_MSG_PONG does not\n> arrive on the source from the destination in the return path thread. The\n> migration thread would then be blocked waiting for package_loaded event\n> indefinitely in POSTCOPY_DEVICE state. Where as, in such a condition the\n> source VM can safely resume as the destination has not yet started. The\n> pong message can get lost in case of a network failure or destination\n> crash before sending the pong.\n> \n> This patch removes the package_loaded event and uses rp_sem, instead of\n> kicking multiple events. The error is detected in case of network\n> failure or destination crash and rp_sem is set in the out path of the\n> return path thread. This will kick the migration thread out from a\n> condition of indefinitely waiting for rp_sem. The migration thread then\n> fails early and breaks from the migration loop to resume the vm on the\n> source side.\n> \n> Fixes: 7b842fe354c6 (\"migration: Introduce POSTCOPY_DEVICE state\")\n> Signed-off-by: Pranav Tyagi \n> ---\n> V1: https://lore.kernel.org/all/20260421052227.8278-1-prtyagi@redhat.com/\n> \n> changed in v2:\n> - removed postcopy_package_loaded_event and using rp_sem to kick the\n> migration thread\n> - using migration_rp_wait() in place of qemu_event_wait() in the\n> migration thread\n> \n> migration/migration.c | 48 ++++++++++++++++++++++++++++---------------\n> migration/migration.h | 1 -\n> 2 files changed, 31 insertions(+), 18 deletions(-)\n\nReviewed-by: Juraj Marcin ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Lqa5IEgx;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=OPPCYIlA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g28SY0ZnZz1yDD\n\tfor ; Fri, 24 Apr 2026 20:33:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGDqS-0008E1-EB; Fri, 24 Apr 2026 06:33:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGDqR-0008DX-1J\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 06:33:11 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGDqP-0008QD-Er\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 06:33:10 -0400","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-676-MY8MJ2LxM9KRIk2ISJ0BFQ-1; Fri, 24 Apr 2026 06:33:06 -0400","by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-4891f97aef0so31038275e9.2\n for ; Fri, 24 Apr 2026 03:33:06 -0700 (PDT)","from fedora ([213.175.46.86]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7bf7besm207800005e9.34.2026.04.24.03.33.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Apr 2026 03:33:04 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777026788;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=/23mnfMfqzJeZ8cWu76P0yAPF56uKl4A/ka3wR5nlzc=;\n b=Lqa5IEgxovcMfbHkg/lpaBZ1vBjuGWoVF1eWrMWSuu2uZyB4TdLofT7XjKCK7py6BlaO0A\n QNulCnRNQBdckmfWqZ/4eaJXNh6GZsxjT8vsBthPLpADSbuh6zOtPHJUmZylcLkyclf480\n zouxb9kZ+jap9cRBWl60LuuZpizFiak=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777026785; x=1777631585; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=/23mnfMfqzJeZ8cWu76P0yAPF56uKl4A/ka3wR5nlzc=;\n b=OPPCYIlAdQgBipypgkw9831PI/YNhwh6SdYpLByKfrlz/bwn3AX4Xeu+fYZWXv4pm2\n S1uVUmuIYUrkQ5kPGF50lGF7NWEDcgoeLHfjvi1vuTd9oVe6yxfmYLw4cJKjnTVtxDRo\n X52jX3ACOoKD0+94LLLndynRR4e80QKk8wDiDtApJY23zX5YajL9SV67u0ugnWWAf3T9\n hGQ5B7DdAn6O+4pz3+TFDVLltoDua3GiIFN4nRPg3AgPf6WpMJ7Dai62DRJWoOgxozmC\n R3kGwpgj8yDyEZG2vXKW2DkqouiAZEaXNwbnBHOBxGk1pxjBQJo6T2tbyOqA7rDc7LLl\n dt7w=="],"X-MC-Unique":"MY8MJ2LxM9KRIk2ISJ0BFQ-1","X-Mimecast-MFC-AGG-ID":"MY8MJ2LxM9KRIk2ISJ0BFQ_1777026786","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777026785; x=1777631585;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/23mnfMfqzJeZ8cWu76P0yAPF56uKl4A/ka3wR5nlzc=;\n b=ggjRuJrb6wMbLUnxHrk3ET4uKSoWTMv3HFJAJtxj6mK5QPtStl0xqiROBWP27G1QUs\n XLikjmDRY5DSB0uFq9o7ZybvCHwgMr38FmHDQmUIhBORA9nHqycpxm+8BPS7UV3or4Dd\n TXEpVJIYNMTeFDeZJJKVuOmE9fPxoDBCi0zvuabAdG3AUUpSnDRfMoNpNxjqDYTqESrY\n GEPqgpJ7O9h+unqmpLi9CfI5pfTlPMwQqlk1vx2wpvNEGnqVo4mmPg6OA35UQQp7rs63\n EQMCBFjD1/aE42D2nQHkBZWRJ3MdZiuANH6i/4UxajEKYRJvvwNtmZ/b8M83Zb7lELGt\n jmGw==","X-Gm-Message-State":"AOJu0YzLzG7cb9IDdPbr2CWgIEkZYbtQWHN6q2RXTBhc3vnPVYrSjkuv\n lIaGTzUiqJ39eRHXA+UQE3/melqCCP19nN3NXc0CZwuyKEJisyHawFdJordYrCMZ6z8TbaWEbiv\n A7qpwvvcF6RVeXMzFUxujb/NCOvXYfADR0BN9M/axeiyEwTIsSZ01Bja/","X-Gm-Gg":"AeBDiesn1oA0a1NOVz3cMM/aJ8VJ1cBSMSrDvmI+MxFLXoLFX8o8P/bRZTroTXtzsJa\n z4VXL8CAgDUN1JVaeuronFOga3M68FRg9QTc6f2WC88S+EUPJxOiVbYGjcKZqCEctcsf8adl1jl\n CajZqrSZxGZ8i2/sqTLPmAXz++DbJ8Qw5n4UjM21TgRpOpkePnVKlOVpLO7uDWFR8QgtdNfzs64\n co6aPb75oVIFW9hLf2m1rLKtBWi53bCJe+43SQ3P6KspX/y7xDWElQHDbHkOD1d9LLmYP74Q/Gk\n uaBMPa9HFhjZzpqgKsV1ZcYeAV0U+ppVYK724ACCxOjwal2lhi4xvTesZU/v2pJhMqT57dJ3gpO\n roPJqeE0GB26L","X-Received":["by 2002:a05:600c:4f49:b0:489:1ff1:74df with SMTP id\n 5b1f17b1804b1-4891ff176bamr318167615e9.1.1777026785494;\n Fri, 24 Apr 2026 03:33:05 -0700 (PDT)","by 2002:a05:600c:4f49:b0:489:1ff1:74df with SMTP id\n 5b1f17b1804b1-4891ff176bamr318167155e9.1.1777026785085;\n Fri, 24 Apr 2026 03:33:05 -0700 (PDT)"],"Date":"Fri, 24 Apr 2026 12:33:02 +0200","From":"Juraj Marcin ","To":"Pranav Tyagi ","Cc":"qemu-devel@nongnu.org, Peter Xu ,\n Fabiano Rosas , Prasad Pandit ","Subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","Message-ID":"","References":"<20260423094438.43556-1-prtyagi@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260423094438.43556-1-prtyagi@redhat.com>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=jmarcin@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3682046,"web_url":"http://patchwork.ozlabs.org/comment/3682046/","msgid":"","list_archive_url":null,"date":"2026-04-24T14:00:43","subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Apr 24, 2026 at 12:33:02PM +0200, Juraj Marcin wrote:\n> Reviewed-by: Juraj Marcin \n\nThank you! I queued it for 11.1.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BWpcLz4v;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Go/fCEd1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2F5H1WfSz1yDD\n\tfor ; Sat, 25 Apr 2026 00:02:11 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGH5o-0008Tq-2g; Fri, 24 Apr 2026 10:01:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wGH5T-0008Qe-S4\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 10:00:56 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wGH5R-00056x-Vm\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 10:00:55 -0400","from mail-oo1-f72.google.com (mail-oo1-f72.google.com\n [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-584-MbOv17ztO9G-t_z0GLUIxw-1; Fri, 24 Apr 2026 10:00:49 -0400","by mail-oo1-f72.google.com with SMTP id\n 006d021491bc7-672c40f3873so16288241eaf.2\n for ; Fri, 24 Apr 2026 07:00:49 -0700 (PDT)","from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8e7d5fe98dcsm1998381285a.7.2026.04.24.07.00.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Apr 2026 07:00:45 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777039252;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=GwumuizkFfW4BtGEByu3LeybmWfMZHEtBBMWT7PFlpc=;\n b=BWpcLz4vqMvhRYKZ/qJq6Qj7yWv6LhVy3//FEEkz4+cLh+9z8W/Q3ZQuxDD444y2oHpxGx\n PFrXz/vLQnUf+p7p7X528hmjuZTUSEzvLhf5/sXt7jroiq+Rj+CSQsvT39XbLkLYLEcgFy\n x9RU3nAQO9yuPknXktsuIvmsnNko7F8=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777039248; x=1777644048; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=GwumuizkFfW4BtGEByu3LeybmWfMZHEtBBMWT7PFlpc=;\n b=Go/fCEd1qwCn7gaJqzAtuaG4FHAJiq/Y6MQVRJrSbPUO39lQvChBuBez6bWYnPZ+oP\n L2LL42nm0NmqvPXm3wwb22faKP8pU0IwOjPeUzCO7ahs09tmbnrno/vMd917u9SUCpZI\n e+H1A+Jx7kEdZWHIO31zQhCVj8y7Pn1kd/aMM6cLBROYQqW83qYRK2S4dsqJ3uktq8gn\n rZtbTHVAQvARlEIIJ8Yg9EgQrqfms0opsKX6xSqOX4IccFi3IP562C/YGNu8YoXAAK/f\n bWiK2ywY4v2oWl7S8Qs4GkFynjuW/j5M7dYPUu+ja6/SV8UoTqB0dduoyQ5UhzzhiHUR\n eYdQ=="],"X-MC-Unique":"MbOv17ztO9G-t_z0GLUIxw-1","X-Mimecast-MFC-AGG-ID":"MbOv17ztO9G-t_z0GLUIxw_1777039249","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777039248; x=1777644048;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=GwumuizkFfW4BtGEByu3LeybmWfMZHEtBBMWT7PFlpc=;\n b=p/Z96k6SoFfwXQoJPjZAG+TdlJcBdFFfvIbD0riF+U4ZnDaJcQEyxN9kV6ro9NM15v\n n++H+H4mo+5uI0M94g0OJbdhRcmJw7vDqjzlX1yXkUFSvaWUmb9fllyMFEYDquJtPM3C\n E/rj/1kjjPLNWzmCCe278FIAuirzKlx3WXFvsAxYccqk8rzEYZk18vDdKJRn7AF+Ojvy\n SwDbdF0zPkpu+p2TeTGp/s8xS/1Hnq/R2iJxv0dqNJCmBvqrcVHyvXQ5w4PRnU8chMqV\n e93QQi1k0KE2NqeITLXW4ws2jNnTOuIxFsMcw7GR4b6lubrIC/NcdOvCwzWZqTCm4gKG\n EvvQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/FikYYtfqPw9FcMkcmzd9TSflDC+V4qVLqucKF8kFYuZQjKvdBHpmQkFj5OCOIRW4sVMdUh8eZb2/8@nongnu.org","X-Gm-Message-State":"AOJu0YyxHTYokqOSwT6V0Elq3lkVP24uPzPpk4TllUyTKlqTjfCZUDoO\n CwhsnuWHs7IHbbB5urEkq6//9GUqDWEoHNcG5uzpsjowUc9O+kagEj8wA4lGFr0u/fOeAFDeNUQ\n pSYr0aLA+v7vwSEjHm46g11s5uIfqBb6SuMWtEOymsZfPJht3tJxJN+He","X-Gm-Gg":"AeBDieu6wqrSXiQa+omsMk3EOYDjgY7KhRzc8JNVlxr3lCOpxWEZGLUZsZSTZWBImBn\n vORijtDUDkyLPPQt25iVnLrpjfajnRU5A8l3j5j7G8Yp1kEpxqmSfI9C+apFm0iffqVj6GRlIx0\n 2T3gOcTkIbRSCnBK5ol9Ymn0R5gGBW5WHox3VlDJ7ikeKZ5bo+L6/BzZVVjeV5qb/XgIxLcYDAu\n BrOZgtRDxQQEAA4PQCrFsQNq/ssUiNFZBBsoWh49Kutb44IWXAncR0WqqxfHUGzAt3IHgPLlaby\n QbTg5wUrCDroa3KnGOI0uTbZ4piFBgBMSOCqteutoy3v22vfJc4w7x0w/e2v54fBXXBIP6T6Xm2\n x+l6K46LGX/BWGojJlYqSvG09ZGoiXv1v5gsEGmuXhC7Q54s9XXllbNhplw==","X-Received":["by 2002:a05:6820:188b:b0:694:9720:65e0 with SMTP id\n 006d021491bc7-69497206ca5mr10322794eaf.39.1777039246816;\n Fri, 24 Apr 2026 07:00:46 -0700 (PDT)","by 2002:a05:6820:188b:b0:694:9720:65e0 with SMTP id\n 006d021491bc7-69497206ca5mr10322757eaf.39.1777039246262;\n Fri, 24 Apr 2026 07:00:46 -0700 (PDT)"],"Date":"Fri, 24 Apr 2026 10:00:43 -0400","From":"Peter Xu ","To":"Juraj Marcin ","Cc":"Pranav Tyagi , qemu-devel@nongnu.org,\n Fabiano Rosas , Prasad Pandit ","Subject":"Re: [PATCH v2] migration: Fix blocking in POSTCOPY_DEVICE during\n package load","Message-ID":"","References":"<20260423094438.43556-1-prtyagi@redhat.com>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]