[{"id":3681605,"web_url":"http://patchwork.ozlabs.org/comment/3681605/","msgid":"<6bdce57340942334cf7d3c7f7ed0215458717495.camel@crapouillou.net>","list_archive_url":null,"date":"2026-04-23T17:59:21","subject":"Re: [PATCH v2 10/41] drm/ingenic: remove now-redundant call to\n drm_connector_attach_encoder()","submitter":{"id":5484,"url":"http://patchwork.ozlabs.org/api/people/5484/","name":"Paul Cercueil","email":"paul@crapouillou.net"},"content":"Hi Luca,\n\nLe jeudi 23 avril 2026 à 11:17 +0200, Luca Ceresoli a écrit :\n> drm_connector_attach_encoder() is now called by\n> drm_bridge_connector_init().\n> \n> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>\n\nAcked-by: Paul Cercueil <paul@crapouillou.net>\n\nCheers,\n-Paul\n\n> ---\n>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 --\n>  1 file changed, 2 deletions(-)\n> \n> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c\n> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c\n> index 4068114adf8c..70088db34f69 100644\n> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c\n> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c\n> @@ -1330,8 +1330,6 @@ static int ingenic_drm_bind(struct device *dev,\n> bool has_components)\n>  \t\t\tret = PTR_ERR(connector);\n>  \t\t\tgoto err_drvdata;\n>  \t\t}\n> -\n> -\t\tdrm_connector_attach_encoder(connector, encoder);\n>  \t}\n>  \n>  \tdrm_for_each_encoder(encoder, drm) {","headers":{"Return-Path":"\n <linux-tegra+bounces-13935-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=crapouillou.net header.i=@crapouillou.net\n header.a=rsa-sha256 header.s=mail header.b=VidnwjpK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13935-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net\n header.b=\"VidnwjpK\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.119.170.32","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=crapouillou.net","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=crapouillou.net"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1kPx4kFLz1yDD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 03:59:49 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0DF99300678C\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 17:59:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B402838D6A2;\n\tThu, 23 Apr 2026 17:59:40 +0000 (UTC)","from aposti.net (aposti.net [185.119.170.32])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A26E13AA4E7;\n\tThu, 23 Apr 2026 17:59:37 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776967180; cv=none;\n b=HRxqg5Cc9eGRqYvIhIo6BJQgaZX7fdDODx1nxtlP4oIrSFKVzn81+DymHnq4m+13qWYFLcu0xGR75sucUqbNF0blAeS1n9UqsmWEtsDsEBfCwF7Jm9dAuMbNZtSKf7P0BVn8cqZkPOKAzOsf0D9XOaaQogu813/rO3eDfrVP33s=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776967180; c=relaxed/simple;\n\tbh=QGXWKH7JhojDk/vCfoesF6wdkbcwasz+b8TzqgsvnEY=;\n\th=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=l4edDqx79mpKVfHeDJZhrRKqXbhIXbPargs0d1QU//u/hUK54H3t7cllKaFYzpsAqzFJtFUWNeDSoSBZkhTV/oZ5hYlyBOqO4ssSu36EEwMfXuLQpjIM8MQSpTcqrw03HXb4syPLUxFFVme+oM0bEf8oTDBAUIXoU0JdrPfH1xQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=crapouillou.net;\n spf=pass smtp.mailfrom=crapouillou.net;\n dkim=pass (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net\n header.b=VidnwjpK; arc=none smtp.client-ip=185.119.170.32","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=crapouillou.net;\n\ts=mail; t=1776967168;\n\tbh=QGXWKH7JhojDk/vCfoesF6wdkbcwasz+b8TzqgsvnEY=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=VidnwjpKlxAHpZXdZ5M8HqNp1+KLzj/lVqpTUjnVCvvI0AlMOvy6xLPjbVADW6Z7T\n\t zX2omNSMnvzMFu+5OaTkic3YSw0JBpTj1pMqKOxAH5KG+vq/PHkgVXLcKBhtSsGmGS\n\t Vrdc/osIcU6MzDXs3blATAtRvZpS57uE18zfDmjI=","Message-ID":"<6bdce57340942334cf7d3c7f7ed0215458717495.camel@crapouillou.net>","Subject":"Re: [PATCH v2 10/41] drm/ingenic: remove now-redundant call to\n drm_connector_attach_encoder()","From":"Paul Cercueil <paul@crapouillou.net>","To":"Luca Ceresoli <luca.ceresoli@bootlin.com>,\n Dmitry Baryshkov\t <dmitry.baryshkov@oss.qualcomm.com>,\n Andrzej Hajda <andrzej.hajda@intel.com>,\n  Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,\n Laurent Pinchart\t <Laurent.pinchart@ideasonboard.com>,\n Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,\n Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,\n  Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,\n David Airlie <airlied@gmail.com>,  Simona Vetter <simona@ffwll.ch>,\n Sasha Finkelstein <fnkl.kernel@gmail.com>, Janne Grunau <j@jannau.net>,\n Liu Ying <victor.liu@nxp.com>, Douglas Anderson <dianders@chromium.org>,\n Laurentiu Palcu\t <laurentiu.palcu@oss.nxp.com>,\n Lucas Stach <l.stach@pengutronix.de>, Frank Li\t <Frank.Li@nxp.com>,\n Sascha Hauer <s.hauer@pengutronix.de>,\n Pengutronix Kernel Team <kernel@pengutronix.de>,\n Fabio Estevam <festevam@gmail.com>, Philipp Zabel\t <p.zabel@pengutronix.de>,\n Anitha Chrisanthus <anitha.chrisanthus@intel.com>,\n  Chun-Kuang Hu <chunkuang.hu@kernel.org>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,\n Kevin Hilman <khilman@baylibre.com>,  Jerome Brunet <jbrunet@baylibre.com>,\n Martin Blumenstingl <martin.blumenstingl@googlemail.com>,\n Rob Clark\t <robin.clark@oss.qualcomm.com>,\n Dmitry Baryshkov <lumag@kernel.org>, Abhinav Kumar <abhinav.kumar@linux.dev>,\n Jessica Zhang <jesszhan0024@gmail.com>, Sean Paul\t <sean@poorly.run>,\n Marijn Suijten <marijn.suijten@somainline.org>,\n Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,\n Sandy Huang <hjc@rock-chips.com>,\n Heiko =?iso-8859-1?q?St=FCbner?=\t <heiko@sntech.de>,\n Andy Yan <andy.yan@rock-chips.com>,\n Thierry Reding\t <thierry.reding@gmail.com>,\n Mikko Perttunen <mperttunen@nvidia.com>,\n  Jonathan Hunter <jonathanh@nvidia.com>,\n Icenowy Zheng <zhengxingda@iscas.ac.cn>, Jingoo Han <jingoohan1@gmail.com>,\n  Inki Dae <inki.dae@samsung.com>, Seung-Woo Kim <sw0312.kim@samsung.com>,\n Kyungmin Park\t <kyungmin.park@samsung.com>,\n Krzysztof Kozlowski <krzk@kernel.org>,\n Alim Akhtar\t <alim.akhtar@samsung.com>,\n Laurent Pinchart\t <laurent.pinchart+renesas@ideasonboard.com>,\n Tomi Valkeinen\t <tomi.valkeinen+renesas@ideasonboard.com>,\n Kieran Bingham\t <kieran.bingham+renesas@ideasonboard.com>,\n Geert Uytterhoeven\t <geert+renesas@glider.be>,\n Magnus Damm <magnus.damm@gmail.com>, Biju Das\t <biju.das.jz@bp.renesas.com>,\n Marek Vasut <marex@denx.de>, Stefan Agner\t <stefan@agner.ch>,\n Jyri Sarha <jyri.sarha@iki.fi>, Michal Simek\t <michal.simek@amd.com>","Cc":"Hui Pu <Hui.Pu@gehealthcare.com>, Ian Ray <ian.ray@gehealthcare.com>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,\n\tasahi@lists.linux.dev, imx@lists.linux.dev,\n linux-arm-kernel@lists.infradead.org, \tlinux-mips@vger.kernel.org,\n linux-mediatek@lists.infradead.org, \tlinux-amlogic@lists.infradead.org,\n linux-arm-msm@vger.kernel.org, \tfreedreno@lists.freedesktop.org,\n linux-rockchip@lists.infradead.org, \tlinux-tegra@vger.kernel.org,\n linux-samsung-soc@vger.kernel.org, \tlinux-renesas-soc@vger.kernel.org","Date":"Thu, 23 Apr 2026 19:59:21 +0200","In-Reply-To":"\n <20260423-drm-bridge-connector-attach_encoder-v2-10-2ae6ca69b390@bootlin.com>","References":"\n\t<20260423-drm-bridge-connector-attach_encoder-v2-0-2ae6ca69b390@bootlin.com>\n\t <20260423-drm-bridge-connector-attach_encoder-v2-10-2ae6ca69b390@bootlin.com>","Autocrypt":"addr=paul@crapouillou.net; prefer-encrypt=mutual;\n keydata=mQENBF0KhcEBCADkfmrzdTOp/gFOMQX0QwKE2WgeCJiHPWkpEuPH81/HB2dpjPZNW03ZM\n LQfECbbaEkdbN4YnPfXgcc1uBe5mwOAPV1MBlaZcEt4M67iYQwSNrP7maPS3IaQJ18ES8JJ5Uf5Uz\n FZaUawgH+oipYGW+v31cX6L3k+dGsPRM0Pyo0sQt52fsopNPZ9iag0iY7dGNuKenaEqkYNjwEgTtN\n z8dt6s3hMpHIKZFL3OhAGi88wF/21isv0zkF4J0wlf9gYUTEEY3Eulx80PTVqGIcHZzfavlWIdzhe\n +rxHTDGVwseR2Y1WjgFGQ2F+vXetAB8NEeygXee+i9nY5qt9c07m8mzjABEBAAG0JFBhdWwgQ2VyY\n 3VlaWwgPHBhdWxAY3JhcG91aWxsb3UubmV0PokBTgQTAQoAOBYhBNdHYd8OeCBwpMuVxnPua9InSr\n 1BBQJdCoXBAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHPua9InSr1BgvIH/0kLyrI3V0f\n 33a6D3BJwc1grbygPVYGuC5l5eMnAI+rDmLR19E2yvibRpgUc87NmPEQPpbbtAZt8On/2WZoE5OIP\n dlId/AHNpdgAtGXo0ZX4LGeVPjxjdkbrKVHxbcdcnY+zzaFglpbVSvp76pxqgVg8PgxkAAeeJV+ET\n 4t0823Gz2HzCL/6JZhvKAEtHVulOWoBh368SYdolp1TSfORWmHzvQiCCCA+j0cMkYVGzIQzEQhX7U\n rf9N/nhU5/SGLFEi9DcBfXoGzhyQyLXflhJtKm3XGB1K/pPulbKaPcKAl6rIDWPuFpHkSbmZ9r4KF\n lBwgAhlGy6nqP7O3u7q23hRU=","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0"}}]