[{"id":3681587,"web_url":"http://patchwork.ozlabs.org/comment/3681587/","msgid":"<20260423-reformist-humpback-38a087567cb2@spud>","list_archive_url":null,"date":"2026-04-23T17:30:46","subject":"Re: [PATCH v5 1/2] dt-bindings: pwm: dwc: add optional reset","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Thu, Apr 23, 2026 at 04:37:31PM +0800, dongxuyang@eswincomputing.com wrote:\n> From: Xuyang Dong \n> \n> The DesignWare PWM includes separate reset signals dedicated to each clock\n> domain:\n> The presetn signal resets logic in pclk domain.\n> The timer_N_resetn signal resets logic in the timer_N_clk domain.\n> The resets are active-low.\n> \n> EIC7700 use DesignWare IP for PWM controllers. Add ESWIN EIC7700 support\n> in snps,dw-apb-timers-pwm2.yaml\n> \n> Signed-off-by: Xuyang Dong \n> ---\n> .../bindings/pwm/snps,dw-apb-timers-pwm2.yaml | 29 ++++++++++++++++---\n> 1 file changed, 25 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> index 7523a89a1773..d9685fdd72a7 100644\n> --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> @@ -20,12 +20,11 @@ description:\n> instead of having to encode the IP version number in the device tree\n> compatible.\n> \n> -allOf:\n> - - $ref: pwm.yaml#\n> -\n> properties:\n> compatible:\n> - const: snps,dw-apb-timers-pwm2\n> + enum:\n> + - snps,dw-apb-timers-pwm2\n> + - eswin,eic7700-pwm\n> \n> reg:\n> maxItems: 1\n> @@ -43,6 +42,12 @@ properties:\n> - const: bus\n> - const: timer\n> \n> + resets:\n> + minItems: 1\n> + items:\n> + - description: Interface bus reset\n> + - description: PWM timer logic reset\n> +\n> snps,pwm-number:\n> $ref: /schemas/types.yaml#/definitions/uint32\n> description: The number of PWM channels configured for this instance\n> @@ -54,6 +59,22 @@ required:\n> - clocks\n> - clock-names\n> \n> +allOf:\n> + - $ref: pwm.yaml#\n> +\n> + - if:\n> + properties:\n> + compatible:\n> + contains:\n> + const: eswin,eic7700-pwm\n> + then:\n\n> + properties:\n> + resets:\n> + items:\n> + - description: Interface bus reset\n\nThis doesn't do anything, I don't think.\nDrop it, and just keep the required.\n\npw-bot: changes-requested\n\nThanks,\nConor.\n\n> + required:\n> + - resets\n> +\n> additionalProperties: false\n> \n> examples:\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=M8bIPJCu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8680-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"M8bIPJCu\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1jmd1lYGz1yCv\n\tfor ; Fri, 24 Apr 2026 03:30:57 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id AF934300B3FE\n\tfor ; Thu, 23 Apr 2026 17:30:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AD79735F161;\n\tThu, 23 Apr 2026 17:30:52 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0AA1D6DB5;\n\tThu, 23 Apr 2026 17:30:52 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 48497C2BCAF;\n\tThu, 23 Apr 2026 17:30:49 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776965452; cv=none;\n b=cCjPSpm1BqmNrpP0M52xM1Vzp1bDkhwXdMey18RM1S4ebb3izmiZ7RpnBcXduNt5qLXSTJiBbzem1XVftTsKyF/YQaRxChi9gkrEYnTHzTjUaVNCHKrrwwSEfWc1EX6GSSNUUdAejgYOcEITdebo4ncwDLatuJWLmW1Dkjzos/4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776965452; c=relaxed/simple;\n\tbh=GTND1Ycvcov57U/LCP6zxwu5n+6TXmKmS7CxyVPvXW8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=oy14baHcjCdcj8Kn/+E4p6zP6jvp9vjx5vIuOal17D8wQ9xuYtAjTQinP5xadtKLPwccOQxTj9TE5TSctnHnfBgM7BSZe8OL1/l2uw0IOmXxIxUFeWHCgqzL2PHgiFBHMKrjHeBlRjieDEZDeJN4ItC2saL3V36n0dEj5eI4em0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=M8bIPJCu; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776965452;\n\tbh=GTND1Ycvcov57U/LCP6zxwu5n+6TXmKmS7CxyVPvXW8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M8bIPJCu4NO+rJckavr78vqTxV23Se6NSBzU1JZFMlHgshRVDRmU9jqMYwaE7Jb5o\n\t z8KhIFGWK8gBUyxr44pzM0mLUfXkLDEUOdGsUXZIqgDSNXciPu5/ZHve/OBMeuE7rf\n\t ZfhSdm4skqb+HMwMzxj1674F2morgEJFDwh/IdAnxa5uC9sd7tUypDNfJrRc+AdsH+\n\t o3JD7A5yCBSuSowC6ZralfQ9BIZaY8tu8vc8mrvnHKlA+GnBTqXazSf+bDKkOquUrD\n\t tm+EqOp9M2JJZqgv79qInO54l6g4BR24WS1WMwx+JN1l3h8wb6aARDlEXWaYNXqxQx\n\t qeAJp5LWcHv5w==","Date":"Thu, 23 Apr 2026 18:30:46 +0100","From":"Conor Dooley ","To":"dongxuyang@eswincomputing.com","Cc":"ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, ben-linux@fluff.org, ben.dooks@codethink.co.uk,\n\tp.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n\txuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: [PATCH v5 1/2] dt-bindings: pwm: dwc: add optional reset","Message-ID":"<20260423-reformist-humpback-38a087567cb2@spud>","References":"<20260423083644.1168-1-dongxuyang@eswincomputing.com>\n <20260423083731.1226-1-dongxuyang@eswincomputing.com>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"UfISgeyQ1QZtmGZk\"","Content-Disposition":"inline","In-Reply-To":"<20260423083731.1226-1-dongxuyang@eswincomputing.com>"}}]