[{"id":3681336,"web_url":"http://patchwork.ozlabs.org/comment/3681336/","msgid":"<20260423084744.GA649606@pevik>","list_archive_url":null,"date":"2026-04-23T08:47:44","subject":"Re: [LTP] [PATCH v1] ns-tools: Restore ns-icmpv4_sender","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Wei,\n\n> Commit 19c9b694c6b (\"ns-tools: Remove unused tools\") removed\n> ns-icmpv4_sender.c, assuming it was unused. However, it is still\n> required by broken_ip tests (e.g. broken_ip4-version, broken_ip4-ihl),\n> which were not removed.\n\n> Restore ns-icmpv4_sender.c and update Makefile, .gitignore and\n> 00_Descriptions.txt accordingly.\n\n> Fixes: 19c9b694c6b (\"ns-tools: Remove unused tools\")\n\nGood catch, thanks! Merged.\n\nKind regards,\nPetr","headers":{"Return-Path":"<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=tnURhN1f;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=Qq/i29Kj;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=tnURhN1f;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Qq/i29Kj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tnURhN1f;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=\"Qq/i29Kj\""],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1V9C1FJfz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 18:47:58 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id F29613E5376\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 10:47:55 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 099213E1B4F\n for <ltp@lists.linux.it>; Thu, 23 Apr 2026 10:47:52 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 4F07414004FA\n for <ltp@lists.linux.it>; Thu, 23 Apr 2026 10:47:51 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 4F92A6A7DE;\n Thu, 23 Apr 2026 08:47:50 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0ADF9593A3;\n Thu, 23 Apr 2026 08:47:49 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id fMp0ObXc6WkhBgAAD6G6ig\n (envelope-from <pvorel@suse.cz>); Thu, 23 Apr 2026 08:47:49 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776934070;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lLiGtgVmGwuknHIDdhMv5qrEAV4YhAPa0LVA09W4scc=;\n b=tnURhN1flMsGPUSbZd7IS38F7aBo+02CFMx0bYaNQygTAwCvWomqREqwuNr70X1STeip3X\n 3g1k+3f+hW5BJdgcdsyxy/iEdvjuynpz4NcZQRKC+Y8xgeN8uQ8Wv4Yw+au4/CbQhLpNNe\n /sKoCP1irqPUPomeiFcdvvkRe98bMLs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776934070;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lLiGtgVmGwuknHIDdhMv5qrEAV4YhAPa0LVA09W4scc=;\n b=Qq/i29Kj2579DhImME4TN51t3QllFrxl+fhlyxBJdfive2DCNP48JihYF+0X20YZA3ms5O\n 63Z2uNHgECzSGABA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776934070;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lLiGtgVmGwuknHIDdhMv5qrEAV4YhAPa0LVA09W4scc=;\n b=tnURhN1flMsGPUSbZd7IS38F7aBo+02CFMx0bYaNQygTAwCvWomqREqwuNr70X1STeip3X\n 3g1k+3f+hW5BJdgcdsyxy/iEdvjuynpz4NcZQRKC+Y8xgeN8uQ8Wv4Yw+au4/CbQhLpNNe\n /sKoCP1irqPUPomeiFcdvvkRe98bMLs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776934070;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lLiGtgVmGwuknHIDdhMv5qrEAV4YhAPa0LVA09W4scc=;\n b=Qq/i29Kj2579DhImME4TN51t3QllFrxl+fhlyxBJdfive2DCNP48JihYF+0X20YZA3ms5O\n 63Z2uNHgECzSGABA=="],"Date":"Thu, 23 Apr 2026 10:47:44 +0200","From":"Petr Vorel <pvorel@suse.cz>","To":"Wei Gao <wegao@suse.com>","Message-ID":"<20260423084744.GA649606@pevik>","References":"<20260423082003.28493-1-wegao@suse.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260423082003.28493-1-wegao@suse.com>","X-Spamd-Result":"default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[];\n HAS_REPLYTO(0.30)[pvorel@suse.cz];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; MISSING_XM_UA(0.00)[];\n REPLYTO_EQ_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:replyto];\n RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.cz:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.71","X-Spam-Level":"","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"4F92A6A7DE","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v1] ns-tools: Restore ns-icmpv4_sender","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project <ltp.lists.linux.it>","List-Unsubscribe":"<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>","List-Archive":"<http://lists.linux.it/pipermail/ltp/>","List-Post":"<mailto:ltp@lists.linux.it>","List-Help":"<mailto:ltp-request@lists.linux.it?subject=help>","List-Subscribe":"<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>","Reply-To":"Petr Vorel <pvorel@suse.cz>","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>"}}]