[{"id":3681368,"web_url":"http://patchwork.ozlabs.org/comment/3681368/","msgid":"<2483c24d-8674-422a-82a0-5c839f72e82d@kernel.org>","date":"2026-04-23T10:41:03","subject":"Re: [PATCH v5 v5 5/6] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","submitter":{"id":92023,"url":"http://patchwork.ozlabs.org/api/people/92023/","name":"David Hildenbrand (Arm)","email":"david@kernel.org"},"content":"On 4/23/26 09:19, Muchun Song wrote:\n> The memmap_init_zone_device() function only initializes the migratetype\n> of the first pageblock of a compound page. If the compound page size\n> exceeds pageblock_nr_pages (e.g., 1GB hugepages with 2MB pageblocks),\n> subsequent pageblocks in the compound page remain uninitialized.\n> \n> Move the migratetype initialization out of __init_zone_device_page()\n> and into a separate pageblock_migratetype_init_range() function. This\n> iterates over the entire PFN range of the memory, ensuring that all\n> pageblocks are correctly initialized.\n> \n> Also remove the stale confusing comment about MEMINIT_HOTPLUG above\n> the migratetype setting since it is an obsolete relic from commit\n> 966cf44f637e (\"mm: defer ZONE_DEVICE page initialization to the point\n> where we init pgmap\") and no longer makes sense here.\n> \n> Fixes: c4386bd8ee3a (\"mm/memremap: add ZONE_DEVICE support for compound pages\")\n> Signed-off-by: Muchun Song \n> Reviewed-by: Mike Rapoport (Microsoft) \n> Reviewed-by: Oscar Salvador \n> ---\n\nAcked-by: David Hildenbrand (Arm) ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R1nFHnWF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20003-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R1nFHnWF;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=david@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Xgs0fpdz1yCv\n\tfor ; Thu, 23 Apr 2026 20:41:13 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g1Xgr6klRz2yFQ;\n\tThu, 23 Apr 2026 20:41:12 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g1Xgr0hm6z2y8d\n\tfor ; Thu, 23 Apr 2026 20:41:12 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 8FEF243526;\n\tThu, 23 Apr 2026 10:41:10 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7380BC2BCAF;\n\tThu, 23 Apr 2026 10:41:05 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776940872;\n\tcv=none;\n b=E+okxG42lckVvl2dJKktrUwqytTfWmfEX7QO6oBsKra6k0arhK86DoWllGtMt88qOjXH/fDka/unnIMuc5se290ePCVDQpOtSzSF3Qn8qOTuEmqAnImNBoxMSL1Lz08JR9IaSD5SwP8EO0HiRyndxixV4a0uy9fbIrgNRY+5N21bbVQvFDFylwiN783zDhHq1PomnvSAlRBVUt4/wBMaUB8PWkOADxrzIoiQrvHj301CX83Yunl5GFAnra5DRQ/ARJ9bWJ7LWlSRQUSiYujkh2U+UAd8o2fFseDui5HXI3LjWAyUdSpohJiTAknhM2/WLt5t2frZ8anZBr1t/TOL5g==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776940872; c=relaxed/relaxed;\n\tbh=wrWFeAqappEvsHyHiM1opcwy4+CKVvlf8ke7UyR6S5A=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=nDHa9ycEEF+8HHpBKYeqTQNdvUAUkVO/gLvRpJthp3qYMvAqXimlO7cg+/gzmojxh5XdFVvfyS+hLh0oKYpMbmPp+26ILIRdL+57Ezkkdqi76YUTYWWdamA2frdBx0IuiBWA/599gw9i5vKoyP+mtTNjxP/2gSG/7m4BJeoYKhPNESzvK3/npOF+RaAizzQhv97HcDmEkzGkHubU7ZH3As7j9KTTfnAwknn7w82NsSPxxJdFZqu/2ou17889Ye8ge7mZwT5hl9qP1d+LdrN5dwMeNzFtwHKw9gI0b+zwPsMuMUOYPkAzH8BaWkgiHj0hJe5XwP4jCT2qbroDny3rPw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R1nFHnWF; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=david@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776940870;\n\tbh=Bi0JKllmc8EsuTFVoWIS7hebjAew4hxnm0zhHQlaF5Y=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=R1nFHnWFi6JiIUWL60faGZIP3/hDO1R12xZ/Ub/HIJvhp/ZLJJUndzXe2l7oIfkW8\n\t DvcvPzHs0epRiENLhVmIskMbigjGQb0fHjj9lOstZ7yjPNALz/upNHJr9ZHkAULqNZ\n\t oT3gpMlowjJJXYzmJ41Ij7ozC3fH+U7nMhgdQxOVfULIrMN7DwP1Mjltu+lcwNHyBv\n\t OSXsNgJp21t5QSzfuHps/eKej/w7rizHW6mVIRf8q2LD6ByrBNPov/KoAZrFRSlUgY\n\t 6IKlIulIuumqCaaQbH8WO525fzDWT08ktKSzpd0Xpngv/3HVXZgUVHp4ljy450u/eD\n\t /nht8rOBJcuTg==","Message-ID":"<2483c24d-8674-422a-82a0-5c839f72e82d@kernel.org>","Date":"Thu, 23 Apr 2026 12:41:03 +0200","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 v5 5/6] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","To":"Muchun Song ,\n Andrew Morton ,\n Muchun Song , Oscar Salvador ,\n Michael Ellerman ,\n Madhavan Srinivasan ","Cc":"Lorenzo Stoakes ,\n \"Liam R . Howlett\" ,\n Vlastimil Babka , Mike Rapoport ,\n Suren Baghdasaryan , Michal Hocko ,\n Nicholas Piggin , Christophe Leroy ,\n aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org,\n linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","References":"<20260423071911.1962859-1-songmuchun@bytedance.com>\n <20260423071911.1962859-6-songmuchun@bytedance.com>","From":"\"David Hildenbrand (Arm)\" ","Content-Language":"en-US","Autocrypt":"addr=david@kernel.org; keydata=\n xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ\n dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL\n QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp\n XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK\n Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9\n PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt\n WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc\n UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv\n jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb\n B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk\n ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik\n AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN\n 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD\n g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz\n ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x\n 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7\n /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4\n jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ\n DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R\n HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC\n 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7\n LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR\n 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt\n VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk\n /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy\n iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ\n 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21\n zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg\n azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY\n FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D\n sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO\n 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e\n EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts\n IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC\n 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV\n Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS\n sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx\n yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9\n 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg\n r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ\n 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ\n CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY\n qIws/H2t","In-Reply-To":"<20260423071911.1962859-6-songmuchun@bytedance.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]