[{"id":3681966,"web_url":"http://patchwork.ozlabs.org/comment/3681966/","msgid":"<c6a06641-c345-4e65-9fec-7f2d4367710a@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-24T10:45:23","subject":"Re: [PATCH v3 3/4] pinctrl: qcom: eliza: Split QUP lane mirror\n alternates","submitter":{"id":89450,"url":"http://patchwork.ozlabs.org/api/people/89450/","name":"Konrad Dybcio","email":"konrad.dybcio@oss.qualcomm.com"},"content":"On 4/23/26 6:43 AM, Alexander Koskovich wrote:\n> Several QUP lanes have MIRA/MIRB mirror routings which are collapsed\n> under a single function name (e.g. qup1_se6).\n> \n> This is an issue because it means there are multiple functions defined\n> for a given pin that share the same name:\n> \n> [42] = PINGROUP(42, qup1_se6, qup1_se2, qup1_se6...\n> \n> So when you select pin 42 and request function qup1_se6, it will select\n> the first instance of it in this group, which just happens to be\n> QUP1_SE6_L2, making the second instance (QUP1_SE6_L1_MIRA) effectively\n> unreachable.\n> \n> Split each of these lanes that has an alternative GPIO into their own\n> function so they can actually be selected, following the pattern seen\n> in pinctrl-sm8550.c.\n> \n> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>\n> ---\n\nReviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>\n\nKonrad","headers":{"Return-Path":"\n <linux-gpio+bounces-35476-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=OkjPmKeZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=GhJLAtlh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35476-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"OkjPmKeZ\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"GhJLAtlh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g28kQ6bLVz1yDD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 20:45:34 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 2F55F300232D\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 10:45:31 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 085D8391E49;\n\tFri, 24 Apr 2026 10:45:30 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A69F390CB8\n\tfor <linux-gpio@vger.kernel.org>; Fri, 24 Apr 2026 10:45:28 +0000 (UTC)","from pps.filterd (m0279863.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63OAfkb81959136\n\tfor <linux-gpio@vger.kernel.org>; Fri, 24 Apr 2026 10:45:28 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n [209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dr2nrh94p-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-gpio@vger.kernel.org>; Fri, 24 Apr 2026 10:45:27 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n af79cd13be357-8d59968444aso228071385a.3\n        for <linux-gpio@vger.kernel.org>;\n Fri, 24 Apr 2026 03:45:27 -0700 (PDT)","from [192.168.119.254] (078088045245.garwolin.vectranet.pl.\n [78.88.45.245])\n        by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-672c4d69708sm4772555a12.28.2026.04.24.03.45.24\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Fri, 24 Apr 2026 03:45:25 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777027529; cv=none;\n b=J35Pi1i92hEXJMwU9BZtXq8SSIV4aUDqBN8DXNdlgnTIFd+KGOFlJgOpHRefmgWoa73qauptKgnNusrCqeV8QhkgFQEBYGnlDK8IGzG8vFMSft6fDx3GEf55Kef8n0aNywTiUiKXocX7FTTLZlP1hhU9O4hG2fmMCPrPXvl5pkM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777027529; c=relaxed/simple;\n\tbh=OnzGzcqNY+ArADqz4SnmiPYbRzsG9LBv1JybDtwFAvs=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=RmstaUivHbDHnpkOB0+9JhGB9OdnQckYr8YsvLJQwY7ZkFqVRvzrHkWuz/J1UJAeXhMnfyY8wkLE+JGcnIQSZBrWvxMtfJItjQJL84p50GnhYQjy6YM+3O3QriCmZyOnWG8VD1fvacHOWCsw1UjLHym4yvGvpo5l7KPmZ3McJIA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=OkjPmKeZ;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=GhJLAtlh; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\t7eXC+Vvh1qI0aXe+adcCnpHa7mHRMAm7stQmrq1bj9Q=; b=OkjPmKeZh+bJGatv\n\tLPW5N9Q8BVgqBkX/Tbliwcl2mCwKO2ek52J3z3rJi3DuOAm2RQndSxQL50j2bCNK\n\tmOHkQrQhpvgU2cReoDtKuekLUJo85LlJz0BR04qYnK8W+CqK3ER6jitRDmM5CYa/\n\tjruCtDZpOxh2VVTt9NO4KOCpQKYyWEoplJm3JcndlEuWtvTqtyFmF9uSGZf8DFi0\n\trpninchS1CgTDCoQtdxTkNaYI9vgfoQAQvOsQKFJ8pOkcvwr4ygYpZFk54YTWc1V\n\tiUOptEVp2RV4enz0KkqLvqTnWMxQtdYIwUj6KNe+Pw0eobaJa1H+nEs7ySuBLVxZ\n\t03h5HA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=oss.qualcomm.com; s=google; t=1777027527; x=1777632327;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:in-reply-to:from:content-language\n         :references:cc:to:subject:user-agent:mime-version:date:message-id\n         :from:to:cc:subject:date:message-id:reply-to;\n        bh=7eXC+Vvh1qI0aXe+adcCnpHa7mHRMAm7stQmrq1bj9Q=;\n        b=GhJLAtlhhzS2WSt1QUG8PErNE2bUnp0lH/q2AVMCqmU1Jx0docu2FHw1qnFVt7PPvd\n         5BuxfUj+Ig+X8STbVcDXY1xP6UpKUGHNoLpt4x7O+2HOn0L1Cqt05XHXQEs2EU74/XzY\n         /e/xDE7hmJAeH6JfUrlXn8esttz7YL8sDwAgErCwhZRDGANobC0o+yYG8tjdj2xdYHv5\n         Y+yDrS5jlp/nSV4b4ya6R8lAlyb4OShvfBbfOEd5zoK8tB3c6XzCT7z04eTv4Q53yFjs\n         uHQmAgzI4cw4fuX1JCIP754Kn6nKNGU8q700C9Air++3j0ghnIc3189tGp2zrJT8Idk4\n         NdwA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777027527; x=1777632327;\n        h=content-transfer-encoding:in-reply-to:from:content-language\n         :references:cc:to:subject:user-agent:mime-version:date:message-id\n         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n         :reply-to;\n        bh=7eXC+Vvh1qI0aXe+adcCnpHa7mHRMAm7stQmrq1bj9Q=;\n        b=A9x2jgYR2CqDQWoNmKpjUrPnGb9L592UbITZ6hDvg1rQJC56U68jIqDFWLuL4YCElV\n         Rza1WNOxEma/lXGaave2gcj3WknQ2Xo+tB1af72Dnc6v1eGSELWpCz0kLhSLIAlcF91w\n         YFzBJPJWXp5mqPZZIjbOuVgAmuVyOd9XwtV+vVmyTJHv5fmDVEHyYZb9k7+OVLrtpHT9\n         f28Rpml4yrh4p6UL4tZfLY8dYKcHuZiSzLIK9Nwb37mfVMv0Pf+5Q6Xo0sCX3tt2F+HP\n         QzDX2iaB2D4TEKhGN1ioC25x1CvhtjDZ7X40G8jfAKCCb3GQffrgr4XpHprOG1hfZs+M\n         O9Rg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+rbJgfEPzknAyYh4yqdWVhlCnTfTRL5Vu6KLNZH36p2WXddkO0bbUGRam+h7o+5zRXobIA3iXjGIJp@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw0lskwWWeUswyKRDPV7krsS2aPaKoGFOnBxEXhDH08iNuffDCe\n\tV+W790eXqt/d6OWayk1Z6rPd5zTCXcjKcVHQGVaPIe0VQcqQttj0G0v69IVp6ZXWTaAmMH8b2MY\n\toObVPUz3deanpWtV7bFHXzBzzyFQ990CJoW0+fSoxnOviBAfE7OaxOLG69rsqg1w3","X-Gm-Gg":"AeBDiesZLoZ3MYdTaAkxA1+n5X7XxLIgypgGQbOCXOZCR6q7AAF11srizl+XNh8QQRM\n\tLyEqsvoLYJrHYehgLQysNlV6GsbmBHAhfMelkw2lJyVhb3KgVIEr6R3koYeU4hbNLP9SlH65U/W\n\tJv9pCmvs9dPcjXcNiOq7yUNySzmBrct+/NiAcJtIJB9QtrbkXo4Ew6yrMHzIGnNb3WS/G4iYRqN\n\terKqEcKcbF/mSaC2ej9WiSasEqlBP/kqHqR2Q2K5vHe6tyabuJRargXUZIwC+jsXAAhabsa2Qap\n\tT4IhPsxq5E2kl0b7MeBW8V+LhcZjNlpQT12gawiloEBE+Q+LKfcAbqU4YyBUVpZ5HOiakYN2u2E\n\ttINq5kzuyTlwLmcQgiHgu1z8izV3zs4CfG1lCaHPfaMWieM3i1eIBdaKlaL0dNgVPKaj/ZuPp0+\n\tACcbjgqUK7SDD/AQ==","X-Received":["by 2002:a05:620a:4114:b0:8f0:7516:da94 with SMTP id\n af79cd13be357-8f07516e2aamr868767785a.1.1777027526981;\n        Fri, 24 Apr 2026 03:45:26 -0700 (PDT)","by 2002:a05:620a:4114:b0:8f0:7516:da94 with SMTP id\n af79cd13be357-8f07516e2aamr868765485a.1.1777027526447;\n        Fri, 24 Apr 2026 03:45:26 -0700 (PDT)"],"Message-ID":"<c6a06641-c345-4e65-9fec-7f2d4367710a@oss.qualcomm.com>","Date":"Fri, 24 Apr 2026 12:45:23 +0200","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 3/4] pinctrl: qcom: eliza: Split QUP lane mirror\n alternates","To":"Alexander Koskovich <akoskovich@pm.me>,\n        Bjorn Andersson <andersson@kernel.org>,\n        Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,\n        Krzysztof Kozlowski <krzk+dt@kernel.org>,\n        Conor Dooley <conor+dt@kernel.org>,\n        Abel Vesa <abel.vesa@oss.qualcomm.com>","Cc":"linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,\n        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20260423-fix-eliza-pinctrl-v3-0-68b24893ae63@pm.me>\n <20260423-fix-eliza-pinctrl-v3-3-68b24893ae63@pm.me>","Content-Language":"en-US","From":"Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>","In-Reply-To":"<20260423-fix-eliza-pinctrl-v3-3-68b24893ae63@pm.me>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI0MDEwMSBTYWx0ZWRfXwiCu2pAhtXmz\n eHk+e/MNtYoI9t5llZjatgpQkgpEEVLTXsxzf4VgW4T+lyXK+iI1HlpiZArTA6Rf8wQmbA/shlv\n G3bYQI+nJ/CP6J9tUmUnGTLdek4KWnwqI0z5UlqBQL5B9pFkKBl4mkPzpB4JVsBLvewTtGLzdmp\n lBd13Wpr0nk9E5QNYW3iggLSBSl7nz3yoE48l2aia3DLrNFqBaN6serTh8agCOtCsXDoNwMm+mA\n pvlDsVMYlUIyEAqtOQh4bZUanXayqTqpDcbCALtTN7QiAfxZjyHbRsfsk/8Sk+EceEJCaSY0qsW\n 56sTQ9G2Sa2SwfjyZnhoWjzOxv8O358MYQ3G9B104dGbTI7Hkw2vqrwr632h+0iAc8QWjpQBjvR\n xn6CaM67DjrIaOax1zrnb4lgjOKizVJQa3Uxu1lrDx/6INck1Mq76DdbbwHqRKNZZjOXOpN2JyR\n Zq4u80FrBnG8qbCm5yA==","X-Authority-Analysis":"v=2.4 cv=UqpT8ewB c=1 sm=1 tr=0 ts=69eb49c7 cx=c_pps\n a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22\n a=EUspDBNiAAAA:8 a=j-nvzvvU1SLIUX5pO48A:9 a=QEXdDO2ut3YA:10\n a=IoWCM6iH3mJn3m4BftBB:22","X-Proofpoint-ORIG-GUID":"SptmSEaBo56aRZY6ioVoZEqkSAWTVx8J","X-Proofpoint-GUID":"SptmSEaBo56aRZY6ioVoZEqkSAWTVx8J","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 priorityscore=1501 clxscore=1015 bulkscore=0\n lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 spamscore=0\n malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604240101"}}]