[{"id":3681282,"web_url":"http://patchwork.ozlabs.org/comment/3681282/","msgid":"<CAFULd4Z6aYqcaCmKAk88SYoATz-fRfmzUPzMiZESYKOh5RvK4w@mail.gmail.com>","list_archive_url":null,"date":"2026-04-23T06:22:37","subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","submitter":{"id":808,"url":"http://patchwork.ozlabs.org/api/people/808/","name":"Uros Bizjak","email":"ubizjak@gmail.com"},"content":"On Thu, Apr 23, 2026 at 12:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:\n>\n> commit 5cf1b9a03ec5b617af8c50c1e9c0d223083fd7f2\n> Author: H.J. Lu <hjl.tools@gmail.com>\n> Date:   Fri Aug 19 11:50:41 2022 -0700\n>\n>     x86-64: Remove redundant TLS calls\n>\n> changed the x86_cse pass to also remove redundant TLS calls.  Remove the\n> SSE2 check in x86_cse::gate so that redundant TLS calls are removed when\n> SSE is disabled.\n>\n> gcc/\n>\n> PR target/124994\n> * config/i386/i386-features.cc (x86_cse::gate): Drop TARGET_SSE2.\n>\n> gcc/testsuite/\n>\n> PR target/124994\n> * gcc.target/i386/pr124994.c: New test.\n>\n> OK for master and GCC 16 branch?\n\nOK, needs RM's approval for the gcc-16 branch.\n\nThanks,\nUros.","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=QwJIVBtN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=QwJIVBtN","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.208.170"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1QyJ49mpz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 16:23:19 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 04C1D4BBC0CD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:23:17 +0000 (GMT)","from mail-lj1-f170.google.com (mail-lj1-f170.google.com\n [209.85.208.170])\n by sourceware.org (Postfix) with ESMTPS id 356BD4BBC0B2\n for <gcc-patches@gcc.gnu.org>; Thu, 23 Apr 2026 06:22:50 +0000 (GMT)","by mail-lj1-f170.google.com with SMTP id\n 38308e7fff4ca-38e7fc3c419so57338851fa.0\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 23:22:50 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 04C1D4BBC0CD","OpenDKIM Filter v2.11.0 sourceware.org 356BD4BBC0B2"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 356BD4BBC0B2","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 356BD4BBC0B2","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776925370; cv=pass;\n b=LNIh5vdRviQLQvZqyVsoxG1k9QlywcsXGMrR+bcEkkfeRx37VZQTuVOD9azq3SE7ryBM7Dbtv8SvyUgZPUYZ42QteTrso2AUC523Rj9qd3KACt5Mn/SQCURZx9mg42n3y3EcNpSc2frrvhOwAS9NjNlAkwS5qHMSHYMpHmz6C5U=","i=1; a=rsa-sha256; t=1776925369; cv=none;\n d=google.com; s=arc-20240605;\n b=c93teQ0tEbAZgVsf3wfMELcei/qLZKX6rxHnorjrSMj4TAGvPOmK3/nHREz9M4HB1M\n R3NImUVQOwnGIzfhZOIub3U+/KTVaszkGhQZ7T0/MT3Rs4kb0fvCb6Tk1aKWGIhN8I9w\n MUAilZ0rZ57s7/nJBI+mLSFxFGKWr9fQp/Nl6NRG+dRJvGPxZL0qaww/sYKiRAMPQKyV\n YgGqmVKEp0raIskGMlJU1bHYE32MqSbWFB+KEZPQv8dWjp+I+pvuvPV2Dc17A4+ymEvx\n ftVIgxmPwfXBbeNGSEAIOmdG1o5Fje2Uu/FiyL9c94YGWwQbeMNaPDhynGufMmorkOuM\n Tudg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776925370; c=relaxed/simple;\n bh=DJlpsMMpG7Q604a7rTQdpOasqRntZoy1RtN1cQ9HLus=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=cz4mYwbYOZoRPvTwop1v/ZeUsi4c8RgstM/wl56M63S6/01YP7wJALNWFb5706N7ujQbkjNr8gqLTJ/2WYS5jZgiebaJQ/3qNU/CU2Dw+u87QCHnYiZfXu3kQijzh7RvusG7GBifM4PMn9L59kxBLnlhvIbP9aIsAH4dzeb0Id8=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=7dG69poNwXfDyonF/gofLnT4Cygser6IC24KSfjnpis=;\n fh=xm5hFFkcwZTyXeId3zqVau7OknzlenR6YJdaND0PG1w=;\n b=K70letoHkK6wP1yF+MiALd72/rg0UFntDvfJqHWL1fxTygpWVvG/x/Fd5opCRKfZMM\n sxYgDaldw5v/ew8jr//6taJFd9IdkgKzP6upU+fAAwzqCA/nZkLF4/cHb0SQ1hbRtbqk\n PB3rctorngTLguGtT1FIexNnhCZjI2jeEy+janibZR/22wVQ/H2SJfT118R6z29ydH/g\n s9X9QLIGH2GiLZoRiuQ+5ili1BrMOm3Ca7kDySOHV3nF+BDudSYPZoPf9tb817kAkRwK\n E9c7DhBWXP+bMziQKGCFpNpEYRLQTxk55Kq7IV/sjwSne1G/UIPqxU19jKy0fEd+tO9P\n JPpg==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776925369; x=1777530169; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7dG69poNwXfDyonF/gofLnT4Cygser6IC24KSfjnpis=;\n b=QwJIVBtNZpYs+GTqHB35Pe/f+xErdcJoJHscUru6/539iFVGXOmeo+cVLekBEdbWjf\n ic2JjxcVhQN6sD8E3RBluuKkzDjaZ9PkMZYEv4PNCPITG74lNiitZXg+dOXzgj+uwNCG\n 1S8LCW6fjbXAFFxYX2qyjxUY02pWWw2CTP6iLESCAlVG8LbUeJeAS4DhKVCTwVMZYpsd\n z88M5qO3Dl3DkCaJbdkOK5H2r9VktHJJni3gXOBWu8mAq5dpL2bmBlWts7SgM9l0+kPK\n I6I+tlveXfucU0gmWXh+rT3v8b6ovJj1PkGQX0B3KEgSDtnmC4rjcTSuKftztkp6APkN\n WlnA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776925369; x=1777530169;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7dG69poNwXfDyonF/gofLnT4Cygser6IC24KSfjnpis=;\n b=KFYtXfGkM+1/13fhQtztD8+tJ/cdYQNzqp3rmOJdnYj6aBt2yIXyBJuP5neOF4/Cku\n RGCzEt/hjGeDKSsqasi/UurCY2+wsu1Li+qFjSH26JtWnVpkK2vvrzpQh208IqJjztge\n +Si5UqMvPfZ+5ba6mOf/n56SC3x0CXb9JYhtfq6PZh/u3zonNmwbN5Zg/yppIOnCyFrp\n AbBtcxhvoz8cSwcV3FSxIuQ6XIQ5dY7qQ400atYHuFoWKHzqpnrMTFDxMywyW1sqCeBm\n 0tCyAK29TZwZkdRi3maWeF0ZCkV9XozH5umiPx48fNqta2oRXm+6Um0TrXHVcc5fny9Z\n wqNg==","X-Gm-Message-State":"AOJu0YxjhYRfGsPHxlOwJf7ZNCUBNmooORoOwZNXA/icAV13yaVDasp4\n 3Dv77/UvT8ZAIWyV7xIeILu1AW+Niu1lR+sbuCCC1BH2D2MdKkiNdV/Aywz3YvTgzJJJjSW51o8\n 68NiRVMUBMiRY6qdMYKgTfZrHyyCr4xg=","X-Gm-Gg":"AeBDieviTmfH2BhT/Qh3lOXEu02aayeV0QMbGVoKXAVnm41lf+2NE1p6yqbNicl8eVC\n xRla6K7HnN90a2D7qX3dVFc5iuCfxdVghcIbMJTjQmtHSK5hEwlz98TYYu7tm+Y/1N71HXkB4CT\n HEnIr9vhaEmXC8Nkzn/7GQJ2GZV+rlGlA4qM0+zj/qvSxPgEXmDmLu7mtQNU8Ej2rnstuq1xUsm\n 2PTYULufoWH1mm/xaHuOZ6wqai8x86btoLmmjzJdadZRw0Dz7XxoQx73c1jmqRWGyszk0ghLxAk\n N6KKSWD+vcT6syZcGgk2MNCLnO+qUyiPK921jBzcTfJMFlebtAiZ9JJ81ex96/sHt/QgOagXWJl\n 8XAndRWbbclksypV5KXj/xW4lUJ8R2Q+I6qL5w9mAMxxJUg==","X-Received":"by 2002:a2e:a5c1:0:b0:38e:4810:4f36 with SMTP id\n 38308e7fff4ca-38ec7818f12mr77504931fa.9.1776925368402; Wed, 22 Apr 2026\n 23:22:48 -0700 (PDT)","MIME-Version":"1.0","References":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>","In-Reply-To":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>","From":"Uros Bizjak <ubizjak@gmail.com>","Date":"Thu, 23 Apr 2026 08:22:37 +0200","X-Gm-Features":"AQROBzBD4apFe5N1Mz6eF6bRjlzzXwWfMs64I_ZgK6ab7kWU9rynq1yR5ChHjO0","Message-ID":"\n <CAFULd4Z6aYqcaCmKAk88SYoATz-fRfmzUPzMiZESYKOh5RvK4w@mail.gmail.com>","Subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","To":"\"H.J. Lu\" <hjl.tools@gmail.com>","Cc":"GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>,\n Hongtao Liu <hongtao.liu@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3681288,"web_url":"http://patchwork.ozlabs.org/comment/3681288/","msgid":"<aem_-XK8Lkl4aOKF@tucnak>","list_archive_url":null,"date":"2026-04-23T06:45:13","subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Thu, Apr 23, 2026 at 08:22:37AM +0200, Uros Bizjak wrote:\n> On Thu, Apr 23, 2026 at 12:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:\n> >\n> > commit 5cf1b9a03ec5b617af8c50c1e9c0d223083fd7f2\n> > Author: H.J. Lu <hjl.tools@gmail.com>\n> > Date:   Fri Aug 19 11:50:41 2022 -0700\n> >\n> >     x86-64: Remove redundant TLS calls\n> >\n> > changed the x86_cse pass to also remove redundant TLS calls.  Remove the\n> > SSE2 check in x86_cse::gate so that redundant TLS calls are removed when\n> > SSE is disabled.\n> >\n> > gcc/\n> >\n> > PR target/124994\n> > * config/i386/i386-features.cc (x86_cse::gate): Drop TARGET_SSE2.\n> >\n> > gcc/testsuite/\n> >\n> > PR target/124994\n> > * gcc.target/i386/pr124994.c: New test.\n> >\n> > OK for master and GCC 16 branch?\n> \n> OK, needs RM's approval for the gcc-16 branch.\n\nTo me this doesn't look like a 16.1 blocker, not removing redundant TLS\ncalls is just a missed optimization.  Whether it is desirable for 16.2 is\nanother question, I guess this isn't a regression (were we removing\nredundant TLS calls in 15 even with -mno-sse?), so it would need an\nexception.\n\n\tJakub","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=h05sOM5M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=h05sOM5M","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1RSh4fCtz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 16:45:51 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 1A8824BBCDAB\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:45:49 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 8266E4BBC0F3\n for <gcc-patches@gcc.gnu.org>; Thu, 23 Apr 2026 06:45:21 +0000 (GMT)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-w-fGgJNLMsyG3s8lQWbcLA-1; Thu,\n 23 Apr 2026 02:45:19 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0A2E318004AD; Thu, 23 Apr 2026 06:45:18 +0000 (UTC)","from tucnak.zalov.cz (unknown [10.44.48.12])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 3D8C81800345; Thu, 23 Apr 2026 06:45:17 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 63N6jEe84109759\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Thu, 23 Apr 2026 08:45:14 +0200","(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 63N6jEpJ4109758;\n Thu, 23 Apr 2026 08:45:14 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 1A8824BBCDAB","OpenDKIM Filter v2.11.0 sourceware.org 8266E4BBC0F3"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 8266E4BBC0F3","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 8266E4BBC0F3","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776926721; cv=none;\n b=is3nrkOh3hla4TIxdcAwzTIAexcko1bQDoIqTtl9N9u6nhfAArTTpqQ8roseBUk9V4Xt4l6SmXiw3obCuCLlGf9bbKzcJb/LB3Fc9VZj1XSsN+HzD+pRI8I8kHjMiUYWmd8IaNaJdyzqGAIly0Fx7+kdmBdUmt/9y+yyVwCo0EQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776926721; c=relaxed/simple;\n bh=yRFrygW72XOBoLDdZsaabrs2j1BWQ77zQ5DwbHkdMhg=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=w6dzK89hlUSjBhdE+G8EzMdho756U174LOAuzQ5lQ0/Vykw6+RAWCFkAVeTPN9fnYSRWQC/p1n/JDtAt7gYI1yWf9ADR0P42knlj5DcWC6yLF0SR/s6Wu3JYWypQn0nuBlJquLNsHZscMpITnqq17TSAjS0KcRoba9MAlROsCgM=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776926721;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nRXI+q7YnHWtvwEF9c4majQL+VkweyhRNJMHhS+lcKE=;\n b=h05sOM5MyGHAUp9P9Swbez1wFktNkAW3u0oNk0ObV1xgGxWF30nG0Vmtmql9SGFNWEfjwF\n NKqv0kClOSrnKKIVWxo1M5u28mrebjRcAyekIYo90zz+TuVbf7t/UYP7I2cVOQwZThZ1Ll\n d0A92yszj/0XoQe6Z3Xq6aqFvAfMa+s=","X-MC-Unique":"w-fGgJNLMsyG3s8lQWbcLA-1","X-Mimecast-MFC-AGG-ID":"w-fGgJNLMsyG3s8lQWbcLA_1776926718","Date":"Thu, 23 Apr 2026 08:45:13 +0200","From":"Jakub Jelinek <jakub@redhat.com>","To":"Uros Bizjak <ubizjak@gmail.com>","Cc":"\"H.J. Lu\" <hjl.tools@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>,\n Hongtao Liu <hongtao.liu@intel.com>","Subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","Message-ID":"<aem_-XK8Lkl4aOKF@tucnak>","References":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>\n <CAFULd4Z6aYqcaCmKAk88SYoATz-fRfmzUPzMiZESYKOh5RvK4w@mail.gmail.com>","MIME-Version":"1.0","In-Reply-To":"\n <CAFULd4Z6aYqcaCmKAk88SYoATz-fRfmzUPzMiZESYKOh5RvK4w@mail.gmail.com>","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9dWp2VitRnk4ggBycdjoT4TdC0OOugEWV0whdBZJgNs_1776926718","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Reply-To":"Jakub Jelinek <jakub@redhat.com>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3681498,"web_url":"http://patchwork.ozlabs.org/comment/3681498/","msgid":"<ydd5x5hkb0c.fsf@CeBiTec.Uni-Bielefeld.DE>","list_archive_url":null,"date":"2026-04-23T14:27:15","subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","submitter":{"id":4362,"url":"http://patchwork.ozlabs.org/api/people/4362/","name":"Rainer Orth","email":"ro@CeBiTec.Uni-Bielefeld.DE"},"content":"Hi H.J.,\n\n> commit 5cf1b9a03ec5b617af8c50c1e9c0d223083fd7f2\n> Author: H.J. Lu <hjl.tools@gmail.com>\n> Date:   Fri Aug 19 11:50:41 2022 -0700\n>\n>     x86-64: Remove redundant TLS calls\n>\n> changed the x86_cse pass to also remove redundant TLS calls.  Remove the\n> SSE2 check in x86_cse::gate so that redundant TLS calls are removed when\n> SSE is disabled.\n\nI strongly suspect that this patch broke i686-pc-linux-gnu bootstrap:\n\nduring RTL pass: x86_cse\n/vol/gcc/src/hg/master/local/libgomp/target.c: In function 'gomp_map_vars.constprop':\n/vol/gcc/src/hg/master/local/libgomp/target.c:2155:1: internal compiler error: in as_a, at machmode.h:391\n 2155 | }\n      | ^\n0xb1055c5 internal_error(char const*, ...)\n\t/vol/gcc/src/hg/master/local/gcc/diagnostic-global-context.cc:787\n0xb112581 fancy_abort(char const*, int, char const*)\n\t/vol/gcc/src/hg/master/local/gcc/diagnostics/context.cc:1813\n0x8bcea23 scalar_mode as_a<scalar_mode>(machine_mode)\n\t/vol/gcc/src/hg/master/local/gcc/machmode.h:391\n0x9bc6ebe ix86_get_vector_cse_mode\n\t/vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:3609\n0x9bc9190 x86_cse\n\t/vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:4710\n0x9bc874c execute\n\t/vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:4326\n\n\tRainer","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=NSMA6r2V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=NSMA6r2V","sourceware.org; dmarc=none (p=none dis=none)\n header.from=CeBiTec.Uni-Bielefeld.DE","sourceware.org;\n spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de","server2.sourceware.org;\n arc=none smtp.remote-ip=129.70.160.84"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1djK45h0z1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 00:27:48 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 73FBB4BBF6FB\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 14:27:46 +0000 (GMT)","from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE\n [129.70.160.84])\n by sourceware.org (Postfix) with ESMTPS id 0368E4B88941\n for <gcc-patches@gcc.gnu.org>; Thu, 23 Apr 2026 14:27:16 +0000 (GMT)","from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1])\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 2544863F80;\n Thu, 23 Apr 2026 16:27:16 +0200 (CEST)","from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])\n by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new,\n port 10026)\n with ESMTP id juUTPEnB2kqz; Thu, 23 Apr 2026 16:27:15 +0200 (CEST)","from manam.CeBiTec.Uni-Bielefeld.DE (p508551ea.dip0.t-ipconnect.de\n [80.133.81.234]) (Authenticated sender: ro)\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 97BAE63DB5;\n Thu, 23 Apr 2026 16:27:15 +0200 (CEST)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 73FBB4BBF6FB","OpenDKIM Filter v2.11.0 sourceware.org 0368E4B88941"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 0368E4B88941","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 0368E4B88941","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776954437; cv=none;\n b=dQGlLn0HYbyOVQoYzo6dS8qwcU2+hmxru1Tl0g2mgS8crDnfHUvZU+TT7CaWCzSXbVkliMEJneeGzY/pNKJq+8Vtkk/W4pbz1/EvWtvm+U+FyTU9Fb/fiJTJS0d3b2jxC/VTq2+mPXxL12A8/ZX58kNlqcvM9ZcyQCQP8tB5ows=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776954437; c=relaxed/simple;\n bh=0pdGB73cz13ogjFh5YWUsCFhnWpbgQEwaxNfoJA7Gk4=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=awExAyCJlrDI3V97XzXxnIsa2bp2VR1gFdD5+5ct7HjrQNUkNxj7H5QtkNTm2NrDl9Jkt6V4984HY8EtOgBG6PooQgfFMWifLmM9XVVuPubDJO9DXt3sAdKjX9JLJmbPsexagWX5qeT50S8umBTSbocNekt56j4eLAJkgrYj+3k=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=\n cebitec.uni-bielefeld.de; h=content-type:content-type\n :mime-version:user-agent:message-id:date:date:references\n :in-reply-to:subject:subject:from:from:received:received; s=\n 20200306; t=1776954435; bh=0pdGB73cz13ogjFh5YWUsCFhnWpbgQEwaxNfo\n JA7Gk4=; b=NSMA6r2V/XkkJefwDv52aKkJqEnP52Mr3PPeloqeVGCqq/W2t3AOn\n tEHqfZKNqvVlPj+uzh0T/oiYOsRfvJDNLVJ2uA0r0hhhou6yBDeG0BXT+GPCJZGK\n OVlkB/ekYHik8ISXeAEOQKKFk76x+FNPGKFMHIXE47jYI1mJKHIukfQSnUzU+4YD\n kvwcmcMrkMYxTDGu02k6A8GQ+H2mlDDFN12lbi58c0kNcIrxT4TKI2hPs8P1vhLx\n 0D7v4gqu056tJwt8MHz/cC1EhoqrjPITA6QoKlBxX9mmf8OV60Fgo9AImszNYse+\n bYmxKC2rOQKbxw5vUos+c6p4AQtCIW/8g==","X-Virus-Scanned":"amavisd-new at cebitec.uni-bielefeld.de","From":"Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>","To":"\"H.J. Lu\" <hjl.tools@gmail.com>","Cc":"GCC Patches <gcc-patches@gcc.gnu.org>,  Jakub Jelinek\n <jakub@redhat.com>,  Uros Bizjak <ubizjak@gmail.com>,  Hongtao Liu\n <hongtao.liu@intel.com>","Subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","In-Reply-To":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>\n (H. J. Lu's message of \"Thu, 23 Apr 2026 06:55:26 +0800\")","References":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>","Date":"Thu, 23 Apr 2026 16:27:15 +0200","Message-ID":"<ydd5x5hkb0c.fsf@CeBiTec.Uni-Bielefeld.DE>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3681580,"web_url":"http://patchwork.ozlabs.org/comment/3681580/","msgid":"<yddjytxioot.fsf@CeBiTec.Uni-Bielefeld.DE>","list_archive_url":null,"date":"2026-04-23T17:14:42","subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","submitter":{"id":4362,"url":"http://patchwork.ozlabs.org/api/people/4362/","name":"Rainer Orth","email":"ro@CeBiTec.Uni-Bielefeld.DE"},"content":"Hi H.J.,\n\n>> commit 5cf1b9a03ec5b617af8c50c1e9c0d223083fd7f2\n>> Author: H.J. Lu <hjl.tools@gmail.com>\n>> Date:   Fri Aug 19 11:50:41 2022 -0700\n>>\n>>     x86-64: Remove redundant TLS calls\n>>\n>> changed the x86_cse pass to also remove redundant TLS calls.  Remove the\n>> SSE2 check in x86_cse::gate so that redundant TLS calls are removed when\n>> SSE is disabled.\n>\n> I strongly suspect that this patch broke i686-pc-linux-gnu bootstrap:\n>\n> during RTL pass: x86_cse\n> /vol/gcc/src/hg/master/local/libgomp/target.c: In function 'gomp_map_vars.constprop':\n> /vol/gcc/src/hg/master/local/libgomp/target.c:2155:1: internal compiler error: in as_a, at machmode.h:391\n>  2155 | }\n>       | ^\n> 0xb1055c5 internal_error(char const*, ...)\n> \t/vol/gcc/src/hg/master/local/gcc/diagnostic-global-context.cc:787\n> 0xb112581 fancy_abort(char const*, int, char const*)\n> \t/vol/gcc/src/hg/master/local/gcc/diagnostics/context.cc:1813\n> 0x8bcea23 scalar_mode as_a<scalar_mode>(machine_mode)\n> \t/vol/gcc/src/hg/master/local/gcc/machmode.h:391\n> 0x9bc6ebe ix86_get_vector_cse_mode\n> \t/vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:3609\n> 0x9bc9190 x86_cse\n> \t/vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:4710\n> 0x9bc874c execute\n> \t/vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:4326\n\nconfirmed: reverting the patch allows the bootstrap to succeed.\n\n\tRainer","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=CxQgULFb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=CxQgULFb","sourceware.org; dmarc=none (p=none dis=none)\n header.from=CeBiTec.Uni-Bielefeld.DE","sourceware.org;\n spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de","server2.sourceware.org;\n arc=none smtp.remote-ip=129.70.160.84"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1jQj0n32z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 03:15:23 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 8719A4BABF3C\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 17:15:20 +0000 (GMT)","from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE\n [129.70.160.84])\n by sourceware.org (Postfix) with ESMTPS id CE1B94B99F43\n for <gcc-patches@gcc.gnu.org>; Thu, 23 Apr 2026 17:14:44 +0000 (GMT)","from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1])\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0580E63FCE;\n Thu, 23 Apr 2026 19:14:44 +0200 (CEST)","from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])\n by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new,\n port 10026)\n with ESMTP id NhPAk9GCl9O3; Thu, 23 Apr 2026 19:14:43 +0200 (CEST)","from manam.CeBiTec.Uni-Bielefeld.DE (p508551ea.dip0.t-ipconnect.de\n [80.133.81.234]) (Authenticated sender: ro)\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 1768863FCD;\n Thu, 23 Apr 2026 19:14:43 +0200 (CEST)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 8719A4BABF3C","OpenDKIM Filter v2.11.0 sourceware.org CE1B94B99F43"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org CE1B94B99F43","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org CE1B94B99F43","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776964484; cv=none;\n b=JykkDceir/KV6ydtj1q69fCmTUFcpD6NyjGwHg+R8wM0IXo4bD7jPkbl/Xzhr0xEzFcqUoG+G3SA7frVV8dcC6dXb3VubWShmy+slmJ6XE+tCOTTFqCxTjdbiRv4dvb8sXSqX8ar7nsyDFXBYJvtYkH2eQJRoliRa7YZLGKNYjA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776964484; c=relaxed/simple;\n bh=P2+J+qsMfLZ/v3fHejgtNbiOcHU5wnpohW81/2JvK+E=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=lUIPYiFK02EMyG4DCQPuoKBLVoKVQDokCsxurS3O+mHbWZLaiXp9gnnO4kJaByaEaTzJyWCuiNgbYjxfmz0T7ZC/eXMul6ct/7ieh5dg90hUJQUfTk7DG80xeQ3tMYAo+3nMH3P6atp+P0vs5pwQULupKcC6cIHSF1MQpzVU0dg=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=\n cebitec.uni-bielefeld.de; h=content-type:content-type\n :mime-version:user-agent:message-id:date:date:references\n :in-reply-to:subject:subject:from:from:received:received; s=\n 20200306; t=1776964483; bh=P2+J+qsMfLZ/v3fHejgtNbiOcHU5wnpohW81/\n 2JvK+E=; b=CxQgULFb2H3AUooL5fJcJYuILzOaFM+xVB2z0MrB/ezw8hDKIrsrg\n JOm39YsQsiktFeH4Uche60jPCYvuPNgVeCqro61JSwBLcNkZN39Bja6ZVt5JUFaT\n 5wi6g6qS9spqOo8xl9e1/qNGA9aYqzA5+0GgXiDvL33e0Ce+WzINgPMZopMBvbGl\n cz1BA7Oi6+p9IJtnyoDqy7Ax2+rnX+q21yiKchon47gnS97+6nosUdgpbIRB2xA1\n WgdkvTuKVwBNxoqQVY6FWEWl7YfelcQ+6WnP/bwJE3ULvMA22vVSMQTkFldcpzly\n D3YpBBRkau6F/ge2e8NmfhpOyYtjTI+5g==","X-Virus-Scanned":"amavisd-new at cebitec.uni-bielefeld.de","From":"Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>","To":"\"H.J. Lu\" <hjl.tools@gmail.com>","Cc":"GCC Patches <gcc-patches@gcc.gnu.org>,  Jakub Jelinek\n <jakub@redhat.com>,  Uros Bizjak <ubizjak@gmail.com>,  Hongtao Liu\n <hongtao.liu@intel.com>","Subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","In-Reply-To":"<ydd5x5hkb0c.fsf@CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's message\n of \"Thu, 23 Apr 2026 16:27:15 +0200\")","References":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>\n <ydd5x5hkb0c.fsf@CeBiTec.Uni-Bielefeld.DE>","Date":"Thu, 23 Apr 2026 19:14:42 +0200","Message-ID":"<yddjytxioot.fsf@CeBiTec.Uni-Bielefeld.DE>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3681702,"web_url":"http://patchwork.ozlabs.org/comment/3681702/","msgid":"<CAMe9rOr=JJYoRkhnEL0aQvEAdoOEFSWLYkwdxpvnAjEGOYA7jw@mail.gmail.com>","list_archive_url":null,"date":"2026-04-23T22:36:37","subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Fri, Apr 24, 2026 at 1:14 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:\n>\n> Hi H.J.,\n>\n> >> commit 5cf1b9a03ec5b617af8c50c1e9c0d223083fd7f2\n> >> Author: H.J. Lu <hjl.tools@gmail.com>\n> >> Date:   Fri Aug 19 11:50:41 2022 -0700\n> >>\n> >>     x86-64: Remove redundant TLS calls\n> >>\n> >> changed the x86_cse pass to also remove redundant TLS calls.  Remove the\n> >> SSE2 check in x86_cse::gate so that redundant TLS calls are removed when\n> >> SSE is disabled.\n> >\n> > I strongly suspect that this patch broke i686-pc-linux-gnu bootstrap:\n> >\n> > during RTL pass: x86_cse\n> > /vol/gcc/src/hg/master/local/libgomp/target.c: In function 'gomp_map_vars.constprop':\n> > /vol/gcc/src/hg/master/local/libgomp/target.c:2155:1: internal compiler error: in as_a, at machmode.h:391\n> >  2155 | }\n> >       | ^\n> > 0xb1055c5 internal_error(char const*, ...)\n> >       /vol/gcc/src/hg/master/local/gcc/diagnostic-global-context.cc:787\n> > 0xb112581 fancy_abort(char const*, int, char const*)\n> >       /vol/gcc/src/hg/master/local/gcc/diagnostics/context.cc:1813\n> > 0x8bcea23 scalar_mode as_a<scalar_mode>(machine_mode)\n> >       /vol/gcc/src/hg/master/local/gcc/machmode.h:391\n> > 0x9bc6ebe ix86_get_vector_cse_mode\n> >       /vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:3609\n> > 0x9bc9190 x86_cse\n> >       /vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:4710\n> > 0x9bc874c execute\n> >       /vol/gcc/src/hg/master/local/gcc/config/i386/i386-features.cc:4326\n>\n> confirmed: reverting the patch allows the bootstrap to succeed.\n\nTesting this:\n\ndiff --git a/gcc/config/i386/i386-features.cc b/gcc/config/i386/i386-features.cc\nindex 0dd278a3ea6..da5a7c9ceda 100644\n--- a/gcc/config/i386/i386-features.cc\n+++ b/gcc/config/i386/i386-features.cc\n@@ -3759,7 +3759,13 @@ ix86_broadcast_inner (rtx op, machine_mode mode,\n     if (!rtx_equal_p (tmp, first))\n       return nullptr;\n   }\n-      *scalar_mode_p = GET_MODE (first);\n+      /* Use QImode, instead of E_VOIDmode, for\n+    (const_vector:V2QI [(const_int 0 [0]) repeated x2])\n+       */\n+      if (CONST_INT_P (first))\n+  *scalar_mode_p = GET_MODE_INNER (mode);\n+      else\n+  *scalar_mode_p = GET_MODE (first);\n       *insn_p = nullptr;\n       return first;\n     }","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PPs1GoBM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PPs1GoBM","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.214.178"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1rZd1MSGz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 08:37:43 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B7EA84B99F57\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 22:37:41 +0000 (GMT)","from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by sourceware.org (Postfix) with ESMTPS id B6E594B99F69\n for <gcc-patches@gcc.gnu.org>; Thu, 23 Apr 2026 22:37:15 +0000 (GMT)","by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-2b2503753efso73142735ad.0\n for <gcc-patches@gcc.gnu.org>; Thu, 23 Apr 2026 15:37:15 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B7EA84B99F57","OpenDKIM Filter v2.11.0 sourceware.org B6E594B99F69"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org B6E594B99F69","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org B6E594B99F69","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776983835; cv=pass;\n b=CDAWKF18XioIV3rbtXD/ugDxLRz7s24Gkt6unniwdiV33tifWnqVWiJz4cmPvf9qFXtL0Is+CoP3w0qFQmc5vXxMl6fsyaqjUYOG1dQupFhJa6kfbE3IocP1sxMfCpCoANAHqEOroGfiLrE3ps2jRsUPUKQ/PEL3S0e8G5+zAVA=","i=1; a=rsa-sha256; t=1776983834; cv=none;\n d=google.com; s=arc-20240605;\n b=cNN0X/pmW0hoAzqo6vwFYO2rKTXQih81jLQMxBT2WngQGnTN5WAAgdAJF1d+qolnk+\n IEEVQxHw2eRWi1VXDlnP1GsHQjJIIDzF/jgJ6woLKxvBuYrOt99ca3bFwIiwTVC8lqqM\n w4dP11dARP4mrZCEzaaR2aZos7Q9mCEdbMAspG1W64TzVX4Lr7ccHZaUqajNscDQull/\n BY7XBg+WnO7vOwAiWpb/7XRcj9F0OGHx38+IBfoYWEvjZVHdvoq0REfmT7S31xkVyv8p\n RdgC4KwZuAvf+0eYywqO0wc6CKerQvtBjFpMWYCklNMpOk8NgxQ6isUr0aDbcVTzrPQp\n QIig=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776983835; c=relaxed/simple;\n bh=JBH8XaiDMuxM8LRQAczWr2qkj/B5pFe5ulWb19OjMSk=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=P7uYprEMjOBrKxrsGzC27OB5BrebsIQaGM5HmZ0k2nV8fTxNi3IPOj8Ql7pW3UOXkXsOjxyktGqPOdI89vaTxGC//H758Q5rI4GwB/uENMYi+LYMq24gvN5fiuTEZT6H7xHSi/3GYTU/u4gQWg8F1GqIUPbjTIuP2rgt6619frM=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=NayVfzNotgNIGnrLIqZQnFsLI5A/tBskfz53JXVUoyQ=;\n fh=RdKu4wAGWwzccXQ/c5oVUFxyfWF6YW75G0JhPxG5XsE=;\n b=BaWDI1rTFy5YTM2G4HEmnH2RaZ8y9qSbJkkyh6+aWrzfRrXsmvaUBpo/LohfCHpYvB\n a+9R+MlmJvxpq3OXcMmyWuicXNC1VMLo/wuRFgYVsfF6J+ZR5wQkKTCQ+ecOS4xhk+Zl\n afCo1oJ2abI0JWohzJtXD88AITMqgAdOLtJT8yKVOjx1nE/JCwB1ZP8hFD3UftH6kfqr\n p4xcFJ60KRfkbEMjSv7EFCgfnYxehQPGZLodOvtfjnsNMbTpsMt0YrZ6B6RBQdWVhOEl\n zGq590U0bFRbLnUkDz3GJNyjsgBW5sew0Rbw0lEgEF6VE/dacv1h11f3padpUBc279z9\n ye9g==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776983834; x=1777588634; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NayVfzNotgNIGnrLIqZQnFsLI5A/tBskfz53JXVUoyQ=;\n b=PPs1GoBMIEZthcuAdHt8iYK5QSRj6cOJfuIPdNPz0GrsMmilzhjLYy4PlvEvnb/U2J\n 0XvRyy2mIPc7ypyQ+t+0QePf2ONP1GNscXU8s0G5XSj/9vC5Ztzk4JXnpCi/7v4qwEiA\n 6hpD2kb1HXiWMjozeVW653l4m9wiSnwfuNsqYCPxxiJZSwDOc6HwURVMPXXtBHGpefdF\n hahoLW1tXeHe+70jJD/c/Nm7460Y81DDmQWwipyKOKNK38MV+3oLp3Zncwr4cYFMbjb5\n Ownb6XW6vIZTbT1PJnM46e3sAC2K6jmhthszgGUwwXJZwfCCV2V0oQJ4NT82V1PigsJS\n Vq4Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776983834; x=1777588634;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=NayVfzNotgNIGnrLIqZQnFsLI5A/tBskfz53JXVUoyQ=;\n b=okCL1prbujC6X7cOSsyS3bTon9VJljwphfGmSnmiGXcCuWiuF5Fsq80iNDFjpcpZp+\n uAd/Anw2upcp/HybV8HtLNHaPUQ5g3eFQ5JbnDNFezcX6aBgU1feyiLaVUU0x+CVX0W1\n kS+so7mfaA25yuYl8DCKuS+VnLOK1JMCLlY7xvwOcsRXUx0MxHnH3wXK5YBsgvuXS9nm\n Evn5mG8tTv7SpCHVQcW2/f30588dQWMLqSBK7ahr3eb3+1KSlktUjc4mbFjct18SQgim\n or8V3OFodrR7tSree/7bRGqU47rK5tF9sEx4lwlIuY++CeQKxGYObdnyPrRPlLsTajUq\n eiZw==","X-Gm-Message-State":"AOJu0YxEHJ9p32uimXd4tTj1/T+AqDYdOEDE4vNFdGMRHnxqLeraIVER\n mNYaAqc3bxQWp/laVK2Q1dOQed8vFiXMeMX9r4rg8pcBDAFfuvJhoHk5CBR1/AKTqoUxXlZjHfV\n FknPdIy+k918UgyCIug9zYnVqKDmoCPo=","X-Gm-Gg":"AeBDiesN8niw6uPP2IQ1UQ0/6qBf7VwzQG56BOuUI8AEviku8gBhh1L2sZyAlcnKtQE\n ZhRN1+1TGk9bB5ePXAc1uDIXfIxhNucsYHSSg1DDKrYv0krOJXaeJRVCEemnJTSEXhCWFnjpqkc\n RyJKECVr6ZR5d6kNCtaaAS1KWHgsWx4++RdNen5AeW9u07If0XZkGm/yzlw6FSHYdwizyIFJOnR\n /jqWT+K3UW3qs68lR3NiZQBYm3IyNgi9n97/F71K/sZ72LcEZfplrcHZCG2gjozI4l4qh0X7Esq\n sp4bK252zVeu/BwObw==","X-Received":"by 2002:a17:902:ce0c:b0:2b7:88f9:9c3d with SMTP id\n d9443c01a7336-2b788f9a2bcmr148192895ad.12.1776983834529; Thu, 23 Apr 2026\n 15:37:14 -0700 (PDT)","MIME-Version":"1.0","References":"\n <CAMe9rOpFW-DLDJY1zZG+DhqE9VRgQcG-NdAniAjuS_XRPQvG3w@mail.gmail.com>\n <ydd5x5hkb0c.fsf@CeBiTec.Uni-Bielefeld.DE>\n <yddjytxioot.fsf@CeBiTec.Uni-Bielefeld.DE>","In-Reply-To":"<yddjytxioot.fsf@CeBiTec.Uni-Bielefeld.DE>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Fri, 24 Apr 2026 06:36:37 +0800","X-Gm-Features":"AQROBzBNg6TmLtArhcUw_yPy48jfkB1K_11QzpIFEO7s00ubV6lL7MI76Ljg5tE","Message-ID":"\n <CAMe9rOr=JJYoRkhnEL0aQvEAdoOEFSWLYkwdxpvnAjEGOYA7jw@mail.gmail.com>","Subject":"Re: [PATCH] x86: Don't check SSE2 in x86_cse::gate","To":"Rainer Orth <ro@cebitec.uni-bielefeld.de>","Cc":"GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>,\n Uros Bizjak <ubizjak@gmail.com>, Hongtao Liu <hongtao.liu@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]