[{"id":3681520,"web_url":"http://patchwork.ozlabs.org/comment/3681520/","msgid":"<9be648f1-b408-46c7-b56d-5324f5c4047f@redhat.com>","list_archive_url":null,"date":"2026-04-23T15:05:29","subject":"Re: [PATCH] c++/modules: stream PTRMEM_CST_LOCATION and\n TRAIT_EXPR_LOCATION","submitter":{"id":4337,"url":"http://patchwork.ozlabs.org/api/people/4337/","name":"Jason Merrill","email":"jason@redhat.com"},"content":"On 4/22/26 4:27 PM, Patrick Palka wrote:\n> Tested on x86_64-pc-linux-gnu, does this look OK for 17/16.2?\n\nOK.\n\n> -- >8 --\n> \n> gcc/cp/ChangeLog:\n> \n> \t* module.cc (trees_out::core_vals) :\n> \tStream PTRMEM_CST_LOCATION.\n> \t: Stream TRAIT_EXPR_LOCATION.\n> \t(trees_in::core_vals): As in trees_out::core_vals.\n> ---\n> gcc/cp/module.cc | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc\n> index 61e9e70936bd..9ab299f6e559 100644\n> --- a/gcc/cp/module.cc\n> +++ b/gcc/cp/module.cc\n> @@ -6872,6 +6872,8 @@ trees_out::core_vals (tree t)\n> \n> case PTRMEM_CST:\n> WT (((lang_tree_node *)t)->ptrmem.member);\n> + if (state)\n> +\tstate->write_location (*this, ((lang_tree_node *)t)->ptrmem.locus);\n> break;\n> \n> case STATIC_ASSERT:\n> @@ -6933,6 +6935,9 @@ trees_out::core_vals (tree t)\n> case TRAIT_EXPR:\n> WT (((lang_tree_node *)t)->trait_expression.type1);\n> WT (((lang_tree_node *)t)->trait_expression.type2);\n> + if (state)\n> +\tstate->write_location\n> +\t (*this, ((lang_tree_node *)t)->trait_expression.locus);\n> if (streaming_p ())\n> \tWU (((lang_tree_node *)t)->trait_expression.kind);\n> break;\n> @@ -7444,6 +7449,7 @@ trees_in::core_vals (tree t)\n> \n> case PTRMEM_CST:\n> RTU (((lang_tree_node *)t)->ptrmem.member);\n> + ((lang_tree_node *)t)->ptrmem.locus = state->read_location (*this);\n> break;\n> \n> case STATIC_ASSERT:\n> @@ -7493,6 +7499,8 @@ trees_in::core_vals (tree t)\n> case TRAIT_EXPR:\n> RT (((lang_tree_node *)t)->trait_expression.type1);\n> RT (((lang_tree_node *)t)->trait_expression.type2);\n> + ((lang_tree_node *)t)->trait_expression.locus\n> +\t= state->read_location (*this);\n> RUC (cp_trait_kind, ((lang_tree_node *)t)->trait_expression.kind);\n> break;\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WDHlbTkO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WDHlbTkO","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1fYb0pG2z1y2d\n\tfor ; Fri, 24 Apr 2026 01:06:09 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B59854B88945\n\tfor ; Thu, 23 Apr 2026 15:06:07 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 6D3D44B8A680\n for ; Thu, 23 Apr 2026 15:05:35 +0000 (GMT)","from mail-oo1-f69.google.com (mail-oo1-f69.google.com\n [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-626-tHS2O9rfM7SgECN7nKYNbQ-1; Thu, 23 Apr 2026 11:05:32 -0400","by mail-oo1-f69.google.com with SMTP id\n 006d021491bc7-6961cacdd3aso581809eaf.0\n for ; Thu, 23 Apr 2026 08:05:32 -0700 (PDT)","from [192.168.50.130]\n (130-44-146-247.s12789.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com.\n [130.44.146.247]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8eb428ca90bsm1204980385a.4.2026.04.23.08.05.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 08:05:30 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B59854B88945","OpenDKIM Filter v2.11.0 sourceware.org 6D3D44B8A680"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 6D3D44B8A680","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 6D3D44B8A680","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776956735; cv=none;\n b=ZtTp8tnqtjs9+HqlD/4dQ6tJZx9o6wNQy1MEs4tcBxJbI7UFDZMV/6gsfnJsJLVhf1ng1TDJh+6RYmIqrcP1DfKPyTyg2Y3ExxFVMGKZ+/8Ggl+ZF8/VWhRrJSfJTK4+BJOaeq9KHcJ495n+CDQRnvORCnIFkKCUmCkHmBPtuds=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776956735; c=relaxed/simple;\n bh=5RA171IjsXF9idAqO6MAqBbA4RNjxcg5zf69n0GyMWI=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=TLzPeEo1rFtKLHwnyEJBiOmOctJhk6y/fqiXy8CsgHm0h9O5kPe5V4vboLH8uQ5tfsCJ79ywz7a8txqqSyHbl+CiulGVtkGNnx4kEV/dGG4aEWMUufwy4excc4FhFqbftwnjJDVf40RuUaLiEfe++0jtYH7royfAZkdKjMXSN4A=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776956735;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ecD9xcwjUrk5hNGU+vwgPxlviLLwDg6LuQKmJNR7Y1w=;\n b=WDHlbTkO7hpROJ93O9EE0U08qBRVrCAR37VRtcwB8JA5JMIaW9irNX9irPU8D8/8vWZHct\n qOARF4uJvcvdzYS5OvJe1XA1AGq+uDBKUhegwc8obL0EQHN0v3/wWlHP+xyW5xzKbgTbUo\n 0Lp1AVySTUpxO1q/Tc3kOdOMxLVhKtc=","X-MC-Unique":"tHS2O9rfM7SgECN7nKYNbQ-1","X-Mimecast-MFC-AGG-ID":"tHS2O9rfM7SgECN7nKYNbQ_1776956732","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776956732; x=1777561532;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ecD9xcwjUrk5hNGU+vwgPxlviLLwDg6LuQKmJNR7Y1w=;\n b=IBQ7aSHvHcNgRljFzZoot1j7gnQPOQg2IWkarGysSsG80/vZx8T2vdCLnfRguV/NpN\n X38FR8BkF8b5p3rIuB+BZGzkV2jnhMfK09j3Nja0nSV6PE31xevC+E4zKg7/xGiG5tdo\n sFb6F41L0+ZxCy4wnyQ0VIJ1YzT4o+O+pGj+2uudoJ39RXv6PPngfeteHCHRzO0h2E7z\n ltTLx8bXFS2d0mtMPDBBYXAvGxw70AsFlAQEX5XGCxgoU3rMMv8mv2ResU72mhWKVlZY\n z3ifSCYxQh3F2IH9aXZJrHpB2WaR0vNvgMF+cJnbu1XGHiyfJHdfnpsuM7BSFESNQa7h\n A8Fw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9FWR6AyWzArBjPsrjGrbENuhBdy9ddeNs6cCQbEXqfu6r284jKXagsmz4OwKehOm5WawL4/mBZ+cs4bQ==@gcc.gnu.org","X-Gm-Message-State":"AOJu0Yxp6fiqHrEa2AsDCcvDUglCW5Wh0167ajpFjaBK4rfkynHBN/j2\n RnUunFFaEr/eScrnAhCtdfw58+VbM8CnKXYBFUnc+S1FhykiUN6qOOees4nfT/rxJRdTYXE22tu\n OVyrmlwI7qMPggeDSqGUh+B8C2r7mGZeaK8CwM7QW31JrPjm4KrAbL8Lk9uI=","X-Gm-Gg":"AeBDievnJgnV5yRZU8xz03w/x+WLT1XuMFP4PaeKneb1hWXom6y8XsxFgGKXlJwqILG\n nrQOdGiM54ABqWhkweLIu2cd2+5B9WHM4ut2jHGymxZZPRvjvJ0KhjfTBmTRFPj/yfqPXsEd4yF\n LAUROl9swYh3T8rIISp48Wy/Z2nF61JzShUdVP1Hw0W3RV7WRgOigdn6SYvmXD+igQhxFpWxhgm\n +4XLVoYcJ4hUiAU4sTtyHZbpcgvKPs6D7q2DIzo+XA1FxalemmmNQ+ra2w/NtrsWSwVYS46+xEu\n It0TmfmqQZzQkQhzR3twp3oa10byqveT50fpnduKBHmAJYudgGnQMN9zS+p3IYok6fPNuDNttjH\n Lxce3yabDOPpFGVXmF5E8U3am3dkmFDY1lidZnO7z74gsT44tkt9A+1oBGuGP31egtlqpXTjUEE\n JCyYVRYpww9oCi2uJS4pYNbNacx+bSyM653yz+qimvpQ==","X-Received":["by 2002:a05:6820:820:b0:67f:abdd:24b9 with SMTP id\n 006d021491bc7-69462ee251dmr14133443eaf.29.1776956732044;\n Thu, 23 Apr 2026 08:05:32 -0700 (PDT)","by 2002:a05:6820:820:b0:67f:abdd:24b9 with SMTP id\n 006d021491bc7-69462ee251dmr14133395eaf.29.1776956731487;\n Thu, 23 Apr 2026 08:05:31 -0700 (PDT)"],"Message-ID":"<9be648f1-b408-46c7-b56d-5324f5c4047f@redhat.com>","Date":"Thu, 23 Apr 2026 11:05:29 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] c++/modules: stream PTRMEM_CST_LOCATION and\n TRAIT_EXPR_LOCATION","To":"Patrick Palka , gcc-patches@gcc.gnu.org","References":"<20260422202741.1000191-1-ppalka@redhat.com>","From":"Jason Merrill ","In-Reply-To":"<20260422202741.1000191-1-ppalka@redhat.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"5P91g00_1-NFRrhnIY3xmWDPTBSiuIXfqvKgjSYFfqg_1776956732","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]