[{"id":3681513,"web_url":"http://patchwork.ozlabs.org/comment/3681513/","msgid":"<6195d22f-beeb-4c8a-ab8e-b9b34f48efcb@redhat.com>","list_archive_url":null,"date":"2026-04-23T14:55:18","subject":"Re: [ovs-dev] [PATCH ovn v3] expr: Fix an old copy/paste error.","submitter":{"id":76591,"url":"http://patchwork.ozlabs.org/api/people/76591/","name":"Dumitru Ceara","email":"dceara@redhat.com"},"content":"On 4/22/26 9:34 PM, Dmitry Mityugov wrote:\n> Without this fix, expression\n> \n> a_type < b_type ? -1 : a_type > b_type\n> \n> always evaluates to 0.\n> \n> Originally discovered with cppcheck.\n> \n> Signed-off-by: Dmitry Mityugov \n> ---\n\nHi Dmitry,\n\nThanks for the fix! Applied to main and all stable branches down to 24.03.\n\nRegards,\nDumitru","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Def3mpro;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Def3mpro","smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=Def3mpro"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1fKS0Sy0z1yD5\n\tfor ; Fri, 24 Apr 2026 00:55:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 61AF260ED4;\n\tThu, 23 Apr 2026 14:55:38 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id GIk1BdWwjhL7; Thu, 23 Apr 2026 14:55:34 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 0E53360ECF;\n\tThu, 23 Apr 2026 14:55:34 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id E1329C058E;\n\tThu, 23 Apr 2026 14:55:33 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id DD5FDC058D\n for ; Thu, 23 Apr 2026 14:55:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id CF83C4078D\n for ; Thu, 23 Apr 2026 14:55:32 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id W9Fe9IixUag6 for ;\n Thu, 23 Apr 2026 14:55:28 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 6B87340796\n for ; Thu, 23 Apr 2026 14:55:28 +0000 (UTC)","from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-661-fYOK_P1ZO1mqSwT7fqVB_g-1; Thu, 23 Apr 2026 10:55:25 -0400","by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-358df8fbd1cso9149346a91.0\n for ; Thu, 23 Apr 2026 07:55:25 -0700 (PDT)","from ?IPV6:2001:1c05:1417:d800:d1ef:9817:2a26:625d?\n (2001-1c05-1417-d800-d1ef-9817-2a26-625d.cable.dynamic.v6.ziggo.nl.\n [2001:1c05:1417:d800:d1ef:9817:2a26:625d])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3613fb4b4b5sm11036297a91.3.2026.04.23.07.55.21\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 07:55:23 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0E53360ECF","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6B87340796"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=dceara@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 6B87340796","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776956127;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=CU+3fc5FZE/ltDy99IUOJtWyZD9wLOt6a7Psi0jO2tc=;\n b=Def3mproEHP+U5SjDupb5I4HVT9wAx71x0DIWR9/SLIH5vE34EZPgaiMenpWdGs3UXVX6t\n Oz4bmfuITUUjAuyyTG5HwF0V6feOzritY7WnuAO8ZwR+2rWY3d6D8qiorhC2HapRqgUfYy\n k8UD/QzJem0OwMxbssSDttgljpWSvok=","X-MC-Unique":"fYOK_P1ZO1mqSwT7fqVB_g-1","X-Mimecast-MFC-AGG-ID":"fYOK_P1ZO1mqSwT7fqVB_g_1776956125","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776956125; x=1777560925;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=CU+3fc5FZE/ltDy99IUOJtWyZD9wLOt6a7Psi0jO2tc=;\n b=KmWOIC9hFftzt4qkiW9h+8F0o+D82a6p61zFx/S2FA/6gubN3GlUo92LoREO948yIS\n dq7RukZOgTtz2/opxXUwyjZp/1RYZXWqWfD7XHJnpUvYxHiRuWhYRC7UjJQ19DEeJtH2\n pTxbjuPRYum4qo7oI8gI3PVwi4PgtBdvgsAI2yQ+tWkAOGYXyiwbVNkCcHKt51m0VLke\n p+Cf/BSaGrtzEAKP6DJTYo+Hy60MIiHCP+Q5QfTvWY0r7uukzJl8LcZKSCKJUPoDrIh1\n H3hhirOZ8Sv/95neaP5lMeQwPjx7K1t0yuCP0vdod+7FeK0mLij6GtCnVTC9mwiAe4Qm\n Z5qA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Z2KcoaX/SbtqngnlRYxewFeeRqAZA3OWz/trRAduisx9YGy/rmD6+nLGRPOaJPGV3nCOChk6p@openvswitch.org","X-Gm-Message-State":"AOJu0YzcMfNiCTpvaFOOR/XqHJ2NPKEJUe1jS9LP3aFoVgjKKbMmyi83\n 4y9ScsFD96ni/mymGI2/JyajK8iNbGX0kxy2OpdbGwhQAijZMrne15x5D3cstjncYvMpmzs9pR6\n SLj1k5XvVwv2RHsrBGQAksY2X62uEUFTelhW33Tp3/H/l1RUrd/wNV5ExIUs=","X-Gm-Gg":"AeBDiesc07PVMdpwunrPK0kZoKOuZ06SrsthNaKkRlFvqrPHP/ZOYgR2jZ6Oho+LRNQ\n 9V5HcnlvZFoZ5c1iXa+4Q3CmYSqX5MwCUQ2WZXuZw5o1Mdt+B/cCAV3Vit6EVXp1GB7pogn+V+R\n 0xmzn8HjozdYILwjbVMD8X80tsUUbBCWdxuS9oJY1o6kvccGgzKoq92yJ64V/azo4dG9/zUd37j\n 5QauHAZnUjOPCdTw4EamrolVRhVLy6nMH8T9g+WXQZoV42gat4/e3gPgxy9GSUdYaRrw/qFJfJK\n hRQ3smj/Bn6QJMkRVMN3sYYKqh0xRg4I1HlrIf8G8Y6NFwOX4eI/MJltTTcmD50PvLDod6RNhCh\n ak8ExNwRQWgnstca+4/lNCNdjU63/v/t9VJ3fIOHEOue/bR9fI9+QoO2dYeH9+lqhsOu20Jq4jj\n rQJ/z/zzen/p3lpKvlfTue9B1JOASI8s2lscHbucEnGLePtt1wMLhLizCkj6QnGQy9SsjQCc/vR\n 79iNzse2Fc=","X-Received":["by 2002:a17:90b:53c3:b0:35d:a38a:a117 with SMTP id\n 98e67ed59e1d1-361404745f7mr28844517a91.15.1776956124477;\n Thu, 23 Apr 2026 07:55:24 -0700 (PDT)","by 2002:a17:90b:53c3:b0:35d:a38a:a117 with SMTP id\n 98e67ed59e1d1-361404745f7mr28844487a91.15.1776956123944;\n Thu, 23 Apr 2026 07:55:23 -0700 (PDT)"],"Message-ID":"<6195d22f-beeb-4c8a-ab8e-b9b34f48efcb@redhat.com>","Date":"Thu, 23 Apr 2026 16:55:18 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Dmitry Mityugov , ovs-dev@openvswitch.org","References":"<20260422193621.707020-1-dmitry.mityugov@gmail.com>","In-Reply-To":"<20260422193621.707020-1-dmitry.mityugov@gmail.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Vg_JvByQdrqYv9zNVsHznOueb8LBKnTMwpWWvFAWw9I_1776956125","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Subject":"Re: [ovs-dev] [PATCH ovn v3] expr: Fix an old copy/paste error.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Dumitru Ceara via dev ","Reply-To":"Dumitru Ceara ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]