[{"id":3680687,"web_url":"http://patchwork.ozlabs.org/comment/3680687/","msgid":"<48d4b6e1-b150-42cb-9949-d99a08fcdbcf@linaro.org>","list_archive_url":null,"date":"2026-04-22T16:26:33","subject":"Re: [PATCH v3 1/4] arm: mach-meson: provide reset_cpu only when\n SYSRESET is disabled","submitter":{"id":84903,"url":"http://patchwork.ozlabs.org/api/people/84903/","name":"Neil Armstrong","email":"neil.armstrong@linaro.org"},"content":"On 4/22/26 17:43, Ferass El Hafidi wrote:\n> This is in preparation of enabling SYSRESET across all Amlogic boards by\n> default. SYSRESET brings its own reset_cpu implementation which will\n> conflict with the one defined in board-common.c.\n> SPL however will not have SYSRESET enabled (due to overhead in the final\n> image, as we have very little space to work with), and thus will still\n> need that reset_cpu to be defined. Furthermore, some boards do not enable\n> PSCI support in U-Boot, so they may still need this implementation.\n> Guard reset_cpu inside #ifdef to only compile it in when SYSRESET is not\n> enabled.\n> \n> Signed-off-by: Ferass El Hafidi \n> ---\n> arch/arm/mach-meson/board-common.c | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/arch/arm/mach-meson/board-common.c b/arch/arm/mach-meson/board-common.c\n> index a5afc2d75c0..c34b81e5e78 100644\n> --- a/arch/arm/mach-meson/board-common.c\n> +++ b/arch/arm/mach-meson/board-common.c\n> @@ -155,16 +155,14 @@ int board_late_init(void)\n> \treturn meson_board_late_init();\n> }\n> \n> +#if defined(CONFIG_XPL) || !CONFIG_IS_ENABLED(SYSRESET)\n> void reset_cpu(void)\n> {\n> -#if CONFIG_SPL_BUILD\n> \t/*\n> \t * We do not have BL31 running yet, so no PSCI.\n> \t * Instead, let the watchdog reset the board.\n> \t */\n> \tfor (;;)\n> \t\t;\n> -#else\n> -\tpsci_system_reset();\n> -#endif\n> }\n> +#endif\n> \n\nReviewed-by: Neil Armstrong \n\nThanks,\nNeil","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=D4qaAxno;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"D4qaAxno\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=neil.armstrong@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14P33YPrz1yD5\n\tfor ; Thu, 23 Apr 2026 02:26:47 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 94855842EF;\n\tWed, 22 Apr 2026 18:26:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 46487842BF; Wed, 22 Apr 2026 18:26:38 +0200 (CEST)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n [IPv6:2a00:1450:4864:20::32f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7B09484262\n for ; Wed, 22 Apr 2026 18:26:35 +0200 (CEST)","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488d2079582so66728645e9.2\n for ; Wed, 22 Apr 2026 09:26:35 -0700 (PDT)","from ?IPV6:2a01:e0a:106d:1080:7d92:9cde:4eb2:46d7?\n ([2a01:e0a:106d:1080:7d92:9cde:4eb2:46d7])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a5d27d6casm4330665e9.27.2026.04.22.09.26.34\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 09:26:34 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776875195; x=1777479995; darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to; bh=cuCeYogGpkN/LhhedCGAUq7c/dseD6cXD/qn9VdqF2U=;\n b=D4qaAxnoYqiAH004s/yR2r8KFGqksmAy9P5cgonV1sI5NCx3IcNxGNg0UE+45JUF9A\n ZNOAWGuVg89mAZArNkt/q6Cx4QTrOYwe7H/2b97YeY0VDxt6KTZsYdjtMXEzgDDNayCe\n mOyzxVLgQvY3yWWPsQXVixLCxajE9Z9FSV2ElxYdH96XMcPD3P7noz/rbjq4WutPt/b0\n WjaBJsEYrcIO9FKSYap63+HkiFOYuhqh6u7Zt32yMvikh0ZAbKFTqzzTWtaaMJ7cpCxY\n aVt2jb76ZccjJ+B7M4GQ+P6gn+E/hNWMRpiMFg6EiRnB2+a/LECr4HdkCsreU+Ztko9g\n l0sw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776875195; x=1777479995;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=cuCeYogGpkN/LhhedCGAUq7c/dseD6cXD/qn9VdqF2U=;\n b=l6hqZi6gSfOcQPH0qAAE5ZrEmp/w2aM8CoPMc4C69Ds3/xgfj9BfVR6NFl13qYvYzq\n 6TJ9q0Wv+5av4VpsOfdPGO+mIgQsVl0gpTbrajapx1u8zMxL4lAFDNfdjH65EyzJ4Ggo\n NdlvAPCkKxHdySmwDiGM8y3SH0fO3B+iqKfEvz9Zy8Fi6PAicIRvdZlHPvJONi1q/ROQ\n H4+UNpxVA6QL+SQ0YFigA/OhI6ve+gFAYHSwI3niiHNq2R/uDBM0PMCTHrZJ42Bafo6c\n LG8oiOPTxx7oAg5U+nUvhBhJJdTb8vW8MLcclBa8gBvHMEB1rDHQvWPAIM5sBQryiOTH\n ZTEg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/UoP65C5rg2dr+QL9FkA+yUlt/y83xu40YWTIgRQbaBob2RZ7NOJpgK2MLpF9Idxx9R11nChg=@lists.denx.de","X-Gm-Message-State":"AOJu0YzSuF4mPYUpaVhnaW1RtYKkmv9Q93Jy4mUzMz/QXPhu88etw1e7\n QKohRsQgCcCs1f04Rvbh1UUIpTWmiL0xqr/XotqTkuAGG/K71LUtIBtBFg5o3d0tM4s=","X-Gm-Gg":"AeBDieu87crjx6Ad+SaS3PTE2NmbTKNkN6lG0Wg2BxVMunvCb3JrA5AwTMS/foxN6Cd\n CRfVNAFpFN57rOOvrMYo/gAcWnUXf3UJjjsWaHU2VHTnMdXGjIuCnrz8VgHk9IeZbtBZaqyhAIB\n Ah8AsAEahmomLqo2G8xETopWO9tLky9B7YVhR7aYT7jjGUS3AceihqVaXaBAYwxNEyNtTgdiyxI\n yfUcsLbzZQrkPdyEMGReZTYWbeduX+PddQ3c8x/YEdnCJrjFxXiKCZvjeT2KYT6aAFnj+lxJK3Z\n 3VzYY43WYh/WMAMVQ7JjpA3MWV5nvLmlhIbS2bNUeVJVgmoFr+KzzH4SpbJZSWCRdOFQ7qPPQaE\n 6uR+/5hsIe+BUXNkcvx0Hn+iALxYwTPqxqhdHvF1FV+pTVWz9356WUuvL4oOplJYGrVpdmJ8iX+\n ajgDxIcg0vVi9O/2gBa1KPFsgwz0VNNkjQLuDYj2ShaAv30pfpULYtv11wMTznkAQtLna37K7PR\n B4tBSYGKjZ6jRz0WQ==","X-Received":"by 2002:a05:600c:444a:b0:487:1520:d107 with SMTP id\n 5b1f17b1804b1-488fb793580mr307763075e9.31.1776875194750;\n Wed, 22 Apr 2026 09:26:34 -0700 (PDT)","Message-ID":"<48d4b6e1-b150-42cb-9949-d99a08fcdbcf@linaro.org>","Date":"Wed, 22 Apr 2026 18:26:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Neil Armstrong ","Subject":"Re: [PATCH v3 1/4] arm: mach-meson: provide reset_cpu only when\n SYSRESET is disabled","To":"Ferass El Hafidi ,\n u-boot-amlogic@groups.io, u-boot@lists.denx.de","Cc":"Tom Rini ,\n Evgeny Bachinin ,\n Marek Vasut ","References":"\n <20260422-b4-amlogic-sysreset-capsules-v3-0-07b5ccc8f552@postmarketos.org>\n <20260422-b4-amlogic-sysreset-capsules-v3-1-07b5ccc8f552@postmarketos.org>","Content-Language":"en-US, fr","Autocrypt":"addr=neil.armstrong@linaro.org; keydata=\n xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP\n GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4\n BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9\n qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik\n 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB\n AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA\n OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk\n Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04\n YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ\n GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw\n UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa\n GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r\n yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp\n QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+\n SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY\n 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM\n Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX\n oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn\n M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3\n 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS\n KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy\n 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT\n QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g","Organization":"Linaro","In-Reply-To":"\n <20260422-b4-amlogic-sysreset-capsules-v3-1-07b5ccc8f552@postmarketos.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Neil Armstrong ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]