[{"id":3680654,"web_url":"http://patchwork.ozlabs.org/comment/3680654/","msgid":"<20260422143114.GD2707369@p1gen4-pw042f0m>","list_archive_url":null,"date":"2026-04-22T14:31:14","subject":"Re: [PATCH v3 3/3] s390/pci: Fix circular/recursive deadlocks in\n PCI-bus and -device release","submitter":{"id":91674,"url":"http://patchwork.ozlabs.org/api/people/91674/","name":"Benjamin Block","email":"bblock@linux.ibm.com"},"content":"On Wed, Apr 22, 2026 at 04:22:13PM +0200, Benjamin Block wrote:\n> When removing PCI device or PCI bus objects there are a couple of\n> call-chains where it is possible that the kernel runs into a circular\n> deadlock involving the central `pci_rescan_remove_lock`.\n> \n--8<--\n> \n> Fixes: 05bc1be6db4b2 (\"s390/pci: create zPCI bus\")\n> Fixes: ab909509850b2 (\"PCI: s390: Fix use-after-free of PCI resources with per-function hotplug\")\n> Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>\n> Tested-by: Niklas Schnelle <schnelle@linux.ibm.com>\n> Signed-off-by: Benjamin Block <bblock@linux.ibm.com>\n> Reference-ID: JUP1193979\n\nAh, damn. This `Reference-ID` wasn't meant to be in the \"final\" email. Sorry.\nI'll re-send without it.","headers":{"Return-Path":"\n <linux-pci+bounces-52978-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=ZHPnn/l4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52978-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"ZHPnn/l4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g11qx4mM1z1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 00:31:25 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 124A230073E8\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 14:31:23 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0504B203710;\n\tWed, 22 Apr 2026 14:31:22 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C56C528A1E6;\n\tWed, 22 Apr 2026 14:31:20 +0000 (UTC)","from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63MDVnr21018719;\n\tWed, 22 Apr 2026 14:31:20 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dphfrbbpd-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 22 Apr 2026 14:31:19 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63MEKIGd003165;\n\tWed, 22 Apr 2026 14:31:18 GMT","from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dpjkxtk65-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 22 Apr 2026 14:31:18 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n\tby smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63MEVEBU52691428\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tWed, 22 Apr 2026 14:31:15 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id DC9362004D;\n\tWed, 22 Apr 2026 14:31:14 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C91F92004B;\n\tWed, 22 Apr 2026 14:31:14 +0000 (GMT)","from p1gen4-pw042f0m (unknown [9.52.223.163])\n\tby smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS;\n\tWed, 22 Apr 2026 14:31:14 +0000 (GMT)","from bblock by p1gen4-pw042f0m with local (Exim 4.99.1)\n\t(envelope-from <bblock@linux.ibm.com>)\n\tid 1wFYbi-0000000Fz5d-2Fng;\n\tWed, 22 Apr 2026 16:31:14 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776868281; cv=none;\n b=Vdgk+vUGB93yRr80EUMeZOHrkihJ3YVzwapT0SCCctBJ6N3h5WXDEr06817BHlneNZn8jdyAhJi+ublrOY/fKkDQnC7lzqbGkvt5tW5jNj5pvjXlwSBmediY2NAO/MLCPWDNphCJoozMhbrPksxu5d/Q/zYR2l6Cda2lvOalb3s=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776868281; c=relaxed/simple;\n\tbh=qo+kvKacmlRsLljwYuAMP2dcX5LkjsfJ+a1e/lKtgeA=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=HLQkB0JXQf7M4IbOsJLjUdWZ+d0PmexddOC9JTR6bcS1/F8HfY8w3a9VeRbrdfUTyre2LS5fhTFc8mXINWz0eFffpol9twuVbsw65HBJ1pZuNtrZbLjYJJaOIA9ahNbf8a5YW53JustvFaYAo96LD+03qGFshFi5WYPtYbdNqkw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=ZHPnn/l4; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:sender:subject:to; s=pp1;\n\t bh=wc5xyRzLMgKaTWJhLQUu6Av9od0cCpXKLmDnSF8zkrs=; b=ZHPnn/l4QTGL\n\tmsQ/H9O8twR4iULcL+PHfwHwkJgq7+5QjINxiUfxWjayrLBAgXui5FsAIFY//INL\n\tXciWgdsPjpKmNKHzBkZVQSCcxjWpLAFUjj15o3lmq2+Eo1EKI4XZ7WSqojnblTTr\n\tJ+nXFNRN/pkEsgolu+2SAyZGFBM/j1Mca1VmwCzPp/HHTeLnXlq1dQvpEFaijK5+\n\t4WI75RNOIwlB3MIiS76uskTPFSzPkviyngecghMUc6v0pLn9NihqmW8jJJdKfvTO\n\t/ZxHgCH77ni6vMUvB0aJVLdMvcMUJZcA3cmn0HviYC80eUNClR4QG6NS9EAhSMnu\n\tJgDdtIQwjg==","Date":"Wed, 22 Apr 2026 16:31:14 +0200","From":"Benjamin Block <bblock@linux.ibm.com>","To":"Bjorn Helgaas <bhelgaas@google.com>","Cc":"Ionut Nechita <ionut.nechita@windriver.com>,\n        Tobias Schumacher <ts@linux.ibm.com>,\n        linux-pci <linux-pci@vger.kernel.org>,\n        Gerd Bayer <gbayer@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,\n        Christian Borntraeger <borntraeger@linux.ibm.com>,\n        Niklas Schnelle <schnelle@linux.ibm.com>,\n        Sven Schnelle <svens@linux.ibm.com>,\n        linux-kernel <linux-kernel@vger.kernel.org>,\n        Ionut Nechita <ionut_n2001@yahoo.com>,\n        Heiko Carstens <hca@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>,\n        linux-s390 <linux-s390@vger.kernel.org>,\n        Alexander Gordeev <agordeev@linux.ibm.com>,\n        Andreas Krebbel <krebbel@linux.ibm.com>,\n        Matthew Rosato <mjrosato@linux.ibm.com>,\n        Julian Ruess <julianr@linux.ibm.com>","Subject":"Re: [PATCH v3 3/3] s390/pci: Fix circular/recursive deadlocks in\n PCI-bus and -device release","Message-ID":"<20260422143114.GD2707369@p1gen4-pw042f0m>","References":"<cover.1776866921.git.bblock@linux.ibm.com>\n <da7d517cf35528dd54b4323600302c3c9d3dc2c4.1776866921.git.bblock@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <da7d517cf35528dd54b4323600302c3c9d3dc2c4.1776866921.git.bblock@linux.ibm.com>","Sender":"Benjamin Block <bblock@linux.ibm.com>","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"7e1QERqw--Lhv4FCdU2_1LuNWKOjZGkk","X-Proofpoint-ORIG-GUID":"9VsENo6kmKgg5TKXaTW1o_SvShJbismp","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDEzOCBTYWx0ZWRfX6aSwDKvCqzu8\n Vyh2s63uolMb7hGqEuK0GFIW89F2TQ7bt7OfvzDDkwU2MxvTCSA7iVyDdaGi7M9iHdyq0icSXlk\n vesFJcwL/WZCbEzhiVGGmX8gSBCU1IW6SxlyR0OZG0aWcQDEAIPd2WcuEQYtqwlQBnuPfDrL06d\n oJ/6c89rR+qwx1sMFcjyN0ZPJ5ubVDQREXbSRAbkD0DIuwE7Lozriz9bgpYa75GdA5mUj/7tbSE\n 0GAVTmbLBn/kzsBER3YGbV+3fN2I1T6j97JSBLwBc/Zv5qzYMXpOQInPDFdqNpoXdQNaQFT26+e\n WzjE91SGOIACvOLTpry/FMzkWyrysi1/Md1EEkfmL2OC708084pQF/ctgKhxv0eFgVo2/tV4CIT\n ja3iEKtSlfFlxrtWIaPyOmfdC5KmnGIb/SACsrQUHpTpCT9sM4fua0u3fgzcTgmgmGF2niAm4+x\n erA7tc1xZwJqvqoImmg==","X-Authority-Analysis":"v=2.4 cv=SJxykuvH c=1 sm=1 tr=0 ts=69e8dbb7 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8\n a=Tnmygc6K0V6LZGle_IMA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0\n lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220138"}}]