[{"id":3680667,"web_url":"http://patchwork.ozlabs.org/comment/3680667/","msgid":"<20260422151852.3943-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-22T15:18:52","subject":"Re: [LTP] lib: Ignore empty LTP_ENABLE_DEBUG","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Petr,\n\n--- [PATCH 5/5] ---\n\nOn Wed, 22 Apr 2026 16:12:34 +0200, Petr Vorel wrote:\n> lib: Merge functionality of LTP_QUIET into LTP_REPRODUCIBLE_OUTPUT\n\n> +\tfprintf(stderr, \"LTP_REPRODUCIBLE_OUTPUT Values 1 or y suppress printing TCONF, TWARN, TINFO, and TDEBUG messages and\");\n> +\tfprintf(stderr, \" discards the actual content of all other messages\");\n\nBoth lines are missing a trailing '\\n'; the next help entry will run\nonto the same line in the output.\n\n> +\t\tif (reproducible_output)\n> +\t\t\treturn;\n> +\t\tres = \"TCONF\";\n[...]\n> +\t\tif (reproducible_output)\n> +\t\t\treturn;\n> +\t\tres = \"TINFO\";\n[...]\n> +\t\tif (reproducible_output)\n> +\t\t\treturn;\n> +\t\tres = \"TDEBUG\";\n\nThe help text claims TWARN is also suppressed, but there is no\ncorresponding guard for case TWARN in print_result(). Either add\nthe guard or remove TWARN from the help string.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://patchwork.ozlabs.org/project/ltp/list/?series=501017\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=VU5k1pE9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g12tv6HVXz1y2d\n\tfor ; Thu, 23 Apr 2026 01:19:02 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 106A23E5817\n\tfor ; Wed, 22 Apr 2026 17:18:59 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 0CE9E3C66CA\n for ; Wed, 22 Apr 2026 17:18:56 +0200 (CEST)","from mail-yw1-x1141.google.com (mail-yw1-x1141.google.com\n [IPv6:2607:f8b0:4864:20::1141])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 93E5910000EB\n for ; Wed, 22 Apr 2026 17:18:55 +0200 (CEST)","by mail-yw1-x1141.google.com with SMTP id\n 00721157ae682-793fdbb8d3aso58216137b3.3\n for ; Wed, 22 Apr 2026 08:18:55 -0700 (PDT)","from\n runnervm04xxt.ufidxgkzfoxuhpw0hs3jtcphyb.cx.internal.cloudapp.net\n ([135.119.239.42]) by smtp.gmail.com with ESMTPSA id\n 00721157ae682-7b9ee9b1c4dsm69911247b3.33.2026.04.22.08.18.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 08:18:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776871134; x=1777475934; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dyUsV6uSzqOtrioqeWDTa7QbABg/QdZSz//zqMv0snE=;\n b=VU5k1pE91R8awANSLQc1Ri3VWlAuNVkA9luznr/oa1ciAZ8W2rZ5XuUTel8Jif8ThZ\n 0ZGPJ3I8/IGkPyW3kkQfl2KMXVODaYHBb3bPlv4UgGu9W0VSAWGl857FIFZBZbCgFyUC\n ezUI3CiqBMjldZFy7wWN6Y9PyU9hL25jOF8qKm6tqZmq+whXrJA7Rg7BXI4THt2EZsQC\n jTjAaG9TRuXVO4+Awm30Yzkbmqz4G0Go3YOBfh9+VOf0XEonlOc7DFpxZ6Fgyeqiz/wD\n b7onMwdnMhNHbTxZuIIjZpQbjfpWHkXufXuy1uzNB0g7yNXw8aJ+iF/VOh0dKibq4KhZ\n C90g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776871134; x=1777475934;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=dyUsV6uSzqOtrioqeWDTa7QbABg/QdZSz//zqMv0snE=;\n b=V8flCq1cr9VIsTUc7IIe/1pFJoUQ3DrKXhG1b0KpA/miE58aLrJEQ1iUk4Rd1SlfYD\n def7WUUIK4ynfB6SPtmzdOnhQxCkUm2LMItyVHJs4LhhuQ9xRCpLlhfITYNVyDIXSRyh\n PPz55o0lrriOCVtPKpjDeR2qfCfTQSj/SaZbLtLE0DBgWmZGPrFTYMmWcuHSi6ichrkh\n gUCi2eSrHQTEEUv7yn952utC86HizbmZRsCit5rvgfzBzXQZRrJ0AUd4oUNl6kpSrKgR\n 9t4FEo2L1rD4jrMfVY2BgP9QxXUb7otDDD8bsOIVdLUqgkewNI4egHEJllFEe/COjTZo\n T38A==","X-Gm-Message-State":"AOJu0YzUSWXDni3dNbKA/llGyUzunvi/op/1OqiBTm0edSloo+rX/yr7\n NWa1PJkpcIxeTl+4lzTp7wSaqY9cijaVGzvsN/fiqV3AUq93yusb9NtC","X-Gm-Gg":"AeBDievHCpj3gFxX5DkUJAc4IA+3igXgtr8jYWNUkGFDMYzX2ec+VdKiQRnDVYlIMrt\n i92ONToILLezASkluD+5gY8NKRV4n0vT+G7s96Vm+E5lS8atMYjdOZ01RAxcABvz1I7IRl3+FDw\n BvFEquyblGEe3Ete8n2H//+LRseaSeYhl8YXeTWZR2lTL2mNOVMdYLmw1iJIyepN1BrBb8MQEfK\n oDYHsF8KZQdnOsiw8WF/JWKZ9VgY8T/zIrh+Njco/7QoDVuGLaUJFULsd3/41tuXfc15NTapSoE\n wuUS3XKwm3GRKmG75hP0oTZRV50ttktaWrzoDcM5dg75B8IKEptsy8m00dpy/XbfUSR+RS9rmWM\n 4IukVuOifagKvhoConnMYlA2CY4ImDOCCuXbI4gX7XY+5mhYf9REp8Ya8+L4PiQxAbQxtOSa4fT\n +ngEWJaPTn7frKycMtkoJ1jR/jY64B8PWDK4tqscw43VIzp4a0MQLTx8KXineoJf5YdXXIYRZLg\n xntoruxHmtGi1/k+bk7Mrg0DJGsjVMPoToUKD9eZE1jkGBByvMNfHvWsuDyng==","X-Received":"by 2002:a05:690c:e3cb:b0:7b2:9347:7be1 with SMTP id\n 00721157ae682-7b9ecf86543mr239444317b3.29.1776871134288;\n Wed, 22 Apr 2026 08:18:54 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Petr Vorel ","Date":"Wed, 22 Apr 2026 15:18:52 +0000","Message-ID":"<20260422151852.3943-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422141234.632195-2-pvorel@suse.cz>","References":"<20260422141234.632195-2-pvorel@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] lib: Ignore empty LTP_ENABLE_DEBUG","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]