[{"id":3680711,"web_url":"http://patchwork.ozlabs.org/comment/3680711/","msgid":"","list_archive_url":null,"date":"2026-04-22T16:57:48","subject":"Re: [PATCH v3 26/32] target/arm: ensure aarch64 DISAS_WFE will exit","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/26 14:52, Alex Bennée wrote:\n> This mirrors the logic for DISAS_WFE in 32 bit world.\n> \n> Fixes: 252ec405768 (target-arm: implement WFE/YIELD as a yield for AArch64)\n> Reviewed-by: Richard Henderson \n> Signed-off-by: Alex Bennée \n> ---\n> target/arm/tcg/translate-a64.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c\n> index 073454b9195..d79c8ab431b 100644\n> --- a/target/arm/tcg/translate-a64.c\n> +++ b/target/arm/tcg/translate-a64.c\n> @@ -10917,6 +10917,7 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)\n> case DISAS_WFE:\n> gen_a64_update_pc(dc, 4);\n> gen_helper_wfe(tcg_env);\n\nIf we mirror the logic we can also mirror the comment,\notherwise the description rationale isn't very helping:\n\n /*\n * The helper can return if the event register is set, so we\n * must go back to the main loop to check for events.\n */\n\n> + tcg_gen_exit_tb(NULL, 0);\n> break;\n> case DISAS_YIELD:\n> gen_a64_update_pc(dc, 4);\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pYXhh+Jq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g155p3qzhz1yD5\n\tfor ; Thu, 23 Apr 2026 02:58:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFatp-0002Dy-Aq; Wed, 22 Apr 2026 12:58:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFatf-0002Ck-Nf\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 12:57:57 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFatd-0002Dc-Nm\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 12:57:55 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-4890d945eb4so24976645e9.0\n for ; Wed, 22 Apr 2026 09:57:52 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb72d365sm229925445e9.1.2026.04.22.09.57.49\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 09:57:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776877071; x=1777481871; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=DbTeMp0F6npNH4gs60DUNZm6vpG8shzFCghJCd+tOro=;\n b=pYXhh+JqchMsCzXSwdYupdwEYdhn3WQXhghMjEuEEmRUmZFOGhdT0Hx70+HcC9vbMv\n +kLopuHlRjf8zc+eRn+UXBo9bDmxzZOnyszp4PJhoWdGISGcqp6vrV2i4/bBpHslcrlg\n 567yG6sDjs83EeyuzvWGxpXTPKbTkZ78taivZHpj/I/NNYddDGQZCoXSYaoyZEWvHSL0\n ghL2PL0eXvB8m6jUJjknqQZ4WOk72pGVv8bCVmb+6DBab0QeuL/cr1Hg7+3KZE6GP5xL\n u4IkoNKaGUcbz8iwjftE9pSP0160RsuowqQ98k4WCx0wgBFd3/yc6wk96LBRWGhnUiCK\n avuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776877071; x=1777481871;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=DbTeMp0F6npNH4gs60DUNZm6vpG8shzFCghJCd+tOro=;\n b=jGkpKqWz+Jf6ko2G1g+j0/2N9vDGXOXygkpokhQqv5kWPHvfZCVZxI7zNoTt5lNDUP\n fOV0jUXwliEvrzjbMb9jfTcM/jsLWHsbhs9ynIyiKhw00gd1K3rs6VfQN8SSDn1mXDwY\n e9zn0Um+/HpsOWFlLmOj4lsV7ZaFepD8Pyq/BXSW+uoTYOiu9JChw9pGp3k3pVk7aXiU\n pEGAzAIwvwMsir+3C7f3w3t+2x0tbDEYvPiQi4Z/r06BEhXwTKd2S75kh7AOMLXQMNQ9\n y/PxEu8gpCgj+X/lR79z0ZKB43XhM55umHejgQKHmMhY3YqqhgjMosNooXvs9iZ0SKmM\n BKxQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9Bset9Y1GfQCib4KOicD859jXusWSJUi0RN7UONtaRMAv0JacwcV5uy3Eur1abM75W925uyioQj2qB@nongnu.org","X-Gm-Message-State":"AOJu0YyPiv5VxsDju6wZfXCQAFDwqLbNdumwJlef/p+a5OA1iLXmUhhd\n rAYfG/Hjaf8nqGz6ClYBLtQVd21asGyac29B61dX4v+oJx+g3+MW7VLgjDl88zWOKBdjz+kqbOq\n MQ4xSyb0=","X-Gm-Gg":"AeBDieuM2sWGjAv153el3eYI9hItxrEAdAIWXM48RfgHI7ios+Wo4SGsFtXA7FX0G+H\n IFxbvAUrt+j5pd3agWyxJmmT7eLVJMLoxIcTG2a7IC5giWAvuqFAUKuuDfOJ6fnhxXKGS6Pg22n\n HobR2HFDNx5GuP0s8kyljepHKvTZlGhiXjGRmH8ozk6YsrkjrB9m6TLd6hL2spXwNZOiLq0g//T\n IanNBv2JNb2bWVrOzBn+g2gycxR4o5cuYUJtXeo0s/5AzqD2oZ7Cpto8fW3mxt6jm0ls9kSzDA3\n TEkVs1wXJmtvjGRS2DWgZDaghE2fmpzWP2swXisCZJI+RalKEruRp9ArkvzlzYxkHj58woqYfj5\n OsXULBTU/ULlNiNnCxNKB48KE6+CBdrc13aNFobQYM8LaQ1r1CpXFfzLMsTFvHytrAE9tdMdNY0\n vCGU1L49uk0Z+NmgHLT3vVDHXIYvimcrfxzD11NQ5QrZ+PR6xQ/h3t9Rtf65OdoN3aHZkqynd9m\n 1gU","X-Received":"by 2002:a05:600c:3150:b0:485:3cef:d6ea with SMTP id\n 5b1f17b1804b1-488fb8b9deamr269580515e9.13.1776877070648;\n Wed, 22 Apr 2026 09:57:50 -0700 (PDT)","Message-ID":"","Date":"Wed, 22 Apr 2026 18:57:48 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 26/32] target/arm: ensure aarch64 DISAS_WFE will exit","Content-Language":"en-US","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n qemu-devel@nongnu.org","Cc":"Pedro Barbuda , Alexander Graf ,\n Peter Maydell , Paolo Bonzini\n , Mohamed Mediouni ,\n kvm@vger.kernel.org, qemu-arm@nongnu.org,\n Richard Henderson ","References":"<20260422125250.1303100-1-alex.bennee@linaro.org>\n <20260422125250.1303100-27-alex.bennee@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260422125250.1303100-27-alex.bennee@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]