[{"id":3680633,"web_url":"http://patchwork.ozlabs.org/comment/3680633/","msgid":"<20260422132918.3932-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-22T13:29:18","subject":"Re: [LTP] include: Remove 'make install' support","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Petr,\n\nOn Wed, 22 Apr 2026, Petr Vorel wrote:\n> include: Remove 'make install' support\n\n> +# Copyright (c) Linux Test Project, 2026\n\nNit: existing line above uses \"(C)\" (uppercase); \"(c)\" here is inconsistent.\n\nReviewed-by: LTP AI Reviewer \n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: \n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SpWdjYjc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g10ST10kQz1yCv\n\tfor ; Wed, 22 Apr 2026 23:29:29 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id ED9C93E53C5\n\tfor ; Wed, 22 Apr 2026 15:29:25 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id DAFE13E2DC8\n for ; Wed, 22 Apr 2026 15:29:21 +0200 (CEST)","from mail-qt1-x841.google.com (mail-qt1-x841.google.com\n [IPv6:2607:f8b0:4864:20::841])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 79AD71000479\n for ; Wed, 22 Apr 2026 15:29:21 +0200 (CEST)","by mail-qt1-x841.google.com with SMTP id\n d75a77b69052e-50faeb8317bso21544731cf.2\n for ; Wed, 22 Apr 2026 06:29:21 -0700 (PDT)","from\n runnervmeorf1.ahhkzqflhvruxcz0lwfxlmk5ff.bx.internal.cloudapp.net\n ([20.55.15.102]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50e394c1fddsm140337981cf.30.2026.04.22.06.29.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 06:29:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776864560; x=1777469360; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=QM9j5mOFwrWhpzSIyQCMJIkyzNFJiSJWe55BHjuBLJI=;\n b=SpWdjYjcznqb84+Hkvtbb4EStsIx8VbQ6nsE8z0ymf/ja9EtdqCclntNXY/+QWiZmQ\n Aoc/0dS4Vc2a8XII16JkJ3usM8pJlPPK2XXPNCRlIHPnpxE9AzH8Q6Zh07zemnJspGMV\n ZK8Hr6ikXSqkzd6Q8zgUu3dVtfgSEPaqoHvI3fi+wYBQOg3+VVu9oEd1Fcbm0I4vNpWp\n zgR2HDnRNboMY2lTNyMGi9sSXLlPRgjXMK9uDdH/EMpb+S13m3SqfBTGewmx3j7bK5Gi\n 92VegPjX7vF/F6bwoaD6l/Ltbt8nXVIubxc6Vh/zMSz+nFDCzwLe+Ttq20hZbxzSLiP+\n JvJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776864560; x=1777469360;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=QM9j5mOFwrWhpzSIyQCMJIkyzNFJiSJWe55BHjuBLJI=;\n b=bxlW3v9w7k6cwSosucnwVyG5S/lXgPVLb+vVE/WLsseW1dX2SY0JgWbOxpz62gu5ba\n iVgFoTykNq2iSyngUYBgFWPz3y+XoK/NSXMCa4C3iFg2RezKFJRj6RdkwYGTdFKV+XBu\n AA7TgFxZsdiDWEmdjHs+lSkFjvVkS9mXWlgVTAZj4zDwxgD5d2B3h9iY9bF7XlO9uXG0\n EBPAGyo7o+O3udLNW807bVuaqtRhT+Qu/0LK2MY0N3sZf3z/u8KNJPIj9qifUt558YWr\n EI0kZiyM5G+LwXrTQ8swCNK/9FuYjEc0vFEDtar2gNL+sqzKesaziZBbb7XLfVsF1W0V\n iSQw==","X-Gm-Message-State":"AOJu0YzxFGy4AHh33Uo/tFVggiTl1JmF/6O8YkJFYfoxzAl9lZ/z00TX\n S/BMc5vCFZyZ1R7zPIjC07HdD2WhfOfiiqheWMhdqmBtLtspvT7JE5gUt8HaZtPQtv4=","X-Gm-Gg":"AeBDiet5RMEx+j632TKec6D7Bv9frjZm4lOMG8p8Q9lfwf8IqDUXVjS9FsSPkWxjC0M\n ULTosxEN+nkwcT2+kaxiqcgFOJZK+HcaRonizwdyJOUNz+zp0rfMSVZXcOx6r8+wTHPy96KHOV3\n yOi1Z2HZR6GzqXLV9d9cHqKPKqMJxgqK2O57uQUQrjgvth6ynqFDanzjlaR3YnLNcG+hwCT6kea\n srOUUl7Og9YWp6xD2gk59KjR0FmmjFAraRwrvwq8D65tKeHjwxidAGGQfoqK3AwzpiJ9EYacYAn\n 81Kq79blKUO9UZTLByPlIRgqIgQlLCrgroJGgmPplHCyODY7W74P9Ujdn92Pkcm+3jdmpGFb9Rp\n CZpEpB+f/QUzoxFbfSWSKhc1JeOh47VuLNdsNktJcTqAT1u1DLB1oKU5n74nLtE68owPUwO7sFW\n +5cKuh0CiUZXR2VTBN7s36f4HqJYIw700JE0JQ9PKJ73C8z2uzgBXiYDuDlbSHdU9YbHs9tkyaC\n oq0sbSfee91E7YSiPzfrIAYh9yQOYu/x27sTkjnwf7NIfWo","X-Received":"by 2002:a05:622a:5a0a:b0:509:127d:ee06 with SMTP id\n d75a77b69052e-50e36c9140dmr53569551cf.58.1776864560147;\n Wed, 22 Apr 2026 06:29:20 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Petr Vorel ","Date":"Wed, 22 Apr 2026 13:29:18 +0000","Message-ID":"<20260422132918.3932-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422113136.416482-1-pvorel@suse.cz>","References":"<20260422113136.416482-1-pvorel@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] include: Remove 'make install' support","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it, LTP AI Reviewer ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3681084,"web_url":"http://patchwork.ozlabs.org/comment/3681084/","msgid":"","list_archive_url":null,"date":"2026-04-22T21:12:29","subject":"Re: [LTP] [PATCH 1/1] include: Remove 'make install' support","submitter":{"id":89547,"url":"http://patchwork.ozlabs.org/api/people/89547/","name":"Ricardo B. Marlière","email":"rbm@suse.com"},"content":"On Wed Apr 22, 2026 at 8:31 AM -03, Petr Vorel wrote:\n> LTP headers aren't needed to be installed, they are unusable without LTP\n> core library anyway (which is not separated from sources). Therefore\n> newly added Makefile for 'make check' in 684cae7552 (\"include/lapi: add\n> leaf Makefile\") did not support it. Remove it also from\n> include/Makefile.\n>\n> Signed-off-by: Petr Vorel \n\nReviewed-by: Ricardo B. Marlière \n\n> ---\n> Hi,\n>\n> trivial patch, but I'd appreciate your ack that we really don't want\n> headers to be installed. Otherwise it'd have to be added also to\n> include/lapi/Makefile (added in 684cae7552).\n\nThanks!\n\n>\n> Kind regards,\n> Petr\n>\n> include/Makefile | 9 +--------\n> 1 file changed, 1 insertion(+), 8 deletions(-)\n>\n> diff --git a/include/Makefile b/include/Makefile\n> index 84cd4ed6e3..7fe72a2557 100644\n> --- a/include/Makefile\n> +++ b/include/Makefile\n> @@ -1,19 +1,12 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2009, Cisco Systems Inc.\n> +# Copyright (c) Linux Test Project, 2026\n> # Ngie Cooper, July 2009\n> \n> top_srcdir\t\t?= ..\n> \n> include $(top_srcdir)/include/mk/env_pre.mk\n> \n> -INSTALL_DIR\t\t:= $(includedir)\n> -\n> -INSTALL_MODE\t\t:= 00644\n> -\n> -INSTALL_TARGETS\t\t:= *.h\n> -\n> -MAKE_TARGETS\t\t:=\n> -\n> .PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean\n> distclean:: clean ac-distclean\n> maintainer-clean:: distclean ac-maintainer-clean","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=MNH7CVRy;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=QvqGSTOQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Bky3sjqz1yDD\n\tfor ; Thu, 23 Apr 2026 07:12:40 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 2EE5E3E6FE0\n\tfor ; Wed, 22 Apr 2026 23:12:37 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D4D7F3E6FDE\n for ; Wed, 22 Apr 2026 23:12:33 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n [IPv6:2a00:1450:4864:20::32a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id EC7E41A00249\n for ; Wed, 22 Apr 2026 23:12:32 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-4891d7164ddso23930895e9.3\n for ; Wed, 22 Apr 2026 14:12:32 -0700 (PDT)","from localhost ([2804:7f0:b765:105d:2ecf:67ff:fe81:9da0])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ea8e4b373dsm8171428eec.6.2026.04.22.14.12.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 14:12:31 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1776892357; h=mime-version :\n date : message-id : to : references : in-reply-to : subject : list-id\n : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=3brSipw1JxZ7qSKlK45l6IemdkDTLhI7TR+scscRil8=;\n b=MNH7CVRy2Sy21iywhwBUosLgSDXaPjVk5yH3pnbdWwfqnkNY6A20YfFEpamzMbIBFLUQ3\n aPDWGBm2QaebmKkhayi/nC5lwsWOFtlkKPqWrViKOWst0Wlt28qFOOd5c0mXoQso1SnYdEH\n NfwDsE24lZLTi+r8Rn351Tk9DidMjTg=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776892352; x=1777497152; darn=lists.linux.it;\n h=in-reply-to:references:from:to:cc:subject:message-id:date\n :content-transfer-encoding:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LLfX5712aTh39FgcQbjU7Licn3rEVlQpXs+5zsN+6Rg=;\n b=QvqGSTOQLbLNSA1bcneZWlF5nUsK3J+UnhvBB4cmWRDEv77Lv0X2Erv27jcahi/vub\n 1CueDkos6jf1OFnloxXYbB0r7+UKLN5CAVM9txuqK0M1F2JQw/mxClyts6ts8p7uweSm\n DBDyuyQPlQqhGAh4+9tug0FHY3x0GWapadQ3EYNwaDwJEJpnDBccQ+Rvp3Vg9dosTCWW\n rn/wUZpFyzKkKJUkrhjkME4gVoZ421KurQWSvduZT7jW4IrRnmWrE0DapeM4FUnVp567\n pfAF7iwDHMoK72lkrp+P3pbLnYxOydzOvdPpWabZpT3XpbPP3l66t6WwuOGrEQvogDJG\n lETw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776892352; x=1777497152;\n h=in-reply-to:references:from:to:cc:subject:message-id:date\n :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=LLfX5712aTh39FgcQbjU7Licn3rEVlQpXs+5zsN+6Rg=;\n b=MsM/y5hFCKOdOt+to3ICEukGhVAD0+N/3l5hP41lNZWbJ1FTk1e3wVi5KnDMjzi0IH\n TCq81wARX/7wEDKP7rUkAaWGa8L48CyQrodAOIp3Rzm2Qrsnkr7emjKn2q/3PzdwPUu3\n PIi9WPBJsnnBT/QCgvPVPOU9pzzve5Sd80KCFIwmXM5WrVVj+qxqPtyl3UQ/kq1dyoDt\n u7gHmpd2xKZLGTrsyA+5YC5Afu8VLdKxiyC92T50Jt7MLVQX84AdjyIkRgq+XgitrNva\n No+sZ87UMhuDjdtNNwHA2SNbHtBZm5YY1yrbQxZa9UBUbIvegqhh7QUDcRocpigWBEFF\n Ot+g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9+FJ3vu+cAPppDzAaU2MYbAPQgz1LhH3fBCeTsK3wuQ2fITLfX0ZCl75Qn5/1VgHDoSSw=@lists.linux.it","X-Gm-Message-State":"AOJu0Yyh1hYX6TfYZGb2rkNg2im78hRlEDJXWOfvkFLCJEEYYCw1Ra20\n 7gy7RmJ+Cav6MWURChZhYh4u+0fj5SdB6duDCxt5nLQaVwO+Z2kmTHS0PEesKZj7Kmg=","X-Gm-Gg":"AeBDieskkNfsaVLY0JsOFeSjmi6TmeRib8AyIbsQqF7c4ysRkp3TehWz64dzgM+jaSl\n nvQmpUfmD6xsUNL4g8GI25q0YV/9wULZnWjr+bTFbmUQ+wElWUfiDm1jIzROOcO410BkVZibuWy\n 8aNrB1xlegl/7Wlx/n1tTPLd62+hdWK0C1Dn7tEOQovF8q13MJ82HLo0wCb4Wy8gYo5icpGxhFw\n g7u9smOPuQaz3zEXCE7Ss7zGfspkWGdPhm6b5YWoUFbb5Gm7UbFPt5mxub6pnnqUMzHfPu20v95\n 1MZmeUktPp2htJBfTGvCr1rZc/vSuhO9z2M6pwTZ+zlF8v9IfjTEZnAlCaR11dvGYDf+6xFxzol\n EMuiLoFaMVb853U8D0oxeGHu1+ejmMolWclzcwYPTb1shTmWsq5/fP6PaaE7eAp7PkPvMN6D2Xc\n D3BHL9g32G9DvTo4EY17bccd4=","X-Received":"by 2002:a05:600c:4f0c:b0:489:1c1f:35e6 with SMTP id\n 5b1f17b1804b1-4891c1f38c8mr228221245e9.6.1776892352247;\n Wed, 22 Apr 2026 14:12:32 -0700 (PDT)","Mime-Version":"1.0","Date":"Wed, 22 Apr 2026 18:12:29 -0300","Message-Id":"","To":"\"Petr Vorel\" , ","X-Mailer":"aerc 0.21.0-120-g22b95d38161f","References":"<20260422113136.416482-1-pvorel@suse.cz>","In-Reply-To":"<20260422113136.416482-1-pvorel@suse.cz>","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 1/1] include: Remove 'make install' support","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"=?utf-8?q?Ricardo_B=2E_Marli=C3=A8re_via_ltp?= ","Reply-To":"=?utf-8?q?Ricardo_B=2E_Marli=C3=A8re?= ","Cc":"ltp , =?utf-8?q?Ricardo?=\n\t=?utf-8?q?_B_=2E_Marli=C3=A8re?= ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]