[{"id":3680569,"web_url":"http://patchwork.ozlabs.org/comment/3680569/","msgid":"<CACb0b4=Svx13p0UE9inKZYfxJe6fxM9iiD6CKuG3-047b4eTkQ@mail.gmail.com>","list_archive_url":null,"date":"2026-04-22T11:36:19","subject":"Re: [PATCH] libstdc++: Expand tests for std::type_order.","submitter":{"id":48004,"url":"http://patchwork.ozlabs.org/api/people/48004/","name":"Jonathan Wakely","email":"jwakely@redhat.com"},"content":"On Wed, 22 Apr 2026 at 11:59, Tomasz Kamiński <tkaminsk@redhat.com> wrote:\n>\n> Expanded test coverage to include:\n> * array of unknown bounds\n> * function types and pointers\n> * data and function member pointers\n>\n> libstdc++-v3/ChangeLog:\n>\n>         * testsuite/18_support/comparisons/type_order/1.cc: New test.\n\n\"tests\" (otherwise it looks like the entire file is new).\n\nMaybe \"Add tests for more types\" would be a better description.\n\n>\n> gcc/testsuite/ChangeLog:\n>\n>         * g++.dg/cpp26/type-order1.C: New tests.\n\nHere too.\n\nThe library part is OK with a better changelog.\n\n> ---\n> Tested all *type_order* test both for libstdc++ and g++.\n> OK for trunk?\n>\n>  gcc/testsuite/g++.dg/cpp26/type-order1.C      | 21 +++++++++++++++++++\n>  .../18_support/comparisons/type_order/1.cc    | 21 +++++++++++++++++++\n>  2 files changed, 42 insertions(+)\n>\n> diff --git a/gcc/testsuite/g++.dg/cpp26/type-order1.C b/gcc/testsuite/g++.dg/cpp26/type-order1.C\n> index d5693570a47..bc7e87644a9 100644\n> --- a/gcc/testsuite/g++.dg/cpp26/type-order1.C\n> +++ b/gcc/testsuite/g++.dg/cpp26/type-order1.C\n> @@ -92,3 +92,24 @@ constexpr eq <W, W> r;\n>  constexpr ne <V, W> s;\n>  constexpr eq <U <W>, U <W>> t;\n>  constexpr ne <U <V>, U <W>> u;\n> +\n> +constexpr eq <int[], int[]> v;\n> +constexpr ne <int[], int[2]> w;\n> +constexpr eq <S[], S[]> x;\n> +constexpr ne <S[], S[2]> y;\n> +\n> +constexpr eq <int (), int ()> z;\n> +constexpr eq <int () noexcept, int () noexcept> aa;\n> +constexpr ne <int (), int () noexcept> ab;\n> +constexpr eq <int () const, int () const> ac;\n> +constexpr ne <int (), int () const> ad;\n> +constexpr eq <int () &, int () &> ae;\n> +constexpr ne <int (), int () &> af;\n> +constexpr eq <int (*)() noexcept, int (*)() noexcept> ag;\n> +constexpr ne <int (), int (*)()> ah;\n> +\n> +constexpr eq <int V::*, int V::*> ba;\n> +constexpr ne <int V::*, long V::*> bb;\n> +constexpr eq <int (V::*)() const& noexcept, int (V::*)() const& noexcept> bc;\n> +constexpr ne <int (V::*)(), long (V::*)()> bd;\n> +constexpr ne <int (V::*)(), int (*)()> be;\n> diff --git a/libstdc++-v3/testsuite/18_support/comparisons/type_order/1.cc b/libstdc++-v3/testsuite/18_support/comparisons/type_order/1.cc\n> index 63864fa98b4..7c428a93f96 100644\n> --- a/libstdc++-v3/testsuite/18_support/comparisons/type_order/1.cc\n> +++ b/libstdc++-v3/testsuite/18_support/comparisons/type_order/1.cc\n> @@ -93,3 +93,24 @@ constexpr eq <W, W> r;\n>  constexpr ne <V, W> s;\n>  constexpr eq <U <W>, U <W>> t;\n>  constexpr ne <U <V>, U <W>> u;\n> +\n> +constexpr eq <int[], int[]> v;\n> +constexpr ne <int[], int[2]> w;\n> +constexpr eq <S[], S[]> x;\n> +constexpr ne <S[], S[2]> y;\n> +\n> +constexpr eq <int (), int ()> z;\n> +constexpr eq <int () noexcept, int () noexcept> aa;\n> +constexpr ne <int (), int () noexcept> ab;\n> +constexpr eq <int () const, int () const> ac;\n> +constexpr ne <int (), int () const> ad;\n> +constexpr eq <int () &, int () &> ae;\n> +constexpr ne <int (), int () &> af;\n> +constexpr eq <int (*)() noexcept, int (*)() noexcept> ag;\n> +constexpr ne <int (), int (*)()> ah;\n> +\n> +constexpr eq <int V::*, int V::*> ba;\n> +constexpr ne <int V::*, long V::*> bb;\n> +constexpr eq <int (V::*)() const& noexcept, int (V::*)() const& noexcept> bc;\n> +constexpr ne <int (V::*)(), long (V::*)()> bd;\n> +constexpr ne <int (V::*)(), int (*)()> be;\n> --\n> 2.53.0\n>","headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=btG8hbPE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=btG8hbPE","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0y2C1mFfz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 21:40:03 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id E2DBD4C91752\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 11:40:00 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id BFD104C3183E\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 11:36:40 +0000 (GMT)","from mail-yx1-f69.google.com (mail-yx1-f69.google.com\n [74.125.224.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-107-G9tUskn9PjiE-2hYoVqSJw-1; Wed, 22 Apr 2026 07:36:38 -0400","by mail-yx1-f69.google.com with SMTP id\n 956f58d0204a3-649deef077eso6537763d50.1\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 04:36:38 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org E2DBD4C91752","OpenDKIM Filter v2.11.0 sourceware.org BFD104C3183E"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org BFD104C3183E","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org BFD104C3183E","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776857801; cv=none;\n b=ByeHFbnshbW0qxekTKYHdELoqgWtPrOeDmFvgKfqWIRR5XnTp7EcDf15Ufrm36VLcsgy9Ojon/OgRQo3DcMp1Xesah4uuEVQujPwlV/Q5xc/7UzQYUqFUahh9xmzfx/dP81pqEdt99osrKSslfxhRPxWPR84GeIA0KfiIwSAgw0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776857801; c=relaxed/simple;\n bh=jFthnazTNJwZ604A1hyI+XGYI6wktMbAiN4pGgOEDvo=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=k2pDiu71enHR6mNph/jBYKvlTTiREuJVBp+sqYBGEci52/781Z0N+3H30M8Sr+N+rD1wh3tzfG8riGrJp9V3EBaxUFXGh9IoNlPA5PRqwtcRB/sQN2Pz5E1W6JcU7GuyaKXw2bQ4B7Uj+6m65EBft0a0wGoT55XYk3xs9xM8PK0=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776857799;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=x27T/TG5aQe59mHSb4cz0iHxYzDGE74jSobls3bVbUI=;\n b=btG8hbPE01CXCm0v9M61MQC0ots20O6S0z3pUYeqeecqEOyfXQnE0SxL8WRCAmG8sLAFD1\n kdKY1Q7VINIPpRyXT6ZDkln9huPa3cDnE7o0z3u1nDDWkwg+8U10EQMcPiOQDCAHALOIrI\n J8AWVIkEttmh70FmqoAOnGrin50fDDQ=","X-MC-Unique":"G9tUskn9PjiE-2hYoVqSJw-1","X-Mimecast-MFC-AGG-ID":"G9tUskn9PjiE-2hYoVqSJw_1776857798","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776857798; x=1777462598;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=x27T/TG5aQe59mHSb4cz0iHxYzDGE74jSobls3bVbUI=;\n b=oNDX9PqJj94csfTgFjmiMeev91Rffjv2snyKdqMLZoZq74sr6saHPodFDF94uAxWwq\n Twwx34DiwjmPGIouJNag4CSbIHQMhGrtcIQ/KGJgIxFe1JSjmcxV4Lg/B6pTh4abP39L\n abVIjqkJhhBbg2CIY3qHKZ+Px2LgrEjqRmCKzcYZCzRhYmP7uuYJz/yK5VOzPLtSG71/\n onKbC1ZaqJrfjaMld46iYN7L4Ft8fXP9OQoDgSVRrz9FNyYlWTXYJ6wLO5eQ0Yhcf4M4\n 4k2yuPuU9bv7CoFK/4ctDWO/Q0z3iVMRnP0haK8MKRySfBNHjqJ/B4+h1qbVlj3s0mJK\n rOvg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8t/tqODcrdyu45V7dXPj4rMD71lVN+S5Da6O4naRdMiNzeBastje1F4vv46kLhTppF9xOJd5suBJ6JvA==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YzOoS8JldSKgi2XRsqGSpfe8dgY61N889cGFz3JBseVKxPWsKBx\n ruC03LiloSWeX/o7wgBe9b7M2bHekYdsP1O4q8fXQy8UV81jbyAtA6qRupHSBG5wax4eSRotXqg\n rf6m8gz4VLJlJkH08LTgHx0yb80/NLvlB4qK5ZcL1sjBFVCHuFFLk8Vl5vgNho4YU5WQ/5TQEpq\n EthKG76ktRFNBf91j8bX2p0+gW9IG5ntNWTeJ6dN5QgQ==","X-Gm-Gg":"AeBDievAYt5w7cpbkdnLBTa3O6Vav5zgVbQP/bDTnrTTDPdzVfT8PxJAuEBp8JgJrki\n xzKj7ohdtWAj7KCMn3RG1r1X+oRq9hhWZYqpUjh4TsYipfr983Nboo3GjrMaMtQi87TROdyha3g\n 2a3s56yqH3JhLGApy/niWENJptjviDaicTpZN1O40z6uL5UpSHsLANZawB5U70a31MYQZ7hySir\n EaEN0tcqU6RwX3MTIzmW78jYS6H3mMDqvDemy4mM+53XY4Q+4ILoqOZkA4ZV51QUwvzGoOWSOcF\n Ww==","X-Received":["by 2002:a53:d017:0:b0:651:b73b:251a with SMTP id\n 956f58d0204a3-6531058d034mr17085539d50.0.1776857797791;\n Wed, 22 Apr 2026 04:36:37 -0700 (PDT)","by 2002:a53:d017:0:b0:651:b73b:251a with SMTP id\n 956f58d0204a3-6531058d034mr17085506d50.0.1776857797303; Wed, 22 Apr 2026\n 04:36:37 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260422103255.614998-1-tkaminsk@redhat.com>","In-Reply-To":"<20260422103255.614998-1-tkaminsk@redhat.com>","From":"Jonathan Wakely <jwakely@redhat.com>","Date":"Wed, 22 Apr 2026 12:36:19 +0100","X-Gm-Features":"AQROBzALvutz3ZHr4Rt0MfQ6XVvBTsRqhYW3e5gVBVk5Aq6J-f-FivKrJd5y97s","Message-ID":"\n <CACb0b4=Svx13p0UE9inKZYfxJe6fxM9iiD6CKuG3-047b4eTkQ@mail.gmail.com>","Subject":"Re: [PATCH] libstdc++: Expand tests for std::type_order.","To":"=?utf-8?q?Tomasz_Kami=C5=84ski?= <tkaminsk@redhat.com>","Cc":"libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"ZVABWh2yZLr3o-z8TyswfhITOJrH3ZQ2oSmadKHuYnc_1776857798","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]