[{"id":3681209,"web_url":"http://patchwork.ozlabs.org/comment/3681209/","msgid":"","list_archive_url":null,"date":"2026-04-23T00:29:00","subject":"Re: [PATCH] fs: smb: server: zero buffer before filling file entry","submitter":{"id":79386,"url":"http://patchwork.ozlabs.org/api/people/79386/","name":"Namjae Jeon","email":"linkinjeon@kernel.org"},"content":"On Wed, Apr 22, 2026 at 7:50 PM Marios Makassikis\n wrote:\n>\n> this ensures there is no stale data in padding area between entries\n> when processing SMB2_QUERY_DIRECTORY request.\n>\n> Signed-off-by: Marios Makassikis \n> ---\n> fs/smb/server/smb2pdu.c | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c\n> index 07782f7205dc..b55bef96d94b 100644\n> --- a/fs/smb/server/smb2pdu.c\n> +++ b/fs/smb/server/smb2pdu.c\n> @@ -3962,6 +3962,7 @@ static int smb2_populate_readdir_entry(struct ksmbd_conn *conn, int info_level,\n> rc = -ENOSPC;\n> goto free_conv_name;\n> }\n> + memset(d_info->wptr, 0, next_entry_offset);\nThe response buffer is allocated with kvzalloc(). Could it be a\nduplicate initialization?\nThanks!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=o2upG81O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11033-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"o2upG81O\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1H804qh4z1yD5\n\tfor ; Thu, 23 Apr 2026 10:31:12 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C02473013A8D\n\tfor ; Thu, 23 Apr 2026 00:29:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 288161EA7DB;\n\tThu, 23 Apr 2026 00:29:16 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B7E1ACEDF\n\tfor ; Thu, 23 Apr 2026 00:29:15 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9E012C2BCB6\n\tfor ; Thu, 23 Apr 2026 00:29:15 +0000 (UTC)","by mail-ed1-f45.google.com with SMTP id\n 4fb4d7f45d1cf-674a44b84fcso7637376a12.1\n for ;\n Wed, 22 Apr 2026 17:29:15 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776904156; cv=none;\n b=NWIVmF+h63m30XhT33aeQfo0D36d74lIWiFL/F+iDbP2BGNKir/zbLvzVCs3aykbzPmKjE3FiZWW/iHeP1AyL3Iee4Mnfmf0fsHpwrqcdJ0EMbobQb0VuqLMheypMwhS9yb6MmxcnNk6MqEUhwPnyAheO6mnlplErCuHMdg50WQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776904156; c=relaxed/simple;\n\tbh=OKfR/w8sEXIXWNyijWFx/otknLfPN0BVon7J3GcY8Gg=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=Si97WXCCXXBXY3yBQECVLPUnstxtflHdPr+/uK8C4ObosUscNIpfIXQUaOvoTiVQ01kq0aQH9hJ+W47YvnoP0nM7wSrqy3soAb1MNSbDTxF0RHn2OsHrTFXP/lV2JqVFf9gKSVj246A2LRs9FtWfYS/GtXVVJkZtWvpRQzWgWYw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=o2upG81O; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776904155;\n\tbh=OKfR/w8sEXIXWNyijWFx/otknLfPN0BVon7J3GcY8Gg=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=o2upG81OI2tUED9Oix6HEnkHEEf5gFj+1t8FR39a4LZBnL5/Ddy3P5fcnoFOsVyyS\n\t wMmXw4Hq2D7X+GOjatf2h7TH7AkYRIgg9aIn6Q02lOvuGu1zNejLlwtno1r4nfCFx6\n\t 9jyFPiTVJKS2/YXFXJPxpq6ihCxyAUZ5YYeM0FmPMvJQtQxjEqrQx40w5W5aQMCIPu\n\t 0xiL+sAXvwi+KqtUq7/+YsbA6YkBEC1RxaCoZBlWtT/tbnSBrRCbbf1awqKdOD0Smd\n\t TTPndecC9ovN4TjQbAHcdjbKpPnelKDDKdbWr0GkmkU+zeF0Jkgb9EvrMXO8YC6m3P\n\t ZwetaCbHJ0i7w==","X-Gm-Message-State":"AOJu0YxG5xeTeiK3qZF1dlj7T8Q49jEJzOr91EDAjNAmB0ODU9w4mwlE\n\tUg1Hka9A+cFAufzkChuN1loReIgcyPsShQzCOafe8GQBfYgbjzvc0yrIJ/xEiTaoURVO4+ss7Td\n\tJYbSNQWYJGKERhzgJ5khw6NjzXbCroFI=","X-Received":"by 2002:a05:6402:3586:b0:676:6eaf:52be with SMTP id\n 4fb4d7f45d1cf-6766eaf5d05mr5839938a12.13.1776904154214; Wed, 22 Apr 2026\n 17:29:14 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260422105010.2600337-2-mmakassikis@freebox.fr>","In-Reply-To":"<20260422105010.2600337-2-mmakassikis@freebox.fr>","From":"Namjae Jeon ","Date":"Thu, 23 Apr 2026 09:29:00 +0900","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzAloIY78uD5qdQ5GpKGAG-IO6O2O1q34EszYl7bD-yggtw1OfAu-_Rko40","Message-ID":"\n ","Subject":"Re: [PATCH] fs: smb: server: zero buffer before filling file entry","To":"Marios Makassikis ","Cc":"linux-cifs@vger.kernel.org, smfrench@gmail.com, tom@talpey.com,\n\tsenozhatsky@chromium.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]