[{"id":3680508,"web_url":"http://patchwork.ozlabs.org/comment/3680508/","msgid":"<20260422110623.2j6x6au3s2a4ngfg@wintermute.fritz.box>","list_archive_url":null,"date":"2026-04-22T11:06:23","subject":"NACK/Cmnt: [SRU][R][PATCH v2] ASoC: qcom: x1e80100: limit speaker\n volumes","submitter":{"id":86131,"url":"http://patchwork.ozlabs.org/api/people/86131/","name":"Manuel Diewald","email":"manuel.diewald@canonical.com"},"content":"On Wed, Apr 22, 2026 at 02:17:17AM +0200, Tobias Heider wrote:\n> Limit the digital gain and PA volumes to a combined -3 dB in the machine\n> driver to reduce the risk of speaker damage until we have active speaker\n> protection in place (or higher safe levels have been established).\n> \n> Based on commit c481016bb4f8 (\"ASoC: qcom: sc8280xp: limit speaker\n> volumes\") which addressed the same issue on the sc8280x SoC with some\n> minor changes as explained below.\n> \n> The Digital Volume behaves identical to sc8280x, both use the same\n> lpass-wsa-macro.\n> For PA x1e80100 machines use wsa884x amplifiers which expose a linear\n> scale from -9 dB to 9 dB with a 1.5 dB step size giving us\n> 0 dB = -9 dB + 6 * 1.5 dB.\n> \n> On x1e80100 there are two different speaker topologies we need to handle:\n> 2-Speakers: SpkrLeft, Spkr Right\n> 4-Speakers: WooferLeft, WooferRight, TweeterLeft, TweeterRight\n> \n> Signed-off-by: Tobias Heider \n> ---\n> \n> - Changed in v2:\n> Fixed names of Digital Volume Channels. On X1 they are prefixed with\n> WSA and WSA2 (for 4 speaker configurations). Based on LKML feedback.\n> \n> sound/soc/qcom/x1e80100.c | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n> \n> diff --git a/sound/soc/qcom/x1e80100.c b/sound/soc/qcom/x1e80100.c\n> index a3f4785c4bbe..c81df41ace88 100644\n> --- a/sound/soc/qcom/x1e80100.c\n> +++ b/sound/soc/qcom/x1e80100.c\n> @@ -27,10 +27,29 @@ static int x1e80100_snd_init(struct snd_soc_pcm_runtime *rtd)\n> {\n> \tstruct x1e80100_snd_data *data = snd_soc_card_get_drvdata(rtd->card);\n> \tstruct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);\n> +\tstruct snd_soc_card *card = rtd->card;\n> \tstruct snd_soc_jack *dp_jack = NULL;\n> \tint dp_pcm_id = 0;\n> \n> \tswitch (cpu_dai->id) {\n> +\tcase WSA_CODEC_DMA_RX_0:\n> +\tcase WSA_CODEC_DMA_RX_1:\n> +\t\t/*\n> +\t\t * Set limit of -3 dB on Digital Volume and 0 dB on PA Volume\n> +\t\t * to reduce the risk of speaker damage until we have active\n> +\t\t * speaker protection in place.\n> +\t\t */\n> +\t\tsnd_soc_limit_volume(card, \"WSA WSA_RX0 Digital Volume\", 81);\n> +\t\tsnd_soc_limit_volume(card, \"WSA WSA_RX1 Digital Volume\", 81);\n> +\t\tsnd_soc_limit_volume(card, \"WSA2 WSA_RX0 Digital Volume\", 81);\n> +\t\tsnd_soc_limit_volume(card, \"WSA2 WSA_RX1 Digital Volume\", 81);\n> +\t\tsnd_soc_limit_volume(card, \"SpkrLeft PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"SpkrRight PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"WooferLeft PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"TweeterLeft PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"WooferRight PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"TweeterRight PA Volume\", 6);\n> +\t\tbreak;\n> \tcase DISPLAY_PORT_RX_0:\n> \t\tdp_pcm_id = 0;\n> \t\tdp_jack = &data->dp_jack[dp_pcm_id];\n> -- \n> 2.51.0\n> \n> \n> -- \n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team\n\nThe patch is missing the BugLink that v1 had and I think it should be\nprefixed with `UBUNTU: SAUCE:` since it's not upstream yet.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=qgpgpYHG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0xHf1j1Zz1yD5\n\tfor ; Wed, 22 Apr 2026 21:06:37 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wFVPY-0007cz-OD; Wed, 22 Apr 2026 11:06:28 +0000","from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wFVPW-0007bn-Qk\n for kernel-team@lists.ubuntu.com; Wed, 22 Apr 2026 11:06:26 +0000","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n [209.85.221.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B219E3FEA3\n for ; Wed, 22 Apr 2026 11:06:26 +0000 (UTC)","by mail-wr1-f69.google.com with SMTP id\n ffacd0b85a97d-4362197d1easo4010301f8f.2\n for ; Wed, 22 Apr 2026 04:06:26 -0700 (PDT)","from localhost ([2001:16b8:a7e4:dc00:9466:c9ff:fefc:5627])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb75ab25sm136739165e9.11.2026.04.22.04.06.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 04:06:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776855986;\n bh=g4IeBULl+k+EC7QDVp8qqpwJ/0pv89SENiD1OPkQu1Y=;\n h=Date:From:To:Subject:Message-ID:References:MIME-Version:\n Content-Type:In-Reply-To;\n b=qgpgpYHG7aMh5HNhQOYCXsjC+Jdlpi/dWsxSJOAnERXmC7MN8c+gZk4gvHynrC74c\n 95IKlE5CtoGMxL/jaHXXtz+AEJRQdbuY/VIjEbTkp43KWWBZznzkxKmeaOYgIiDIFU\n O2ccEM9KNH4EHNyU5D4qEK7VaGu0laNoXJPs6mg2Yus2h3gjItjuw33ELzbU6WckkF\n RVgn6vsVHb45ypv3U7C3p4KAu/dyxTZIXtaz5+rrO3ST4ZtMMjdKj1XPeUSx2WdYvO\n ytBUpaLkTKIa+tG2GFADjtGGbCJBa7npfSfuvLFPxu6P9Zh/ygb/ivzd998FbGHp0U\n hXAjxTEvhpXvWo8hIE+RkiWhH+/Q2AiiTnBiCIRHBKlbBxbqNwTkmzpQtmvf9UmYF2\n k9JiWT1lLddCfV0sPYGJmhwSQED+p6908g/MSdZt8hfXEgTQjHFG8ssVS5udLhSsYM\n Y/19vDE0GQxDMBKbEja6KP//G1tyrGQ4jeil+LDu1mI7c2BhhusqxxVPvCuc92LmeH\n //YcThn6976bAyqPWy1YMTx7rBNR6o0WGcPh2iNMV5Ixh7RbOHK9kB2utCronefqaq\n 3X0uaEqB14aMx1uWjeFY+feiK5fwg6LZjO0a9nwNszCbjaFSDJzmtNX7neFVPi4zCj\n 7sbRJqiDuqaTNCnmfKhNou6Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776855986; x=1777460786;\n h=in-reply-to:content-disposition:mime-version:references\n :mail-followup-to:message-id:subject:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=g4IeBULl+k+EC7QDVp8qqpwJ/0pv89SENiD1OPkQu1Y=;\n b=FCGHtT0xmfPH7ejsRZkxjP5qHZlPt6fI1hlNfolJlOvmRWaEEBIsVxw6jcyhjogMjZ\n zBjhet635ej04lalkQ5Bx35Efly1xOOXNNs/hyVOHyyZKMLNIWvkABm42EB+GCPoGzyD\n s8u0FnJ0ub5HRqQEAloa19XCMx8f4FwWEhTMv0hZIS+AxjUrmwEeCAPtL2++yd09GFct\n BE7k/nurAbp6WOHIGtVVRZlFjCbmcSI/m8YxHoMghLk0kzMillSJq7dfgSa9nMb8tPHE\n 1ksan9ZMWjmQFAb8DeQfyymdpqQEbSNqUPmBDoKM8rrYYOQWmIU/gs+xz/b66cp+OV8y\n qi0w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+pdgR300lilN8WWy26EJc6jCG/5b8ADccIxKf3VH+HHuafVu+UWF1U+1qRzok+jizHEf4THOt+Ntzdew==@lists.ubuntu.com","X-Gm-Message-State":"AOJu0YzyZinFF8nIA0Jdwh7MloNuoIELK108rKOmkQvMxe3TLlxjP0C+\n cNHW9WLp3W+BBQy6zA584ch92fngcB6TZNBSYaEdrNgrrZvBMJOVmyffK21DXEWCZdwTWYatJjS\n F3RQmknetDM/KqbdbJyDT6Dg2Vn/fuLUNr2jVt9lw03Zl8OhwkuMyJ2Zlr4vCX9sdcgGJfpwo4w\n hNG7QClQ==","X-Gm-Gg":"AeBDievApo2KWV7GvUN4k6/77Lb+PARStMgy27WLZoxF90y5O54fc7ciIDBx/pxM6cE\n MwQbypqkN7S70Q2YyqAN1RIoSZ60Inxw/z4CoozUVCqaobyvdKXDDWSDbQZNh8phOTcDWYw2frB\n 87mcQ5gXgEDejSzERqXCo1eEL0qZc6Tq5SYddil2Ht5L0Xo75yH1aaNp8RNNUm0faRk7PudmJZJ\n Tu9xvT00vqq5XgR+8BF3Hozemr4Dxf/uEQx7N5Gd2KW1JLBdp0L+Clo/OWJ/NAVm0kMeM8sXXgx\n 0g2M1G8wd7U4sVvQ1x11h5G/jruV0DUYl0vRtre6gnz3yVzEAsauveAmrB5Hr16DjdtXwi+d0rA\n tJ5NXYtMBzqs4ahGRRUdgllK/lF7oKcPKHZ6fjiMywRs=","X-Received":["by 2002:a05:600c:3110:b0:487:2439:b7be with SMTP id\n 5b1f17b1804b1-488fb7389dfmr329434585e9.6.1776855986079;\n Wed, 22 Apr 2026 04:06:26 -0700 (PDT)","by 2002:a05:600c:3110:b0:487:2439:b7be with SMTP id\n 5b1f17b1804b1-488fb7389dfmr329434025e9.6.1776855985485;\n Wed, 22 Apr 2026 04:06:25 -0700 (PDT)"],"Date":"Wed, 22 Apr 2026 13:06:23 +0200","From":"Manuel Diewald ","To":"Tobias Heider , kernel-team@lists.ubuntu.com","Subject":"NACK/Cmnt: [SRU][R][PATCH v2] ASoC: qcom: x1e80100: limit speaker\n volumes","Message-ID":"<20260422110623.2j6x6au3s2a4ngfg@wintermute.fritz.box>","Mail-Followup-To":"Tobias Heider ,\n kernel-team@lists.ubuntu.com","References":"<20260422001715.294759-3-tobias.heider@canonical.com>","MIME-Version":"1.0","In-Reply-To":"<20260422001715.294759-3-tobias.heider@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"multipart/mixed; boundary=\"===============0138101106325483445==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]