[{"id":3680151,"web_url":"http://patchwork.ozlabs.org/comment/3680151/","msgid":"","list_archive_url":null,"date":"2026-04-22T00:12:56","subject":"Re: [PATCH v5 06/15] test: dm: ecdsa.c: clean this test as software\n ecdsa is now implemented","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Philippe,\n\nOn 2026-04-21T21:09:51, Philippe Reynes wrote:\n> test: dm: ecdsa.c: clean this test as software ecdsa is now implemented\n>\n> The test ecdsa was done when ecdsa was only supported by hardware.\n> So it wasn't possible to test ecdsa on sandbox, and there is a test\n> to check that ecdsa is not supported on sandbox.\n> Now, there is a software implementation of ecdsa. So we remove\n> this outdated test.\n>\n> Signed-off-by: Philippe Reynes \n>\n> test/dm/ecdsa.c | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++------\n> 1 file changed, 97 insertions(+), 10 deletions(-)\n\n> diff --git a/test/dm/ecdsa.c b/test/dm/ecdsa.c\n> @@ -3,36 +3,123 @@\n\nThe commit message says \"we remove this outdated test\" but this patch\nrefactors it to perform actual ECDSA verification. Please can you\nrephrase to describe what it actually does.\n\n> diff --git a/test/dm/ecdsa.c b/test/dm/ecdsa.c\n> @@ -3,36 +3,123 @@\n> +#define CHECK(op) ({ \\\n> + int err = op; \\\n> + if (err < 0) { \\\n> + printf(\"%s: %s: %s\\n\", __func__, #op, \\\n> + fdt_strerror(err)); \\\n> + return err; \\\n> + } \\\n> + \\\n> + err; \\\n> + })\n\nhex2bin() returns -1 on error, which is not a valid fdt_strerror()\ninput. Consider using a more generic error message.\n\n> diff --git a/test/dm/ecdsa.c b/test/dm/ecdsa.c\n> @@ -3,36 +3,123 @@\n> + value = malloc(len / 2);\n> + if (!value) {\n> + ret = -EINVAL;\n> + goto out;\n> + }\n\nWe use -ENOMEM when out of malloc() space.\n\n> diff --git a/test/dm/ecdsa.c b/test/dm/ecdsa.c\n> @@ -3,36 +3,123 @@\n> + size_t fdt_size = 512;\n> + char fdt[512];\n\nThe value 512 is duplicated. Please can you use a #define for clarity.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=fOIIs5N5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"fOIIs5N5\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0fnl2399z1yGs\n\tfor ; Wed, 22 Apr 2026 10:13:15 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3A1D68352B;\n\tWed, 22 Apr 2026 02:13:13 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6058683AC5; Wed, 22 Apr 2026 02:13:12 +0200 (CEST)","from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n [IPv6:2a00:1450:4864:20::62b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 78B53805D7\n for ; Wed, 22 Apr 2026 02:13:09 +0200 (CEST)","by mail-ej1-x62b.google.com with SMTP id\n a640c23a62f3a-ba67b332bbaso463076166b.0\n for ; Tue, 21 Apr 2026 17:13:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776816789; cv=none;\n d=google.com; s=arc-20240605;\n b=gQBye0vjAdsXrXSqzVDldqIeAqui9JKDBzTtuSoY7qybTz+2yyT8TPxlNqbHDM6aem\n CzAIWsKarW/YCbSqp5hMHPa6bWcQbXCOAzWzf1/zdGIxwN20PgZTfyrcYPjeCqQYlBHr\n 5sa/xM7+miJCpSa5mDSd9KehUE25KTvBtuYoowAgjj4EymRnXNotaCiTdkoF+pETL6sH\n xESlQKU5RAv/tgjd4Dg4NxUbG1zxRcQ5m1KUeNkYWOYEb1S6YSnywzTtKFF1beT7tXCS\n gaHl25zl9gaWSAsbiMh6D0h3V1fy7N/Rjfnl3VVMPlEy0bySfpalM97zRlnP/waaRtfz\n NVFg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=jyjfIQcSftFAylXzsKPrC0AWe0hc9g5QRAy3Jh+Tdjg=;\n fh=W+sppDaEmylgYtfj8wklqZS5+WrCEISPF8M8G6j8M6g=;\n b=JWD9r3K9ti7L3lgxAA8XOOS6HjHNxtR7HGeah2WuhCxkzu0vWIu1hiGRj7SDNdmbyG\n /D+3iHjRxWz3DxMBI3UUWeWhFPznMldIKmMQJCQlZoe3JwOeLqwPrJWGCV6kCXb3pg4i\n w26QdUu+bNggJk10FRpj561brQ+wHjjIyymPucMMTQtGrDRKZL/MltQCJNE+7EXwNODV\n D/+Uba8pPL+IfeXMCuOIMqKQvVMF5mfDrhWzYEonAVp2YqQpReGfnv/SsV0CNSHsqqaQ\n +DcUFbfkz+9c4Va3NaEb21x5Xb6QeF8vQsmyII7VFd6gwGQ6wN/GC9EtA4In5j1sobuT\n pyyg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776816789; x=1777421589; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=jyjfIQcSftFAylXzsKPrC0AWe0hc9g5QRAy3Jh+Tdjg=;\n b=fOIIs5N55ZNK0BbV8SeB4S+bBil4nmpcyJKpPY1t5uqn2wCCF8GDdXnkIsigrAlhD3\n YloxXM/YBk04U36R6EeM4DDnl9hfC7/zfpXXTk3Q4A5oEbOEQlc1Fj0ukGYhnEQ1swRv\n ieFU3xltZdAt5+UdWQPSeBqhjkYKeNdtIPbVQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776816789; x=1777421589;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jyjfIQcSftFAylXzsKPrC0AWe0hc9g5QRAy3Jh+Tdjg=;\n b=PiDT2Omc/m6qyI+bmj4uN0CYpc808tk+QZDqnp1grpms02PO0cBq8DbjHh77uiRCBB\n fC1y2XGnSiJHThBc9m3SJlfvOr+zLvsZpAwTcOoXsslt8ST+oBu8+o6IgQ9Nwl7xzblT\n rGkYKTNMVMrsaqFd6ESmYdxRWSCkx8NDwnFAFlsip0xttGKUOTJJXH30Jz+3mTjX2ZBc\n IxMBvqPVQrG7qIv0HeFiVh/9iXx/IZl8b9fd63aNJutOWNA55yD1Z5nD+WDIT42keGWE\n YFYKn5ILQhn2zEBrPmwwjIFAPHIpGRfvrN7ub3F48ZH0yWFsbjGlJ5o1hhiDmtYfQQD6\n 9Nkg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Z9r0bXKXakpNtgXugXock9yqcRMppLmknpfsX0QmK2R38bL7Au6vWXlnCqfXXHWmR4pSJjb0=@lists.denx.de","X-Gm-Message-State":"AOJu0YyjJ4ueJyw5m4P55vtB3bjqv6do2NwDv9o9+PEL5IiXTAsYFLcY\n f+fGvfi0uRwvkGoY27Z5r9iUMTJkElrpu8pVe8DFiF47F0VS/qI9X4eg148dpLx9lEEnajOAlLb\n UYj9Su+vnoZGZ5uWmsc4xFSK3muF9QtHRP6QlH4s+","X-Gm-Gg":"AeBDietY94zL+rFljZ7A1VMgnNHBHI3fTjSlO6VAqDxEpYD7BBY09lRto67fVkejA+c\n pPIL50J6fl0ojfL7G73Y+phBsol2V9NzIjAgPLlBonq5CxX+Uari/lR1HwvZZtPu95GCvpm95uD\n 7zpwC66kAMo4Rd3HxrHVGhNsaIoxQRg5hSTqtTtunjGkbyxNhsLb6LWOfxMd2pdjjHIDs8An2cu\n lFeWY4JDHHMGzhx+hmMoVIkM3FdFsYzgA3Qc6XjD8JkAqjbMDC0s6gqYSxoocJpiDF+YOTtlDJU\n RlG9xEIVYpfrDrVc4oJq","X-Received":"by 2002:a17:906:8e15:b0:b9c:4fa:9141 with SMTP id\n a640c23a62f3a-ba419077377mr894224466b.9.1776816789346; Tue, 21 Apr 2026\n 17:13:09 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421210954.1170437-1-philippe.reynes@softathome.com>\n <20260421210954.1170437-7-philippe.reynes@softathome.com>","In-Reply-To":"<20260421210954.1170437-7-philippe.reynes@softathome.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 12:12:56 +1200","X-Gm-Features":"AQROBzCBBOIy6JCV0GOBaDaHmHCMcV4pLEdNS-sRKS77buW78PVJpQbs5hFGg8E","Message-ID":"\n ","Subject":"Re: [PATCH v5 06/15] test: dm: ecdsa.c: clean this test as software\n ecdsa is now implemented","To":"philippe.reynes@softathome.com","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]