[{"id":3680148,"web_url":"http://patchwork.ozlabs.org/comment/3680148/","msgid":"","list_archive_url":null,"date":"2026-04-22T00:10:54","subject":"Re: [PATCH v5 03/15] ecdsa: initial support of ecdsa using mbedtls","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Philippe,\n\nOn 2026-04-21T21:09:51, Philippe Reynes wrote:\n> ecdsa: initial support of ecdsa using mbedtls\n>\n> Adds an initial support of ecdsa verify using mbedtls.\n>\n> Signed-off-by: Philippe Reynes \n>\n> include/crypto/ecdsa-uclass.h | 15 +----\n> include/crypto/internal/ecdsa.h | 39 +++++++++++\n> lib/mbedtls/Makefile | 3 +\n> lib/mbedtls/ecdsa.c | 146 ++++++++++++++++++++++++++++++++++++++++\n> 4 files changed, 189 insertions(+), 14 deletions(-)\n\n> diff --git a/include/crypto/internal/ecdsa.h b/include/crypto/internal/ecdsa.h\n> @@ -0,0 +1,39 @@\n> + * @pubkey : ecdsa public key\n> + * @hash : Hash\n> + * @hash_len : Size of the hash\n> + * @signature : Signature\n> + * @sig_len : Size of the signature\n\nThe kernel-doc style uses no space before the colon. Please can you\nuse @pubkey: etc.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=MAmDqVXh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"MAmDqVXh\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0flT6MrMz1yGs\n\tfor ; Wed, 22 Apr 2026 10:11:17 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CF10B8352B;\n\tWed, 22 Apr 2026 02:11:10 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id F038483BC8; Wed, 22 Apr 2026 02:11:09 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1614F805D7\n for ; Wed, 22 Apr 2026 02:11:08 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-ba8472c1613so430596666b.0\n for ; Tue, 21 Apr 2026 17:11:08 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776816667; cv=none;\n d=google.com; s=arc-20240605;\n b=Apv0wJ+FkOXs06EhvsADTujgNWxQ0Rzrq0PKCXEvf/P3quwjzu6DfvOkDGcHq/XVs2\n +WN+RGytL8tPQdooEbff0xUu2cEjoEGrYO0rJjfalrUVBD92BKy6WoaRH1Cf06g0AvSK\n fOUIrRqDXJ94T/H+p8WnLo7ytmFdRu6JQSiYK+nTDpeEHIAAZsxeCs/oscVQHCs2ccJn\n kgU/w6+RQbgCr/2ekc9p8GnQ0nHNnUBHnpG/p6eti+6nJR6bTexxgFvGvoNAVtGnvEU0\n utNFsEAj/hgKOzBDuXkLKTQDL03Ts+mrR6QFydlZR3fn1LSHeygb9Wsu5zTU98p97M4x\n IEhw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=TL4r1tdGjUnwEXTXhpc7lA+MRbNVa5uxrUyWPErcVsc=;\n fh=ayJuwa4Uc6vWMTHhvM545NH9C0PrVSSSMfPknYNDaJQ=;\n b=HG4Zsle5el32iGPcLDxU55SgzthPyvoT0/0QifRvQROnHqi4012b2aKoUyG7NHcHFZ\n IwmkUVYbIw+oZjCh30fFQ2Cgn2h8X0h1IrnCVcri2Sv5sIhKdzyJtKC6bJYruEbRXRCO\n rism80vdD8WsjWN5O6iTP8SqPmkKN1CSQXWLuoWMludz729G5h9o9Gad5dh7ZfNO3caO\n wS5O4VkYCZfvpr9muy07+bQm8phXc5pS9nppcjpuH7pxKeNvzh0XBpKbA+85kEwAuKlm\n u82nzRyFFzGF4pzGSoxN06h8/FJlYW7jzq8WPXmCcag4KBeKL7kzxq2aJkNwnLs0EHai\n g1vw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776816667; x=1777421467; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=TL4r1tdGjUnwEXTXhpc7lA+MRbNVa5uxrUyWPErcVsc=;\n b=MAmDqVXhF/czGc66bb/VRK5cATNiC5mt7zJ4DZ6jZZewZDYSa7p0PcHQI4sMibYWvE\n UBdzBwCSyG3KGRBVBnZLGyDBv/AuokGCJEE4QKQLci1IOBSdz0qmQPr0BSr970wKi5GC\n YIcnU21Hn/Xl6FmRvcO9LI68vMVbA0ZDfcKLw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776816667; x=1777421467;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TL4r1tdGjUnwEXTXhpc7lA+MRbNVa5uxrUyWPErcVsc=;\n b=YRCZU+fx8SLrujahHd+CHYdw5K5w9/5lt7/4OYI0soDGe+VU/DI1yJ+DdiOg60jYCI\n dfdaVAUB+wMN578GcosVBJ4PqrFixSjm3e+X17CiST7cKXJBx6X06HvBs4cRq0MDzsjT\n Dyi5hZ8M3EcMzFN8+Rpg2crZ3wtv1/waldQkkdangtlN6G75crn7ZxQ4KLsYgrx5PFKQ\n 4yAugro8eMicqgfS7YX9nu/FUWdze79evAj+6gMHUqRls0trpSn6679CsBGbs4tlSu1q\n RmMcEEoTsiCVcU7Jw3ZzIh0JqlnbhWPT3YZ7PWRN/KNL8wz/XnPk/uOW31J5mT9rco1R\n /rlQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9I152UjK3Y0/K4FSg/7tWWAEMip/rseYMEFPYzX8+KCuiE2g6aEWhPpVkBYGvghyotxyiIXfs=@lists.denx.de","X-Gm-Message-State":"AOJu0YxakwMhr3i9uLQ20mhtJVLXHQK4ad2UsP7W3WlqhCA9MWCCMK0g\n 4b6jpU/+2yt+IMcDo055F82hhGSOfBh1hCIB4Y96IiCvHW4B41/e2xnemJkMQFEZpKGYkveaEUf\n EgqXT/Tn2Fn59BKa2xRgCWt3TLyCH77LE6pN7IVor","X-Gm-Gg":"AeBDiesBjNmqEHKw93CrX8uWr7vpbc2wbeF7Zm2Cly7NzIq5Jl1zquJEeCbrMc43qU7\n TBA2ZV6GM1TvAkY8SFrJYrwDBrSGPGb1lKkea00fJjBsCw8NP6fnsrQoZtAimI1Rk7jrMWyVoVe\n 6LO5dqfqT/LsoUhM34AFg7y/nR1qZs+1tM9pWsqZ54fyuqLM5eBiybgpwwLDDakKuoNFA9g0V5m\n 9FsQMTUCiFv3FHZ7wLJSFMTi1TqtOHCMmXyxMXR2OBs2eh01GPXjvxrWlncL1DE8PTDcprBJdJa\n rsvRgS73277iHI1hEsgE","X-Received":"by 2002:a17:907:3f9b:b0:ba8:bcb3:e2d0 with SMTP id\n a640c23a62f3a-ba8bcb3eaabmr449489866b.0.1776816667147; Tue, 21 Apr 2026\n 17:11:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421210954.1170437-1-philippe.reynes@softathome.com>\n <20260421210954.1170437-4-philippe.reynes@softathome.com>","In-Reply-To":"<20260421210954.1170437-4-philippe.reynes@softathome.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 12:10:54 +1200","X-Gm-Features":"AQROBzBMMiCjVDIi6Sl52vATlSUNDyJ5CsX6Q-w7DW-BVB9fb2kvEkUGhYPETyo","Message-ID":"\n ","Subject":"Re: [PATCH v5 03/15] ecdsa: initial support of ecdsa using mbedtls","To":"philippe.reynes@softathome.com","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]