[{"id":3680150,"web_url":"http://patchwork.ozlabs.org/comment/3680150/","msgid":"","list_archive_url":null,"date":"2026-04-22T00:12:03","subject":"Re: [PATCH v5 05/15] drivers: crypto: add software ecdsa support","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Philippe,\n\nOn 2026-04-21T21:09:51, Philippe Reynes wrote:\n> drivers: crypto: add software ecdsa support\n>\n> Add a software ecdsa driver so it is\n> now possible to use ecdsa signature on\n> board without ecdsa hardware support.\n>\n> Reviewed-by: Raymond Mao \n> Signed-off-by: Philippe Reynes \n>\n> drivers/crypto/Makefile | 1 +\n> drivers/crypto/ecdsa/Makefile | 6 ++++++\n> drivers/crypto/ecdsa/ecdsa-sw.c | 33 +++++++++++++++++++++++++++++++++\n> 3 files changed, 40 insertions(+)\n\n> diff --git a/drivers/crypto/ecdsa/ecdsa-sw.c b/drivers/crypto/ecdsa/ecdsa-sw.c\n> @@ -0,0 +1,33 @@\n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n\nThe include of u-boot/ecdsa.h does not appear to be needed - this file\nonly calls ecdsa_hash_verify() which is declared in\ncrypto/internal/ecdsa.h. I may be missing something though.\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=PIo8ILuD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"PIo8ILuD\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0fmk0dMVz1yGs\n\tfor ; Wed, 22 Apr 2026 10:12:22 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DD23B8412A;\n\tWed, 22 Apr 2026 02:12:19 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A2BA184198; Wed, 22 Apr 2026 02:12:18 +0200 (CEST)","from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n [IPv6:2a00:1450:4864:20::62b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BB8888352B\n for ; Wed, 22 Apr 2026 02:12:16 +0200 (CEST)","by mail-ej1-x62b.google.com with SMTP id\n a640c23a62f3a-b79f8f7ea43so657332966b.2\n for ; Tue, 21 Apr 2026 17:12:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776816736; cv=none;\n d=google.com; s=arc-20240605;\n b=I+Af/F+Pl1wgAnB33jcf8loQk03An+EDRPxQlBD3bxDCKRhe6m1CNOEvW5VvD720mP\n U20k9wEPcTDoGzmueaoe8hlspWoTScTDEBx0pxzJ3ophMcn0T9iRz2iPCJ36iW4BaF9i\n oqPGYCPzTc8tq2YTAJ3zEWc5bEy2cyz1HLhqBaWfq/uVsdlSKm0acbALrouU2IP7Qadp\n 5TN0CIw74lpxyQ1lEoJoQuKjLB5/qeerSxKnam8/ytzrm8iWL9ny0c16/Xu2TtTbQtUD\n zJUADqoMaBSBnG71xPK9scTWqDB20udrviPIxzsDlshUHfnBWvdvCbyYGHg33cKI1AsC\n ANOw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=d0fn4JTiBcL/Or/JqFPUv5LhQmQpXkuYxJ/udobwL+Y=;\n fh=I6CTiDPzeA+BW8DYWutm03yjh1GNqU0SVuKgjx4bg08=;\n b=euhP7nlFR/rzZf2emFhrqL1YFSDDZWXsrwWRR1RCgxs5NXGr2Kc/uvJFePRnT1cvLb\n uOVB37GlxmxwEnEX6bu08b9aZ8qWSK8DW+a9oIMmcQZNGDd8/tKnWltsq82Pvmdo2lz9\n gxvjK3SlR+2kN17Eplual24LTL8NrOkXVU5bhKCdo5PyrEybJkAXEOil1g3452NKYm84\n YHz4GYUAzQv+qhJ6WpM1H4dvLUztJaVCyeTHHgV6irm0hTHHwxlykF/eY1fJX7eplONa\n jiLZ5OpnqrNdEDFGLqe35+1o3uMmZkKv+m+xh3Zh3cyeXktJFbGbAsmCWc3aSSdlErG7\n /s3Q==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776816736; x=1777421536; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=d0fn4JTiBcL/Or/JqFPUv5LhQmQpXkuYxJ/udobwL+Y=;\n b=PIo8ILuD4u45qBgJPdtNuQ+HlXGHMbwRXR2vjehwoh6oTmYSzfjtKcfpsn069YHHII\n RBtTh+JLB//dIlT8qJ5EgPiYDg3Wb3AJlEqlDx6Og+dBW8f9oxqxitVPmskoqZ/1edwS\n LoG6B1qNY16HTJASw9DzoZLOlFmLEWiQ0SwTE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776816736; x=1777421536;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=d0fn4JTiBcL/Or/JqFPUv5LhQmQpXkuYxJ/udobwL+Y=;\n b=hQM4Oz3B2x79rz+Klit4EUtQxbgwdJszl1a0zYJXtUccVxafkEkRgW/utvDTw+ioRp\n EMawUiSOvcCrg6UIrExfYIMdtrjM7HiRkox9dTU05YVlEwp6JRmqIlFliFA7x05kV7DX\n DSXjir6sigziPWkEo9QZwxOLU1GhFtSpOCizY5f41ZT37sqFpe0hzTPqCPD4jl1tiFpm\n /O9bGgsL5HOuWZPLLvNRcHrNayfZThD6y8T0P+uuSpclMXteVksqM6n2GF+5d8JJVkRS\n dgufvkjm3GFBLOaKPQuiUD1AStlYBfRx7nWzpFq8QFO12EagexqOto05wDICGV0PD/RX\n RuHA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9b5IXNmYjr1NJOuLkJv56WWVAuxQnDj8srx7eccM6mCSmUOhKDLw1G86POqYYnIJyAgdUjZ1Q=@lists.denx.de","X-Gm-Message-State":"AOJu0YzilD6oFvS0xJ0qQo0ara7V6sAsU4g5Pj9svtNDgSsx6vYJFXXz\n 0Y61BrwB6wRpCITU2WtlIY9MyE1AAOztKLC03zTwSOu2c6F0pUC6DNTWMw2LM/nbYSvS2m7frAZ\n 2nQw0YPwV3VpDaYbziedNPPdYuDQ0C+qtuIWBp9pi","X-Gm-Gg":"AeBDiesUH45wRqYMY1+tkqe9Gar3E5xXDVtNjh8geEulO9+lzwDARBSg5iHTdyqjf6H\n 2qmRo0kCAoeSWDyF9uUEOfY3ByVqMSZY18/XV1LqiOmX2+pxCa1mPlsxG2/PLGXbvyQbZ1iMZab\n ejZ6RJApCtFOH+dETdAoPKXvuAv4MY0HtJ7/qfCJ2Z5JbdwgW6ewF2sydeua06/W0nKCllG+9/W\n JuO2QZzZHXmxwBfq2valPGUiO0AVLS+MqMzjlEMqDnW10AIyuMRnJ8nwgOnbMeJgnGnE9sKsqOi\n yq9L5B9TEqqc5pn8bBjk","X-Received":"by 2002:a17:907:980e:b0:ba8:30a6:c35a with SMTP id\n a640c23a62f3a-ba830a6c3acmr483601866b.6.1776816736165; Tue, 21 Apr 2026\n 17:12:16 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421210954.1170437-1-philippe.reynes@softathome.com>\n <20260421210954.1170437-6-philippe.reynes@softathome.com>","In-Reply-To":"<20260421210954.1170437-6-philippe.reynes@softathome.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 12:12:03 +1200","X-Gm-Features":"AQROBzDguFxO3A5q22yNc24y752FWW1iVVhtC9uvg3gKzqc2K2Kf-dhv9UHqYtg","Message-ID":"\n ","Subject":"Re: [PATCH v5 05/15] drivers: crypto: add software ecdsa support","To":"philippe.reynes@softathome.com","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]