[{"id":3680281,"web_url":"http://patchwork.ozlabs.org/comment/3680281/","msgid":"","list_archive_url":null,"date":"2026-04-22T07:51:12","subject":"Re: [PATCH v2 16/16] vfio/migration: Add tracepoints for\n precopy/stopcopy query ioctls","submitter":{"id":85406,"url":"http://patchwork.ozlabs.org/api/people/85406/","name":"Cédric Le Goater","email":"clg@redhat.com"},"content":"On 4/21/26 22:21, Peter Xu wrote:\n> Add two tracepoints for both precopy and stopcopy query ioctls. When at\n> it, add one warn_report_once() for each of them when it fails.\n> \n> Signed-off-by: Peter Xu \n\n\n\nReviewed-by: Cédric Le Goater \n\nThanks,\n\nC.\n\n\n> ---\n> hw/vfio/migration.c | 33 +++++++++++++++++++++++----------\n> hw/vfio/trace-events | 2 ++\n> 2 files changed, 25 insertions(+), 10 deletions(-)\n> \n> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c\n> index e6e6a0d53d..04d9f94edb 100644\n> --- a/hw/vfio/migration.c\n> +++ b/hw/vfio/migration.c\n> @@ -329,6 +329,7 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n> struct vfio_device_feature_mig_data_size *mig_data_size =\n> (struct vfio_device_feature_mig_data_size *)feature->data;\n> VFIOMigration *migration = vbasedev->migration;\n> + int ret;\n> \n> feature->argsz = sizeof(buf);\n> feature->flags =\n> @@ -340,12 +341,18 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n> * is reported so downtime limit won't be violated.\n> */\n> migration->stopcopy_size = VFIO_MIG_STOP_COPY_SIZE;\n> - return -errno;\n> + ret = -errno;\n> + warn_report_once(\"VFIO device %s ioctl(VFIO_DEVICE_FEATURE) on \"\n> + \"VFIO_DEVICE_FEATURE_MIG_DATA_SIZE failed (%d)\",\n> + vbasedev->name, ret);\n> + } else {\n> + migration->stopcopy_size = mig_data_size->stop_copy_length;\n> + ret = 0;\n> }\n> \n> - migration->stopcopy_size = mig_data_size->stop_copy_length;\n> + trace_vfio_query_stop_copy_size(migration->stopcopy_size, ret);\n> \n> - return 0;\n> + return ret;\n> }\n> \n> static int vfio_query_precopy_size(VFIOMigration *migration)\n> @@ -353,18 +360,24 @@ static int vfio_query_precopy_size(VFIOMigration *migration)\n> struct vfio_precopy_info precopy = {\n> .argsz = sizeof(precopy),\n> };\n> -\n> - migration->precopy_init_size = 0;\n> - migration->precopy_dirty_size = 0;\n> + int ret;\n> \n> if (ioctl(migration->data_fd, VFIO_MIG_GET_PRECOPY_INFO, &precopy)) {\n> - return -errno;\n> + migration->precopy_init_size = 0;\n> + migration->precopy_dirty_size = 0;\n> + ret = -errno;\n> + warn_report_once(\"VFIO device %s ioctl(VFIO_MIG_GET_PRECOPY_INFO) \"\n> + \"failed (%d)\", migration->vbasedev->name, ret);\n> + } else {\n> + migration->precopy_init_size = precopy.initial_bytes;\n> + migration->precopy_dirty_size = precopy.dirty_bytes;\n> + ret = 0;\n> }\n> \n> - migration->precopy_init_size = precopy.initial_bytes;\n> - migration->precopy_dirty_size = precopy.dirty_bytes;\n> + trace_vfio_query_precopy_size(migration->precopy_init_size,\n> + migration->precopy_dirty_size, ret);\n> \n> - return 0;\n> + return ret;\n> }\n> \n> /* Returns the size of saved data on success and -errno on error */\n> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events\n> index 287df0b8cb..854a7e4b19 100644\n> --- a/hw/vfio/trace-events\n> +++ b/hw/vfio/trace-events\n> @@ -176,6 +176,8 @@ vfio_save_setup(const char *name, uint64_t data_buffer_size) \" (%s) data buffer\n> vfio_state_pending(const char *name, uint64_t stopcopy_size, uint64_t precopy_init_size, uint64_t precopy_dirty_size, bool exact) \" (%s) stopcopy size %\"PRIu64\" precopy initial size %\"PRIu64\" precopy dirty size %\"PRIu64 \" exact %d\"\n> vfio_vmstate_change(const char *name, int running, const char *reason, const char *dev_state) \" (%s) running %d reason %s device state %s\"\n> vfio_vmstate_change_prepare(const char *name, int running, const char *reason, const char *dev_state) \" (%s) running %d reason %s device state %s\"\n> +vfio_query_stop_copy_size(uint64_t size, int ret) \"stopcopy size %\"PRIu64\" ret %d\"\n> +vfio_query_precopy_size(uint64_t init_size, uint64_t dirty_size, int ret) \"init %\"PRIu64\" dirty %\"PRIu64\" ret %d\"\n> \n> #iommufd.c\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dp6GUs+E;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=nKgMNT+G;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0rz61jbqz1y2d\n\tfor ; Wed, 22 Apr 2026 17:52:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFSMk-0002fF-BH; Wed, 22 Apr 2026 03:51:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFSMi-0002f1-UR\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 03:51:21 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFSMh-0005xt-6u\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 03:51:20 -0400","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-539-JRwK8gwbPMmCV2wtgaqL4w-1; Wed, 22 Apr 2026 03:51:15 -0400","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-48a55ecc249so10810345e9.1\n for ; Wed, 22 Apr 2026 00:51:15 -0700 (PDT)","from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c?\n ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a55dc9f58sm247407695e9.6.2026.04.22.00.51.12\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 00:51:13 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776844277;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=Hpuf+M4UmIbCe/RfxqV7TXZA+yAkP158DxqJdHpPHCk=;\n b=dp6GUs+ETVlWKtTDo4gevRMB8B7J0tDy4g8ryIQXOt8dFknE+xLX9rIW1zRfaCtRwWfAg/\n FS7zRbVJG87YaexacjFK8K3Q8X8X4d9/KupqU8J+Pymdv7fDbgP05nC5ADBTmHmvx6Zgy5\n m+3M9S5aGh+pcYjoSjSx5jgNwzjROjY=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776844274; x=1777449074; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=Hpuf+M4UmIbCe/RfxqV7TXZA+yAkP158DxqJdHpPHCk=;\n b=nKgMNT+GttBUT7TDk4O4sRCa+/7dVXvKz2ISquapzOhXB1fBgX0hgnuRHMjnl1TVzC\n 4R9m+OVS8+uxodanEtbMKXukdjmp+vzBEzw+IQTyEflokTNYcI9nCiLjqr3G3KttgjAJ\n mssdPlMjsohdxSidSUhVH1om5UY6KkICqwBiaXePLgpmMVZW6r7Q7doK45yyp/ATVibP\n RuRynjzbF9smyPBFD1ASVzGKafSiTPdkgayfNNRrCXrMclgwMXwOMGZ3CbunZl04d2JA\n t6mW4AroF5B/FVkn0309ww6B/W8EAB9CFX6yWdHcNyTrgWy7BZ7oK4bWm6dBGuGnNOXu\n HZDw=="],"X-MC-Unique":"JRwK8gwbPMmCV2wtgaqL4w-1","X-Mimecast-MFC-AGG-ID":"JRwK8gwbPMmCV2wtgaqL4w_1776844274","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776844274; x=1777449074;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Hpuf+M4UmIbCe/RfxqV7TXZA+yAkP158DxqJdHpPHCk=;\n b=gNTLyWJz1yhH65s4YMFrW63WQ7funyIs87xDV26GL4BNtA3o7DaNMnFjV5DsStYLUm\n LZglt0Bi00ZUI15Ef93SOr80wf/qdQlBb3RxonG0Uf1JVezGJ6NOyQ6wO2YKy3uJK/3+\n w9YwKL+s1NbRYvE72ONfIATtc/MKT4UuDqN+0j7xQrtsTHhQLO2Wx6FcDeMhB8XApUIP\n VqOA8ty0dWdU+iEUsqsuDqwAZqmlkzA6wDW5EIo0WfSxyNbaBA2IpCTjMAxOL01Jrq32\n HFnnB31VgjJWZoywhUv/BaZCK/8urRH316xqKnIQBQkPMetXLQmDW3WNODo8WwSGJzZ8\n OXhw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/EskFZ3FQMgCbGX4r2sN3LrvfaiHEyhzsD13Q7Q4NoPlayibuz5BRZykgywQ2mGMD//B4oJNS6Ackn@nongnu.org","X-Gm-Message-State":"AOJu0YwDdU+wSL/7iib8N56BQxkBHplXUoVxbHL02BS3qfmWhwrYji5J\n +26GFGTWbm65hxSmjcQ7jCV1RJYO5fOPvszMlRI0+b5nDwJYgjRN/6vy+zu9SWqBhmIasZ+Jm4X\n f3nQyUNKXNDYkrett6ioLNpNQv4IxYi6/S10lhiUQPVaELyigNWi1T4ws","X-Gm-Gg":"AeBDievCQJ4tUi5SUKSxuE9sOjODLnsS8T1p//e1qcy+aFNiRomo+JNHRUDTUHqwjNk\n 2E/9FOA3oIEtu2/QIO439pgyDTR/b8yBKRO+WmK7FaI9GDjjqJeG3uEvL0BiJ9cVvMcwXFaaTDn\n Jz4nmJxBrW6Cd4imv/e+UWsDwfiilxQPkBc8lPeAboRICBw/BZtuvGzkpQWo6uXJTemmi17yDjs\n I2UoVnMuvY31HQ044njo18sQk2t7bQIcwEfrpaqI7WhpgEonDLphOOOFbmTAd9S+RAUyuTBNz0r\n 5ARCsPYalMWj+WdOYjduUZQFiYIPn2q+dWdJb7mDmsUa6GuSwRpYT/JrIsKiPy8g5cIV/3S/LUR\n yjkIi/jTIHkQa8d/lTb69idBkPLps6IgXqYP2n8rlXHdJRSZqPiSkgOhnnjvSmuSRh+BDav0=","X-Received":["by 2002:a05:600c:3150:b0:480:3ad0:93bf with SMTP id\n 5b1f17b1804b1-488fb7930famr312657135e9.24.1776844274316;\n Wed, 22 Apr 2026 00:51:14 -0700 (PDT)","by 2002:a05:600c:3150:b0:480:3ad0:93bf with SMTP id\n 5b1f17b1804b1-488fb7930famr312656555e9.24.1776844273772;\n Wed, 22 Apr 2026 00:51:13 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 22 Apr 2026 09:51:12 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 16/16] vfio/migration: Add tracepoints for\n precopy/stopcopy query ioctls","To":"Peter Xu , qemu-devel@nongnu.org","Cc":"Joao Martins ,\n Markus Armbruster , Avihai Horon ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Fabiano Rosas , Prasad Pandit ,\n Alex Williamson , Kirti Wankhede ,\n Zhiyi Guo ,\n \"Maciej S . Szmigiero\" ,\n Juraj Marcin ","References":"<20260421202110.306051-1-peterx@redhat.com>\n <20260421202110.306051-17-peterx@redhat.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Autocrypt":"addr=clg@redhat.com; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7\n 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg//\n S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY\n lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh\n EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71\n xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl\n hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8\n VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy\n k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ\n RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS\n 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi\n V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW\n pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ\n KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp\n bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6\n TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU\n CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS\n YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g\n LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7\n JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu\n jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx\n IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k\n 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK\n yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j\n hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop\n s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p\n LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU\n wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU\n XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA\n HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ\n izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD\n uVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260421202110.306051-17-peterx@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=clg@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3680284,"web_url":"http://patchwork.ozlabs.org/comment/3680284/","msgid":"","list_archive_url":null,"date":"2026-04-22T07:52:25","subject":"Re: [PATCH v2 16/16] vfio/migration: Add tracepoints for\n precopy/stopcopy query ioctls","submitter":{"id":85406,"url":"http://patchwork.ozlabs.org/api/people/85406/","name":"Cédric Le Goater","email":"clg@redhat.com"},"content":"On 4/21/26 22:21, Peter Xu wrote:\n> Add two tracepoints for both precopy and stopcopy query ioctls. When at\n> it, add one warn_report_once() for each of them when it fails.\n> \n> Signed-off-by: Peter Xu \n\n\nTested-by: Cédric Le Goater \n\nThanks,\n\nC.\n\n> ---\n> hw/vfio/migration.c | 33 +++++++++++++++++++++++----------\n> hw/vfio/trace-events | 2 ++\n> 2 files changed, 25 insertions(+), 10 deletions(-)\n> \n> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c\n> index e6e6a0d53d..04d9f94edb 100644\n> --- a/hw/vfio/migration.c\n> +++ b/hw/vfio/migration.c\n> @@ -329,6 +329,7 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n> struct vfio_device_feature_mig_data_size *mig_data_size =\n> (struct vfio_device_feature_mig_data_size *)feature->data;\n> VFIOMigration *migration = vbasedev->migration;\n> + int ret;\n> \n> feature->argsz = sizeof(buf);\n> feature->flags =\n> @@ -340,12 +341,18 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n> * is reported so downtime limit won't be violated.\n> */\n> migration->stopcopy_size = VFIO_MIG_STOP_COPY_SIZE;\n> - return -errno;\n> + ret = -errno;\n> + warn_report_once(\"VFIO device %s ioctl(VFIO_DEVICE_FEATURE) on \"\n> + \"VFIO_DEVICE_FEATURE_MIG_DATA_SIZE failed (%d)\",\n> + vbasedev->name, ret);\n> + } else {\n> + migration->stopcopy_size = mig_data_size->stop_copy_length;\n> + ret = 0;\n> }\n> \n> - migration->stopcopy_size = mig_data_size->stop_copy_length;\n> + trace_vfio_query_stop_copy_size(migration->stopcopy_size, ret);\n> \n> - return 0;\n> + return ret;\n> }\n> \n> static int vfio_query_precopy_size(VFIOMigration *migration)\n> @@ -353,18 +360,24 @@ static int vfio_query_precopy_size(VFIOMigration *migration)\n> struct vfio_precopy_info precopy = {\n> .argsz = sizeof(precopy),\n> };\n> -\n> - migration->precopy_init_size = 0;\n> - migration->precopy_dirty_size = 0;\n> + int ret;\n> \n> if (ioctl(migration->data_fd, VFIO_MIG_GET_PRECOPY_INFO, &precopy)) {\n> - return -errno;\n> + migration->precopy_init_size = 0;\n> + migration->precopy_dirty_size = 0;\n> + ret = -errno;\n> + warn_report_once(\"VFIO device %s ioctl(VFIO_MIG_GET_PRECOPY_INFO) \"\n> + \"failed (%d)\", migration->vbasedev->name, ret);\n> + } else {\n> + migration->precopy_init_size = precopy.initial_bytes;\n> + migration->precopy_dirty_size = precopy.dirty_bytes;\n> + ret = 0;\n> }\n> \n> - migration->precopy_init_size = precopy.initial_bytes;\n> - migration->precopy_dirty_size = precopy.dirty_bytes;\n> + trace_vfio_query_precopy_size(migration->precopy_init_size,\n> + migration->precopy_dirty_size, ret);\n> \n> - return 0;\n> + return ret;\n> }\n> \n> /* Returns the size of saved data on success and -errno on error */\n> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events\n> index 287df0b8cb..854a7e4b19 100644\n> --- a/hw/vfio/trace-events\n> +++ b/hw/vfio/trace-events\n> @@ -176,6 +176,8 @@ vfio_save_setup(const char *name, uint64_t data_buffer_size) \" (%s) data buffer\n> vfio_state_pending(const char *name, uint64_t stopcopy_size, uint64_t precopy_init_size, uint64_t precopy_dirty_size, bool exact) \" (%s) stopcopy size %\"PRIu64\" precopy initial size %\"PRIu64\" precopy dirty size %\"PRIu64 \" exact %d\"\n> vfio_vmstate_change(const char *name, int running, const char *reason, const char *dev_state) \" (%s) running %d reason %s device state %s\"\n> vfio_vmstate_change_prepare(const char *name, int running, const char *reason, const char *dev_state) \" (%s) running %d reason %s device state %s\"\n> +vfio_query_stop_copy_size(uint64_t size, int ret) \"stopcopy size %\"PRIu64\" ret %d\"\n> +vfio_query_precopy_size(uint64_t init_size, uint64_t dirty_size, int ret) \"init %\"PRIu64\" dirty %\"PRIu64\" ret %d\"\n> \n> #iommufd.c\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YSXH3zKW;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=syDQje4j;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0s0H1J4nz1y2d\n\tfor ; Wed, 22 Apr 2026 17:53:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFSO1-0002uQ-0q; Wed, 22 Apr 2026 03:52:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFSNt-0002rN-IK\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 03:52:35 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFSNr-0006F0-OF\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 03:52:33 -0400","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-231-HKC3lorcPTiKlA3Cudlhug-1; Wed, 22 Apr 2026 03:52:29 -0400","by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-488d1b5bca0so28232665e9.2\n for ; Wed, 22 Apr 2026 00:52:29 -0700 (PDT)","from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c?\n ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb755938sm179438345e9.3.2026.04.22.00.52.26\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 00:52:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776844351;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=5csxU3hR9C3BM5+Oi92q6/uRD9VcEGCveeGP8reuJXs=;\n b=YSXH3zKWSzvg63YoMAWYD6MwaxxVQVwqri9DOes5AZsdwyifwiy0b9mYzz3/Xwy0iWzocj\n iWakKtZsHEU9jiGflI3nv8xvhm14ryq6+2K4joAHCv5oRzJ39oYR8L9Z6K/E8JSkHYdQOt\n 5NyiKn0QFnVMWNMzjRmzAcSzyFXKmsA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776844348; x=1777449148; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=5csxU3hR9C3BM5+Oi92q6/uRD9VcEGCveeGP8reuJXs=;\n b=syDQje4jCsPfk95En6xXBwP/8X1KMSMKuycOsVDs4JGwSBGl69xNFzrD9PkR5/8mih\n 00o3GplL/5G4rsjKuG3ikQR6TdngOIxwmEJxKVNXci0fuRYI1X/aJoVlznlP21v8Z9lI\n Q9eAvs8m/QmXd1z7SoMLGu41Xi4110LODR7xU1FaS+oizVXMZGOwDsVTdS85JgAVwhhj\n AfmxChHKW4cs9qp+ecSq8Z7V0wq1H2Abs+CWWtMOQHQvkhPV0dbO9LEsKsnfBWmxPawC\n 8Ic8tueUzd4pNFinP0FQjQJaF10n9jgJOqe6A2qOmgte9Ep2INKFSdHQ+Wewa+IFMhYg\n fVQA=="],"X-MC-Unique":"HKC3lorcPTiKlA3Cudlhug-1","X-Mimecast-MFC-AGG-ID":"HKC3lorcPTiKlA3Cudlhug_1776844348","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776844348; x=1777449148;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5csxU3hR9C3BM5+Oi92q6/uRD9VcEGCveeGP8reuJXs=;\n b=LtC6Qzb2OvGKe6lRR0FtIF3R2sNAaDJgDQfBfCPJ+gYm+6vff5fGeEAYIZIGoDFVZu\n UCruR1SpE+vaA7CgcnMC1hzGRfn8uKBNu9JYalko20AIMARt05NmaUkM0nnQ9fFRMfWa\n EH4BZteFKonP45zVIK+a4sGZZ7jBNYtOJGZyFP+5oATSRJ30uOjDdECZ3c0RVLHMoyvG\n NoS9qnaOXYHtwofMIkl47e+PnBOdt4AzLsqwinKouqwxZxOhSTluxWppuPOA8eIVXOni\n /ix4JoZEaYDq32ii2B4aoS3UK+Q/7CcHW1HAyyEJwmzEjJ2HJWBp0ElR1IjkmTiQzW0i\n kn/g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9vN1fBRT8Fh8SIBfHEplg/89BOuEDfVcy+hxb8APyFVMDu39lZAYZdxFiIReKWLAwcIAA6b4ANYaBU@nongnu.org","X-Gm-Message-State":"AOJu0Yzo2jNa8kVsCDfpRUXUh4y5Sc/fgQGeGJtvy0VTr1y7XMz6tANT\n sfubCm8FodDKeC9fmDB2rdXT9Mgn05uGWAb0Jba7Ajrm9hnjbnsgTScndTqjJ37CQpCgJIArbi6\n eewRRLf7DSAAEs/exlFJ831P0iziynpstNd743gPGglMftRqGXfRLaVux","X-Gm-Gg":"AeBDiesrE+JZdI68kWSlvdWt4gyKIyTver1yLQpW6+R/Cpu8F7TXvKoOV24ny4TK/3Q\n oWIUSqXsgG4OxHOif49umKG/vyse4pB0SQAM9+VDG04gFt5lt11eAGJhI5Bc2prSFkC2X+5CapN\n VjSRT2Ys0+1q1BnotVnku+30In7UO8Q5ONWlU/uWSBUeiTvb22YV5ptu29fuXs6itNDh6EnnS8C\n aVEQR79H9vBZgubFIXVTUo5gNJP9oCJIHPSWYfFWK8ztDC8Ejl7QvCEGWjF5fARFCd2eRQ0mS4y\n PiYW0pjLpxogvfxc732Du/7qRbLdDNvou4+rdyNKq5MLgZlTzuF640YKbmUDejTatA87fI7m4CN\n h/VAi7KHiTmCS9hEFjDgjLFklz0uQbwoPBo2IHUmQq3QrR1aHdZ9qpmlm/1SWhhL4KoM4fK8=","X-Received":["by 2002:a05:600d:84ca:10b0:488:aa33:dcbd with SMTP id\n 5b1f17b1804b1-488fb796fabmr192046565e9.26.1776844348112;\n Wed, 22 Apr 2026 00:52:28 -0700 (PDT)","by 2002:a05:600d:84ca:10b0:488:aa33:dcbd with SMTP id\n 5b1f17b1804b1-488fb796fabmr192046315e9.26.1776844347631;\n Wed, 22 Apr 2026 00:52:27 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 22 Apr 2026 09:52:25 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 16/16] vfio/migration: Add tracepoints for\n precopy/stopcopy query ioctls","To":"Peter Xu , qemu-devel@nongnu.org","Cc":"Joao Martins ,\n Markus Armbruster , Avihai Horon ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Fabiano Rosas , Prasad Pandit ,\n Alex Williamson , Kirti Wankhede ,\n Zhiyi Guo ,\n \"Maciej S . Szmigiero\" ,\n Juraj Marcin ","References":"<20260421202110.306051-1-peterx@redhat.com>\n <20260421202110.306051-17-peterx@redhat.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Autocrypt":"addr=clg@redhat.com; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7\n 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg//\n S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY\n lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh\n EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71\n xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl\n hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8\n VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy\n k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ\n RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS\n 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi\n V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW\n pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ\n KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp\n bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6\n TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU\n CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS\n YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g\n LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7\n JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu\n jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx\n IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k\n 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK\n yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j\n hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop\n s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p\n LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU\n wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU\n XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA\n HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ\n izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD\n uVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260421202110.306051-17-peterx@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=clg@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3680389,"web_url":"http://patchwork.ozlabs.org/comment/3680389/","msgid":"","list_archive_url":null,"date":"2026-04-22T09:56:38","subject":"Re: [PATCH v2 16/16] vfio/migration: Add tracepoints for\n precopy/stopcopy query ioctls","submitter":{"id":85406,"url":"http://patchwork.ozlabs.org/api/people/85406/","name":"Cédric Le Goater","email":"clg@redhat.com"},"content":"On 4/21/26 22:21, Peter Xu wrote:\n> Add two tracepoints for both precopy and stopcopy query ioctls. When at\n> it, add one warn_report_once() for each of them when it fails.\n> \n> Signed-off-by: Peter Xu \n> ---\n> hw/vfio/migration.c | 33 +++++++++++++++++++++++----------\n> hw/vfio/trace-events | 2 ++\n> 2 files changed, 25 insertions(+), 10 deletions(-)\n> \n> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c\n> index e6e6a0d53d..04d9f94edb 100644\n> --- a/hw/vfio/migration.c\n> +++ b/hw/vfio/migration.c\n> @@ -329,6 +329,7 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n> struct vfio_device_feature_mig_data_size *mig_data_size =\n> (struct vfio_device_feature_mig_data_size *)feature->data;\n> VFIOMigration *migration = vbasedev->migration;\n> + int ret;\n> \n> feature->argsz = sizeof(buf);\n> feature->flags =\n> @@ -340,12 +341,18 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n> * is reported so downtime limit won't be violated.\n> */\n> migration->stopcopy_size = VFIO_MIG_STOP_COPY_SIZE;\n> - return -errno;\n> + ret = -errno;\n> + warn_report_once(\"VFIO device %s ioctl(VFIO_DEVICE_FEATURE) on \"\n> + \"VFIO_DEVICE_FEATURE_MIG_DATA_SIZE failed (%d)\",\n> + vbasedev->name, ret);\n> + } else {\n> + migration->stopcopy_size = mig_data_size->stop_copy_length;\n> + ret = 0;\n> }\n> \n> - migration->stopcopy_size = mig_data_size->stop_copy_length;\n> + trace_vfio_query_stop_copy_size(migration->stopcopy_size, ret);\n> \n> - return 0;\n> + return ret;\n> }\n> \n> static int vfio_query_precopy_size(VFIOMigration *migration)\n> @@ -353,18 +360,24 @@ static int vfio_query_precopy_size(VFIOMigration *migration)\n> struct vfio_precopy_info precopy = {\n> .argsz = sizeof(precopy),\n> };\n> -\n> - migration->precopy_init_size = 0;\n> - migration->precopy_dirty_size = 0;\n> + int ret;\n> \n> if (ioctl(migration->data_fd, VFIO_MIG_GET_PRECOPY_INFO, &precopy)) {\n> - return -errno;\n> + migration->precopy_init_size = 0;\n> + migration->precopy_dirty_size = 0;\n> + ret = -errno;\n> + warn_report_once(\"VFIO device %s ioctl(VFIO_MIG_GET_PRECOPY_INFO) \"\n> + \"failed (%d)\", migration->vbasedev->name, ret);\n> + } else {\n> + migration->precopy_init_size = precopy.initial_bytes;\n> + migration->precopy_dirty_size = precopy.dirty_bytes;\n> + ret = 0;\n> }\n> \n> - migration->precopy_init_size = precopy.initial_bytes;\n> - migration->precopy_dirty_size = precopy.dirty_bytes;\n> + trace_vfio_query_precopy_size(migration->precopy_init_size,\n> + migration->precopy_dirty_size, ret);\n\n\nThis is possibly an overflow (in the kernel) :\n\nvfio_query_precopy_size init 18446744073281946832 dirty 0 ret 0\nvfio_state_pending (4fbce62c-8ce2-4cc9-b429-41635bc94f24) stopcopy size 3735178384 precopy initial size 18446744073281946832 precopy dirty size 0 exact 1\nvfio_state_pending (0000:b1:01.0) stopcopy size 7106032 precopy initial size 0 precopy dirty size 496 exact 0\nvfio_state_pending (4fbce62c-8ce2-4cc9-b429-41635bc94f24) stopcopy size 3734129808 precopy initial size 18446744073280898256 precopy dirty size 0 exact 0\nvfio_state_pending (0000:b1:01.0) stopcopy size 7106032 precopy initial size 0 precopy dirty size 0 exact 0\nvfio_state_pending (4fbce62c-8ce2-4cc9-b429-41635bc94f24) stopcopy size 3733081232 precopy initial size 18446744073279849680 precopy dirty size 0 exact 0\nvfio_state_pending (0000:b1:01.0) stopcopy size 7106032 precopy initial size 0 precopy dirty size 0 exact 0\nvfio_state_pending (4fbce62c-8ce2-4cc9-b429-41635bc94f24) stopcopy size 3732032656 precopy initial size 18446744073278801104 precopy dirty size 0 exact 0\nvfio_state_pending (0000:b1:01.0) stopcopy size 7106032 precopy initial size 0 precopy dirty size 0 exact 0\nvfio_state_pending (4fbce62c-8ce2-4cc9-b429-41635bc94f24) stopcopy size 3730984080 precopy initial size 18446744073277752528 precopy dirty size 0 exact 0\n\nC.\n\n\n\n> \n> - return 0;\n> + return ret;\n> }\n> \n> /* Returns the size of saved data on success and -errno on error */\n> diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events\n> index 287df0b8cb..854a7e4b19 100644\n> --- a/hw/vfio/trace-events\n> +++ b/hw/vfio/trace-events\n> @@ -176,6 +176,8 @@ vfio_save_setup(const char *name, uint64_t data_buffer_size) \" (%s) data buffer\n> vfio_state_pending(const char *name, uint64_t stopcopy_size, uint64_t precopy_init_size, uint64_t precopy_dirty_size, bool exact) \" (%s) stopcopy size %\"PRIu64\" precopy initial size %\"PRIu64\" precopy dirty size %\"PRIu64 \" exact %d\"\n> vfio_vmstate_change(const char *name, int running, const char *reason, const char *dev_state) \" (%s) running %d reason %s device state %s\"\n> vfio_vmstate_change_prepare(const char *name, int running, const char *reason, const char *dev_state) \" (%s) running %d reason %s device state %s\"\n> +vfio_query_stop_copy_size(uint64_t size, int ret) \"stopcopy size %\"PRIu64\" ret %d\"\n> +vfio_query_precopy_size(uint64_t init_size, uint64_t dirty_size, int ret) \"init %\"PRIu64\" dirty %\"PRIu64\" ret %d\"\n> \n> #iommufd.c\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=N3tnmgHK;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Vb7ekV/C;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0vlH3hMZz1yCv\n\tfor ; Wed, 22 Apr 2026 19:56:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFUK9-0004KI-58; Wed, 22 Apr 2026 05:56:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFUK7-0004K2-Qs\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 05:56:47 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFUK6-00063H-3F\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 05:56:47 -0400","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-553-JPJYQgfxNWWDGqg2_cb46w-1; Wed, 22 Apr 2026 05:56:43 -0400","by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-4362197d1easo3957319f8f.2\n for ; Wed, 22 Apr 2026 02:56:43 -0700 (PDT)","from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c?\n ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a341sm48180109f8f.24.2026.04.22.02.56.39\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 02:56:39 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776851805;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=ZnQD9U3binwSY9ZMXcH/vcnShSG25vlclm0k3rkQXZc=;\n b=N3tnmgHKcuIDfQZlM2KDVqwa5o+KcU6NbE0+SJE3MiMqMr3ZA351MmpCPTlwhF+uihfl8P\n wp/vkUh7AP/kojxAAn64P/oEl0cPBDZ7HDeHMaz//Sr5KWJNCC3g4D5e6QHpTcEPP3++k5\n tO7bCe+0SsCmM8QweNLvJKPDIwUkfL8=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776851802; x=1777456602; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=ZnQD9U3binwSY9ZMXcH/vcnShSG25vlclm0k3rkQXZc=;\n b=Vb7ekV/CyHmn9OIWIjBpMQQkOGW5zNMOvUKJH4ChzzB4UJS+Bnuok44rLxJi3lZSza\n f+TGiFUcqXRGBqtcONasDk5sdpaADM25xXmdssflO+ShHZIvNgVFLqJKbV4lpai2NUqQ\n 8+OG9EWIUixW+iMFRGAlq0ziElqVMnLUGUDfn3jHrhZMa4PHpEmq5GPl7Pd9T8oqv0zd\n wov7jP4Ewx3tb4/nRDJVTjumtRH6t/MjieDGuYQqvPIRtV1CUGR4UaO8oL4pDheYkh+D\n r7P7GW2FVMitJeKMcBlN09q5K8qrI6g7WUEgUHx+iAc7HVpvL+vZdLJ35JN1JDaJxkiM\n UehA=="],"X-MC-Unique":"JPJYQgfxNWWDGqg2_cb46w-1","X-Mimecast-MFC-AGG-ID":"JPJYQgfxNWWDGqg2_cb46w_1776851802","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776851802; x=1777456602;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZnQD9U3binwSY9ZMXcH/vcnShSG25vlclm0k3rkQXZc=;\n b=iqQETIAH2kOBuB4DpE8KR3/K0gLs4I4T1Au/i8XoJ5+/KVJPVDShZOEPWQGj54Pgnx\n motD1rvTuGCabEMCTTPTf1+VbUmv10grCjC3vvhQz+ksm8jAAN8JYvieShybePSeiEKk\n tK8ET6FOcPPfVRRP9sJ+8GObWPNrfitkcGpXqkx8sPclx91J5bIAusOB6OnQLbEd2Xgg\n kkxxXfJj8p16nsOB3LkaiEINz4SfgeYueHKOn6+C8vcSy3X8QtlpMem7Uef5Mbi2u27M\n VZAXIp+Kmy0ACIxAQee33FPKel+fSdQepFz8cQYmhaGgxTDE3iwEcjJMWejPm6XNK3LS\n LPfA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8/2FOSCmzEDuQEbcnEwmohr5MPfHHFqnrUaPzHRVlRZHB8l8G9+Ntc8kOxivMbXnnoFoGXrgZfh3L7@nongnu.org","X-Gm-Message-State":"AOJu0YyXfB9QBf1E+jV6BH8uoZgndbijpbHYPhGl51o+/HMyCeY5fWZy\n LzSFRLMQHPlqgpGf3bGWLaBbnaYc2mQXtXqWJUHXhdvxtC71bfDGrfHMceDnUDjs+VoKWcvTuBM\n MWi89cyyF2voNJOWeazyM9lihpJsPT/i/Efq8i3EzAO+1h1u0Ehg9/Lld","X-Gm-Gg":"AeBDieuLTEjsx6kodZEJH/M30riCzFEIdyY3LmOMcF5pbCpLiO8GxHH/ExpfcsMGNS8\n YPzBaqvOSzw4sMXmH9zfXIpx+JfReHU9RZGNU5tFitWZPLN5c0toGzAiF3VEawOo97ZJwhpMGGz\n zeIQ32SxrffbN54A9Yxq+xliPO12cM/CxTxxMxCwnhJYVxcL9dxr9dtR3ZoL2xRAw3e/8kja0+I\n H45N3IFck25fP0kYblfNTzCY2mRCp1tyHVqZdWW/V/WeoTegYAl8t4B5NgT4TXN7bfGH87YMjX8\n ZYOuZc32ory0tufy6g0IASAm2eeXMMG2ddF3OgWeIby57gWSR2uzxCu7DdMqMxCcS9yd3PMXpc1\n 86KZXZEVJZUIBdxW6feI+nWrJdhl8Es264uszM5rPv48VII+Lu7LbQUiFfpmoF1uiE/gKEp4=","X-Received":["by 2002:a05:6000:2389:b0:43f:e272:edff with SMTP id\n ffacd0b85a97d-43fe3db29e0mr35319842f8f.4.1776851801494;\n Wed, 22 Apr 2026 02:56:41 -0700 (PDT)","by 2002:a05:6000:2389:b0:43f:e272:edff with SMTP id\n ffacd0b85a97d-43fe3db29e0mr35319722f8f.4.1776851800490;\n Wed, 22 Apr 2026 02:56:40 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 22 Apr 2026 11:56:38 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 16/16] vfio/migration: Add tracepoints for\n precopy/stopcopy query ioctls","To":"Peter Xu , qemu-devel@nongnu.org","Cc":"Joao Martins ,\n Markus Armbruster , Avihai Horon ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Fabiano Rosas , Prasad Pandit ,\n Alex Williamson , Kirti Wankhede ,\n Zhiyi Guo ,\n \"Maciej S . Szmigiero\" ,\n Juraj Marcin ","References":"<20260421202110.306051-1-peterx@redhat.com>\n <20260421202110.306051-17-peterx@redhat.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Autocrypt":"addr=clg@redhat.com; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7\n 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg//\n S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY\n lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh\n EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71\n xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl\n hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8\n VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy\n k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ\n RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS\n 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi\n V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW\n pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ\n KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp\n bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6\n TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU\n CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS\n YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g\n LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7\n JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu\n jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx\n IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k\n 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK\n yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j\n hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop\n s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p\n LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU\n wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU\n XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA\n HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ\n izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD\n uVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260421202110.306051-17-peterx@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=clg@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]