[{"id":3680200,"web_url":"http://patchwork.ozlabs.org/comment/3680200/","msgid":"","list_archive_url":null,"date":"2026-04-22T01:13:12","subject":"Re: [PATCH v3 07/11] mach-snapdragon: Kconfig: changes / additions to\n support SPL","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michael,\n\nOn 2026-04-21T19:43:46, Michael Srba wrote:\n> mach-snapdragon: Kconfig: changes / additions to support SPL\n>\n> An SoC to target has to be selected, e.g. SPL_TARGET_SDM845.\n> This will select reasonable defaults and enable per-SoC linker\n> script (if required).\n>\n> Signed-off-by: Michael Srba \n>\n> arch/arm/Kconfig | 33 ++++++++++++++++++++++++++++++++-\n> arch/arm/mach-snapdragon/Kconfig | 31 ++++++++++++++++++++++++++++---\n> 2 files changed, 60 insertions(+), 4 deletions(-)\n\n> diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig\n> @@ -42,4 +39,32 @@ config SYS_CONFIG_NAME\n> +config TARGET_SDM845\n> + bool \"SPL targeting the sdm845 SoC\"\n> + help\n> + Select this if you are bulding u-boot SPL for sdm845.\n\nTypo: 'bulding' should be 'building'.\n\n> diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig\n> @@ -42,4 +39,32 @@ config SYS_CONFIG_NAME\n> +choice\n> + prompt \"Qualcomm SoC select\"\n> + default TARGET_NONE if !SPL\n> + help\n> + While U-Boot on Qualcomm platforms doesn't generally need compile-time\n> + adjustment based on the target SoC, there are a few exceptions to this.\n> + Currently this concerns boot0.h discrimination.\n> +\n> +config TARGET_NONE\n> + bool \"Generic build\"\n\nThe commit message says 'e.g. SPL_TARGET_SDM845' but the actual config\nsymbol is TARGET_SDM845. Please fix the commit message.\n\n> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n> @@ -1124,6 +1124,7 @@ config ARCH_SNAPDRAGON\n> + select SPL_SPMI_MSM if SPL\n\nSPL_SPMI_MSM depends on SPL_SPMI (from patch 3), but SPL_SPMI is not\nselected here. It might be cleaner to also explicitly select SPL_SPMI\nif SPL\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=bBKP6em6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"bBKP6em6\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0k6j45BCz1yGs\n\tfor ; Wed, 22 Apr 2026 12:43:09 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 06EEB84286;\n\tWed, 22 Apr 2026 04:42:53 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8D9918352B; Wed, 22 Apr 2026 03:13:26 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n [IPv6:2a00:1450:4864:20::631])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 62CDE805D7\n for ; Wed, 22 Apr 2026 03:13:24 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id\n a640c23a62f3a-ba3b9601b97so693894566b.2\n for ; Tue, 21 Apr 2026 18:13:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776820404; cv=none;\n d=google.com; s=arc-20240605;\n b=D4vvATHoerrGIyKLtdeVZLE7ludt5ImH+st4esM6qs74/exo/9t+xs+B0P12tVYrx+\n xrGX67fi8wmsZxYuKGPkjqJG9PVvgvJGI1px4nNtzKtG78g5rzavJaNDglRUzmT0MzWF\n fnK1wYb9xagodTwjYZo/DNhJmkYso2kCSNxbKqMihbzS7X/yagsMFszzJW3NuCEs4dks\n CUh3mprwGUm1i9ppT7Zru1T2PPhmR8UJ1u36YGA2cGhgz/FWQW0R1yakcaKNPhbN7NEF\n UP+EnTglEjxF36dAeC4+eAL+wDZh0RgrzJUu/bgHmtWLYuiSLbS7t/NqWfEgacIXqjgV\n cyYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=lJujimYNTDFFvBgXY9lC36+7PecrWVLWFW0o9Skg9hk=;\n fh=CcNfW6dIjL9WUdVhhW/ZJ0mqXisjz2Ordk1F8mJ+6zw=;\n b=YrdbCL6ZzvSKgIaGsHdSes4jxGPQvGUuUvTEYcwgcl7K0/lllHfk4kETpi7sqFuCQw\n 1ApTOM4H1zFNPMEvE+duKoSgmsZaawFBM0PXpzrJOVS4C3YjXwp2vaCdhaHvyinJb7SJ\n +M/Go/HeHsDDDqSO+nawH16Nezog47QcWoSKyyr5PtzLzUMNJ5t6A1SVgAAY+j8frjrB\n gqMrdLLnky931nn/x3sFOE7AynyWfyygr6vp8yIOjP/g6+Fm6IxTKy7SyWT35wW9HhkM\n yZcD1MCKDrJ6fOqRzmkZMyNWMotEHAHsq4Igjwk7qATes7xuHI5lf9Qe6nJUhSPpjr9Y\n zrDQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776820404; x=1777425204; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=lJujimYNTDFFvBgXY9lC36+7PecrWVLWFW0o9Skg9hk=;\n b=bBKP6em6xqb8T0qhlsJKKyiB+kJae5BFuoQLQO08Q4Fbpuj/wugYgO04X1L+8/dHD4\n lN7OYyxUetyixfV/OpGlKf1QFVAZNIIo5ngEqslqOcFUwSPJ0TaO40AN3R/EaFCkgxlR\n 35iy4g6CiyOA1Ng6sUMIMH+Dr02PsiTQ3M1Xk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776820404; x=1777425204;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lJujimYNTDFFvBgXY9lC36+7PecrWVLWFW0o9Skg9hk=;\n b=StxZpFMAmy6YDuAjkUnqoI0MUgGRd6az2i329g06z+1ljH1qy0dka/ezZsdguVBrkr\n SwdvBvF3B7hoJQa5FTa3iA4fSodsMTEcZerOmxPcd0G0lxr2FYqdCIV0BMUZCvdVu1tJ\n EXy+O1MxTPSEoUaeNKhfUfU9A9SG7uHiDPNtcAyEbhy840pX1rx7s6wYNlS6W1AZ9H6s\n Lp06aPE7kmYD5GKL6vC3AZZ3mZrH8OTcEoMZAUKbkSINihf0lt/1y8TQo0ENqfSZgQMm\n rAVQY9nGJkRnDDkGs8hgWg+2EM/9i6891RwuTDU9vQag3g5Lk7TpF+wsKTkEipIzL4Dl\n ONdw==","X-Gm-Message-State":"AOJu0YwxYDXqhWlQ1HjnCyYu0WWi3IIGFz8V7hC4uhWzopC+BMOjEwps\n owwcD4RpBaBdXrA7se9M4GGpHXS/XB/Y2axJm4ULr3T4GssoHqpo3AeaKmVhHPSltrue2sYx67n\n 6Yrkg+0yMu/6qKDTj6Gz+nlVgp0Km3kJ2Cux/w6rr","X-Gm-Gg":"AeBDievkR7KuWjC+N4nyYIEUfyDmBuzHZQVhisMa9rJYwmx+2sArn0Ger5nAEcWQ8dU\n Si4GiI6LqK7+bAJAuxMoHpc4FObzv2+r+YV9e9rt+u2MloUIFogok2hK+2Z/P33EiPpz/+DfieK\n r58PsVyXlgy+ARNojUo1z4iPWePItMUC0mTxg/eRiZ1BhhuzZgRawcCLvq/gFZhICNxg6cVW4N5\n WOaxRwRKrsvTKvIyLTzjlu5/6ZQU46ehT12o3eyJRnVrzmUtAMyVTHzoldnJ9fl0xszahE8NM9A\n wBFfundcRwMsJ9D8zVHs","X-Received":"by 2002:a17:906:6a19:b0:ba7:7f6d:be4a with SMTP id\n a640c23a62f3a-ba77f6dcc54mr650421566b.26.1776820403723; Tue, 21 Apr 2026\n 18:13:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421-qcom_spl-v3-0-efee3f76754d@seznam.cz>\n <20260421-qcom_spl-v3-7-efee3f76754d@seznam.cz>","In-Reply-To":"<20260421-qcom_spl-v3-7-efee3f76754d@seznam.cz>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 13:13:12 +1200","X-Gm-Features":"AQROBzBAf5K7XY0os5AJFU1Z5GJTqJYU35XC8jvf5pouHCKYvdxn971yxOSyg88","Message-ID":"\n ","Subject":"Re: [PATCH v3 07/11] mach-snapdragon: Kconfig: changes / additions to\n support SPL","To":"michael.srba@seznam.cz","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io,\n Tom Rini ,\n Ilias Apalodimas ,\n Simon Glass , Sughosh Ganu ,\n Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Heinrich Schuchardt , Andrew Davis ,\n Hrushikesh Salunke ,\n Dario Binacchi ,\n Ye Li , Andre Przywara ,\n Alif Zakuan Yuslaimi ,\n Leo Yu-Chi Liang ,\n Andrew Goodbody , Dhruva Gole ,\n Kaustabh Chakraborty ,\n Jerome Forissier ,\n Heiko Schocher ,\n Marek Vasut ,\n Lukasz Majewski ,\n Mateusz Kulikowski ,\n Dinesh Maniyam ,\n Neil Armstrong ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek ,\n Yao Zi , Peter Korsgaard ,\n Rayagonda Kokatanur ,\n Casey Connolly ,\n Tingting Meng ,\n Tien Fong Chee , Alice Guo ,\n George Chan ,\n Balaji Selvanathan ,\n Alexey Charkov , Ronald Wahl ,\n Michael Trimarchi ","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Wed, 22 Apr 2026 04:42:51 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]