[{"id":3680352,"web_url":"http://patchwork.ozlabs.org/comment/3680352/","msgid":"<5ba47c77-3e2a-49c6-96b5-37fa97ef60c4@linux.ibm.com>","list_archive_url":null,"date":"2026-04-22T09:03:47","subject":"Re: [PATCH v2 1/5] accel/tcg: Pass access_type as an argument of\n tlb_set_page*()","submitter":{"id":74525,"url":"http://patchwork.ozlabs.org/api/people/74525/","name":"Ilya Leoshkevich","email":"iii@linux.ibm.com"},"content":"On 4/21/26 17:29, Jim Shu wrote:\n> Pass the access_type so that we could know CPU will do the read or\n> write access. Then, CPU can fill the CPUTLBEntry[Full] of the specific\n> permission (@prot).\n>\n> It is fine for address_space_translate*() to return different section of\n> read and write access. tlb_set_page*() only sets 'CPUTLBEntry.addr_*'\n> for specific @prot, so access from another @prot will only get TLB miss\n> and start to overwrite 'CPUTLBEntry[Full]' with new @prot.\n>\n> It is the preliminary patch of next commit to pass the iommu_flags\n> to IOMMUMemoryRegion from access_type.\n>\n> Signed-off-by: Jim Shu \n>\n> ---\n> accel/tcg/cputlb.c | 14 ++++++++------\n> include/exec/cputlb.h | 11 +++++++----\n> target/alpha/helper.c | 2 +-\n> target/avr/helper.c | 3 ++-\n> target/hppa/mem_helper.c | 1 -\n> target/i386/tcg/system/excp_helper.c | 3 ++-\n> target/loongarch/tcg/tlb_helper.c | 2 +-\n> target/m68k/helper.c | 10 +++++++---\n> target/microblaze/helper.c | 8 ++++----\n> target/mips/tcg/system/tlb_helper.c | 4 ++--\n> target/or1k/mmu.c | 2 +-\n> target/ppc/mmu_helper.c | 2 +-\n> target/riscv/cpu_helper.c | 2 +-\n> target/rx/cpu.c | 3 ++-\n> target/s390x/tcg/excp_helper.c | 2 +-\n> target/sh4/helper.c | 3 ++-\n> target/sparc/mmu_helper.c | 6 +++---\n> target/tricore/helper.c | 2 +-\n> target/xtensa/helper.c | 3 ++-\n> 19 files changed, 48 insertions(+), 35 deletions(-)\n\n[...]\n\n> diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c\n> index ffbad8acfd2..63606c19d07 100644\n> --- a/target/hppa/mem_helper.c\n> +++ b/target/hppa/mem_helper.c\n> @@ -482,7 +482,6 @@ bool hppa_cpu_tlb_fill_align(CPUState *cs, CPUTLBEntryFull *out, vaddr addr,\n> out->prot = prot;\n> out->attrs = MEMTXATTRS_UNSPECIFIED;\n> out->lg_page_size = TARGET_PAGE_BITS;\n> -\n> return true;\n> }\n\nThis whitespace change looks unnecessary.\n\n> @@ -1461,6 +1462,7 @@ void HELPER(ptest)(CPUM68KState *env, uint32_t addr, uint32_t is_read)\n> int prot;\n> int ret;\n> target_ulong page_size;\n> + MMUAccessType qemu_access_type;\n\nDo we need to assign MMU_DATA_LOAD as a default here?\n\n> access_type = ACCESS_PTEST;\n> if (env->dfc & 4) {\n> @@ -1468,9 +1470,11 @@ void HELPER(ptest)(CPUM68KState *env, uint32_t addr, uint32_t is_read)\n> }\n> if ((env->dfc & 3) == 2) {\n> access_type |= ACCESS_CODE;\n> + qemu_access_type = MMU_INST_FETCH;\n> }\n> if (!is_read) {\n> access_type |= ACCESS_STORE;\n> + qemu_access_type = MMU_DATA_STORE;\n> }\n> \n> env->mmu.mmusr = 0;\n> @@ -1480,7 +1484,7 @@ void HELPER(ptest)(CPUM68KState *env, uint32_t addr, uint32_t is_read)\n> if (ret == 0) {\n> tlb_set_page(env_cpu(env), addr & TARGET_PAGE_MASK,\n> physical & TARGET_PAGE_MASK,\n> - prot, access_type & ACCESS_SUPER ?\n> + prot, qemu_access_type, access_type & ACCESS_SUPER ?\n> MMU_KERNEL_IDX : MMU_USER_IDX, page_size);\n> }\n> }\nOtherwise it may be used uninitialized here.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=r6XuAb6I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tby213Sz1yCv\n\tfor ; Wed, 22 Apr 2026 19:05:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFTVW-0007Nh-4P; Wed, 22 Apr 2026 05:04:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFTVU-0007NG-QP; Wed, 22 Apr 2026 05:04:28 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFTVT-000137-42; Wed, 22 Apr 2026 05:04:28 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63LImlPL972859; Wed, 22 Apr 2026 09:03:55 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dpeu3jd59-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 22 Apr 2026 09:03:54 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63M8oOqW015821;\n Wed, 22 Apr 2026 09:03:53 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dpjky1hjx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 22 Apr 2026 09:03:53 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63M93nOB56689124\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 22 Apr 2026 09:03:49 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 876012004D;\n Wed, 22 Apr 2026 09:03:49 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 11C3F20040;\n Wed, 22 Apr 2026 09:03:48 +0000 (GMT)","from [0.0.0.0] (unknown [9.111.34.105])\n by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Wed, 22 Apr 2026 09:03:47 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=Foug6M\n KO/DnOQDiV+Gc1d5FV5lntRd6byKGaNl7t1wg=; b=r6XuAb6I0S0/53blvPeLGi\n V8Z4wGkb35Ad1QUQiVoSZT8CTlK1F7z9AG/esg8XXGB3RXx5hxwfOAlasstj3eRs\n GNcWucaBV6DA+P6Hec9A5HTstF4OucIEgwXiqmp+cStFdpJcHuOgOSTomiuU4EDC\n ktPec9bFQSPWQ6vxYuduHp/rPfvRBhn83dFHp0g9G6eaGJLIVMb71aR82I2PBGNW\n +8o/Fx1u3sUXN0zdo8rcDZzi4aIXMBljhJjo7qEWqHfiUxpCMo1vLmFU9UmDtKxb\n gCOqnJlZfB8DdLr11RzfTr1uNtLZW4VF3xvoYbIiUFs6+Ltdzr5JRlcQpYKq8NSw\n ==","Message-ID":"<5ba47c77-3e2a-49c6-96b5-37fa97ef60c4@linux.ibm.com>","Date":"Wed, 22 Apr 2026 11:03:47 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/5] accel/tcg: Pass access_type as an argument of\n tlb_set_page*()","To":"Jim Shu , qemu-devel@nongnu.org, qemu-riscv@nongnu.org","Cc":"Richard Henderson ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Peter Xu , Michael Rolnik ,\n Helge Deller , Song Gao ,\n Laurent Vivier ,\n \"Edgar E. Iglesias\" ,\n Aurelien Jarno , Jiaxun Yang ,\n Aleksandar Rikalo , Stafford Horne ,\n Nicholas Piggin , Chinmay Rath ,\n Glenn Miles , Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu ,\n Yoshinori Sato ,\n David Hildenbrand , Cornelia Huck ,\n Eric Farman , Matthew Rosato ,\n Mark Cave-Ayland ,\n Artyom Tarasenko ,\n Bastian Koppelmann ,\n Max Filippov ,\n \"open list:PowerPC TCG CPUs\" ,\n \"open list:S390 TCG CPUs\" ","References":"<20260421162912.3295598-1-jim.shu@sifive.com>\n <20260421162912.3295598-2-jim.shu@sifive.com>","Content-Language":"en-US","From":"Ilya Leoshkevich ","In-Reply-To":"<20260421162912.3295598-2-jim.shu@sifive.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"L84vMpyYfJGFsPkM2y0gWZ-8uQtZJWnc","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDA4MyBTYWx0ZWRfXxWz6EOQesTwT\n GX1UIDLtJ5kL+nQZy7OOu/T6bBfX1SjnB8BkWTgZn04n++4aboxXH9fnx2MmJT3dPbiIx/gbPeZ\n 1Q3k8ubrSOm+PeodqiMUVaWxrWN4iQ8QFeXQWzjtUxj9hGRLIwxx+jsLHrVC0g56l7x3bIKaeuR\n 2UchdqGkgIWvtBdSuc91XkH8ZzGRAd/QZfwATCvgDb1/OW3tuh4WG8AlXOwAJBTtgpnUbDFfobr\n AdEDFu4PIH9GRPTqyXSu7Uv/AiAVkhiySUHdAcbk05M0Vq+w6gGx+M56rEyOAEjz2O/kCBlnuV/\n 7UwxJSTYIDfjjT01LLEnrpw1KLz9WKt3ZE36aEtVQMvxabI36rJ8Cw1pZQNv2vNf4oXyFaoczYW\n YUCGts/AtVMnxbaMZz43YL4TmXHKsgydLG21NtgJWq6FxlTGrly0jCgUf/cvyrrVaoSu5vsk3Uo\n wSdFctl6UpQ3JRV9JQA==","X-Authority-Analysis":"v=2.4 cv=a6kAM0SF c=1 sm=1 tr=0 ts=69e88efa cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=pFyQfRViAAAA:8\n a=UKC7VR2YJJbtN_zRHfsA:9 a=QEXdDO2ut3YA:10 a=oJz5jJLG1JtSoe7EL652:22","X-Proofpoint-ORIG-GUID":"I9WLuzlg34-WgK8LZqfSfXsmjRKmd4-u","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0\n lowpriorityscore=0 impostorscore=0 clxscore=1011 phishscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604220083","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]