[{"id":3680591,"web_url":"http://patchwork.ozlabs.org/comment/3680591/","msgid":"<3aecc765-7576-4f2c-9588-534569936438@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-22T12:29:40","subject":"Re: [PATCH RESEND] i2c: change return type to bool for\n i2c_check_functionality","submitter":{"id":91179,"url":"http://patchwork.ozlabs.org/api/people/91179/","name":"Mukesh Kumar Savaliya","email":"mukesh.savaliya@oss.qualcomm.com"},"content":"On 4/21/2026 9:46 PM, Thorsten Blum wrote:\n> i2c_check_functionality() returns a bool - change the return type from\n> int to bool and update the comment accordingly.\n> \n> Signed-off-by: Thorsten Blum \n> ---\n> include/linux/i2c.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/linux/i2c.h b/include/linux/i2c.h\n> index 20fd41b51d5c..6737bcbc5d7a 100644\n> --- a/include/linux/i2c.h\n> +++ b/include/linux/i2c.h\n> @@ -919,8 +919,8 @@ static inline u32 i2c_get_functionality(struct i2c_adapter *adap)\n> \treturn adap->algo->functionality(adap);\n> }\n> \n> -/* Return 1 if adapter supports everything we need, 0 if not. */\n> -static inline int i2c_check_functionality(struct i2c_adapter *adap, u32 func)\n> +/* Return true if adapter supports everything we need, false if not. */\n> +static inline bool i2c_check_functionality(struct i2c_adapter *adap, u32 func)\n> {\n> \treturn (func & i2c_get_functionality(adap)) == func;\n> }\n> \n\nAcked-by: Mukesh Kumar Savaliya ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=gazFE/Ax;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=VwfcEZtK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17124-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"gazFE/Ax\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"VwfcEZtK\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0z8f5gp0z1y2d\n\tfor ; Wed, 22 Apr 2026 22:30:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 68FFE3004637\n\tfor ; Wed, 22 Apr 2026 12:29:49 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B8ACA3D332F;\n\tWed, 22 Apr 2026 12:29:47 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 36EF73C7E16\n\tfor ; Wed, 22 Apr 2026 12:29:45 +0000 (UTC)","from pps.filterd (m0279873.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63MAqJV22209073\n\tfor ; Wed, 22 Apr 2026 12:29:45 GMT","from mail-pg1-f197.google.com (mail-pg1-f197.google.com\n [209.85.215.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpengbap6-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Wed, 22 Apr 2026 12:29:45 +0000 (GMT)","by mail-pg1-f197.google.com with SMTP id\n 41be03b00d2f7-c797e31a9b7so5743941a12.1\n for ; Wed, 22 Apr 2026 05:29:44 -0700 (PDT)","from [10.217.219.207] ([202.46.22.19])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c7976f9cabfsm14406916a12.9.2026.04.22.05.29.41\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 05:29:43 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776860987; cv=none;\n b=qT7GCEH7VwN0jkAtOMHtVrut5DxA0G6iNL5c9yAD0WcHR4CBOwPmdEM6cCXYTJtBbDye2nW4F/QFv4gydJzxKtrUgtlXO7NAiEa0RlIEhbSsPX349Q6bhrjZ3TlvmilQgO1JA6Y8wCG4pMp4jc2zlElWIckkd1y5Fsm4IziYRSs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776860987; c=relaxed/simple;\n\tbh=HE/L6J58Kw/Um32nCqXMSP3+6Ed7LZDOAX0T3RjwuPY=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=XM89lTMuE3uQUrndM1fZlx3/MDTS1iUDwB/Ja5ZvuJP0V2nxii5pt+qq0+vG5E+S7RlpTAuICze8dkyavkmkcZnzKjMoSf9spHNzYQSRFKnqJrwYhQKjCYSoBTCoTeLk23yEoHKoYnFSk82ESvScyEHpJwpm9fbpEGwxRTO6s5A=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=gazFE/Ax;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=VwfcEZtK; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\t/EUnaQmzyJXclg74EbLwevF4NYo7MxnDkmFbb66H9ZQ=; b=gazFE/Ax7ZwhxYWN\n\tGwCnQh6tjbpgKQZ4CoGkv1RC16zfJBfoG5/cb9qrE7ih1XzGUUFJeWWkeReTgXlM\n\tnDKKIO5c78r9a2mVqUYv74SWtOXzUC0aY7wyqL8faOBH7+1BfBzvlNYNRT8TJj4d\n\t7KmX9CfevABVKK9rIAu8opyOiWkRD9YklCnxazx7+MUZ3Q5z5fX8lRCrMaH1DTZH\n\tFYqODssQkoQIAaBuVQvq9RugcGv6MGfV++VFzTIKvq2/T8yYcWyjN8o/gMeMhQ6s\n\tbYHKs5YP5CejI4q2ARMezNFgOCPPQEKTzSirRM6pwZF9Bm3t0vvNW239YZyWKPrs\n\t0Jvs2g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776860984; x=1777465784;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=/EUnaQmzyJXclg74EbLwevF4NYo7MxnDkmFbb66H9ZQ=;\n b=VwfcEZtKIaOB6gUT39wyeFmknTR+5RwlxUV8uvvC5GdPs7rLIG9XwVfnkXHnBjFK2o\n Iw9/SdGce2oqok0BtIPjXkNaBySTAdH1NM8xPefZmyuILQ9BV96KLLtkcjbYrlTU3vEH\n QnXEzp5DE9PP6+lu041ybhdTEyQguiz5EK2xeCBA/SBKWpwiDNc1yJaZ8iBTKi36Z1Y2\n jZVm/bnOGz4WI/O9I2sqPhZFI/6kDl/b6unEi/8IAYegK0QbPQZPeZ1bvK5TqgrVlYUI\n eqgTp41asXmkbVvZxfNxp6JsWJfbMXLB9MOq7s9jMTCX04qS1h/DkJeVHK46m6e6tc8s\n CH8A=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776860984; x=1777465784;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=/EUnaQmzyJXclg74EbLwevF4NYo7MxnDkmFbb66H9ZQ=;\n b=OcP8kIfGQTo2Mo9K69vwhwB3nq8gmDehAACToBSBC8oPun1c/f1ah80IX8H5WcCfXJ\n DKafTmoZQ1aEKiKSMeR6DGFuwfct37SLozWRZpAeJH2FgverwCRh2+6P5JBi17PxfF6q\n ZqeoVIDWiYmiQgM93rBPoG9ogt6V9ffXLZr3q6WMFJ4fzYtDs0sgcPygvZUb6k7GH7Re\n hpW7tbxzyHvkQXnNVOpJv3zc7a3Sxhglz0jawp4takpJr8LD3W5WfWVow7VhUKWvWIYk\n J0AA4sDLdbDk2oMz//OsLxNxBK8+W2vP5zAiCCkv/RAkFLl01J0OJB90cGqy3iunLlcp\n Fg9w==","X-Gm-Message-State":"AOJu0YwTMju1g+YtwD3Av8gtkFzwDXOfFUU8ag98NIXAxS/eqowCTdLs\n\t+0hTkmqN4UI3hu0IYEciTCD2r9lum+jKJaLGR4Cmob3kFJPey+HuawOBb09kAz2fGT5XhRVkds8\n\tjoJgR91+vLOvZLQ8fSwwSbBRjXoXD7f7YGie5mKx7sqy9nuZJ7B43qD42tke/d+8=","X-Gm-Gg":"AeBDietBcC7NdAPGByq5ToNxnVFC32w0mcUzUzHtB3Yg85m+WxQdLlDeDrEP4uVIQcQ\n\t++73BjrK4+Qot5Ep9hqSt6Qypt1OnRFZeZj7v+v4bT73P0esFIR4B3dYY57Ds2WbylmOzZBIO7l\n\tVMaxialFOUqyIIxacYXQKVjQq5lskJ8+yxXUPswVs8XLE1a0nEkKxSjdjvi1B5du6xjD4rotRwj\n\tccpi/yepm+vOTS75FzGm2ASR3iCoZIaRXP3Wz/VDvjsYYfkJXs+DpvxmBX4TnbI4eEGF0iKyDWX\n\tQEL6fG0FONOVsr4jPQaDQm1EZXvghYErMBJ9yXSC1rYT37+dViDzwfO9A6utVnPDNhRSJ/XdGxr\n\tZ2pqjegrL/dmZxnKj58Rsp7mkwPSISlTGeEBWEdbPjxIU3+X0XHqHzBEM0sTypBCZ3tg=","X-Received":["by 2002:a05:6a20:2591:b0:39f:3ca8:a331 with SMTP id\n adf61e73a8af0-3a08d7372b4mr25458999637.16.1776860984156;\n Wed, 22 Apr 2026 05:29:44 -0700 (PDT)","by 2002:a05:6a20:2591:b0:39f:3ca8:a331 with SMTP id\n adf61e73a8af0-3a08d7372b4mr25458964637.16.1776860983653;\n Wed, 22 Apr 2026 05:29:43 -0700 (PDT)"],"Message-ID":"<3aecc765-7576-4f2c-9588-534569936438@oss.qualcomm.com>","Date":"Wed, 22 Apr 2026 17:59:40 +0530","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH RESEND] i2c: change return type to bool for\n i2c_check_functionality","To":"Thorsten Blum ,\n Wolfram Sang ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20260421161607.61314-3-thorsten.blum@linux.dev>","Content-Language":"en-US","From":"Mukesh Savaliya ","In-Reply-To":"<20260421161607.61314-3-thorsten.blum@linux.dev>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDEyMCBTYWx0ZWRfX9OTveqeJuv3h\n vQnJH5/D8f9qqvp7BibW2mFeS+7Oseo5+cKruVnm41jPh1aKy1zWer0zrrzaikhcb5iUePvKxVB\n l8QDl5pDa4A4bPoTV6CMYPs56uCJskmcW8E/5KBUsUD6lJ2uwWiTp91EYgw7ksLEohI01F/yD6p\n RFVQUDv8sRTvB3mV+OYoDaha2kCTiwMXttB4DxzbdGL1mvlHzZtOJaeEKil42+W9PtL7ypYKsJ6\n kL3uM82LTBSAlwKLEr9OkG8YgbNi8PVAzHaS4hMGTAhzX7OC8umZ5vMVUsFTCR/slQKLDfSTd99\n wvmOHfpYgneWW4yH51YUOb17Ux4+JgpGVRrx32SXUjnDOBj00UQt0iPIHF7ZvlhD9UPSdQU3dcd\n stX9MNtp3w9UeAeJYHD0uTjc4gR/5UrBALzfztHp6nVPdecQzvtQ6GZf0MLN1EuAx96C+cSC2WD\n y9MJM8g+FCdlHd/kciw==","X-Proofpoint-ORIG-GUID":"AdL2V_o5IW0wfqzpOVo88RiiqypnCxsx","X-Authority-Analysis":"v=2.4 cv=RYygzVtv c=1 sm=1 tr=0 ts=69e8bf39 cx=c_pps\n a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22\n a=EUspDBNiAAAA:8 a=UNYCHEIbOCCRWFwfwnMA:9 a=QEXdDO2ut3YA:10\n a=bFCP_H2QrGi7Okbo017w:22","X-Proofpoint-GUID":"AdL2V_o5IW0wfqzpOVo88RiiqypnCxsx","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 malwarescore=0\n suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220120"}}]