[{"id":3680446,"web_url":"http://patchwork.ozlabs.org/comment/3680446/","msgid":"<20260422103322.tfpolnwbuhnjnwom@wintermute.fritz.box>","list_archive_url":null,"date":"2026-04-22T10:33:22","subject":"NACK: [SRU][R][PATCH] UBUNTU: SAUCE: ASoC: qcom: x1e80100: limit\n speaker volumes","submitter":{"id":86131,"url":"http://patchwork.ozlabs.org/api/people/86131/","name":"Manuel Diewald","email":"manuel.diewald@canonical.com"},"content":"On Tue, Apr 21, 2026 at 04:40:55PM +0200, Tobias Heider wrote:\n> BugLink: https://bugs.launchpad.net/bugs/2149808\n> \n> Limit the digital gain and PA volumes to a combined -3 dB in the machine\n> driver to reduce the risk of speaker damage until we have active speaker\n> protection in place (or higher safe levels have been established).\n> \n> Based on commit c481016bb4f8 (\"ASoC: qcom: sc8280xp: limit speaker\n> volumes\") which addressed the same issue on the sc8280x SoC with some\n> minor changes as explained below.\n> \n> The Digital Volume behaves identical to sc8280x, both use the same\n> lpass-wsa-macro.\n> For PA x1e80100 machines use wsa884x amplifiers which expose a linear\n> scale from -9 dB to 9 dB with a 1.5 dB step size giving us\n> 0 dB = -9 dB + 6 * 1.5 dB.\n> \n> On x1e80100 there are two different speaker topologies we need to handle:\n> 2-Speakers: SpkrLeft, Spkr Right\n> 4-Speakers: WooferLeft, WooferRight, TweeterLeft, TweeterRight\n> \n> Signed-off-by: Tobias Heider \n> ---\n> sound/soc/qcom/x1e80100.c | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/sound/soc/qcom/x1e80100.c b/sound/soc/qcom/x1e80100.c\n> index a3f4785c4bbe..94ed3ade0daf 100644\n> --- a/sound/soc/qcom/x1e80100.c\n> +++ b/sound/soc/qcom/x1e80100.c\n> @@ -27,10 +27,27 @@ static int x1e80100_snd_init(struct snd_soc_pcm_runtime *rtd)\n> {\n> \tstruct x1e80100_snd_data *data = snd_soc_card_get_drvdata(rtd->card);\n> \tstruct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);\n> +\tstruct snd_soc_card *card = rtd->card;\n> \tstruct snd_soc_jack *dp_jack = NULL;\n> \tint dp_pcm_id = 0;\n> \n> \tswitch (cpu_dai->id) {\n> +\tcase WSA_CODEC_DMA_RX_0:\n> +\tcase WSA_CODEC_DMA_RX_1:\n> +\t\t/*\n> +\t\t * Set limit of -3 dB on Digital Volume and 0 dB on PA Volume\n> +\t\t * to reduce the risk of speaker damage until we have active\n> +\t\t * speaker protection in place.\n> +\t\t */\n> +\t\tsnd_soc_limit_volume(card, \"WSA_RX0 Digital Volume\", 81);\n> +\t\tsnd_soc_limit_volume(card, \"WSA_RX1 Digital Volume\", 81);\n> +\t\tsnd_soc_limit_volume(card, \"SpkrLeft PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"SpkrRight PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"WooferLeft PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"TweeterLeft PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"WooferRight PA Volume\", 6);\n> +\t\tsnd_soc_limit_volume(card, \"TweeterRight PA Volume\", 6);\n> +\t\tbreak;\n> \tcase DISPLAY_PORT_RX_0:\n> \t\tdp_pcm_id = 0;\n> \t\tdp_jack = &data->dp_jack[dp_pcm_id];\n> -- \n> 2.51.0\n> \n> \n> -- \n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team\n\nA v2 of the patch has been submitted.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=VOoKtJj8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wYW3zTnz1y2d\n\tfor ; Wed, 22 Apr 2026 20:33:35 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wFUta-0007HZ-Vt; Wed, 22 Apr 2026 10:33:27 +0000","from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wFUtZ-0007FI-Kq\n for kernel-team@lists.ubuntu.com; Wed, 22 Apr 2026 10:33:25 +0000","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6C35C3F949\n for ; Wed, 22 Apr 2026 10:33:25 +0000 (UTC)","by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-43e52dc8a04so4644779f8f.3\n for ; Wed, 22 Apr 2026 03:33:25 -0700 (PDT)","from localhost ([2001:16b8:a7e4:dc00:9466:c9ff:fefc:5627])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4eec9sm42374224f8f.34.2026.04.22.03.33.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 03:33:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776854005;\n bh=TpMjZaKIP5qfc4ozs50ivXhCPVU8yUfnwYysqvaQVSM=;\n h=Date:From:To:Subject:Message-ID:References:MIME-Version:\n Content-Type:In-Reply-To;\n b=VOoKtJj8NFq2G80vlvZDoCdSU5tNBMJDX0YaiAFvavu2wIm4QbQduNddiXVZ0Geua\n BpwrFWgNmB5xAhKGPQroUzfDDpCY6m0of6bYvRuMxO3epeEGoj4i3Ac1/mYxHqATe7\n +qWIvoNkzu/Uq4+QV8S4/KQp3Yrrn1AJi8pbTDYXtTX1AyIQ32X4qUc9iSMyATCCzP\n rkfReqvWTYUAmJwaSEj5eGpPh8sY9m+571viZjUHuxg6kmqCnWHlZ7DL2ariijlFrF\n NRgdaGCYhmvwY7+2gq/sI12RRyCynti2nGWdAcSsXNg5aGv2FfGH/inLToIQ0E1gNy\n Yut5rPN1PAz/bZSiD09LcEOXk0ep58SYMZ7skvLhfhDkLIvJOqKlQF0cxhQlXf1WSz\n auiZmJpvyvNFRlpPp47vUB0G5ltIuSlCa3gR2OTJh7FEH6fPg3M2hvgWWt5ku1+Fs2\n 0Ti0UPl2mbg2OCYtgpxxZW36U68XmoJdn6YXQoJvghOEGZn+fY90GZeTg5kYhG1zdb\n auSdvHmRrGbHbJj0TNg4OuDvooqVQqdrq7mc6kBDsbPmBB0cYHcYYvTdiI1Jx6+xUW\n kFHr9V7+A9ySpgcQSbTU1wa/QKaddNNsX8l/Obl+/1IYVo5WZeBef2U1g1VfZ0DTmV\n R+NiIH7RRqJulS25XydWiWL4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776854005; x=1777458805;\n h=in-reply-to:content-disposition:mime-version:references\n :mail-followup-to:message-id:subject:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=TpMjZaKIP5qfc4ozs50ivXhCPVU8yUfnwYysqvaQVSM=;\n b=jEBKrmvs10KwdnwCL6McpfO2IhaFyak56WCNyZyvegVubDktYbYFDHkwPoFJnkP/VU\n ybiLUeS/RR2c+ExISGC8Mz38Zakne37ZY6/kMlz5w9b/zxQykIRdFVTNiQrQoLNr4W8y\n 1vhx/PkqslKw8458zACg+nNb7NukEbocw4pg3bVXdkY95WbzQJn6FovMWFODkew3PPBv\n TbnqA2QJQpNgk2P5E7tSK7GeaATTiDFPrVeo9FiImipSHRXwrhatWqvJdoNCIhDrOkz5\n ebquZVi4dUeh+gtAuXFgyqBSp5QTT3VhsaJPB5ffzN7pAkRTS1iKtMuoAxJHaVRUXfk+\n Vpyw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9IgC93wRzKPleE6TRWry8v50WtgsILBNSxST7lfusSB2JzKfs9VeENzj7kiFFKQ16RCYf1ZtZI43Jzwg==@lists.ubuntu.com","X-Gm-Message-State":"AOJu0YxuY3DCxPRcLi1gXTlqTmFXY7Ev4s7Ii18lmYslpFo+jQ42qKx1\n y3b847CVECrn9wCNjShEc29LpT9ibWQU9cuLy08OERuOTcGyMmkYm6hRslRdJQdSzUliZXZqxlS\n 6sdpv3w0hCNjFRiZlqjG0TsHMSQ5IUojEvUqbXJalyjLxaSgFqJXDsglAHEWMTF9Wap9L9melg4\n KtKb4Fcqz0Zi0cTQ==","X-Gm-Gg":"AeBDievCuaqpmtN1K1ONomUbYl7rCvT2cDLc4tahh9Zm5N8HIZKnGFL2SEHbSvew1H9\n KqtIjCUYaBE5ofd9dQPY6DXYKJeqjKb9qjlYSkIhu06fhLsJLkfauSF1AVYM2EE1NJ2xXFdil2v\n mjwZNe3XXMJpZXisCV7leNvxoGzy0Jmw6+YAhRs928dzOE8VfUThL5+XF8HDji3v2Ly7VWFTlQi\n lrKsfDf4zBVi4x8fgzqWl53Pb9nDiav2sKTAHpt1RFS6G0qs+wiQZOPZUZg2OC0MngqGT+uz3ZK\n INZE/9MVJZNg0MX4KMe6j6X+tG4muloVfezB0WzgPVS8bNX1HGkF49Rj8GQVVcjC7FvThEoBXEN\n KOdfjsAk5qh+8EeeHMKnpA7Z7x5oqXXahK3YAwUPrbUk=","X-Received":["by 2002:adf:f2c7:0:b0:43f:e44a:f276 with SMTP id\n ffacd0b85a97d-43fe44b01a5mr24427401f8f.3.1776854004888;\n Wed, 22 Apr 2026 03:33:24 -0700 (PDT)","by 2002:adf:f2c7:0:b0:43f:e44a:f276 with SMTP id\n ffacd0b85a97d-43fe44b01a5mr24427361f8f.3.1776854004309;\n Wed, 22 Apr 2026 03:33:24 -0700 (PDT)"],"Date":"Wed, 22 Apr 2026 12:33:22 +0200","From":"Manuel Diewald ","To":"Tobias Heider , kernel-team@lists.ubuntu.com","Subject":"NACK: [SRU][R][PATCH] UBUNTU: SAUCE: ASoC: qcom: x1e80100: limit\n speaker volumes","Message-ID":"<20260422103322.tfpolnwbuhnjnwom@wintermute.fritz.box>","Mail-Followup-To":"Tobias Heider ,\n kernel-team@lists.ubuntu.com","References":"<20260421144053.131431-3-tobias.heider@canonical.com>","MIME-Version":"1.0","In-Reply-To":"<20260421144053.131431-3-tobias.heider@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"multipart/mixed; boundary=\"===============5711587021888659336==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]