[{"id":3679913,"web_url":"http://patchwork.ozlabs.org/comment/3679913/","msgid":"<7f3f6800-8449-4fb3-a3ad-a844f9a22a25@swupdate.org>","list_archive_url":null,"date":"2026-04-21T14:27:47","subject":"Re: [swupdate] [PATCH 2/2] refactor(mbedtls): align HASH_final return\n values across implementations","submitter":{"id":86869,"url":"http://patchwork.ozlabs.org/api/people/86869/","name":"Stefano Babic","email":"stefano.babic@swupdate.org"},"content":"On 4/21/26 16:12, 'Storm, Christian' via swupdate wrote:\n> From: Felix Moessbauer \n> \n> The HASH_final implementations are expected to return 0 on success and a\n> negative value on error. While the mbedtls_HASH_final correctly\n> implements this interface, it still is better to align the return codes\n> across the backends - what we do in this commit.\n> \n> While doing so, we also document the expected return values of the\n> crypto backends.\n> \n> Signed-off-by: Felix Moessbauer \n> ---\n> crypto/swupdate_HASH_mbedtls.c | 2 +-\n> include/swupdate_crypto.h | 4 ++++\n> 2 files changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/crypto/swupdate_HASH_mbedtls.c b/crypto/swupdate_HASH_mbedtls.c\n> index 4165b940..9005256b 100644\n> --- a/crypto/swupdate_HASH_mbedtls.c\n> +++ b/crypto/swupdate_HASH_mbedtls.c\n> @@ -99,7 +99,7 @@ static int mbedtls_HASH_final(void *ctx, unsigned char *md_value,\n> *md_len = mbedtls_md_get_size(dgst->mbedtls_md_context.md_info);\n> #endif\n> }\n> - return 1;\n> + return 0;\n> \n> }\n> \n> diff --git a/include/swupdate_crypto.h b/include/swupdate_crypto.h\n> index aa9da964..0e579dfb 100644\n> --- a/include/swupdate_crypto.h\n> +++ b/include/swupdate_crypto.h\n> @@ -46,6 +46,10 @@ typedef struct {\n> void (*DECRYPT_cleanup)(void *ctx);\n> } swupdate_decrypt_lib;\n> \n> +/*\n> + * Return:\n> + * 0 on success, < 0 on error\n> + */\n> typedef struct {\n> void *(*HASH_init)(const char *SHAlength);\n> int (*HASH_update)(void *ctx, const unsigned char *buf, size_t len);\n\nReviewed-by: Stefano Babic ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=googlegroups.com header.i=@googlegroups.com\n header.a=rsa-sha256 header.s=20251104 header.b=MVurcVKV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com\n (client-ip=2a00:1450:4864:20::43d; helo=mail-wr1-x43d.google.com;\n envelope-from=swupdate+bncbd2zdgn6sekrbzust3hqmgqer74ngya@googlegroups.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from mail-wr1-x43d.google.com (mail-wr1-x43d.google.com\n [IPv6:2a00:1450:4864:20::43d])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0PpN4CFNz1yCv\n\tfor ; Wed, 22 Apr 2026 00:27:56 +1000 (AEST)","by mail-wr1-x43d.google.com with SMTP id\n ffacd0b85a97d-43ea7a5da57sf3426828f8f.1\n for ;\n Tue, 21 Apr 2026 07:27:56 -0700 (PDT)","by 2002:a05:6000:4b03:b0:43b:9efc:6a64 with SMTP id\n ffacd0b85a97d-43eb1bd5702ls4945565f8f.0.-pod-prod-09-eu; Tue, 21 Apr 2026\n 07:27:49 -0700 (PDT)","from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.10])\n by gmr-mx.google.com with ESMTPS id\n ffacd0b85a97d-43fe7c7052fsi258686f8f.3.2026.04.21.07.27.48\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 07:27:48 -0700 (PDT)","from client.hidden.invalid by mrelayeu.kundenserver.de (mreue106\n [212.227.15.152]) with ESMTPSA (Nemesis) id 1MkpvV-1vXMjb1QYJ-00ptHj; Tue, 21\n Apr 2026 16:27:48 +0200"],"ARC-Seal":["i=2; a=rsa-sha256; t=1776781673; cv=pass;\n d=google.com; s=arc-20240605;\n b=fLWnExhgAcGJHI7pf3JNWs6Hq/gfb0m5Ksj42vaCv39syqjLuvCTkBB37nizXrUEXG\n 9kNcqk/9a8E6m9lcjSbdxWcEEW57nzAxkm4fiVVDipC1Gyxtan4KHFOMlsyxIWtjsH6c\n n61NEsmn+n+o+TQbYJG4M/LIufIFcVUFU/UTligVHMu6cIHm6tNUIyXk2DrQEvMogM5n\n LHZVaQAUSzBIP05D1JUalfkS1QULKQO94G81D/SqsuPIk8pvbK1VEfRNDGnNyVsoz7YD\n kXGUUUJWGnSwrEJ3j9rg1/JbyaIGjixriIj40KwENzUVz0en/e7Bf4jrv246XczU+sRK\n vEXg==","i=1; a=rsa-sha256; t=1776781668; cv=none;\n d=google.com; s=arc-20240605;\n b=BN4lcXgCvQYbsF2F5S8aF7sgQAX8QeaHO3qIc9dQnYYnRyXIzpzdjS/IFsDvXyhVAx\n owE9CgKxA+lFRJJ/ODhPJ98NNkxn4OQgCgg22lrRYHsHjwKGxssrwHYeBoyzUWo6enIw\n Un2BIEKJwiJnH77l0/i+Ed5LxWaNgQVVi2VAgAPUkdimKig3C/IOlO0/Bx+R7kGIFN1x\n 9DGAmyaoBJAAC04szDr09sryZilvNlrSE8KY3NA0bDUwlP/crVREJGdaD3VOmLcVwVMC\n ZMQc/D4GdeszAIOH7GYHadpsBmcMCW+isQ2Iu26VDZcRKfXwG8/dx72wcy9bl4PYg0dC\n A9Zg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:ui-outboundreport\n :content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :sender:dkim-signature;\n bh=nE+NMQx30/3ksD6tb+PlgShGa0bnP0iIAXONmAY/TI8=;\n fh=v+V1M8S/f6PuP5rZHX+YVujJbNwDVgQkdtGI7wEGgBU=;\n b=ORQpj//4jU6AQfq5/4DYRD/TJnP57HMcZwVRK1lNAkkwM8KvegCUoJmDRvQ1aXOKIZ\n xHtBwrJJ9IIlFzgx3L96tUCJ349IiGI9P4GRGP6vC+6NR8fXuXZWqYIKEPEr+upj0rHV\n CK8AG7WCvMy54BMBLPnx1VdXye05bo6mhPYX/LL0n4FvRvkgt7SbEIZ96/KPLX2mcE0E\n e/EFsaT8tRzg5qDAKuggFwxHp6RnUNyFDRrdMADoY4Ykrn9Qpg5uX53UiHYNzwJk9I+G\n d8GbPnAalx4lEIechnlH1xLrQiudoiKu8y/amEhvDqFxa5ni9sSyEbhigmfqEcbpaduN\n DoDQ==;\n darn=patchwork.ozlabs.org","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=ui-outboundreport:content-transfer-encoding:in-reply-to:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:dkim-signature;\n bh=Yn+nHqPxIYeT84Oby1h4Vy5nSvbfAAl5l+gEkqdCnio=;\n fh=jVhCEMILIPQu855m+iubP4yxiepa1Q40P9Vwe9Vio/s=;\n b=GKHzB8o9p8J5F55uq9qzJagu0nWdO8ZUW/ZEYXT/XXQzd4wZYzQXBXIJ2SjQc2+nUE\n /n0mE/SbZtXDLikRofTzk8uRMa0qkOydJgoo8VLFoucEoHWz/4wx2hi90anFKjLPFfHC\n QvDql5xuqte9CzWtlVK/bpqN27+icGFhXw7Ec2WfHNCJN8wV8036cfCHdimtIi9V38nd\n kc9/kBrHmQJ496GAcz8WQTxvP2Tbo2rsFJUHB60vY9lSR3UDhsHJUrl/qWsVst9LTy7l\n 8ItvQfsXcXUZwrQbhkKXZ2YAsFx1pZwzZBHdDlE9UjRgIk8MnzVhN+4yKpauo3wDpb0q\n 5OJw==;\n dara=google.com"],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=uOjYTBnc;\n spf=pass (google.com: domain of stefano.babic@swupdate.org designates\n 212.227.17.10 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org;\n dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=swupdate.org","i=1; gmr-mx.google.com;\n dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=uOjYTBnc;\n spf=pass (google.com: domain of stefano.babic@swupdate.org designates\n 212.227.17.10 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org;\n dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=swupdate.org"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=googlegroups.com; s=20251104; t=1776781673; x=1777386473;\n darn=patchwork.ozlabs.org;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:x-original-authentication-results\n :x-original-sender:ui-outboundreport:content-transfer-encoding\n :in-reply-to:from:content-language:references:cc:to:subject\n :user-agent:mime-version:date:message-id:sender:from:to:cc:subject\n :date:message-id:reply-to;\n bh=nE+NMQx30/3ksD6tb+PlgShGa0bnP0iIAXONmAY/TI8=;\n b=MVurcVKVTMQI0bbSN3TIpLEGIqUzLmCMcmrZTAbn7Tz7hGsMrqxAFrsYSAHcAZbPoK\n 2Sa/wLURtJD9nBer8UXBPcq1PkK/+lZ9YjVfch1uqk/y/hsQgOVDYjlJBZyAjwSr+NJ1\n 19IRWyBYAgfGqOz6nvyLlGZbvYSykZW6XxLjQ0Yj9Y3o+P67sLYkD1BqM9xQB6L4nzP1\n IgdIMTs+cFVaAciYBC4wsACX7slMCZd/D6dEuRBtrDMNbVP6BNXRa7DSKXL4PYLoKVqo\n 8Lxjiexzke+GaLUf8fqLVQTkihgurCj3vSEnWORpTWhTbe7hHP/r/b/U8P6TAHbqslaP\n 37Yg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776781673; x=1777386473;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :x-spam-checked-in-group:list-id:mailing-list:precedence\n :x-original-authentication-results:x-original-sender\n :ui-outboundreport:content-transfer-encoding:in-reply-to:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc\n :subject:date:message-id:reply-to;\n bh=nE+NMQx30/3ksD6tb+PlgShGa0bnP0iIAXONmAY/TI8=;\n b=AyPtDAqE/Y1dT9aRvGf6zYKOtoQni91jo7AA+b+wvHjVFk17tC9tdq/5emtmMlpo8h\n Vyw9zQpy3qNzUafYXXXbEIwwEhGq5IiQoZrPGcFG4WN6shlYXhAEvLNCwZFHO47jaHjQ\n S552IY5uUetglzhFTgQDX/o2dbDKbTh1pCuLPQ/f9vCampTalOvXgbXlE6fHsn7pcwuZ\n lk+6I/1M0iMgYY6N5VMDt9TLPv3R6OgUJ4QQZROtYlkn+6is5PuqHMnBUzlrWMnRJ6u9\n 8HyV45UGIa2Gbl7XAJ4+h9eKljCD/Jb/nlQNFq+iOYBhH1Ka1R2kc03NSvS7wHBZZHRA\n R+6w==","Sender":"swupdate@googlegroups.com","X-Forwarded-Encrypted":["i=2;\n AFNElJ+VPCixyeA2jg4drnMyoLtyUmnJfmciYKWvAlIkh+4MGvLUvTdWCAkTz7UQeyx2KDToUjrlEYrFqQ==@patchwork.ozlabs.org","i=2;\n AFNElJ/ey2CHEly9WJcXBrTljaZ+VPBca5sPBoaey8P8rDbmcyIYlRrRLOlwCRbPXA3H/HwdIwo7zkDePQ==@googlegroups.com"],"X-Gm-Message-State":"AOJu0Ywdu0H1dctS3epGI4Yr8fO4MmeubJXU61msv3IbK1DpKY0Fba87\n\t2oRdKTJs4iMFFYH9YaUHz2H7DLuojJVBGogHpGBmONg0nRnCcLIBtpGU","X-Received":["by 2002:a5d:5d83:0:b0:441:1e41:19c with SMTP id\n ffacd0b85a97d-4411e4102d7mr5457059f8f.20.1776781672872;\n Tue, 21 Apr 2026 07:27:52 -0700 (PDT)","by 2002:a5d:5f89:0:b0:441:1c95:17e7 with SMTP id\n ffacd0b85a97d-4411c951810mr8649058f8f.15.1776781668771;\n Tue, 21 Apr 2026 07:27:48 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com;\n h=\"AYAyTiLLPXIHtBxRU1CKV6as9SvUChxnS3n5Tixpi3iZy9bldA==\"","Received-SPF":"pass (google.com: domain of stefano.babic@swupdate.org\n designates 212.227.17.10 as permitted sender) client-ip=212.227.17.10;","X-UI-Sender-Class":"55c96926-9e95-11ee-ae09-1f7a4046a0f6","Message-ID":"<7f3f6800-8449-4fb3-a3ad-a844f9a22a25@swupdate.org>","Date":"Tue, 21 Apr 2026 16:27:47 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [swupdate] [PATCH 2/2] refactor(mbedtls): align HASH_final return\n values across implementations","To":"\"Storm, Christian\" ,\n swupdate ","Cc":"\"MOESSBAUER, Felix\" ,\n \"Gylstorff, Quirin\" ","References":"<0EC9AC91-BD5E-4565-A6EF-EE468E4D304E@siemens.com>\n <89927E47-3CB5-45C7-BF47-323103C4EAED@siemens.com>\n <7CF8D62F-DA33-4134-8BE9-97E4EC9A9CB9@siemens.com>","Content-Language":"en-US","From":"Stefano Babic ","In-Reply-To":"<7CF8D62F-DA33-4134-8BE9-97E4EC9A9CB9@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:u4k6oxd9hCOJklOXBEVA8m+pLd9n+mKVoOzZcWzV5baXgir/LCJ\n BsVqvJIlpOwrkP30dIrG2v259NEe5CsMgMTM18HBZ/nZJzJXnTe6WuLLkzA43N0aF/Ckua0\n qw8xCEMvycD1XvS+LwjEzXv7rpzTCGzBOJfagDW8HAqDBO+ek1l6pdI/yecOWdYvTn6WqOM\n jFej9fgo+Cc5ux67PZ5jQ==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1;M01:P0:IHQmf5WZRMU=;ADOxcpTjiZHicU55kuF1pVJOZC1\n Hvsu1Q4duNAdO+Iq3CdVv9xS42zaf9fC0ePmOcdmvtYBhfbF6rmoFWp6BmgrSRzadxfoKcTKP\n MUd9Gy+oqmrW6gK/I4DPRPlYthiMgAZfizwtctUIIrWeY3l3gl2Alfy5eLT3WNm8SmvYA7jXU\n C0QbTw/kSoUnRp0QpNPLzyo3CfzFsLBOBJVx5JmKloLvlM/pnNbMzWDI08OxZS+EHh5+rCzUc\n eRcV0kSfaY5B9OFF082+bydrEaEs4fC7uI37wNmnHcq9MhwDC8njxyMmqEdOh6o0qcgBWMve0\n szv5qt1xzWCi9RLRcz0oa3hYe4uKxV4Ektmk0QhW2clVBSegEv+doNqM1WmcQ4TqbOyTmFQoC\n ugHLK1M70izfOUkodrqazTzEaGz83l7hkhO07FV3bsl1SLz6J8YqewQymVCAioSP1H6sEYdzH\n D5P51Fm1N/yytdNGqL0yHoe7cVGi4rbTRKcLmnTy1JdpzfRklMWgidVFY5cLl+K0Ao0xWF0YM\n mUdfubIDvQZA+nQNUcEEAH/AK5m5Pn6Y8jlM5+RI1JBzPqzKjaShPc8j7qg9MYeWkfaWmmoba\n nQdmB7ytqgR5CliKXxEa8wADB7qT8vi4PwkricwqVWG6EVk/9MPebCkIBb+EufLgreHv/rOj8\n ZFGOnY+k8Lhum15D3hRWnPSEQBe0HpQd6KakO8HC1R82ArjOg/QBL+GMXlDXVx+Eh6TTQi47f\n 3j4eXi+w+Z+PN33y79ORh68YwqjJKIJm31fRIGOcdTEJovT2EesJQvH1jDM/6WlkQBDerVBgJ\n qpnFagDxsn5nwH9ifd9wYZNaS1YIT8k3Q5XaAGnvAbJ5eNcI9mRTlpFPKpaL+2SNsrSwx9khN\n bdHRE0WGuOmFBVR6LxyqYo7IDOWrCvevNy1NpTrwdm7MwHid9D5yMuYu/GGGlnOJlAfVmwikb\n IinzIpAxl0aPVl7moWc4xXpViqYyofMrxHs3KYWa2w0fcj2xixBk786VCQ4EVTUD9IqOZLq+M\n GTg/Th+cBp/WE6gV9itp+ibs6vg9qsMiI/7yWU2bZfEkKKVKXZ+GT+3gAhnmvdsa6hA+O+IV6\n tqsYvRv7dByuNKRKt4K8Oodg5S0TAcNbQL6DDOohR1LxD3R0M0ge7gzMIbCMTJx5+Ha3D9KzI\n fovgdyd5X8QbfEL+is5ihJRR++4ikJvb0S5TAtfEIiL/+AOn1aSFSPMUAqiNXOumASAst8rWj\n BI7l7gISZTzLD5P7keI7ceT5E/eHvM8SXAOkBl99/Ds2481rcDojmkBar7sAZraJIcXILDqWE\n GQ5DahpwqVGyprgKtQPHpGa3pdh7wLibOCoLiL6K9JeOQBomzp7NIzmZyDQ9yEyp1eMGHsewn\n lBLI8ZpNRJXYIqjMA/SmiUrOGmJh7JesDnOTlL5ExCVY2VSGOqzQ5Et1ADvQkzc9El/wgrz3F\n fxLhm310NPpaBifWAoSMLz3nDHeQNu9Ciw4KTjLstSu69Q80gpRIWTSe0VBDCn94O7SvWejpR\n ca34SAxV35hAK+HFKEmTjY0ThuCrin/6B846kuGKhX30GnCqweJBvrugJqxVZqbEQ9Gve9Rhp\n Hp8LOLZqxnpaXzk1lQBTNI7gS1g1NrSqHO6RsGH34oQG4iZAngck0Akl99w/pq+gEy6plrZhu\n CKj/GzR1sEYkNHDRbEEdhvvCN9Py8yRYZMGW42lInbshbSfy+c9kLOxOSW2n6HPqEQJgIwJ9S\n 8ibX5xg4BAegeOcoToI7LIus3C/yGQ3o1pP7ttn7RicGLdZDZbrc4qvA3dNhuneB2AaAIigJL\n aSjH0jZTtl/Nm56TmoN2JOy6N4BIyLYKP7y2sdkNuZ2wzJSM0/nchREhO8/TVdugOKPdizQIG\n FX630cl5zC23Y+fKryC2JfAdqXcrepOtRrAg7zB8dj1gb1v38YDN6Q7SVArz6xf9GjBo2kIHu\n y++wy13IHX89z3sAW24JxMM80KElOvbDW188JEgKbBZ4KxeEZpojZCnfrkIVzT0izv4O1em/1\n 1XaGDJU4BMy+kpPJqcljiMfugfK0XAQbbktfwEQKlmgLm1P9meLwOp1d21MeD2eDNF3NW4YMg\n tZdGtds3rnM=","X-Original-Sender":"stefano.babic@swupdate.org","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n header.i=@swupdate.org header.s=s1-ionos header.b=uOjYTBnc; spf=pass\n (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.10 as\n permitted sender) smtp.mailfrom=stefano.babic@swupdate.org; dmarc=pass\n (p=NONE sp=NONE dis=NONE) header.from=swupdate.org","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n contact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n ","List-Help":",\n ","List-Archive":",\n ","List-Unsubscribe":"\n ,\n "}}]