[{"id":3679899,"web_url":"http://patchwork.ozlabs.org/comment/3679899/","msgid":"","list_archive_url":null,"date":"2026-04-21T13:50:23","subject":"Re: [PATCH] libcpp: fix typos in iconv_close [PR124930]","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Tue, Apr 21, 2026 at 09:23:57AM -0400, Marek Polacek wrote:\n> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?\n> \n> -- >8 --\n> This patch fixes two typos I made: the reverse_ prefix is missing\n> in the iconv_close calls.\n\nI'm afraid it was me who made those. Sorry for that.\n\n> \tPR preprocessor/124930\n> \n> libcpp/ChangeLog:\n> \n> \t* charset.cc (_cpp_destroy_iconv): Correct two calls to\n> \ticonv_close.\n\nLGTM.\nCalling iconv_close on something twice means double free + access\nof the freed memory among other nasty things.\n\n> --- a/libcpp/charset.cc\n> +++ b/libcpp/charset.cc\n> @@ -841,9 +841,9 @@ _cpp_destroy_iconv (cpp_reader *pfile)\n> if (pfile->wide_cset_desc.func == convert_using_iconv)\n> \ticonv_close (pfile->wide_cset_desc.cd);\n> if (pfile->reverse_narrow_cset_desc.func == convert_using_iconv)\n> -\ticonv_close (pfile->narrow_cset_desc.cd);\n> +\ticonv_close (pfile->reverse_narrow_cset_desc.cd);\n> if (pfile->reverse_utf8_cset_desc.func == convert_using_iconv)\n> -\ticonv_close (pfile->utf8_cset_desc.cd);\n> +\ticonv_close (pfile->reverse_utf8_cset_desc.cd);\n> }\n> }\n\n\tJakub","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bslWCl04;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bslWCl04","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0P0146Ghz1yGs\n\tfor ; Tue, 21 Apr 2026 23:51:12 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 449054BA23F7\n\tfor ; Tue, 21 Apr 2026 13:51:10 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 9CDA94B9DB7C\n for ; Tue, 21 Apr 2026 13:50:30 +0000 (GMT)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-wPP54yy5OfGLrq4uMUid6Q-1; Tue,\n 21 Apr 2026 09:50:28 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9C8F41800282\n for ; Tue, 21 Apr 2026 13:50:27 +0000 (UTC)","from tucnak.zalov.cz (unknown [10.44.48.12])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 11C1A3000C15; Tue, 21 Apr 2026 13:50:26 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 63LDoOmg919476\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Tue, 21 Apr 2026 15:50:24 +0200","(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 63LDoO37919475;\n Tue, 21 Apr 2026 15:50:24 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 449054BA23F7","OpenDKIM Filter v2.11.0 sourceware.org 9CDA94B9DB7C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 9CDA94B9DB7C","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 9CDA94B9DB7C","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776779430; cv=none;\n b=YARf1W1GKujcauRYCZSi0OGnWjiWVB6KxnRDAs5OH8g39eNK+aAPkW+J7/knCvjac1fh2AaAHS4W4JLiMTRYgKBkXa9dIhYiG/Mbfpo2hoC6lPdlgT1BvSCzSRPxR9ZcYjagGnFK7NKdNPvpzqqqame+hwdpVocnVyJGsUYlCzM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776779430; c=relaxed/simple;\n bh=9SRlLOTYrZzd+fUL7G+VvdgX2ZGInt1o1HO40SYCLpA=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=QKELapW3ccAg6PMTP/XvCwThcIzUDaDvIPNbyF7auxU6YZoGl+boEP1yNEfJaO28vRoHcQKTGofQnDkr3zsMkZ83DMtKQIuTfNJ2vZzti+7+3pYSobBMl/i/zD2gjW/pILsyPPgDcBEH+eUArhVOIJjMF916rgW+W4ynILk+d0E=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776779430;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=1DKcILTJNN0QIsp1dQBoivQkoDi9bccChz23LyNDsFw=;\n b=bslWCl04YAHPyPXui6L3qlx3OtRy+8go3nNqdPsk97Zt8UJErhwYaeAEYUKMNIfjjMU5CU\n 7dGEOzmtd3ZUQDvNW976uhgo7rILPR15RI0vIvtzF1KYXSH1t+8Dj91jEdjeS9cafnBWKC\n EHJe+ZYsNpMKhaZIR3eBpSHBolIk674=","X-MC-Unique":"wPP54yy5OfGLrq4uMUid6Q-1","X-Mimecast-MFC-AGG-ID":"wPP54yy5OfGLrq4uMUid6Q_1776779427","Date":"Tue, 21 Apr 2026 15:50:23 +0200","From":"Jakub Jelinek ","To":"Marek Polacek ","Cc":"Jason Merrill , Joseph Myers ,\n GCC Patches ","Subject":"Re: [PATCH] libcpp: fix typos in iconv_close [PR124930]","Message-ID":"","References":"<20260421132357.29200-1-polacek@redhat.com>","MIME-Version":"1.0","In-Reply-To":"<20260421132357.29200-1-polacek@redhat.com>","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"P46Gqcfl7hi8DUozNAt9Z4uaUhLVW_sC1KcPRRa_9vM_1776779427","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Jakub Jelinek ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]