[{"id":3679886,"web_url":"http://patchwork.ozlabs.org/comment/3679886/","msgid":"","list_archive_url":null,"date":"2026-04-21T13:12:27","subject":"Re: [PATCH v2] board: ti: am335x: Conditional MDIO PAD\n configuration instead of static for AM335_ICE","submitter":{"id":82333,"url":"http://patchwork.ozlabs.org/api/people/82333/","name":"Markus Schneider-Pargmann","email":"msp@baylibre.com"},"content":"On Tue Apr 21, 2026 at 2:30 PM CEST, Parvathi Pudi wrote:\n> This patch removes the static MDIO pinmux configuration from\n> rmii1_pin_mux[] and instead configures the MDIO pins conditionally\n> during board_init(). Previously, the MDIO_CLK and MDIO_DATA pins\n> were always configured for CPSW in mux.c, which could lead to\n> unnecessary pin ownership and conflicts in scenarios where CPSW\n> is not used.\n>\n> With this change, the MDIO pins are configured only when required,\n> ensuring that CPSW Ethernet functionality in U-Boot remains unaffected.\n> This approach keeps Ethernet boot behavior intact and provides cleaner\n> separation between CPSW and other Ethernet use cases.\n>\n> Signed-off-by: Parvathi Pudi \n\nReviewed-by: Markus Schneider-Pargmann \n\nLooks good to me, one nitpick inline:\n\n> ---\n> Changes from v1 to v2 :\n> *) Adressed Markus Schneider-Pargmann's comments on this patch.\n>\n> board/ti/am335x/board.c | 11 +++++++++++\n> board/ti/am335x/mux.c | 2 --\n> 2 files changed, 11 insertions(+), 2 deletions(-)\n>\n> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c\n> index 90e37a8d913..f0a40cb82af 100644\n> --- a/board/ti/am335x/board.c\n> +++ b/board/ti/am335x/board.c\n> @@ -28,6 +28,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -72,6 +73,12 @@ static struct ctrl_dev *cdev = (struct ctrl_dev *)CTRL_DEVICE_BASE;\n> #define GPIO0_IRQSTATUSRAW\t(AM33XX_GPIO0_BASE + 0x024)\n> #define GPIO1_IRQSTATUSRAW\t(AM33XX_GPIO1_BASE + 0x024)\n> \n> +static struct module_pin_mux rmii1_mdio_pin_mux[] = {\n> +\t{OFFSET(mdio_clk), MODE(0) | PULLUP_EN},\t/* MDIO_CLK */\n> +\t{OFFSET(mdio_data), MODE(0) | RXACTIVE | PULLUP_EN}, /* MDIO_DATA */\n> +\t{-1},\n> +};\n> +\n> /*\n> * Read header information from EEPROM into global structure.\n> */\n> @@ -779,6 +786,10 @@ int board_init(void)\n> \t\t\thang();\n> \t\t}\n> \n> +\t\t/* Set the Mux Mode to MDIO_DATA, MDIO_CLK */\n\nI think it is ovious by the names. Can you please remove the comment?\n\nBest\nMarkus\n\n> +\t\tif (!eth0_is_mii)\n> +\t\t\tconfigure_module_pin_mux(rmii1_mdio_pin_mux);\n> +\n> \t\tprueth_is_mii = eth0_is_mii;\n> \n> \t\t/* disable rising edge IRQs */\n> diff --git a/board/ti/am335x/mux.c b/board/ti/am335x/mux.c\n> index d2d87c304f6..36d849d2119 100644\n> --- a/board/ti/am335x/mux.c\n> +++ b/board/ti/am335x/mux.c\n> @@ -190,8 +190,6 @@ static struct module_pin_mux mii1_pin_mux[] = {\n> };\n> \n> static struct module_pin_mux rmii1_pin_mux[] = {\n> -\t{OFFSET(mdio_clk), MODE(0) | PULLUP_EN},\t/* MDIO_CLK */\n> -\t{OFFSET(mdio_data), MODE(0) | RXACTIVE | PULLUP_EN}, /* MDIO_DATA */\n> \t{OFFSET(mii1_crs), MODE(1) | RXACTIVE},\t\t/* MII1_CRS */\n> \t{OFFSET(mii1_rxerr), MODE(1) | RXACTIVE},\t/* MII1_RXERR */\n> \t{OFFSET(mii1_txen), MODE(1)},\t\t\t/* MII1_TXEN */","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=yl5BBj/D;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"yl5BBj/D\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=msp@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0N7d26jGz1yCv\n\tfor ; Tue, 21 Apr 2026 23:12:45 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8C48D83C51;\n\tTue, 21 Apr 2026 15:12:42 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B2AC083E36; Tue, 21 Apr 2026 15:12:41 +0200 (CEST)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n [IPv6:2a00:1450:4864:20::332])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7102B83A91\n for ; Tue, 21 Apr 2026 15:12:39 +0200 (CEST)","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-48909558b3aso33255645e9.0\n for ; Tue, 21 Apr 2026 06:12:39 -0700 (PDT)","from localhost ([62.246.35.158]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891978ef6bsm81082155e9.4.2026.04.21.06.12.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 06:12:37 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776777159;\n x=1777381959;\n darn=lists.denx.de;\n h=in-reply-to:references:to:from:subject:cc:message-id:date\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=IFm9sO/NFzfNysPF3K7l6pPZQEpdtvoEauJaOMo6jxw=;\n b=yl5BBj/DivAycWyMAj1PHUEZllsOiThj61CHzd3Mqb/zXd3QFzpYFsAsfm3wqFvlkk\n 6wWoD+ILQgTL2k5s1mOk7XiVZWvxB2/wFutOxwWwgghhVEKl+mZw6hdXYx3Gc/0IsIU3\n WvmyJEOwn1IRNAPtjPZFEj8KJg0Vk7rnezVc+zBNxYs/j9smj8HYY0csnwEcAZtHeqls\n pcmF0gFA44ZVKSpp7vLZGNC/09UtglWD0Opqfyxc8Q0kChMg9ToTgRS+prBGKlehunaF\n i4rJN38UXNk0bw66VIPuyZJoBh/qD4QxEMtPMH5dEMFYMGLdFUULcrhjvvmuc/mIocFG\n E23A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776777159; x=1777381959;\n h=in-reply-to:references:to:from:subject:cc:message-id:date\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IFm9sO/NFzfNysPF3K7l6pPZQEpdtvoEauJaOMo6jxw=;\n b=lXeXGARBTdO8M1tfL3Pc5yFWvmkxbN9PBCThqtyqEfbdUb1IXuFKQZNBr0KcOJxmPL\n 3KZM9amFvsvcMyYMejNQ52933jAX0MM/D23BgQVHDDEXbqtROIF43cYOKxra//icbkVt\n BNiVxuZ0DAkPsckk0E4g0+zHgN7wLC0mu1iRDCVtd+eqoilP9MssK84aLUG2Ie07tYqg\n NFghy+xw/dAnBxIq9G1dAnyg4adZksKsYhtJqpnO+mSn+BBVMHAu+vU57ZnaL4IjhrFc\n 8C1G26j/br68vQ7s/xa6MD1ZYiGjJ0BcyeJbOqkdjloqMq6w9c/ot+/i723qeP4J1oQ6\n YzwQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+e07aOnG+h6lY1BVEfbHv8I0moGxSjqqS5kGfwCxzuQzzLLw6bm7CdBGZ9Hi9V7xjBygDRBBk=@lists.denx.de","X-Gm-Message-State":"AOJu0Yz3svs0Ootsz7zRbA7eNN5Xt/zWXU4Dflq4oa8sqrLBwnMaYr7i\n YkPytpz3JAERgyDN/2ZococU92sxeB6BRX8euh+Z3EsDxRKjedtQYBHyyH3nN4/a4lc=","X-Gm-Gg":"AeBDievEDi+6JjmqT9FxFRERKpPNZJW4dWV+eHvfZh8TT8u8vC/nEq28Mg3/37JpzA3\n waSyGVWvRXoGa5VsmIIj8TFIXhiq3A/Mbpu3XdcH4AfDAVLEEb9J8Gxw/WWB5pMbB8YCadt7zKc\n 51XmRRMoTAmTRKxekr/nDOmQqzvfT4Y2Q9j0Y2mlhX9nRBcJNZU98fbvn23pk0HTP2Lsp9kwPWs\n CC5tYbxhE5ntSZ+AAOnS3OAtWL2Si1qio0u2Gkf7PnSZih2qcq6266ZXVgkjtJIsqC05Uf1HiHt\n t649XgJ4KrzYR4m+Kv28t/inXiwu66OLGNhsrm0+8J1yTNkyoKB8zEs9aOlFCgI5XRu73gKBUW8\n lpuwx4IOUxNdJY72+mFzyG5V1NyfJ6iyoCDt6EbhV/1ET98EO7DCfM1UtL6AgpH9i2S+OvBvECq\n kn0OC0ftOlnuF8V576GUtodX55tg==","X-Received":"by 2002:a05:600c:1da1:b0:488:f453:b976 with SMTP id\n 5b1f17b1804b1-488fb7844c5mr287107005e9.27.1776777158809;\n Tue, 21 Apr 2026 06:12:38 -0700 (PDT)","Mime-Version":"1.0","Content-Type":"multipart/signed;\n boundary=87877e700a9a669c98cdb06f2bbfcc947d973bf787dc51a12144d055e49d;\n micalg=pgp-sha512; protocol=\"application/pgp-signature\"","Date":"Tue, 21 Apr 2026 15:12:27 +0200","Message-Id":"","Cc":", , ,\n , , , ,\n , , ,\n , ","Subject":"Re: [PATCH v2] board: ti: am335x: Conditional MDIO PAD\n configuration instead of static for AM335_ICE","From":"\"Markus Schneider-Pargmann\" ","To":"\"Parvathi Pudi\" , ,\n , ,\n , , ,\n ","X-Mailer":"aerc 0.21.0-126-g9e77103592fe","References":"<20260421123106.2885994-1-parvathi@couthit.com>","In-Reply-To":"<20260421123106.2885994-1-parvathi@couthit.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679889,"web_url":"http://patchwork.ozlabs.org/comment/3679889/","msgid":"","list_archive_url":null,"date":"2026-04-21T13:18:10","subject":"Re: [PATCH v2] board: ti: am335x: Conditional MDIO PAD\n configuration instead of static for AM335_ICE","submitter":{"id":82333,"url":"http://patchwork.ozlabs.org/api/people/82333/","name":"Markus Schneider-Pargmann","email":"msp@baylibre.com"},"content":"On Tue Apr 21, 2026 at 3:12 PM CEST, Markus Schneider-Pargmann wrote:\n> On Tue Apr 21, 2026 at 2:30 PM CEST, Parvathi Pudi wrote:\n>> This patch removes the static MDIO pinmux configuration from\n>> rmii1_pin_mux[] and instead configures the MDIO pins conditionally\n>> during board_init(). Previously, the MDIO_CLK and MDIO_DATA pins\n>> were always configured for CPSW in mux.c, which could lead to\n>> unnecessary pin ownership and conflicts in scenarios where CPSW\n>> is not used.\n>>\n>> With this change, the MDIO pins are configured only when required,\n>> ensuring that CPSW Ethernet functionality in U-Boot remains unaffected.\n>> This approach keeps Ethernet boot behavior intact and provides cleaner\n>> separation between CPSW and other Ethernet use cases.\n>>\n>> Signed-off-by: Parvathi Pudi \n>\n> Reviewed-by: Markus Schneider-Pargmann \n\nOops, that was supposed to be\n\nReviewed-by: Markus Schneider-Pargmann (TI) \n\n>\n> Looks good to me, one nitpick inline:\n>\n>> ---\n>> Changes from v1 to v2 :\n>> *) Adressed Markus Schneider-Pargmann's comments on this patch.\n>>\n>> board/ti/am335x/board.c | 11 +++++++++++\n>> board/ti/am335x/mux.c | 2 --\n>> 2 files changed, 11 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c\n>> index 90e37a8d913..f0a40cb82af 100644\n>> --- a/board/ti/am335x/board.c\n>> +++ b/board/ti/am335x/board.c\n>> @@ -28,6 +28,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> #include \n>> @@ -72,6 +73,12 @@ static struct ctrl_dev *cdev = (struct ctrl_dev *)CTRL_DEVICE_BASE;\n>> #define GPIO0_IRQSTATUSRAW\t(AM33XX_GPIO0_BASE + 0x024)\n>> #define GPIO1_IRQSTATUSRAW\t(AM33XX_GPIO1_BASE + 0x024)\n>> \n>> +static struct module_pin_mux rmii1_mdio_pin_mux[] = {\n>> +\t{OFFSET(mdio_clk), MODE(0) | PULLUP_EN},\t/* MDIO_CLK */\n>> +\t{OFFSET(mdio_data), MODE(0) | RXACTIVE | PULLUP_EN}, /* MDIO_DATA */\n>> +\t{-1},\n>> +};\n>> +\n>> /*\n>> * Read header information from EEPROM into global structure.\n>> */\n>> @@ -779,6 +786,10 @@ int board_init(void)\n>> \t\t\thang();\n>> \t\t}\n>> \n>> +\t\t/* Set the Mux Mode to MDIO_DATA, MDIO_CLK */\n>\n> I think it is ovious by the names. Can you please remove the comment?\n>\n> Best\n> Markus\n>\n>> +\t\tif (!eth0_is_mii)\n>> +\t\t\tconfigure_module_pin_mux(rmii1_mdio_pin_mux);\n>> +\n>> \t\tprueth_is_mii = eth0_is_mii;\n>> \n>> \t\t/* disable rising edge IRQs */\n>> diff --git a/board/ti/am335x/mux.c b/board/ti/am335x/mux.c\n>> index d2d87c304f6..36d849d2119 100644\n>> --- a/board/ti/am335x/mux.c\n>> +++ b/board/ti/am335x/mux.c\n>> @@ -190,8 +190,6 @@ static struct module_pin_mux mii1_pin_mux[] = {\n>> };\n>> \n>> static struct module_pin_mux rmii1_pin_mux[] = {\n>> -\t{OFFSET(mdio_clk), MODE(0) | PULLUP_EN},\t/* MDIO_CLK */\n>> -\t{OFFSET(mdio_data), MODE(0) | RXACTIVE | PULLUP_EN}, /* MDIO_DATA */\n>> \t{OFFSET(mii1_crs), MODE(1) | RXACTIVE},\t\t/* MII1_CRS */\n>> \t{OFFSET(mii1_rxerr), MODE(1) | RXACTIVE},\t/* MII1_RXERR */\n>> \t{OFFSET(mii1_txen), MODE(1)},\t\t\t/* MII1_TXEN */","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=JG/Xb7nG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"JG/Xb7nG\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=msp@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0NG9341sz1yGt\n\tfor ; Tue, 21 Apr 2026 23:18:25 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7726A83BC8;\n\tTue, 21 Apr 2026 15:18:22 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8129983C51; Tue, 21 Apr 2026 15:18:21 +0200 (CEST)","from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n [IPv6:2a00:1450:4864:20::336])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8054383BC4\n for ; Tue, 21 Apr 2026 15:18:19 +0200 (CEST)","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488ab2db91aso57093155e9.3\n for ; Tue, 21 Apr 2026 06:18:19 -0700 (PDT)","from localhost ([62.246.35.158]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a52583fe7sm93121845e9.13.2026.04.21.06.18.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 06:18:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776777499;\n x=1777382299;\n darn=lists.denx.de;\n h=in-reply-to:references:to:from:subject:cc:message-id:date\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=NwFrs7Sm4coBbV5Ej1N+P+msjENIUmHKxzvVx0QUMqc=;\n b=JG/Xb7nGiE4d/2I0GAwqh3ulQwdvO1PUzsTxryVdxMmDW7KpFt0XqPl6qUS0xxvylV\n 7adzZizSE5SnXV4MF9gkD4hHlnixnWsBaju7LMWDeGPjvgE6mLCEQuub7lbklO7UVsZZ\n uZsCf/ukECvoDugclyA/dsMmpjIronlw6gtpt24NzcoxpUjikuoBPrxiNZ1C4eCke0J8\n rvqfomEaE5KfeGYL3/TXr7Z3tSx6OobFq9vnDFfnoLlXge2F8bOGrko2eHWQ7eTGQnEv\n WiNq6b8UJpSHHnkUCpBQ56264bzjxMik//5Vm/PVK4qer/C/rnYJpu+6mIiOwHvxcJRm\n coIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776777499; x=1777382299;\n h=in-reply-to:references:to:from:subject:cc:message-id:date\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NwFrs7Sm4coBbV5Ej1N+P+msjENIUmHKxzvVx0QUMqc=;\n b=F79qKZra/RhKkmgsJhWsoZn4uZcKNGaBGmgHZ46meVNvpXcYgcKl1YFa9d7y/Xc8PG\n fHYh+1zLGWyyRrnBcX0ZSDAmoXh0UXaL0rO+z/5SMq+lde6uqzCG5BlD6krCmHoFy1mZ\n 357ciSRuYeZigB7ZsbsSNW+AIX67O9e0NLr4sUf8NgtJGAeHZptAiPRbHb1tL60o9u5/\n 85cbxJcL+xwHJac/YHM5CwOLL/E3G3S6Kuy/+C+txVL9lyJtu0Fv1JY9ORqyprIU8mEN\n HQfK3SyJlZFqMnmN02FbpdFbvawqYhOKpmH67HLXr5ldbZKbZyKRpF6nBgf518n3r6Uq\n NhGA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/M35Z+B+vaUAC3jHL9ff24VPKF7qU2rLhCTTvSonlntF4j5C3p4O5+Risy8rczDUXRlEQX1Fk=@lists.denx.de","X-Gm-Message-State":"AOJu0Yw9OKBeVn9ndLmtYKJQwPGg405lpPBG7EDQfVibvMkN3IdGaSz4\n fao0du/m2kEg8graSW5B79Ez2njRCqAJuQMwxyTeerTGFDpBdF4kPOCDAKq4XEcE62A=","X-Gm-Gg":"AeBDieu6N4QjS8Kw2+eVGz3wn4HMyP4CPTOq5iBAoG4zG6zZEiuir/4XEpKiW9uvSc/\n ngJ0hpxtzuxQP6PeTs9qegMGoTLB+PyK94Q3gGygQ67x2Q62DgJRoSdyYd6zq2XhiS903BfYWaD\n ZhHCV5tRYO6KCzd8o63YNiC+BKz4k2g9liA/cFgZrYxCkjb8JLA7S2MSP2DT0BVWY+LwjhaOTX9\n Wlo/cZ7BsWjx2DY+Vu4hZjFh1Mkhh8z8v/Lpy5I4uBOmRt+6ZENTQMgrT4iaWOUl3EztpO0wdzo\n ghtZ+cGrCghmUTY6ZT2buhjbw6RAqC3+Q9oPM8mhI+HSqxtSBSdewe9CXVBnDnKcmKD7e7JhSZO\n 3EZHFpjDkh2uFHju/y/TUjgEcaUV3yxN9brR7vfMvoH7UZ3Pq7UiP3KxdXloDiEA3VK5Z/2iI57\n fTT+Hl3BYtMWhgaXT5LEjB7x9MGg==","X-Received":"by 2002:a05:600c:4e8f:b0:48a:56cd:5266 with SMTP id\n 5b1f17b1804b1-48a56cd549bmr29267135e9.4.1776777498704;\n Tue, 21 Apr 2026 06:18:18 -0700 (PDT)","Mime-Version":"1.0","Content-Type":"multipart/signed;\n boundary=3418c0162d01e621aa9cc83e409070b0230fb3ab63e7546cb2239f3554fc;\n micalg=pgp-sha512; protocol=\"application/pgp-signature\"","Date":"Tue, 21 Apr 2026 15:18:10 +0200","Message-Id":"","Cc":", , ,\n , , , ,\n , , ,\n , ","Subject":"Re: [PATCH v2] board: ti: am335x: Conditional MDIO PAD\n configuration instead of static for AM335_ICE","From":"\"Markus Schneider-Pargmann\" ","To":"\"Markus Schneider-Pargmann\" , \"Parvathi Pudi\"\n , , ,\n , ,\n , ","X-Mailer":"aerc 0.21.0-126-g9e77103592fe","References":"<20260421123106.2885994-1-parvathi@couthit.com>\n ","In-Reply-To":"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3680595,"web_url":"http://patchwork.ozlabs.org/comment/3680595/","msgid":"<2073702355.985026.1776860024162.JavaMail.zimbra@couthit.local>","list_archive_url":null,"date":"2026-04-22T12:13:44","subject":"Re: [PATCH v2] board: ti: am335x: Conditional MDIO PAD\n configuration instead of static for AM335_ICE","submitter":{"id":90270,"url":"http://patchwork.ozlabs.org/api/people/90270/","name":"Parvathi Pudi","email":"parvathi@couthit.com"},"content":"Hi Markus,\n\n> On Tue Apr 21, 2026 at 2:30 PM CEST, Parvathi Pudi wrote:\n>> This patch removes the static MDIO pinmux configuration from\n>> rmii1_pin_mux[] and instead configures the MDIO pins conditionally\n>> during board_init(). Previously, the MDIO_CLK and MDIO_DATA pins\n>> were always configured for CPSW in mux.c, which could lead to\n>> unnecessary pin ownership and conflicts in scenarios where CPSW\n>> is not used.\n>>\n>> With this change, the MDIO pins are configured only when required,\n>> ensuring that CPSW Ethernet functionality in U-Boot remains unaffected.\n>> This approach keeps Ethernet boot behavior intact and provides cleaner\n>> separation between CPSW and other Ethernet use cases.\n>>\n>> Signed-off-by: Parvathi Pudi \n> \n> Reviewed-by: Markus Schneider-Pargmann \n> \n\nThanks for the review.\n\n> Looks good to me, one nitpick inline:\n> \n>> ---\n>> Changes from v1 to v2 :\n>> *) Adressed Markus Schneider-Pargmann's comments on this patch.\n>>\n>> board/ti/am335x/board.c | 11 +++++++++++\n>> board/ti/am335x/mux.c | 2 --\n>> 2 files changed, 11 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c\n>> index 90e37a8d913..f0a40cb82af 100644\n>> --- a/board/ti/am335x/board.c\n>> +++ b/board/ti/am335x/board.c\n>> @@ -28,6 +28,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> #include \n>> @@ -72,6 +73,12 @@ static struct ctrl_dev *cdev = (struct ctrl_dev\n>> *)CTRL_DEVICE_BASE;\n>> #define GPIO0_IRQSTATUSRAW\t(AM33XX_GPIO0_BASE + 0x024)\n>> #define GPIO1_IRQSTATUSRAW\t(AM33XX_GPIO1_BASE + 0x024)\n>> \n>> +static struct module_pin_mux rmii1_mdio_pin_mux[] = {\n>> +\t{OFFSET(mdio_clk), MODE(0) | PULLUP_EN},\t/* MDIO_CLK */\n>> +\t{OFFSET(mdio_data), MODE(0) | RXACTIVE | PULLUP_EN}, /* MDIO_DATA */\n>> +\t{-1},\n>> +};\n>> +\n>> /*\n>> * Read header information from EEPROM into global structure.\n>> */\n>> @@ -779,6 +786,10 @@ int board_init(void)\n>> \t\t\thang();\n>> \t\t}\n>> \n>> +\t\t/* Set the Mux Mode to MDIO_DATA, MDIO_CLK */\n> \n> I think it is ovious by the names. Can you please remove the comment?\n>\n\nSure, we will address this and post the next version shortly.\n\nThanks and Regards,\nParvathi.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=couthit.com header.i=@couthit.com header.a=rsa-sha256\n header.s=default header.b=23f+/PH4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=couthit.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=couthit.com header.i=@couthit.com header.b=\"23f+/PH4\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=couthit.com","phobos.denx.de;\n spf=pass smtp.mailfrom=parvathi@couthit.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0zGZ5Rc2z1yD5\n\tfor ; Wed, 22 Apr 2026 22:35:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 964A584308;\n\tWed, 22 Apr 2026 14:34:34 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C96CE84198; Wed, 22 Apr 2026 14:14:03 +0200 (CEST)","from server.couthit.com (server.couthit.com [162.240.164.96])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 44C3683FFA\n for ; Wed, 22 Apr 2026 14:13:56 +0200 (CEST)","from [115.246.246.98] (port=37165 helo=zimbra.couthit.local)\n by server.couthit.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384\n (Exim 4.98.1) (envelope-from )\n id 1wFWSl-0000000AoLH-40Aj; Wed, 22 Apr 2026 08:13:52 -0400","from localhost (localhost [127.0.0.1])\n by zimbra.couthit.local (Postfix) with ESMTP id B17801A414CE;\n Wed, 22 Apr 2026 17:43:45 +0530 (IST)","from zimbra.couthit.local ([127.0.0.1])\n by localhost (zimbra.couthit.local [127.0.0.1]) (amavis, port 10032)\n with ESMTP id IQE31BruTnm9; Wed, 22 Apr 2026 17:43:44 +0530 (IST)","from localhost (localhost [127.0.0.1])\n by zimbra.couthit.local (Postfix) with ESMTP id 4C68A1A414CA;\n Wed, 22 Apr 2026 17:43:44 +0530 (IST)","from zimbra.couthit.local ([127.0.0.1])\n by localhost (zimbra.couthit.local [127.0.0.1]) (amavis, port 10026)\n with ESMTP id JarF3TsP3JA0; Wed, 22 Apr 2026 17:43:44 +0530 (IST)","from zimbra.couthit.local (zimbra.couthit.local [10.10.10.103])\n by zimbra.couthit.local (Postfix) with ESMTP id 2FF211A414CE;\n Wed, 22 Apr 2026 17:43:44 +0530 (IST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=couthit.com\n ; s=default;\n h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:\n References:In-Reply-To:Message-ID:Cc:To:From:Date:Sender:Reply-To:Content-ID:\n Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n List-Post:List-Owner:List-Archive;\n bh=QflfeTXZTcK5THQfpIFqDYUOKVSahcLfmD2w355EQdY=; b=23f+/PH4RQsptL1M4dljKLdWvZ\n GFXoSU5YOVXJcVL9dIYtHVoWGRcUi2o4SqB0WcPzzslMrwuQSIasqLtxiqAE18L4Et7YlK4Rc2SZg\n gr6H3qt0p4A6ONyLVxRRxw4izio/RPVo/L609ih1fvHbx58DuNTDBzgOuGOyiqXPh3kS/RZw8Qu5V\n sO6F+cf3Xn4ksRpBOWnEn6WYVrJMAxtbe/Y8+0xOoFFbv3PZ8v49jVIWVAR9MCZdpUH6F7esdiS2M\n eFTKmd/I5cT05Mp7OKthxWZNYi8yqS8aJRGVUDx9VS17lfC3GKQ7XU0ko3Vc8aYEHdj7wjXVY2+Uw\n JQbNbdIQ==;","Date":"Wed, 22 Apr 2026 17:43:44 +0530 (IST)","From":"Parvathi Pudi ","To":"Markus Schneider-Pargmann ","Cc":"Parvathi Pudi , u-boot ,\n trini , Maarten Brock ,\n kory maincent ,\n sbellary ,\n romain gantois ,\n pratheesh , j-rameshbabu ,\n praneeth , Vignesh Raghavendra ,\n srk , rogerq ,\n danishanwar , m-malladi ,\n krishna , mohan ,\n pmohan , basharath ","Message-ID":"<2073702355.985026.1776860024162.JavaMail.zimbra@couthit.local>","In-Reply-To":"","References":"<20260421123106.2885994-1-parvathi@couthit.com>\n ","Subject":"Re: [PATCH v2] board: ti: am335x: Conditional MDIO PAD\n configuration instead of static for AM335_ICE","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.10.10.233]","X-Mailer":"Zimbra 9.0.0_ZEXTRAS_20240927 (ZimbraWebClient - GC138\n (Linux)/9.0.0_ZEXTRAS_20240927)","Thread-Topic":"board: ti: am335x: Conditional MDIO PAD configuration instead of\n static for AM335_ICE","Thread-Index":"G83+gw8EplzvAdIGsmAsmbv5QCNmaQ==","X-AntiAbuse":["This header was added to track abuse,\n please include it with any abuse report","Primary Hostname - server.couthit.com","Original Domain - lists.denx.de","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - couthit.com"],"X-Get-Message-Sender-Via":"server.couthit.com: authenticated_id:\n smtp@couthit.com","X-Authenticated-Sender":"server.couthit.com: smtp@couthit.com","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Mailman-Approved-At":"Wed, 22 Apr 2026 14:34:21 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]