[{"id":3680116,"web_url":"http://patchwork.ozlabs.org/comment/3680116/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:50:01","subject":"Re: [PATCH] gpio: 74x164: use dev_read_* APIs for live-tree\n compatibility","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Chanhong,\n\nOn 2026-04-21T08:08:47, Chanhong Jung wrote:\n> gpio: 74x164: use dev_read_* APIs for live-tree compatibility\n>\n> With CONFIG_OF_LIVE=y, dev_of_offset(dev) does not return a valid\n> flat-FDT offset, so fdtdec_get_int(gd->fdt_blob, offset, ...) inside\n> gen_74x164_probe() fails to locate the 'registers-number' property and\n> always falls back to the default value of 1. This results in a 4-chip\n> 74HC595 daisy chain being exposed as only 8 GPIOs instead of 32, and\n> any consumer referencing offsets >= 8 fails to bind with -ENOENT\n> (\"GPIO ... not found\" / Error -22).\n>\n> The 'registers-default' property is ignored for the same reason, so\n> any configured power-on output pattern is silently discarded.\n>\n> Replace the flat-FDT helpers with dev_read_u32_default() and\n> dev_read_u8_array_ptr(), which correctly walk both live and flat\n> trees. This matches how other DM GPIO drivers (e.g. pca953x_gpio.c)\n> read their per-device properties.\n>\n> Tested on stm32mp153d-ssonic (CONFIG_OF_LIVE=y) with a 4-chip 74HC595\n> chain: all 32 GPIOs are now exposed, and 16 consumer LED nodes at\n> [...]\n>\n> drivers/gpio/74x164_gpio.c | 13 ++++++-------\n> 1 file changed, 6 insertions(+), 7 deletions(-)\n\n> diff --git a/drivers/gpio/74x164_gpio.c b/drivers/gpio/74x164_gpio.c\n> @@ -10,7 +10,6 @@\n> -#include \n\nIt looks like gd->fdt_blob is no longer used, so please can you also\nremove DECLARE_GLOBAL_DATA_PTR and the include?\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=UP1Hjlxs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"UP1Hjlxs\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cy25K3Xz1yD5\n\tfor ; Wed, 22 Apr 2026 08:50:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5AE798419C;\n\tWed, 22 Apr 2026 00:50:16 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B20BF841F2; Wed, 22 Apr 2026 00:50:15 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n [IPv6:2a00:1450:4864:20::630])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CA84183AC5\n for ; Wed, 22 Apr 2026 00:50:13 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id\n a640c23a62f3a-b941762394aso649946066b.1\n for ; Tue, 21 Apr 2026 15:50:13 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811813; cv=none;\n d=google.com; s=arc-20240605;\n b=Qp+cS+dynf5/YQaE6ZXTiHM4eYPOgBP+M0H2RetjQlrQa6lKJkOOLkbMmTGoMt1gem\n lou3XhMdP+RnJkFMeVxpN0wPy0UXOtCVF7e9dri+x+QN3MfkLZy3d9jcEFbpYmfixf3U\n 6+zIpJ7+nvjp/aKXbFJQcu88vLdMuf9vqgOXkC50+RfUS+NsDxoQ/WjEU7TlS4wvszUK\n ivx9IFt0KxH//wr77cdUhzmPudz/bGUebaeIepZUGnh9DG4Pb7FHqK8uPRz1cLF44xyb\n tTBf4XjeheYnDpbNonEHTtY7y041NgvQgic3/rZ5Y1K3U6tA26pdjU8h70TvrScEKRJf\n In/w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=4laSJWwq5j9mgWzrTu0vaaBVsCZIZdBeYfVdcXMApys=;\n fh=KO8QE6rRQVYIJkxoHmLSBiK0P81qKBABPT4f61JE6nY=;\n b=Zoc9GzeJq3E4KrV2HsHpLLPh/Uvh3WP6mBZv+5r2JuwLjJ/KPMz2xbduNEHRTJ0QMm\n 1GOVhkzE+MpADqbHKcXafd8mjdKpur2xSCKBkgqZRoGT9Jf0vlaEGcnXvPmPTQjtm3pO\n JGNDXJNr/HrgPW6jg4Ajp/vWrjDtEUGRRXDNzM/0SAtkeCVwIm2bO8Sdg2hUpYQrL0UL\n ia4oyXiqJ3Zj6s9JHyvttbbsvvD3NrGT4oUwQmJ92Y+UyDeCblw5weRLRp8HFnFBcd8L\n E0gWXMqRZE9oV7Yni4tz0FxBtYAu/LnN8O3qROXB91bvrrOgPuHiPl30vFqupVH41u1E\n JnZQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811813; x=1777416613; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=4laSJWwq5j9mgWzrTu0vaaBVsCZIZdBeYfVdcXMApys=;\n b=UP1Hjlxsxg31124vXgdS6WI4t1QL/b/E1no46zoLjp6r9i6OmwiE20BpGd3h46M0tu\n feuRsWHOMiEx7l0Ivi+dFj319VEPuvED6A52PdBRIegZEtuS3Y684A4g/p83HsZnqWnq\n blcdZN6I0sKruG5iGyROz7vDGixJdDz/pYLrM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811813; x=1777416613;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4laSJWwq5j9mgWzrTu0vaaBVsCZIZdBeYfVdcXMApys=;\n b=kHRQnIudEI2rTjPU7J2dE1B46mSBimr3ztN5dGln0wgjHWnfxPGQOKU/1FBjDXqSE8\n H7O3q2YvxCc4Xphbb2ty8eFoR1dcLlLlvaZ8qdmCDALpe50Tuy+AslXpsSl9qQ0jgjJ2\n +JqEVKSAKUsOvBjyz5RMAdMXKlLJrH/s2KkLIpmY6EGQvrLbfUrlQogf4zi9SmC1kH7g\n WCeC859qdziLQX1qxpr2sWLjybJr85J3/rmrSCpOX1Ci0wy4B2QCU3Z0UfSKSn6B5VX+\n IvDsW9stjzTc6fe8joFXwPOinizO82dzmwEfBHOZ67lNhDNr2mHcnVZ/17PMwoLnbuU0\n nBUQ==","X-Gm-Message-State":"AOJu0YztOYfZiTOk7IV06tmP8D76J5X+wBNxBy8DkXVPWoTyHcFgNh58\n 9aqrF7KnsTi+DZQ/Ka+jjPvsTcKJo9HLkHZhYZZtCUd3yyJh5ZJv7dLC0YBIpVhBJABFUhps1lt\n xslSW5hCGFNKfoDK9aFLHImgGU+5q2u6z4CRQCtuO","X-Gm-Gg":"AeBDiesYewTLFM+9rjJDCtHcThISEknUn0rlsH9c82rq99mCnIfg0JUA2iAXtwflrgV\n wdHPTWbrshDZxWnLQcFeOenYO+CvyOOp8m/kwA3zQ6sqcaH5GPwyL6qNYHbnYv4CRgTsE5TVVgU\n V9O6CWBAl4om/AOOCV/8HbBQJgkPURzQI6U2ySwDxF6/eRERCoPsSD2IA10mvR6dsVlhrjVUr6b\n C2H2APrdXd16N0drMfofeQjlSbEMYgWOJLeOexaOgCY4oHICqGz5phJZv+z78SliRAaHdBYgE/X\n y1RgCoXa3SjiguzpEjyI","X-Received":"by 2002:a17:907:1b09:b0:b9d:e69b:58f7 with SMTP id\n a640c23a62f3a-ba41945c089mr983522966b.21.1776811813209; Tue, 21 Apr 2026\n 15:50:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421080847.235789-1-happycpu@gmail.com>","In-Reply-To":"<20260421080847.235789-1-happycpu@gmail.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:50:01 +1200","X-Gm-Features":"AQROBzCjTPuaPluwuLXNi6HipTSCrpTKxJYbB0M6c-dAaEPEbYGT8Am_wafiyBA","Message-ID":"\n ","Subject":"Re: [PATCH] gpio: 74x164: use dev_read_* APIs for live-tree\n compatibility","To":"happycpu@gmail.com","Cc":"u-boot@lists.denx.de, trini@konsulko.com, sjg@chromium.org,\n peng.fan@nxp.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]