[{"id":3681936,"web_url":"http://patchwork.ozlabs.org/comment/3681936/","msgid":"","list_archive_url":null,"date":"2026-04-24T10:01:09","subject":"Re: [PATCH v4 8/8] arm64: dts: amlogic: t7: khadas-vim4: Add i2c MCU\n fan node","submitter":{"id":84903,"url":"http://patchwork.ozlabs.org/api/people/84903/","name":"Neil Armstrong","email":"neil.armstrong@linaro.org"},"content":"On 4/21/26 13:49, Ronald Claveau via B4 Relay wrote:\n> From: Ronald Claveau \n> \n> Enable and configure i2c MCU node to get fan working on Khadas VIM4.\n> \n> Signed-off-by: Ronald Claveau \n> ---\n> .../boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts\n> index 69d6118ba57e7..5d7f5390f3a66 100644\n> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts\n> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts\n> @@ -157,6 +157,19 @@ wifi32k: wifi32k {\n> \t};\n> };\n> \n> +&i2c_m_ao_a {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&i2c0_ao_d_pins>;\n> +\tpinctrl-names = \"default\";\n> +\n> +\tkhadas_mcu: system-controller@18 {\n> +\t\tcompatible = \"khadas,vim4-mcu\";\n> +\t\treg = <0x18>;\n> +\t\tfan-supply = <&vcc5v>;\n> +\t\t#cooling-cells = <2>;\n> +\t};\n> +};\n> +\n> &pwm_ab {\n> \tstatus = \"okay\";\n> \tpinctrl-0 = <&pwm_a_pins>;\n> \n\nReviewed-by: Neil Armstrong \n\nThanks,\nNeil","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EDACZSUS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17163-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"EDACZSUS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.44","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linaro.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g27qQ3dbvz1yDD\n\tfor ; Fri, 24 Apr 2026 20:04:50 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 3D90330398AE\n\tfor ; Fri, 24 Apr 2026 10:01:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EE7883624A1;\n\tFri, 24 Apr 2026 10:01:15 +0000 (UTC)","from mail-wm1-f44.google.com (mail-wm1-f44.google.com\n [209.85.128.44])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 43C403603D7\n\tfor ; Fri, 24 Apr 2026 10:01:14 +0000 (UTC)","by mail-wm1-f44.google.com with SMTP id\n 5b1f17b1804b1-48909558b3aso71018715e9.0\n for ; Fri, 24 Apr 2026 03:01:14 -0700 (PDT)","from ?IPV6:2a01:e0a:106d:1080:79e1:f56b:445c:ca9c?\n ([2a01:e0a:106d:1080:79e1:f56b:445c:ca9c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a6124d7e7sm136810305e9.5.2026.04.24.03.01.09\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 24 Apr 2026 03:01:10 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777024875; cv=none;\n b=u/9RE2n/wwQoNwIQix05S+1P50+eb2FXh3RWOc39tugfxSUOwGf00tOIlmM4qgx1+0nEOBrbDsKBvQofldA8ARJnTG/gFZs0SYCoFbeNx3RLfmPxTKsz1JCYWKZevSiFITF5nUIefTmXEXcwdMySlcbqgBYJB82L0XMFyBFaBNw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777024875; c=relaxed/simple;\n\tbh=i1XmD08sPVyfPetMqZOauvZ1ZD4xqB1oOz6geubur0Y=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=P7LuFwHuUw4s2IzX/0CXtAcxwes4vRPTq/iW6INM1TjKbIpMLZv6FeVdHTq53l855uRKyPlOU/dkzjU7mBYTxuGCJftPAJKz3H9iMp3/gXiGGOxSnJ/Cbfq6DJdPmsm7HL/Q5GJqq6X+gbkusJEoVmqdaJ8UiGr/Dg7IWY1GTJk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org;\n spf=pass smtp.mailfrom=linaro.org;\n dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=EDACZSUS; arc=none smtp.client-ip=209.85.128.44","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777024873; x=1777629673;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to;\n bh=QsMn/6Mklq7GQLtU1u5HkQpW7v3yh2oa94aAy8k1B2Q=;\n b=EDACZSUSirW4+wDj/q+LI7M4bFpKMkITehz4y4HjEHR4Fs84qHr7uP5eDSef5dMNBl\n A1d22OyEqCbR52Tbc2pVAWPBLAjgrmXFBUPXR84zfpfs3MOyuZhE8+Sr8Cmcp3BUNmfW\n 5GiW4i/bXcHgsW+7cOLUxAxZ1nyASWmEIsJ1ZakKb5Z+TDmNcdX8U1v1TiPlUPANCRsk\n LJhb9aTmttrgweiiKkL5JI5IwF5jpm/nbyFJmrbJMesSkQOr7LY6sFgfxaM86JDM56+a\n KnnCEdsw+Gs7NANRwQzGYn9czUAKbetaXMXN8tSPAXQiJD9zeKZZrH9E8T9CLRTxLR9Z\n BdlQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777024873; x=1777629673;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=QsMn/6Mklq7GQLtU1u5HkQpW7v3yh2oa94aAy8k1B2Q=;\n b=XpV8DRhtoIHwvS7DYLrmoGwNgZZR6TC/OvYmSwr38grpfGu/UimwG5Hd/aKiwyZfLN\n W1ODSn50x0GP5ycsmJ33UQwjwafenNk9VupKj0/MMJHol5crPbxmKkvj9TdQOBmtOybV\n C60XOApOkGQxegzuTk2wWqSOQWUpC5kl8uASQv9gMOc9rtMml+wi9BX7NVRnp0KOmX7t\n eMRwEOyH/ASRtu9BJ4qEq3WDZQbO/z2L/3S3mt4oT4cYihZKajdSh5Y29YivZu63tiD8\n IhkV/kquzwh1+YVr6YG0t3dUi86xv+yPPTkah3CQzjoBqD2TfyidEVcSvqfklLegI58v\n RS+A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8HNVjuBpXXVlWGMF+aSQiEkDAm9SGv1IvNfehrE8/1vUvrBZ76Pc6xYdJwHpTh9JXmT4jQsAkIfKw=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yxj4W7JH0RvXftafkJzPxoQ7UI80qwLiPc/yC1ozU1hXRRv+9Ac\n\tbjxPhquRtJGQDAF/zYV0XXQEyWhGcqZDzz6Gbrxv0BEvzFh1+2ztGATqEPBVcPyig+I=","X-Gm-Gg":"AeBDieveEG/0D+szRBnksuEdgXyzM70LkTacg8eDnWzHLfHEImPIH440q3sCprp2ALs\n\ts5qsck58mehj7nj4JsukRAtmotcUxynsBYqHQT3233+LafFTydpkjc6YHqN2t2CexC3V1GnR/6u\n\tB/wRo7tDZe04qR0VHpWPuzGGVkC/Wfve/TpQA4yUhHSp83dOPOZXQOFmO+lPwfr5cGyrGhTkhau\n\tmOuNwxGzJUpgPFRJcUZLSSrt2d8yNqGgnEmMezExeviAqDyHjICVo0pT89tu2fo/F+rpX01kQgb\n\tDdGSebhq13XgG1uMc/5i7MEwMSMjpiilHubmjLys8LXFBoyAE6NyQYkXzMZ1pe70TRxIq7mhdPW\n\tQpOmMWT/gsbzRLlwppmqCrCgo2QKN7A+GOIpGg1hANZTB5AReKJyKr0cmLIbQ+nL7KZTdmwbkQQ\n\tWKls2G8i/EFE0HvGgadhDY6n2qCLAaVJtjIFGE+8McbadjrIC02WIY2ejQtxMYp2P3p4jJ9Xt/q\n\toNPVTvsq+J9+bCs3g==","X-Received":"by 2002:a05:600c:350e:b0:488:a82f:bb95 with SMTP id\n 5b1f17b1804b1-488fb7861c0mr465740345e9.29.1777024870872;\n Fri, 24 Apr 2026 03:01:10 -0700 (PDT)","Message-ID":"","Date":"Fri, 24 Apr 2026 12:01:09 +0200","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Neil Armstrong ","Reply-To":"Neil Armstrong ","Subject":"Re: [PATCH v4 8/8] arm64: dts: amlogic: t7: khadas-vim4: Add i2c MCU\n fan node","To":"linux-kernel-dev@aliel.fr, Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org","References":"<20260421-add-mcu-fan-khadas-vim4-v4-0-447114a28f2d@aliel.fr>\n <20260421-add-mcu-fan-khadas-vim4-v4-8-447114a28f2d@aliel.fr>","Content-Language":"en-US, fr","Autocrypt":"addr=neil.armstrong@linaro.org; keydata=\n xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP\n GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4\n BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9\n qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik\n 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB\n AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA\n OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk\n Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04\n YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ\n GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw\n UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa\n GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r\n yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp\n QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+\n SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY\n 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM\n Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX\n oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn\n M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3\n 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS\n KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy\n 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT\n QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g","Organization":"Linaro","In-Reply-To":"<20260421-add-mcu-fan-khadas-vim4-v4-8-447114a28f2d@aliel.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]