[{"id":3681924,"web_url":"http://patchwork.ozlabs.org/comment/3681924/","msgid":"","list_archive_url":null,"date":"2026-04-24T09:55:14","subject":"Re: [PATCH v4 3/8] mfd: khadas-mcu: Add per-variant configuration\n infrastructure and VIM4 support","submitter":{"id":84903,"url":"http://patchwork.ozlabs.org/api/people/84903/","name":"Neil Armstrong","email":"neil.armstrong@linaro.org"},"content":"On 4/21/26 13:49, Ronald Claveau via B4 Relay wrote:\n> From: Ronald Claveau \n> \n> Introduce a per-variant configuration structure (khadas_mcu_data)\n> holding the regmap config and MFD cells,\n> selected at probe time via the of_device_id match data.\n> This makes adding other variants straightforward.\n> \n> Also introduce khadas_mcu_fan_pdata to pass fan register address and\n> maximum level to the fan sub-driver, removing the hardcoded constants.\n> \n> Signed-off-by: Ronald Claveau \n> ---\n> include/linux/mfd/khadas-mcu.h | 39 +++++++++++++++++++++++++++++++++++++--\n> 1 file changed, 37 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/linux/mfd/khadas-mcu.h b/include/linux/mfd/khadas-mcu.h\n> index a99ba2ed0e4e0..75e275d3fa8d9 100644\n> --- a/include/linux/mfd/khadas-mcu.h\n> +++ b/include/linux/mfd/khadas-mcu.h\n> @@ -70,6 +70,13 @@\n> #define KHADAS_MCU_WOL_INIT_START_REG\t\t0x87 /* WO */\n> #define KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG\t0x88 /* WO */\n> \n> +/* VIM4 specific registers */\n> +#define KHADAS_MCU_VIM4_REST_CONF_REG\t\t0x2c /* WO - reset EEPROM */\n> +#define KHADAS_MCU_VIM4_LED_ON_RAM_REG\t\t0x89 /* WO - LED volatile */\n> +#define KHADAS_MCU_VIM4_FAN_CTRL_REG\t\t0x8a /* WO */\n> +#define KHADAS_MCU_VIM4_WDT_EN_REG\t\t0x8b /* WO */\n> +#define KHADAS_MCU_VIM4_SYS_RST_REG\t\t0x91 /* WO */\n> +\n> enum {\n> \tKHADAS_BOARD_VIM1 = 0x1,\n> \tKHADAS_BOARD_VIM2,\n> @@ -82,10 +89,38 @@ enum {\n> * struct khadas_mcu - Khadas MCU structure\n> * @device:\t\tdevice reference used for logs\n> * @regmap:\t\tregister map\n> + * @data:\t\tpointer to variant-specific config\n> */\n> struct khadas_mcu {\n> -\tstruct device *dev;\n> -\tstruct regmap *regmap;\n> +\tstruct device\t\t\t*dev;\n> +\tstruct regmap\t\t\t*regmap;\n> +\tconst struct khadas_mcu_data\t*data;\n> +};\n> +\n> +/**\n> + * struct khadas_mcu_data - per-variant configuration\n> + * @regmap_config:\tregmap configuration\n> + * @cells:\t\tMFD sub-devices\n> + * @ncells:\t\tnumber of sub-devices\n> + * @fan_cells:\t\tMFD fan sub-devices\n> + * @nfan_cells:\t\tnumber of fan sub-devices\n> + */\n> +struct khadas_mcu_data {\n> +\tconst struct regmap_config\t*regmap_config;\n> +\tconst struct mfd_cell\t\t*cells;\n> +\tint\t\t\t\tncells;\n> +\tconst struct mfd_cell\t\t*fan_cells;\n> +\tint\t\t\t\tnfan_cells;\n> +};\n> +\n> +/**\n> + * struct khadas_mcu_fan_pdata - fan sub-driver configuration\n> + * @fan_reg: register address to write the fan level\n> + * @max_level: maximum fan level\n> + */\n> +struct khadas_mcu_fan_pdata {\n> +\tunsigned int fan_reg;\n> +\tunsigned int max_level;\n> };\n> \n> #endif /* MFD_KHADAS_MCU_H */\n> \n\nReviewed-by: Neil Armstrong \n\nThanks,\nNeil","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=lBI1Xh8s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17158-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"lBI1Xh8s\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linaro.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g27cl2Q2Cz1xvV\n\tfor ; Fri, 24 Apr 2026 19:55:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C73233017042\n\tfor ; Fri, 24 Apr 2026 09:55:22 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6A27435A3BE;\n\tFri, 24 Apr 2026 09:55:19 +0000 (UTC)","from mail-wm1-f46.google.com (mail-wm1-f46.google.com\n [209.85.128.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 962B3358D3D\n\tfor ; Fri, 24 Apr 2026 09:55:17 +0000 (UTC)","by mail-wm1-f46.google.com with SMTP id\n 5b1f17b1804b1-4891e5b9c1fso57724105e9.2\n for ; Fri, 24 Apr 2026 02:55:17 -0700 (PDT)","from ?IPV6:2a01:e0a:106d:1080:79e1:f56b:445c:ca9c?\n ([2a01:e0a:106d:1080:79e1:f56b:445c:ca9c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc18bccfsm526904435e9.8.2026.04.24.02.55.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 24 Apr 2026 02:55:15 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777024519; cv=none;\n b=YyN+WqTKzofIxxPmKtH8R+YOsc8GJzgXAbhzNJilRER0NGMOxsiHZVEElpAi8s9wpM8zgb8+NX8k7CaOY//zRVcnvZWtHUvnZbGVMdCBCSH0dO2Z1U3i4HM6kWcFDhnAP3VUppbbsNdavB9c6TPGedczia1PipKLp8lNfiv1sHw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777024519; c=relaxed/simple;\n\tbh=jRMM/hN8U1NhGO9xpDfgyFzsl6yuuvYEuypvB1mVf20=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=ELjLeRN4M08+cVnNhxiTgDB8lOZH55qeNE1i2yRSi3tpC2vZ0QoPmlogix4VHizIFFNKU7k9mTy94rBRJmJTejk1DwMHfroPyPbtE+qszlEy49cd7CXUJXVGoWGb8Cy8GRfg0QNoO3ZgIGv5Qmu2R9XZNeULgQ9IXr/4oJD1jaE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org;\n spf=pass smtp.mailfrom=linaro.org;\n dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=lBI1Xh8s; arc=none smtp.client-ip=209.85.128.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777024516; x=1777629316;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to;\n bh=e+of0FE0tSbmaf7cezfG/Dp70p8BpOoi594bsa5N30Y=;\n b=lBI1Xh8sAV7sTCdwuXchyqeOFX3nHuRDVMqyYHDLNidoLcaF0RshABFEGznBGzQ/Ib\n X/jQoJeY4pa/oH+vabzeTBIU8RBk0cgqiMqA9uslitiRfQat/bDAvd9t2Ajr2TGCEVwc\n 3Wuz8CULk3dtKI/MuU/3+lX8KEFR1L1cC4GK01jiAiLY8VWcP4I3aVaHb/VZdNia/gcc\n UPlELyI+45RxECpOPImegZzy2RbVj8iKkwMA7Z/Zx4/Z/Q3uIAMJ+x4VvBthw0jXBXyT\n topd7WlIMFXOCfc5Axz66vi5B2nFOPg5Xk8yUNYryGduRxfLWz871uIMOt2C8Xk04RZ2\n GwZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777024516; x=1777629316;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=e+of0FE0tSbmaf7cezfG/Dp70p8BpOoi594bsa5N30Y=;\n b=RK+xYj6ofn22374jNjfU+OEVyrIjfQvvksKVLHX1JD6oHtw4CLLDPdBFMCaC+8d8b0\n ONniYJYtS9I1fKPZYgoJC07Yj5BqYoUDLl/4zmBUSXGgsrZKxRNLVemFqUlRBoqgFa2U\n MVqOtjGTtaBRs1QWXAvroiBV44Rfw6XziZ63t60/7+6OP7sdxIz2RtvugGHEuuGdku4F\n 2rS1CWVJI0oCCdD8ld1bb+au5tp9nshzrKtTpmzy2Q+q6XFtvDy04H0uan7vjTkqpJMT\n ZzFv17bC1OKITx8iq0XNJK8zMmamCFhjmWxZNEnHLX1YhThAjQlExl7DHwl/vg+qBR2d\n 3dMA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9HtAXrNWRepuDPCi75kmi5HXjApcW3pMPzRTkEDcXyVy0wdJsS4G1LjuxiLx8jJMMbCxLtXgfd9lo=@vger.kernel.org","X-Gm-Message-State":"AOJu0YwtbWWd+c3jgp0udK7ZYKOmS3CEZrHDgYmSDksVF0r8+R+yrAPc\n\tdN61hNgTm/x8XPlNcH6u5Qok/TDgZ0XxCGvZIgAJfuXRMZXLgCbN5NopJ+X9IXa6Pco=","X-Gm-Gg":"AeBDievD3X4cTWZ0/o5Y1nPlY881mwKM2vQ7r0jhcdcg09A65MdrVfXiqGwSDuuHJ+T\n\t5U5H4745G69fkaOkdkbpRS+k4BpLtjrTCyYNbP1pA+YrUhsGavyGW4UGQZ/db3XexAriIno9t9k\n\tGLNUHknZF17KFdIHvwiaO+IA40d0iviLTzCvQ41UnKADMAVzXY7sMSRwCuisB0shPO3OPvXb4/5\n\tgJfrwCBz2l76nnsWlvFgr4LcT8HihBV99HxgYTmPCoabDztmw0xm7JIrcmNKvTGiuF3nOBkig48\n\t5T+177VrR2+ivW+WgP3upwjLeqQw7FVvzSAk9BeH7UaUeGIM3+gsPlqxChjHo4CeOykC7LD0MHw\n\tx31w8JWBaoFtXVj97UIF7cbARgWTX4OxtDrqWojXt277VxhKwce8900+mUZUcfkLuhmPbodLvoR\n\tiWzl77GtIFucalTQkckvydufRN2JTSfQ870xZR8w3ecpxyLV8+x4xMT5IPz63vWqYRi/2pPLqEY\n\t91iM7P6AWfcQjTHvw==","X-Received":"by 2002:a05:600c:888b:b0:488:c40b:c8bf with SMTP id\n 5b1f17b1804b1-488fb73d234mr372911565e9.2.1777024515945;\n Fri, 24 Apr 2026 02:55:15 -0700 (PDT)","Message-ID":"","Date":"Fri, 24 Apr 2026 11:55:14 +0200","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Neil Armstrong ","Reply-To":"Neil Armstrong ","Subject":"Re: [PATCH v4 3/8] mfd: khadas-mcu: Add per-variant configuration\n infrastructure and VIM4 support","To":"linux-kernel-dev@aliel.fr, Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org","References":"<20260421-add-mcu-fan-khadas-vim4-v4-0-447114a28f2d@aliel.fr>\n <20260421-add-mcu-fan-khadas-vim4-v4-3-447114a28f2d@aliel.fr>","Content-Language":"en-US, fr","Autocrypt":"addr=neil.armstrong@linaro.org; keydata=\n xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP\n GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4\n BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9\n qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik\n 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB\n AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA\n OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk\n Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04\n YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ\n GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw\n UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa\n GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r\n yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp\n QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+\n SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY\n 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM\n Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX\n oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn\n M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3\n 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS\n KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy\n 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT\n QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g","Organization":"Linaro","In-Reply-To":"<20260421-add-mcu-fan-khadas-vim4-v4-3-447114a28f2d@aliel.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]