[{"id":3681933,"web_url":"http://patchwork.ozlabs.org/comment/3681933/","msgid":"","list_archive_url":null,"date":"2026-04-24T10:00:44","subject":"Re: [PATCH v4 5/8] thermal: khadas-mcu-fan: Add fan config from\n platform data Add regulator support","submitter":{"id":84903,"url":"http://patchwork.ozlabs.org/api/people/84903/","name":"Neil Armstrong","email":"neil.armstrong@linaro.org"},"content":"On 4/21/26 13:49, Ronald Claveau via B4 Relay wrote:\n> From: Ronald Claveau \n> \n> Replace the hardcoded MAX_LEVEL constant and fan register\n> with values read from platform_data (fan_reg, max_level),\n> as new MCUs need different values.\n> \n> Optionally acquire and enable a \"fan\" regulator supply\n> at probe time and on resume,\n> so boards that gate fan power through a regulator are handled.\n> \n> Signed-off-by: Ronald Claveau \n> ---\n> drivers/thermal/khadas_mcu_fan.c | 49 +++++++++++++++++++++++++++++++++++-----\n> 1 file changed, 43 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c\n> index d35e5313bea41..24559bf65de46 100644\n> --- a/drivers/thermal/khadas_mcu_fan.c\n> +++ b/drivers/thermal/khadas_mcu_fan.c\n> @@ -13,13 +13,15 @@\n> #include \n> #include \n> #include \n> -\n> -#define MAX_LEVEL 3\n> +#include \n> \n> struct khadas_mcu_fan_ctx {\n> \tstruct khadas_mcu *mcu;\n> +\tunsigned int fan_reg;\n> \tunsigned int level;\n> +\tunsigned int max_level;\n> \tstruct thermal_cooling_device *cdev;\n> +\tstruct regulator *power;\n> };\n> \n> static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> {\n> \tint ret;\n> \n> -\tret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n> -\t\t\t level);\n> +\tret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level);\n> \tif (ret)\n> \t\treturn ret;\n> \n> @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev,\n> \t\t\t\t\tunsigned long *state)\n> {\n> -\t*state = MAX_LEVEL;\n> +\tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n> +\n> +\t*state = ctx->max_level;\n> \n> \treturn 0;\n> }\n> @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev,\n> {\n> \tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n> \n> -\tif (state > MAX_LEVEL)\n> +\tif (state > ctx->max_level)\n> \t\treturn -EINVAL;\n> \n> \tif (state == ctx->level)\n> @@ -83,11 +86,32 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)\n> \tstruct device *dev = &pdev->dev;\n> \tstruct khadas_mcu_fan_ctx *ctx;\n> \tint ret;\n> +\tconst struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev);\n\nMove this on top to respect reverse christmas ordering.\n\n> \n> \tctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);\n> \tif (!ctx)\n> \t\treturn -ENOMEM;\n> +\n> \tctx->mcu = mcu;\n> +\tctx->fan_reg = pdata->fan_reg;\n> +\tctx->max_level = pdata->max_level;\n> +\n> +\tctx->power = devm_regulator_get_optional(dev->parent, \"fan\");\n> +\tif (IS_ERR(ctx->power)) {\n> +\t\tif (PTR_ERR(ctx->power) == -ENODEV)\n> +\t\t\tctx->power = NULL;\n> +\t\telse\n> +\t\t\treturn PTR_ERR(ctx->power);\n> +\t}\n> +\n> +\tif (ctx->power) {\n> +\t\tret = regulator_enable(ctx->power);\n> +\t\tif (ret) {\n> +\t\t\tdev_err(dev, \"Failed to enable fan power supply: %d\\n\", ret);\n> +\t\t\treturn ret; \n> +\t\t}\n> +\t}\n\nOr you can request with devm_regulator_get(dev->parent, \"fan\"); which will\nreturn a dummy regulator, and then you can just call regulator_enable & disable\nand remove all those checks.\n\n> +\n> \tplatform_set_drvdata(pdev, ctx);\n> \n> \tcdev = devm_thermal_of_cooling_device_register(dev->parent,\n> @@ -124,12 +148,25 @@ static int khadas_mcu_fan_suspend(struct device *dev)\n> \n> \tctx->level = level_save;\n> \n> +\tif (ctx->power) {\n> +\t\tret = regulator_disable(ctx->power);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n\nif (ctx->power)\n\treturn regulator_disable(ctx->power);\n\n> +\n> \treturn 0;\n> }\n> \n> static int khadas_mcu_fan_resume(struct device *dev)\n> {\n> \tstruct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev);\n> +\tint ret;\n> +\n> +\tif (ctx->power) {\n> +\t\tret = regulator_enable(ctx->power);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> \n> \treturn khadas_mcu_fan_set_level(ctx, ctx->level);\n> }\n> \n\nThanks,\nNeil","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=dHlfl1vY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17160-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"dHlfl1vY\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.51","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linaro.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g27n80Tdhz1yDD\n\tfor ; Fri, 24 Apr 2026 20:02:52 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D53A5301A72E\n\tfor ; Fri, 24 Apr 2026 10:00:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1E2AB361662;\n\tFri, 24 Apr 2026 10:00:51 +0000 (UTC)","from mail-wm1-f51.google.com (mail-wm1-f51.google.com\n [209.85.128.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6043B1B4\n\tfor ; Fri, 24 Apr 2026 10:00:49 +0000 (UTC)","by mail-wm1-f51.google.com with SMTP id\n 5b1f17b1804b1-4891f625344so62885395e9.0\n for ; Fri, 24 Apr 2026 03:00:49 -0700 (PDT)","from ?IPV6:2a01:e0a:106d:1080:79e1:f56b:445c:ca9c?\n ([2a01:e0a:106d:1080:79e1:f56b:445c:ca9c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7a0b60sm169961765e9.17.2026.04.24.03.00.46\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 24 Apr 2026 03:00:47 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777024850; cv=none;\n b=TlCONL98Jf16oY27DYseh+pLnsvdK+Lk2RqhROLCL5HRuzq3srsbJccm+jUq5QB7Bspmv/FvAE41mdmHQuuQO15VFDxjyFZwz9d3C+P0/j8cAkVIr7l/GsK93nqHoLh4Gi5V1XyufFzb+zvMPoaQhyXfF9N43v2JEPLqBeJ/Ulw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777024850; c=relaxed/simple;\n\tbh=t9GpYR5T/MbOcfhkn+FQD5aargxAD0uAv82boDZ4aQ0=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=l5lIR31g5tPfY+RlLEHhUQN2Waix5JBVqdugCtFiFkg8WAreC97inbgiJjiBArPoJcbP9FPTMXBPUSjfZVURn14nJu5bAtSRG1UX1FyQi7U2aLfyZLI+/kG4Mw5kH5euKQ2NxbmXOE6933jWXKNHx9s7QJl+Xga7OuUo4SAn1+4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org;\n spf=pass smtp.mailfrom=linaro.org;\n dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=dHlfl1vY; arc=none smtp.client-ip=209.85.128.51","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777024848; x=1777629648;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to;\n bh=9cwRtmDAbT4Y+He6JfFqenlNmTZcScEAW3BnQ0sfKIA=;\n b=dHlfl1vYFONN8q0CI9JprHJtZgrZGJeqbjDPkotWso3sQREWeJ6VKPQXI2f1Qyqb3E\n 3aj/hDM754wQxfKTdcRoWB95yHbiCI6FubX4dKcne4pylr4DpZhZNcV5JuijP9u38xdH\n BukRjVP9w34g69ESj4GVmH1K3ggykFNVu7BlFife63RjkeBJ097DkE2FcbYBs0yj2bDw\n +26Z+FQW7upZkwPAXLv8Af4RzthYHFUUOU+5X494Jz93TGW5FcJ965/MTCbh0MvG/w4m\n qcByPen64cF3WWDWmm+hB8PMncVZ3d6aSusyYbSt5lA1ghf/ioO3PK/IXXL6WdOyBRUi\n tTaw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777024848; x=1777629648;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=9cwRtmDAbT4Y+He6JfFqenlNmTZcScEAW3BnQ0sfKIA=;\n b=MQIhl19XoYK+laQR2+oMx3QNGvEu95SkX1cGaxDdh3hrl4PbmDt1QuTVmKYO26NNuN\n sCN0p0pk7zTRINYA0qqdUD05zuHhAJ8Z70Q8NKHwiycTwCQKxlBWLThWGTeeVDgTVYrU\n CvUT1DG1xyULphnIxZLlkhWwbnGnj3wSRemGjUBif3UyF2l0qvZ+3mKiLyuatrx1seP7\n RO54wBg64fnlWtMja0GdEYwAwKUUkavqlaHHd7EAFVA+/iNdqA8/BUaSg6ijCdb1wxiq\n z3mdU1XPR3ul+G/nt2rzawkHoFNZ5BbQVo8soO3UpMlTzDrha1qdSOoPdms0c5bN3xgc\n JFfg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ89m0HniWc+yztNf1eFW6dpyzIKH8qSrcjWXYKxLlnMYt1ox0pRBAaBE7SadhWA84Ga8poW3ErnoKY=@vger.kernel.org","X-Gm-Message-State":"AOJu0YztfBzFVDv+YKYuWFi5or/IJG6WoPZFd3AR11Q/JTWtGNg+tH1a\n\tkpcPEK3WXfs02RUQnnZ5at7DlGMsZF9ZsRzKfMcsgvnYAzbsTwNeRoKhbvcIV+IAbHk=","X-Gm-Gg":"AeBDies1g25WVi6Py4vj+s9huKVhz3CeG7AKeBbcmnRN35+XWDOoHDiraSL9zUwD9mi\n\tTpUFxHWGixnXffPNNG56uASSFfHCDzpg8CcLkJMg3Ifd5QX0FrzdoPGZ1Q7LLvp/JRPptmE9YON\n\tuGiylpTAo6AFSzuv5w6I/s8xWGzijxhU5saw9f2GRFJliTYc3A6mQYslymhfTjHmmgbiyZxVMnH\n\t6Fl3nKmr061Q1qniGw4ZPVcnSOvNY19byl+joHHSYgGkAwPYnTiLBifs+wYAH4OPy1GVDyKg1Je\n\t9OqZc5KzBVtDWIfMzzd/aE1rnphfObsUin9u4V/OgWc/9gD0TlbZeoTMlrotR+60KTZ1ZUIF3JX\n\tdqwv+l3zCO8KnURF3ZaDN4cF5WAqlEpiIgz1UVTT/j0AuRXhudQTMMY64kTVgjKebl0Z4CQMNZJ\n\trsiB1PKjZ9rcDFp/fCY7bK06uEmwKXSN0WEpWW4/rB0b9gXwXWKw2o7TP5dfB3+Jl5Lq0zg1rfq\n\tGPpyWx5S8wlPO1AbJLELOZUQjuj","X-Received":"by 2002:a05:600c:1d05:b0:489:1baf:8c03 with SMTP id\n 5b1f17b1804b1-4891baf8d2cmr288416295e9.11.1777024847607;\n Fri, 24 Apr 2026 03:00:47 -0700 (PDT)","Message-ID":"","Date":"Fri, 24 Apr 2026 12:00:44 +0200","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Neil Armstrong ","Reply-To":"Neil Armstrong ","Subject":"Re: [PATCH v4 5/8] thermal: khadas-mcu-fan: Add fan config from\n platform data Add regulator support","To":"linux-kernel-dev@aliel.fr, Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org","References":"<20260421-add-mcu-fan-khadas-vim4-v4-0-447114a28f2d@aliel.fr>\n <20260421-add-mcu-fan-khadas-vim4-v4-5-447114a28f2d@aliel.fr>","Content-Language":"en-US, fr","Autocrypt":"addr=neil.armstrong@linaro.org; keydata=\n xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP\n GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4\n BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9\n qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik\n 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB\n AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA\n OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk\n Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04\n YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ\n GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw\n UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa\n GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r\n yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp\n QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+\n SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY\n 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM\n Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX\n oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn\n M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3\n 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS\n KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy\n 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT\n QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g","Organization":"Linaro","In-Reply-To":"<20260421-add-mcu-fan-khadas-vim4-v4-5-447114a28f2d@aliel.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]