[{"id":3681625,"web_url":"http://patchwork.ozlabs.org/comment/3681625/","msgid":"<20260423185530.GI900403@horms.kernel.org>","list_archive_url":null,"date":"2026-04-23T18:55:30","subject":"Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion:\n drop duplicate ether_addr_equal() test","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote:\n> This is just a simple cleanup fix. Commit 35a2443d0910f (\"iavf: Add\n> waiting for response from PF in set mac\") introduced a duplicate\n> ether_addr_equal() check, so the current code tests the new MAC twice\n> against the former MAC.\n> \n> Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b\n> (\"iavf: fix MAC address setting for VFs when filter is rejected\")\n> \n> Signed-off-by: Corinna Vinschen \n> Fixes: 35a2443d0910f (\"iavf: Add waiting for response from PF in set mac\")\n> Reviewed-by: Aleksandr Loktionov \n> ---\n> Added CC: stable@vger.kernel.org\n\nHi,\n\nThis feels more like a cleanup for net-next (without a Fixes tag)\nthan a fix for net. I'm missing where the bug is here.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ChTRmj/f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1lfQ0p3Wz1yDD\n\tfor ; Fri, 24 Apr 2026 04:55:41 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 60685821DC;\n\tThu, 23 Apr 2026 18:55:40 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6f8g92eYBLOq; Thu, 23 Apr 2026 18:55:39 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 94C30821D8;\n\tThu, 23 Apr 2026 18:55:39 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 7401E231\n for ; Thu, 23 Apr 2026 18:55:37 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 653B560F14\n for ; Thu, 23 Apr 2026 18:55:37 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QQc11UU8ahbP for ;\n Thu, 23 Apr 2026 18:55:36 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp3.osuosl.org (Postfix) with ESMTPS id B3FE960D77\n for ; Thu, 23 Apr 2026 18:55:36 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id F147360181;\n Thu, 23 Apr 2026 18:55:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 36726C2BCAF;\n Thu, 23 Apr 2026 18:55:33 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 94C30821D8","OpenDKIM Filter v2.11.0 smtp3.osuosl.org B3FE960D77"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776970539;\n\tbh=RAXpIeK+LhCKngTRYBotZcTm6p1Cp2JAdEiGgrCla4o=;\n\th=Date:From:To:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=ChTRmj/fnphn5yBUCYqbqQ0efF11yY/iDDpiaPUSP4pUKBjm5T4O8pY4d8QyafnNc\n\t syLpAV6r174+zHmLsj0E87HrzCZLdNhoKrtariy/sNBiQTL8oTzLOCZcv4pzF3f7Ci\n\t APBwf3KsixWMhyhZ8zummWfENMFUKgcDCvE4kHZicmmmFKdpsIqlL5acKuFZN4loj8\n\t MjXDZtzomf4cOJiYnE06KsDA42+MessjUquNYS0jngYBwg3iPizUdN2OBjrLz/3u3K\n\t I5Myq2gtxDTskDiC7yOK1FgHq8dSvy8R7fXWRplJ58Q9zmNYZbZEdYyRHE37BhdLrc\n\t SbRZV8dO32n3A==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org B3FE960D77","Date":"Thu, 23 Apr 2026 19:55:30 +0100","From":"Simon Horman ","To":"Corinna Vinschen ","Message-ID":"<20260423185530.GI900403@horms.kernel.org>","References":"\n \n <20260421111236.875379-1-vinschen@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421111236.875379-1-vinschen@redhat.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776970534;\n bh=4yoTlqQgbbVE28AVWHdC5lL1x5os8T5h1viP5QpkKlQ=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=lQ9yjLNhzeNgz5LnKP7c5B4CVVdkDK1FCMsDtp50OIQeKLf5otwlCPfWdgWSPycw/\n XTvQQiA9S+ZybzC9eqC7oQzsM81L7y6MNR7n4RHDo2QaO/5k9PX7EV1EEAok+xCXA+\n f3xysYpsbXmlJ00lhGseIfBYTZq0JzKgi7HG5BkJ5ydr9JUbYQPm6Gid/Hg6hSDHz5\n liAN2JVUnjU+EY4FBqBhoJoIltNPHvSjLCUCMvKUosbMN6Kk79SCWlApAasPYFpayE\n JUE8mai8Fd4DutEfbulAEx6LvAf6+32ED2XpeKNOTrex27dKq87SQDqapgCZUOuE1Y\n Qv/sCT2faOyhQ==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lQ9yjLNh"],"Subject":"Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion:\n drop duplicate ether_addr_equal() test","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"intel-wired-lan@osuosl.org, stable@vger.kernel.org,\n Jose Ignacio Tornos Martinez , netdev@vger.kernel.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3681877,"web_url":"http://patchwork.ozlabs.org/comment/3681877/","msgid":"","list_archive_url":null,"date":"2026-04-24T08:32:14","subject":"Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion:\n drop duplicate ether_addr_equal() test","submitter":{"id":7921,"url":"http://patchwork.ozlabs.org/api/people/7921/","name":"Corinna Vinschen","email":"vinschen@redhat.com"},"content":"On Apr 23 19:55, Simon Horman wrote:\n> On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote:\n> > This is just a simple cleanup fix. Commit 35a2443d0910f (\"iavf: Add\n> > waiting for response from PF in set mac\") introduced a duplicate\n> > ether_addr_equal() check, so the current code tests the new MAC twice\n> > against the former MAC.\n> > \n> > Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b\n> > (\"iavf: fix MAC address setting for VFs when filter is rejected\")\n> > \n> > Signed-off-by: Corinna Vinschen \n> > Fixes: 35a2443d0910f (\"iavf: Add waiting for response from PF in set mac\")\n> > Reviewed-by: Aleksandr Loktionov \n> > ---\n> > Added CC: stable@vger.kernel.org\n> \n> Hi,\n> \n> This feels more like a cleanup for net-next (without a Fixes tag)\n> than a fix for net. I'm missing where the bug is here.\n\nYeah, it's not a bug, the \"Fixes\" tag was just supposed to point out the\npatch introducing the duplicate test.\n\nShall I create a v3 or is it ok as is and just goes to net-next instead\nof net?\n\n\nThanks,\nCorinna","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=OYMuqsi9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g25n31p5tz1yDD\n\tfor ; Fri, 24 Apr 2026 18:32:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 35B7642360;\n\tFri, 24 Apr 2026 08:32:36 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Ze4KkldVHG_7; Fri, 24 Apr 2026 08:32:31 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B49B842367;\n\tFri, 24 Apr 2026 08:32:31 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 08EB2231\n for ; Fri, 24 Apr 2026 08:32:31 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id EED9242367\n for ; Fri, 24 Apr 2026 08:32:30 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id v1uEjz1HBCay for ;\n Fri, 24 Apr 2026 08:32:26 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 4246742360\n for ; Fri, 24 Apr 2026 08:32:24 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-ewUZX9sePIKYDg19RBQe5A-1; Fri,\n 24 Apr 2026 04:32:19 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EB87E1800578; Fri, 24 Apr 2026 08:32:17 +0000 (UTC)","from calimero.vinschen.de (unknown [10.44.32.45])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 68CDB19560AB; Fri, 24 Apr 2026 08:32:17 +0000 (UTC)","by calimero.vinschen.de (Postfix, from userid 500)\n id C0469A80BFD; Fri, 24 Apr 2026 10:32:14 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org B49B842367","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4246742360"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777019551;\n\tbh=VJsfL0ZYr6ksiH6VKINKLh9cflWXlJdEnCTwwmMW534=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=OYMuqsi9yX7sekg8bu7D5LdGocWxyuC/cxLXM2re4VHx37CoA/20hn8CIVuv4U1qv\n\t BJLonvABbkFooa3oO/r2nfpofe7ehqYV/wbd+P19FRKtA65dMzIG7558cDeHn7XPGU\n\t PsLyZQGIOXF+8ImHWshr4BsA2ZF6eI03+mfNC+jMzwZAfuFsbA17zcGN9MBR6aoOw6\n\t SKF/gg3XJLkgPVITLMpq67QoQKiX7LQjeb/i0n4MFVhx6Lbw+5S9S/hEiwhpusGNKc\n\t U3YcBfiroIe59hEVGXKHA3iYbdXGI3aZNW0HMUAnu2tnEsa9osVwV7eybO4n+GXtxp\n\t Wbtv7EQO0gOSQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=vinschen@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4246742360","X-MC-Unique":"ewUZX9sePIKYDg19RBQe5A-1","X-Mimecast-MFC-AGG-ID":"ewUZX9sePIKYDg19RBQe5A_1777019538","Date":"Fri, 24 Apr 2026 10:32:14 +0200","From":"Corinna Vinschen ","To":"Simon Horman ","Cc":"intel-wired-lan@osuosl.org, stable@vger.kernel.org,\n Jose Ignacio Tornos Martinez ,\n netdev@vger.kernel.org, Corinna Vinschen ","Message-ID":"","Mail-Followup-To":"Simon Horman ,\n intel-wired-lan@osuosl.org, stable@vger.kernel.org,\n Jose Ignacio Tornos Martinez ,\n netdev@vger.kernel.org","References":"\n \n <20260421111236.875379-1-vinschen@redhat.com>\n <20260423185530.GI900403@horms.kernel.org>","MIME-Version":"1.0","In-Reply-To":"<20260423185530.GI900403@horms.kernel.org>","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-MFC-PROC-ID":"ikc8P_SL9paTEYabDM3FOaJ4wMMZgf-gSrQfZSEAoCQ_1777019538","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1777019543;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=VJsfL0ZYr6ksiH6VKINKLh9cflWXlJdEnCTwwmMW534=;\n b=BguoAUtS9RwjeXVxIdyJ7uYL9emrpcDsP8J4JmAo6n2WAaNBSE5gYhN62lRykutzKGXcCN\n /FSjHQfXhFGRByWfrLEfc31W4/d7MWOlm/U5j09bxRqejXFKY9PFHSD8vj0A96PgYSPuDa\n yjNUFZm+tbGEYDgF1iOCgIFKmBrHhS4=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BguoAUtS"],"Subject":"Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion:\n drop duplicate ether_addr_equal() test","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]