[{"id":3681325,"web_url":"http://patchwork.ozlabs.org/comment/3681325/","msgid":"","list_archive_url":null,"date":"2026-04-23T08:21:54","subject":"Re: [PATCH] PCI/pwrctrl: Do not try to power on/off devices that\n don't need pwrctrl","submitter":{"id":92191,"url":"http://patchwork.ozlabs.org/api/people/92191/","name":"Bartosz Golaszewski","email":"brgl@kernel.org"},"content":"On Tue, 21 Apr 2026 12:41:01 +0200, Manivannan Sadhasivam\n said:\n> pci_pwrctrl_is_required() is used to detect whether a device really\n> needs the PCI pwrctrl support or not. It is currently used in\n> pci_pwrctrl_create_device(), but not in pci_pwrctrl_power_{on/off}_device()\n> APIs. This leads to pwrctrl core trying to power on/off the incompatible\n> devices like USB hub downstream ports defined in DT.\n>\n> Hence, add this check to prevent pwrctrl core from poking at wrong\n> devices. For this purpose, move the pci_pwrctrl_is_required() helper\n> definition to the top.\n>\n> Fixes: b35cf3b6aa1e (\"PCI/pwrctrl: Add APIs to power on/off pwrctrl devices\")\n> Reported-by: Krishna Chaitanya Chundru \n> Signed-off-by: Manivannan Sadhasivam \n> ---\n\nReviewed-by: Bartosz Golaszewski ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lz04aKBf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53038-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"lz04aKBf\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Tc569fLz1y2d\n\tfor ; Thu, 23 Apr 2026 18:22:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 8AB01301BA51\n\tfor ; Thu, 23 Apr 2026 08:22:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7B6AD3BED59;\n\tThu, 23 Apr 2026 08:21:57 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B533BED37\n\tfor ; Thu, 23 Apr 2026 08:21:57 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 08C79C4AF09\n\tfor ; Thu, 23 Apr 2026 08:21:57 +0000 (UTC)","by mail-lj1-f170.google.com with SMTP id\n 38308e7fff4ca-38a01c80c34so60716111fa.0\n for ; Thu, 23 Apr 2026 01:21:56 -0700 (PDT)","from 969154062570 named unknown by gmailapi.google.com with\n HTTPREST; Thu, 23 Apr 2026 04:21:54 -0400","from 969154062570 named unknown by gmailapi.google.com with\n HTTPREST; Thu, 23 Apr 2026 04:21:54 -0400"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776932517; cv=none;\n b=gDFomOsrqLKRiHrxUMgTTNkVK+kfIFCmWX43aqfqYHcnyoz4Sx65ZMiNn2SFiSejTr4sXe2wldhrOReO2l/JKeZ4fNwjlHdXMtzGm0dAAbk4bfpS5uiKkjrHIaInqaImiqQwINSYBAdo7qI7+r3GSVnVkvMacq6ChqP1tOAQ+LI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776932517; c=relaxed/simple;\n\tbh=fRPblbbwjt/HkZn1EoI5pPJ84BGUdl8hE7iW/86mfGE=;\n\th=From:In-Reply-To:MIME-Version:References:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=SgZhPf/7JkWvcmAYX5huTVaqktFagyKhzQa+YXCVBQboVegUMD0+slHMkltQehTEmeSGeLvDC3EKzIHA4nhz7OkjKhSxpLnPZeCsX2MzgHkt6i08bvyy0/zUZdbuSNd6gaMicstT0mgEDLwLOlb0H+2ZzVaJ7nxzUXakzclptlw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=lz04aKBf; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776932517;\n\tbh=fRPblbbwjt/HkZn1EoI5pPJ84BGUdl8hE7iW/86mfGE=;\n\th=From:In-Reply-To:References:Date:Subject:To:Cc:From;\n\tb=lz04aKBfg+8JqUzu1MNXdN6nJHx7swYtLHfliVAGAJu3+G1kxtkSX3h+OdiZseiL6\n\t MHuyV8KVw+2DdjsyxxCbNwihviZLvQKi4MDoyEbf7Bjb+JAvgZXKslUd0KpbW7MKCC\n\t Yj1fHMhw+/05/nAXLc4KqKS/xeHggwcplJshMffOrzMaqi7R/hL8DRQ6DBT+p4hAqL\n\t qq12LWC+X5f4Kp6y16J75FEdSs0sgWsxfMqn+azreFeKr+QY68MfPQ7rpDKMFLry+a\n\t bg+5ajtjgSO+FzLNbi8NS7y5sdgaSABZv8VzPjgIp/cuyAQAgHJa3a28ZKsvSyXrm/\n\t LUREad7wKbAdw==","X-Gm-Message-State":"AOJu0YwTUh9PhnnyJHaoH/BQznTKmrMy7P+6mJoplOpaJoH281EW5Y7p\n\tgitGz+nFIldx5CubmmSFYhZWg7dXP9SlK+yQnnim0lSlCsUkt18EWFvkvSUS5hF5w+Iel0wQ9Q4\n\t7suDRA63G9/poS8Gv+KkMct54y1LTD/imSEG2sL62SA==","X-Received":"by 2002:a05:6512:304d:b0:5a4:b02:66a2 with SMTP id\n 2adb3069b0e04-5a4172e1bd6mr9210840e87.27.1776932515490; Thu, 23 Apr 2026\n 01:21:55 -0700 (PDT)","From":"Bartosz Golaszewski ","In-Reply-To":"<20260421104102.12322-1-manivannan.sadhasivam@oss.qualcomm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260421104102.12322-1-manivannan.sadhasivam@oss.qualcomm.com>","Date":"Thu, 23 Apr 2026 04:21:54 -0400","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzCs3iVr5IY89wcTf5UqOOil4-CalTt1Oy-nWj2iK6EtAc4zRvrm-BQi4W4","Message-ID":"\n ","Subject":"Re: [PATCH] PCI/pwrctrl: Do not try to power on/off devices that\n don't need pwrctrl","To":"Manivannan Sadhasivam ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tKrishna Chaitanya Chundru ,\n brgl@kernel.org, bhelgaas@google.com","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":3682099,"web_url":"http://patchwork.ozlabs.org/comment/3682099/","msgid":"<20260424161501.GA12467@bhelgaas>","list_archive_url":null,"date":"2026-04-24T16:15:01","subject":"Re: [PATCH] PCI/pwrctrl: Do not try to power on/off devices that\n don't need pwrctrl","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Tue, Apr 21, 2026 at 04:11:01PM +0530, Manivannan Sadhasivam wrote:\n> pci_pwrctrl_is_required() is used to detect whether a device really\n> needs the PCI pwrctrl support or not. It is currently used in\n> pci_pwrctrl_create_device(), but not in pci_pwrctrl_power_{on/off}_device()\n> APIs. This leads to pwrctrl core trying to power on/off the incompatible\n> devices like USB hub downstream ports defined in DT.\n\nIs there a user-visible symptom when the pwrctrl core tries to power\non/off a device when it shouldn't?","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=onvmCjrh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53150-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"onvmCjrh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2J2j4cmGz1yD5\n\tfor ; Sat, 25 Apr 2026 02:15:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0E3F63006157\n\tfor ; Fri, 24 Apr 2026 16:15:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DDE223E121D;\n\tFri, 24 Apr 2026 16:15:03 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC583E1218;\n\tFri, 24 Apr 2026 16:15:03 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3358EC19425;\n\tFri, 24 Apr 2026 16:15:03 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777047303; cv=none;\n b=uPM/wlVNs9ueJ0aAXU6P6N67blDx9Qu3xo++IGf+b4cvTitSp1rjZeLhHianuR1wI243/3N81JRedWSI7rVUleFZ70th/wjlyoET22FrUPXRojpK2qOhmGARCNdcWkcIMVl+ZwttYBrHW3Ps3yzrmfvr2UHTopuF9hCzTKnbAis=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777047303; c=relaxed/simple;\n\tbh=gWymGpGpXq+21g7jwi5PjVdg5u08V4zYbpTysnnQlPc=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=qhbOEF4j3LJh9xunQZHzNI0A+1pNlK3bFE9z7cScuWV+F07uZvyvKtTVR+GrYpp3qummhF1c8M0T7KxIqY1BzMKyFWysUTPt3JQY2hLbEVjItRYGNz72uv6J/XG0mcjul0waUrojidyrGoTTSjcq5P0xvQwFJCE3UOKyiCD4IaY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=onvmCjrh; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777047303;\n\tbh=gWymGpGpXq+21g7jwi5PjVdg5u08V4zYbpTysnnQlPc=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=onvmCjrhRdvulbxsPIg7OL2L7izMUiw3X2ZZ9JyNrsUHXoCZzdcvM3CpJGwnJf1Zl\n\t +SbXa1kq7hCNufi2eMOlpDl1c9h+Oq8z2jpffQ2Mq23smxc0lNrzWtQzqbVQx6jmee\n\t qLFof/absvdyFiEZRL0t9jkhpxt/sHDbo0OpZNYyDKxowHJQXMrBqr0wHMubVMzP61\n\t llb5HHSmeFbDD9Jf2Iv7/ckaeaRWyhxW8wN5+5T3pCBnkaITR07QfEGSY5LiXGKawE\n\t cmndiKFvGuOwn+E1BnaMtlKcLFAxsu4tRbb4QXa0cyTeI/25XKqn6RQkihYyhVzzz0\n\t S5FVlBOOG+5lg==","Date":"Fri, 24 Apr 2026 11:15:01 -0500","From":"Bjorn Helgaas ","To":"Manivannan Sadhasivam ","Cc":"brgl@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tKrishna Chaitanya Chundru ","Subject":"Re: [PATCH] PCI/pwrctrl: Do not try to power on/off devices that\n don't need pwrctrl","Message-ID":"<20260424161501.GA12467@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421104102.12322-1-manivannan.sadhasivam@oss.qualcomm.com>"}}]