[{"id":3680187,"web_url":"http://patchwork.ozlabs.org/comment/3680187/","msgid":"<7vknnza4kjylf7djlykq5ytzyjvk3nsrhpn52bvnb33edzg6hb@ufrlygkis6o6>","list_archive_url":null,"date":"2026-04-22T01:52:23","subject":"Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4","submitter":{"id":90483,"url":"http://patchwork.ozlabs.org/api/people/90483/","name":"Dmitry Baryshkov","email":"dmitry.baryshkov@oss.qualcomm.com"},"content":"On Tue, Apr 21, 2026 at 11:45:14AM +0200, Alexandre MINETTE via B4 Relay wrote:\n> From: Alexandre MINETTE \n> \n> Add a device tree for the Samsung Galaxy S4, codenamed jflte.\n> \n> This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support\n> covers UART, USB peripheral mode with USB networking, the front LED and\n> the physical buttons.\n> \n> Signed-off-by: Alexandre MINETTE \n> ---\n> arch/arm/boot/dts/qcom/Makefile | 1 +\n> .../boot/dts/qcom/qcom-apq8064-samsung-jflte.dts | 484 +++++++++++++++++++++\n> 2 files changed, 485 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile\n> index 32a44b02d2fa..c23c961f79e3 100644\n> --- a/arch/arm/boot/dts/qcom/Makefile\n> +++ b/arch/arm/boot/dts/qcom/Makefile\n> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \\\n> \tqcom-apq8064-ifc6410.dtb \\\n> \tqcom-apq8064-sony-xperia-lagan-yuga.dtb \\\n> \tqcom-apq8064-asus-nexus7-flo.dtb \\\n> +\tqcom-apq8064-samsung-jflte.dtb \\\n> \tqcom-apq8064-lg-nexus4-mako.dtb \\\n> \tqcom-apq8074-dragonboard.dtb \\\n> \tqcom-ipq4018-ap120c-ac.dtb \\\n> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts b/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts\n> new file mode 100644\n> index 000000000000..9e5faf7c086f\n> --- /dev/null\n> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts\n> @@ -0,0 +1,484 @@\n> +// SPDX-License-Identifier: GPL-2.0-only\n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +#include \"qcom-apq8064-v2.0.dtsi\"\n> +#include \"pm8821.dtsi\"\n> +#include \"pm8921.dtsi\"\n> +\n> +/ {\n> +\tmodel = \"Samsung Galaxy S4 (jflte)\";\n> +\tcompatible = \"samsung,jflte\", \"qcom,apq8064\";\n> +\tchassis-type = \"handset\";\n> +\n> +\taliases {\n> +\t\tserial0 = &gsbi7_serial;\n> +\t};\n> +\n> +\tchosen {\n> +\t\tstdout-path = \"serial0:115200n8\";\n> +\t};\n> +\n> +\treserved-memory {\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <1>;\n> +\t\tranges;\n> +\n> +\t\tramoops@88d00000 {\n> +\t\t\tcompatible = \"ramoops\";\n> +\t\t\treg = <0x88d00000 0x100000>;\n> +\t\t\trecord-size = <0x20000>;\n> +\t\t\tconsole-size = <0x20000>;\n> +\t\t\tftrace-size = <0x20000>;\n> +\t\t};\n> +\t};\n> +\n> +\tgpio-keys {\n> +\t\tcompatible = \"gpio-keys\";\n> +\t\tpinctrl-names = \"default\";\n> +\t\tpinctrl-0 = <&gpio_keys_default>;\n> +\n> +\t\tkey-home {\n> +\t\t\tlabel = \"Home\";\n> +\t\t\tgpios = <&pm8921_gpio 30 GPIO_ACTIVE_LOW>;\n> +\t\t\tdebounce-interval = <5>;\n> +\t\t\tlinux,code = ;\n> +\t\t\twakeup-source;\n> +\t\t};\n> +\n> +\t\tkey-volume-up {\n> +\t\t\tlabel = \"Volume Up\";\n> +\t\t\tgpios = <&pm8921_gpio 35 GPIO_ACTIVE_LOW>;\n> +\t\t\tdebounce-interval = <5>;\n> +\t\t\tlinux,code = ;\n> +\t\t\twakeup-source;\n> +\t\t};\n> +\n> +\t\tkey-volume-down {\n> +\t\t\tlabel = \"Volume Down\";\n> +\t\t\tgpios = <&pm8921_gpio 37 GPIO_ACTIVE_LOW>;\n> +\t\t\tdebounce-interval = <5>;\n> +\t\t\tlinux,code = ;\n> +\t\t\twakeup-source;\n> +\t\t};\n> +\t};\n> +\n> +\ti2c-muic {\n> +\t\tcompatible = \"i2c-gpio\";\n> +\t\tsda-gpios = <&tlmm_pinmux 22 GPIO_ACTIVE_HIGH>;\n> +\t\tscl-gpios = <&tlmm_pinmux 23 GPIO_ACTIVE_HIGH>;\n> +\t\ti2c-gpio,delay-us = <2>;\n\n[...]\n\n> +\t};\n> +\n> +\ti2c-led {\n\ni2c-led should be before i2c-muic\n\n> +\t\tcompatible = \"i2c-gpio\";\n> +\t\tsda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;\n> +\t\tscl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;\n> +\t\ti2c-gpio,delay-us = <2>;\n\n[...]\n\n> +};\n> +","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=dBpf+8bf;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=MMDGhwsX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35336-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"dBpf+8bf\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"MMDGhwsX\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0j0b65hTz1yD5\n\tfor ; Wed, 22 Apr 2026 11:52:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 306773020D54\n\tfor ; Wed, 22 Apr 2026 01:52:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7C4F9305E3B;\n\tWed, 22 Apr 2026 01:52:33 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E692DCBFA\n\tfor ; Wed, 22 Apr 2026 01:52:31 +0000 (UTC)","from pps.filterd (m0279867.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63LIZk2l2000982\n\tfor ; Wed, 22 Apr 2026 01:52:31 GMT","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n [209.85.160.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenf96pv-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Wed, 22 Apr 2026 01:52:30 +0000 (GMT)","by mail-qt1-f198.google.com with SMTP id\n d75a77b69052e-50e575a50bcso38522291cf.0\n for ;\n Tue, 21 Apr 2026 18:52:30 -0700 (PDT)","from umbar.lan\n (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi.\n [2001:14ba:a073:af00:264b:feff:fe8b:be8a])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a4185c8a33sm4116785e87.36.2026.04.21.18.52.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 18:52:26 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776822753; cv=none;\n b=P3sNiIS8GfRLB2nXzylfJ8doH8uvyUnd3nI5VfJ0ULNmfMlBiMFSZMqkMwYTUqem2TMx6l2QdY6plSS5WU47qL0cDhP+yHQB7XZ86v8qjcCg6JKsbDUoiFM7g441zz49PqVEQt0mznJF25vkg1JIkhuKh22l/bYHf5a1mtQy/LA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776822753; c=relaxed/simple;\n\tbh=i2BoUeBiaBN5BhTYVusWVsTRIANEkj7qt4bG5qmvTfU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=IUQ9GZeKZjBz0jmEYZ04rwP9nMkBIsysu7XOrK0p+X6cS6AWIpWqW0kS4V64aw45b5FVlCLo1eQYUwkShEfYHaSEOt2MZpagrlSOMA3scousGdH6CBxI/3MQTSLheDMef09tCNhGKQm7StAU1aRF6cQqV/xfb8ibPPTmQP786zY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=dBpf+8bf;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=MMDGhwsX; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to; s=qcppdkim1; bh=C8AfVkpjz5uA/yuNgUlEQ8Vv\n\tm91nbKA2JeN2OZf9jbg=; b=dBpf+8bfQYwThnxsaLcGS9nW4PuPLP683Aj4Hbas\n\tD7BxH58zRTFaJ1ctDXswlDwgYKjhpYTV4jEQ410Vq7HV1kMVmTPCbUBTo4Menmih\n\tN30NGC/VMT2of57nM27ERCyW9WHXW5XscDdWtn3WcMyvBJTTfU5+dffrl4ZNO327\n\t1X+m9yU7Nc+eTmFUNxyU/9akomfYHKE1oyfR3fBTggB4X87CAhkwPSAXah0cfMjn\n\tSZQ8M9k23DNaCOX9WZF3/7hvQlz24lgJmLZe+52UY/TDQPdYi60K2ka/G1IVTXdp\n\tzNRyeWWdUw+aLWum+n35mo4+GPRLR+Q0hZEkebS1KZTmYw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776822750; x=1777427550;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=C8AfVkpjz5uA/yuNgUlEQ8Vvm91nbKA2JeN2OZf9jbg=;\n b=MMDGhwsXcvcetsk944+qSri2xCtPNxBF2L857psVhzn8pGzKifRCTqYxLGSmlkih1W\n +ebG8MobVGiladJfky62j85IQRQEqFTHouj35HhXEy2ajTmeioMRSz7BtMeyDosaO0JM\n 3At0rs4gEyK3o4ByeN8AkXia4k7d/P4NaXdH8iXbyQQqdIXCuj3mUjElxFo+J53D0lnt\n SOGYt3sYTH+mes3XDeGSHYcTK6Jj0t5/b0uOLOhffnbA0cJ9ccIDDzyr5uKRu+JfviPm\n W08wjuLIFVCtESqx7TSqVxZMkZe+7KRq35h51x2RUT4JiPObMGMLr5wS9eYg25WZXy4H\n IMMA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776822750; x=1777427550;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=C8AfVkpjz5uA/yuNgUlEQ8Vvm91nbKA2JeN2OZf9jbg=;\n b=BaU3bK1IcWVm0slSyR4TeEN+5f1dYIvS6gAogLLKhUDNH/+qpxrl/59APHoEGX6GBK\n BaUcL+xT2cbFODAC/PP9ceW4BwqrHZGRaEIovjZSSEwTi3DfNkN+X7HdWgTukGcwkn1F\n KfBFGIO2ApavqzEUSJa50HmvGsSbjPByRMPcFabJETeQjh1B7srrpa83jAWeW69DkxQU\n YJdJmAD72x3crs4Wn0yGUF+4Wn6gfziyw1X46Z9h/8pjEEDdUhLXErlhaU8sbcTJgT/x\n gy5/EU362SXuy8e3tzWW9G9KjLf2a8LGgaWpWi91tgPxCMAeNN/CjAE42/mG0ad6e3Cu\n knNA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+++BJJcnezgGnebpEr/wZjn6d8T92NZX4DG45HH05+jQiklVDeTFFlIn1Hb01d3sC42rnAD2m2hJFR@vger.kernel.org","X-Gm-Message-State":"AOJu0Ywt0RSdnYZdWeXBzHgIUpSMZ4Q7NKrkA099rX1YYow93hYY+7kH\n\te3yMok5RAR3NmUXBo3IcVBp1hzBoOdJo7gSyNGVpyIGTzdAe7IQbmc/im2XNH/T/FFrrI4EN5+b\n\t7Ptk7ZgCvbW0WFzL/B9q9GTxxtpGC8f3WSCEbQLm4bqpKJFo8Xagxi0bUeBriuJatJjMWbg03","X-Gm-Gg":"AeBDiet2946cdKFPSc6B3/LDqDcgeMjamrcQCBkVpxVcGbniLJiuZm0GC1u3txSq6FM\n\te3br6kCLgxeNbq2fcolvn/COP5wJ3Muhnf7eRikUL3Ka4ToU/AXNtCBnqO0BcKKmmqJxpLz63ZF\n\tEHhm6pMt/pME3fIMDeUQelZXW5GmCn3FHHBC+sZ8afvr8nKTOTkSHIWjstc/xgRtwROXRH/zKXO\n\tWtxC7+7TSTz4wQJDKD4KSz7yMh+AbjWh6Raz1DLlfZv6pTVWkP/lLDZCfkYQT/s6zxgJJ5w6p1Y\n\tvEKrdC4H9p2XrySa/MnvLQd+hQJItd1ywcR5SLl3T/ei1czosmwHZPGfg+KQ5Aj5oQ9o/zRHpW/\n\tmxLolCRpGJB6mc+w9EuZcuWVRjIWdKVVckaxevAhwGfnJVtFnTGO8xvRw2iYAg+xa4cU1EUxE/M\n\tpqAntj1HHmPJpxWx+evByX68BiXvRpXRWvZWS89xoIjla/pA==","X-Received":["by 2002:a05:622a:1b24:b0:50f:c26d:f31f with SMTP id\n d75a77b69052e-50fc26e284fmr4058021cf.19.1776822749550;\n Tue, 21 Apr 2026 18:52:29 -0700 (PDT)","by 2002:a05:622a:1b24:b0:50f:c26d:f31f with SMTP id\n d75a77b69052e-50fc26e284fmr4057751cf.19.1776822749072;\n Tue, 21 Apr 2026 18:52:29 -0700 (PDT)"],"Date":"Wed, 22 Apr 2026 04:52:23 +0300","From":"Dmitry Baryshkov ","To":"contact@alex-min.fr","Cc":"Bjorn Andersson ,\n Konrad Dybcio , Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley ,\n MyungJoo Ham ,\n Chanwoo Choi ,\n Guru Das Srinagesh ,\n Linus Walleij ,\n Rob Clark ,\n Joerg Roedel , Will Deacon ,\n Robin Murphy , Kees Cook ,\n Tony Luck ,\n \"Guilherme G. Piccoli\" ,\n linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n iommu@lists.linux.dev","Subject":"Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4","Message-ID":"<7vknnza4kjylf7djlykq5ytzyjvk3nsrhpn52bvnb33edzg6hb@ufrlygkis6o6>","References":"<20260421-mainline-send-v1-sending-v1-0-bcb0857724de@alex-min.fr>\n <20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr>","X-Proofpoint-ORIG-GUID":"qTl07NbzRUIXKa3OrnDX7PyD-RVDF50L","X-Authority-Analysis":"v=2.4 cv=fozsol4f c=1 sm=1 tr=0 ts=69e829df cx=c_pps\n a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=NUSM9a-ApLgp72EsCKoA:9\n a=CjuIK1q_8ugA:10 a=dawVfQjAaf238kedN5IG:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDAxNiBTYWx0ZWRfXwouO45+LxyXe\n ymjRJSDU+bHFrDWSZ1OIKEB8/gbDrqyfrT+40TPu3+WzdTTNMuYWYpWNndJgm0BxwObWUPm+/XG\n Uxi6XUOi1gff5QiYenENdx6w0o/TktX5fbsxZMjs88kUIsiedQiUCiX0AvF6+g78HvndcVnt1hN\n +4QwAeTYD+8A6tMCpwna/JRORoKei+A4hTfBVw/3QBQUtM93FZ5Aqpy3iaBZNo9e8MgEaagFS85\n 5+QbyjO/WGL/Gj7qHAr1lPjaBPjU2mUUXE4VE6YJnq/QTJewEGkP6Iu7PbC4vjV9k5cuz3dsSGS\n Lw1GMDcYrNrV4bcOYRqJ7Q3oaIMqpo9zOS1Umpn42Rl5BXKelCWTCDC3FiiOFiu2GuaXJ9l65FJ\n 5kQKXWcuIq1/9dBreIiX29OlNikAxEDJ/05NNb0UN3rzdDVADZpxRI5PNGCRIH4kwo7ixvV/1ii\n DukT2jM/s848/5/ojZA==","X-Proofpoint-GUID":"qTl07NbzRUIXKa3OrnDX7PyD-RVDF50L","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0\n spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220016"}},{"id":3681389,"web_url":"http://patchwork.ozlabs.org/comment/3681389/","msgid":"","list_archive_url":null,"date":"2026-04-23T11:36:33","subject":"Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4","submitter":{"id":89450,"url":"http://patchwork.ozlabs.org/api/people/89450/","name":"Konrad Dybcio","email":"konrad.dybcio@oss.qualcomm.com"},"content":"On 4/21/26 11:45 AM, Alexandre MINETTE via B4 Relay wrote:\n> From: Alexandre MINETTE \n> \n> Add a device tree for the Samsung Galaxy S4, codenamed jflte.\n> \n> This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support\n> covers UART, USB peripheral mode with USB networking, the front LED and\n> the physical buttons.\n> \n> Signed-off-by: Alexandre MINETTE \n> ---\n\n[...]\n\n> +\ti2c-muic {\n> +\t\tcompatible = \"i2c-gpio\";\n> +\t\tsda-gpios = <&tlmm_pinmux 22 GPIO_ACTIVE_HIGH>;\n> +\t\tscl-gpios = <&tlmm_pinmux 23 GPIO_ACTIVE_HIGH>;\n\nIs this not GSBI2?\n\n[...]\n\n> +\ti2c-led {\n> +\t\tcompatible = \"i2c-gpio\";\n> +\t\tsda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;\n> +\t\tscl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;\n\nLikewise, GSBI3\n\n[...]\n\n> +&riva {\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&riva_wlan_pin_a>, <&riva_bt_pin_a>, <&riva_fm_pin_a>;\n\npinctrl-n\npinctrl-names\n\nin this order please, file-wide\n\n[...]\n\n> +&usb1 {\n> +\tdr_mode = \"otg\";\n> +\textcon = <&muic>, <&usb_id>;\n> +\tstatus = \"okay\";\n\nNit: please keep a \\n before status\n\nlooks fairly good otherwise\n\nKonrad","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=ZgZfOxAj;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Eo5nJ0HJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35410-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"ZgZfOxAj\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"Eo5nJ0HJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1YwN2Vzbz1yCv\n\tfor ; Thu, 23 Apr 2026 21:37:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 32B0C3009804\n\tfor ; Thu, 23 Apr 2026 11:36:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 103FD2E8B8A;\n\tThu, 23 Apr 2026 11:36:43 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 942AE3E5581\n\tfor ; Thu, 23 Apr 2026 11:36:40 +0000 (UTC)","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63N8u4xo3769013\n\tfor ; Thu, 23 Apr 2026 11:36:39 GMT","from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n [209.85.222.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1hq3m63-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Thu, 23 Apr 2026 11:36:39 +0000 (GMT)","by mail-qk1-f199.google.com with SMTP id\n af79cd13be357-8edcc885cd3so89965885a.2\n for ;\n Thu, 23 Apr 2026 04:36:39 -0700 (PDT)","from [192.168.119.254] (078088045245.garwolin.vectranet.pl.\n [78.88.45.245])\n by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-ba455533bdfsm648444466b.57.2026.04.23.04.36.34\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 04:36:37 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776944202; cv=none;\n b=ZcdY6xEcZq8SaeZSrQJf/ia0hfRpWjG8eeaBxbK9PRP3yNxlSdc+xR8zLy9S4Qr3GCJpqmqOGePouxnPJNsiVhwF2ZbBVq9Wtkh8NFcWaX+u96hahoNb258XIc1Qni6/OKuOBpQWKL/NcZWmNxov8NqsSqrPqWDzkV3jat9Eza0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776944202; c=relaxed/simple;\n\tbh=ycCYcFDws687lzPHf4a7ZDQa8w8dkehTffSeJoBHKeY=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=qqL32PrDNcA9UnOwZ3MWHhx06uYDymlYURd448OhZ2Zx5Uw49NT1i61Js8eo1Dh3bJL2wnFmiEfNzWbuKyLr1pfzA00K8U0xEAOg24tUdeipZUubbbpJoksA7ztSy3BzUSU2dW6GIAK0ppGCwOJNKtZsVgJjSWbjwDPPE2hjoN4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=ZgZfOxAj;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=Eo5nJ0HJ; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tC4IVUQBFdsEG3fN5g34uqrFUD35jsuqyNZ/138Z4VVw=; b=ZgZfOxAjPxVx5KBz\n\tM4gXrD1z8OdjWaxuRMaot0/RjOdVU1RYD/dM1HTr//hRHN+xF3/na5P2y6mrg90e\n\tYwgldGzrmoeJgyfeEEzINXBV/Z20joUkbIBPMq66Y2vw30egfAKkzKnBTumdOjdy\n\tvd8ecnk/zxAHGM4aL9YtFLmwLQlY0KcEvqiw4rLF38LnKidn1MdjsJAu7pXTo+mG\n\tKPQ/c1VPaiGvpw7IlBi0ejPtjBKDVOqawKr28ODDmB2pJwXA+sn0DJUF3kDm0R15\n\tnwEob8lA+70+zFhOFMqpo9Z2JmrBx/FsE9wYYOGIg2mD1y/0HESSSRc7U3tELC/u\n\tzNkHPw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776944199; x=1777548999;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=C4IVUQBFdsEG3fN5g34uqrFUD35jsuqyNZ/138Z4VVw=;\n b=Eo5nJ0HJBKnHrOR/uinb0nAGPzCLDRy8cyNOZIMJ4p3Dsi0dzy/sYNTHcV1Jqv8SxV\n 3tapUhWzAfz5XkI2F/G8A4XWjeA7hE6J4lb6qdlsFUWX1MCd8evMQXp2mHX48tDoBWbJ\n 60bpVud79Sy4m+2odkpSl3xnwaR6Fgm5y1iF6+cg7I42MOei9eT5VN1FUtU/o1I2Fe67\n /+OXS6z90Mp7ZzDFQ03kncYs2oau4j5OI9FWf66/WsOHRtx8+jskLNUxTfLqiqy1BFGG\n Bk0VzVm3GHyvbmfCMECyHG3UTRZWiBOUM0YvCHLtCFT5hEcLk+iu64gehT6WsYgrb5vN\n 73pA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776944199; x=1777548999;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=C4IVUQBFdsEG3fN5g34uqrFUD35jsuqyNZ/138Z4VVw=;\n b=sWhRIlwRAY9KFfARFoDHRYIO0q318LdHFaVTOiQk8fj4UW3X5hZqOe3gPRtDObfdfC\n stLDJCnA42tQ+YvYUsv5u5aJeFmIXfveYy3HgOfvBEHIOKrO8QoPxlJyjRX8reMFCrZK\n wVxcgdMT2mriNFgUEUAwNOYKZ/l8RIrFQwYxE7Kn2KykOplXLkkUAx2IMt/sZx8XH/h9\n bZ4lrFfwFPDPKi7Xb5S9rGi9d+W+ME2uEMviEAXB02tw39mUmg2XHGy68UeyYogQ3Zj/\n bkoYaZ45DYkvVjaDSFyYTA2CpRLT6ZfQookgdGyisTtEJBbtDPNh6WY5qiw0jjfUVoQH\n nx/A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8IigUGYs0bq6vHIF8j3yHH3q2hbC6+V4RMH0s4NbR0cS8Yu0OVFZzZleiWWjeRJFvfijoKY7hrkeDT@vger.kernel.org","X-Gm-Message-State":"AOJu0Yx8/W9EWYtkddFL3MeLZO6MiaAWDKltDQEqlVGJ+02P6lgyNwNh\n\tqPTeSnC0tjiOZyNLN95gQ5FRq5LFDIXPVPtwIRJNjmu1dK3Kj8Eb+jsKljRm1U4uDoZofX6BQcU\n\t2rcPwd8sUqw1VAgEm6OUbNKAyDQVrt1uTPY/p6sBKTJTC3MEZ119138K6KqASoD98","X-Gm-Gg":"AeBDiesCVuLJWVy7+j3Zf1VaGenOcs0gVlM21FiryimU6TP4hMOXmNFgQcWJVSHAByQ\n\tE/E8Q+DU47U9HqjpZ5dmCyLfhoH+5Qi9/FEJu0YhOG07URM9iv254vHS7NaJVlqVLoGcD0nxSXB\n\tVtPSaaQmxKo3UdB+Wf2R2/yalpXchOy1rca5BbJVwuZR9x5UwSF81JPeTxsFiB1U2iHd8HXBym4\n\tRFN+VuYwbW45Vx3C+VAtr32tijghnAmpjwBaoAj0C0huIrUgrfiLMiSMXs55QWwjGQVZ0od47P9\n\tc784cdjSiql9stJahBIh9f//wnIoh+C6QesF+70Mcu91BC2lUA5mF4/vlk+BKH3P7tEys+KKhnz\n\tjWUDKwcL6Eocg5dT/oyjg1fT9s+UyhYQ2N8yW27hrV/HGqTLUMJ1cuwWCWd/6TaitKY26+KCZHH\n\tQubr7NzM3ESOFh2A==","X-Received":["by 2002:ac8:5d53:0:b0:50f:b9a6:82ae with SMTP id\n d75a77b69052e-50fb9a68ec7mr100777301cf.2.1776944198943;\n Thu, 23 Apr 2026 04:36:38 -0700 (PDT)","by 2002:ac8:5d53:0:b0:50f:b9a6:82ae with SMTP id\n d75a77b69052e-50fb9a68ec7mr100776841cf.2.1776944198503;\n Thu, 23 Apr 2026 04:36:38 -0700 (PDT)"],"Message-ID":"","Date":"Thu, 23 Apr 2026 13:36:33 +0200","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4","To":"contact@alex-min.fr, Bjorn Andersson ,\n Konrad Dybcio , Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley\n ,\n MyungJoo Ham ,\n Chanwoo Choi ,\n Guru Das Srinagesh\n ,\n Linus Walleij ,\n Rob Clark ,\n Joerg Roedel , Will Deacon ,\n Robin Murphy , Kees Cook ,\n Tony Luck ,\n \"Guilherme G. Piccoli\" ","Cc":"linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n iommu@lists.linux.dev","References":"<20260421-mainline-send-v1-sending-v1-0-bcb0857724de@alex-min.fr>\n <20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr>","Content-Language":"en-US","From":"Konrad Dybcio ","In-Reply-To":"<20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDExNSBTYWx0ZWRfX+oGqXNj3srnt\n qJ0dJtTMLhG5o7/axRh9ZDFDd6Lo0JXZySR9C6KlLfwx6NKkgte7IWzJU2x6dJWKbtMz42mF55+\n AECsda1zdJuCucNtE0Nqn0AAYyWNQqORFnMcMIWHfjHikRedhLljugmWt1TKBJjS5qjQsSfYiKs\n w3yWBCoGabqGz9ThQLwH9orz56gIFLET47LEBOY6qPfrH1lp84TDUto2qoV0e17yyNbAWfWrW2E\n gbm/w7L9jZZOYPJXWY+HxgWvTyxh/ijF5rPnHvhkf6BBjVlyyhI80vWtG4o9SD4uD7+u0fDotNF\n EJ1u/T+Y4Vl58FJ6oEWbdRrxr6RbseLNXaltkvonHI0hfM+LOUHwMw+P/kMnAGTZIvZT/4FCuZx\n XJTyON+MAam+65MklH9ol9wvexIoumGXLHALY2bdz6LnJLbft++Ygzbj0hYteYygu2GYcQp4a3l\n urLMclzJV8IhkaPU2Sw==","X-Proofpoint-ORIG-GUID":"aEpHcKXhzYzXLhq6yuLvPm_ZGpDDYDM2","X-Proofpoint-GUID":"aEpHcKXhzYzXLhq6yuLvPm_ZGpDDYDM2","X-Authority-Analysis":"v=2.4 cv=TJt1jVla c=1 sm=1 tr=0 ts=69ea0447 cx=c_pps\n a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22\n a=7luhnmdphBsOXQ2kz_0A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 clxscore=1015\n malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230115"}}]