[{"id":3680179,"web_url":"http://patchwork.ozlabs.org/comment/3680179/","msgid":"","list_archive_url":null,"date":"2026-04-22T01:45:45","subject":"Re: [PATCH 3/8] pinctrl: qcom: Register functions before enabling\n pinctrl","submitter":{"id":90483,"url":"http://patchwork.ozlabs.org/api/people/90483/","name":"Dmitry Baryshkov","email":"dmitry.baryshkov@oss.qualcomm.com"},"content":"On Tue, Apr 21, 2026 at 11:45:09AM +0200, Alexandre MINETTE via B4 Relay wrote:\n> From: Alexandre MINETTE \n> \n> Register Qualcomm pinctrl with devm_pinctrl_register_and_init() so pin\n> functions can be added before the pinctrl device is enabled.\n> \n> This lets pinmux_generic_add_pinfunction() populate the function list\n> before consumers request states during pinctrl_enable().\n\nWhy is this required? Could you please extend the commit message?\n\n> \n> Signed-off-by: Alexandre MINETTE \n> ---\n> drivers/pinctrl/qcom/pinctrl-msm.c | 15 ++++++++++-----\n> 1 file changed, 10 insertions(+), 5 deletions(-)\n> \n> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c\n> index 45b3a2763eb8..a2a1e0835735 100644\n> --- a/drivers/pinctrl/qcom/pinctrl-msm.c\n> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c\n> @@ -1593,11 +1593,11 @@ int msm_pinctrl_probe(struct platform_device *pdev,\n> \tpctrl->desc.pins = pctrl->soc->pins;\n> \tpctrl->desc.npins = pctrl->soc->npins;\n> \n> -\tpctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);\n> -\tif (IS_ERR(pctrl->pctrl)) {\n> -\t\tdev_err(&pdev->dev, \"Couldn't register pinctrl driver\\n\");\n> -\t\treturn PTR_ERR(pctrl->pctrl);\n> -\t}\n> +\tret = devm_pinctrl_register_and_init(&pdev->dev, &pctrl->desc,\n> +\t\t\t\t\t pctrl, &pctrl->pctrl);\n> +\tif (ret)\n> +\t\treturn dev_err_probe(&pdev->dev, ret,\n> +\t\t\t\t \"Couldn't register pinctrl driver\\n\");\n> \n> \tfor (i = 0; i < soc_data->nfunctions; i++) {\n> \t\tfunc = &soc_data->functions[i];\n> @@ -1607,6 +1607,11 @@ int msm_pinctrl_probe(struct platform_device *pdev,\n> \t\t\treturn ret;\n> \t}\n> \n> +\tret = pinctrl_enable(pctrl->pctrl);\n> +\tif (ret)\n> +\t\treturn dev_err_probe(&pdev->dev, ret,\n> +\t\t\t\t \"Couldn't enable pinctrl driver\\n\");\n> +\n> \tret = msm_gpio_init(pctrl);\n> \tif (ret)\n> \t\treturn ret;\n> \n> -- \n> 2.43.0\n> \n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=fX0/CtT7;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=R9vUAVeI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35332-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"fX0/CtT7\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"R9vUAVeI\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0hrq15GGz1y2d\n\tfor ; Wed, 22 Apr 2026 11:46:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id CFA45300F284\n\tfor ; Wed, 22 Apr 2026 01:45:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CB16C2E8DEB;\n\tWed, 22 Apr 2026 01:45:53 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E84672621\n\tfor ; Wed, 22 Apr 2026 01:45:52 +0000 (UTC)","from pps.filterd (m0279862.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63LIZs6l4051175\n\tfor ; Wed, 22 Apr 2026 01:45:51 GMT","from mail-vs1-f69.google.com (mail-vs1-f69.google.com\n [209.85.217.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfh68e-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Wed, 22 Apr 2026 01:45:51 +0000 (GMT)","by mail-vs1-f69.google.com with SMTP id\n ada2fe7eead31-60fdbcd749fso6481205137.0\n for ;\n Tue, 21 Apr 2026 18:45:51 -0700 (PDT)","from umbar.lan\n (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi.\n [2001:14ba:a073:af00:264b:feff:fe8b:be8a])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-38ecb4f51a7sm32980981fa.7.2026.04.21.18.45.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 18:45:48 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776822353; cv=none;\n b=U27fQE3VZDXnImMPbmgII/GXGIxdOvypAD7KYJyvokeevsgqo64aOo3O4htZ3EXjZOLAqj2yd1WNZ6sGel8ZRGkzyfdSXFqns6aVJ95Gvp36ZocjaWa7TWFTHSmT4x2XJqEzTUTp4pdKV2CqXwCOYyeDI1veOdQkUs4bI66vsCA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776822353; c=relaxed/simple;\n\tbh=WAELlRbfu9Q9ChOw2T9Dh9NZf+cQmOdSh1QOFmr3Lig=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=QSsn853AACoZzmKye9vLi3Uf/vCr0FU534qXuFgB6I1St7WjFJVcZXHC97hafP6HY1tUHFwQdHBZ1Y2iYrTeJDgXf+QQY5lQEr2UvFFuLmfkwmMV1js6QrJqmAcg+Ab1aRdLLQBhiDJeq3aTZSlqs/N+jR/qxnQih6DU7rOKc9g=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=fX0/CtT7;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=R9vUAVeI; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to; s=qcppdkim1; bh=5wHdqqn7SDS+5SZ20jG8Ptef\n\tE6PvolnfCH/vcLHZcaI=; b=fX0/CtT79Lf7McX0/JXcisYHIuPoYziwG/mSIRfA\n\tXEjvT0ia0LCX9MctirgK32TibQzWRVtk+qYMJL16lyXc1AjW61vJMXJShxXbiUKV\n\tuVZ/g9XJP6nId4Uyn8jm5swJq4XNnqJie1CUGayva1WuFux25XpeRyHICacVauvK\n\tCEoH2Im7Hq/AcB8h63ZtnvZc1BKfTrZpFZCt8hpgdIcOJH6DpxG1Sv4KZsaRfaM6\n\t1TgHwDtLN2vJ2zmWbWviDq5PaGI3+jg6d3kexdOFm+BDUA2eU50W8KPNXky0/xDp\n\tbBr2fvx/cN4Jhlq0ZmzzI8RTGRnfZ/k7UN3nicHhRAfBjA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776822351; x=1777427151;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=5wHdqqn7SDS+5SZ20jG8PtefE6PvolnfCH/vcLHZcaI=;\n b=R9vUAVeIJt/Yl4T7nxBtsFiu3yXMm0bLZXkG6X/VRQftd7uX7oaQie5MVvdZvoqIUy\n rwPtkPUPelPLaLAY+elg0f6PLWdyzV+bJT1lnn82dpr6bKfU82OzMj8K/1kRKMffeoo6\n V7voJWN1IHPzeCKbwR0uZQc0CMsSFiyhze5unx6SPw/tmDnTjkMX+Ql24ov9jj3kcClu\n 4pZ/5P1MO24Ugs+VCpuYt0/2t/2v92gink/YD9E1LV7rnRHODsZ6/82PZhCkn866Fyu2\n 2fWqrgzWbsNmvZje/7vEzERH/FgBYy4gs7ooy56W8RAYdBmVaf6NtbT9bPMWxFgXJf2u\n ASow=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776822351; x=1777427151;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=5wHdqqn7SDS+5SZ20jG8PtefE6PvolnfCH/vcLHZcaI=;\n b=rmEklUKv8p8RQdvHKUCx3W517rBYWyfxlPo9RmFWKLzdVrMErtZhZFnTa1+1xYIxNz\n AAGIyfObVoL5vvgbQzcQ4HKSMKKgDHhLgaYQzF0sOR6ceBISp2PHf2D3IyEPdtMzf2VO\n p42xJ3kwDJdYPHl3A3UWCLyBMlaKWtFSM3RuYpS6rjNTzMMBhFM8wEF+IWkvV4F89CdM\n KfLXaLdOvIbQYMW7Dhm2qeS58hrhpwRZl9AoxgEeIJSiL/aGlawyNjPVCgE5CFH1Klub\n K3KxvPwoa2OUC0KZQ9wXE4GQJJE7dCxWkz1dKw8y7og9oa07ktonmllaPaNNzJl5nAk7\n pyLQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/kUynhENlvShudTdEfm51CjoCn8tARhwIz9vWmtMEkwCJdpFV8+oxOtUW2Ze34R1IZO71qRO15Ee8F@vger.kernel.org","X-Gm-Message-State":"AOJu0Yzf6SavPFEklP/QOvyjG+j6dsvtvEIG9SBrQ5aGuDMWipQ39TT8\n\t/miOVvOW4ifdsLQJJEWbft60FG+r4STAyeroLRkUrxZbnBE8q8/4PxBAl9PNcsg7PFS+1oEJvz6\n\twfAqRBQlpk7Wcnh0tQLYuVo2eJV1g8leYONMLgWeJiqv9dQwiVYxt43wKvCqipIO8","X-Gm-Gg":"AeBDievhhfLULvBsNva0zRxh9rloC/yu3Cz4D1b7BC2zZA7+jsUJRSLb45hUvvPLreV\n\tq8IcEJB7K8rQrnAruV3YgZ6DBQVtsZqS5+nPEv7OsmYmksKLiP8RIKGdhAK6b9KqaukY2Joi8Af\n\tBcM+ldfpKb2oT+YtnoLRLzEsi2B79JpgAYP5WHPP2MH/lcjbmBwrTzoAxnsY/BRTChj/Ofpq8fx\n\tTpwiKFSOVTlcFMcd2ZQJNl8HV5hvSh8O+gj/tP6SWplTd0s2NsChwlxIRoaKNB7TdgV2PMR3XKJ\n\t74sheFGW3cl3NByyfCHtvvSjmVi+4m+MhSQg9BNkMhpLiyzhrmD795lMMgbFbg1pD8f3hLTR63F\n\tN9YCJVUiTGolOW4bReoyHGSMMcp74bqDsnUeKKW8cSH6n40MTTPUx6/WqqVuGBBqG/LgHaL2enf\n\t/movaGPsb23vauWwnabFrAtPsd3qbK/loKaySAS8GPGy9FKw==","X-Received":["by 2002:a05:6102:5716:b0:5f7:2568:abb2 with SMTP id\n ada2fe7eead31-616f4b4be78mr10249650137.6.1776822350782;\n Tue, 21 Apr 2026 18:45:50 -0700 (PDT)","by 2002:a05:6102:5716:b0:5f7:2568:abb2 with SMTP id\n ada2fe7eead31-616f4b4be78mr10249640137.6.1776822350339;\n Tue, 21 Apr 2026 18:45:50 -0700 (PDT)"],"Date":"Wed, 22 Apr 2026 04:45:45 +0300","From":"Dmitry Baryshkov ","To":"contact@alex-min.fr","Cc":"Bjorn Andersson ,\n Konrad Dybcio , Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley ,\n MyungJoo Ham ,\n Chanwoo Choi ,\n Guru Das Srinagesh ,\n Linus Walleij ,\n Rob Clark ,\n Joerg Roedel , Will Deacon ,\n Robin Murphy , Kees Cook ,\n Tony Luck ,\n \"Guilherme G. Piccoli\" ,\n linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n iommu@lists.linux.dev","Subject":"Re: [PATCH 3/8] pinctrl: qcom: Register functions before enabling\n pinctrl","Message-ID":"","References":"<20260421-mainline-send-v1-sending-v1-0-bcb0857724de@alex-min.fr>\n <20260421-mainline-send-v1-sending-v1-3-bcb0857724de@alex-min.fr>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421-mainline-send-v1-sending-v1-3-bcb0857724de@alex-min.fr>","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDAxNSBTYWx0ZWRfXxWyEsu5GtxqG\n o6vEY4wap8O5of1ToCR3tLeokyzNsQ2hoC/K1xCA1r5Jog8G5+3Y26I4ZDMl3BCS6q0pGHOfEKz\n 4+YrDVVGB+gxujBWnhB3wdoDVK3Yk7Ws9dZPso3KXS+m5TKsqGjdrn5EZJ/+liYIQFkVirCrMDo\n XicfEICmK2wZojYmrdDWj3PVnZFrHyo2pdMO4DZFDo9Hndwq7hqto2/gtFdokjqfAbfJtCK8cC2\n 1Lty5/V6rIdvc2j2DuuV/kdsK8iBG2L3jKloZcr39rzCmuzpvQtkigdKE7Le5LscAWXz5zKkUn3\n NjmA6TMvVYkNI7zSGPfQeYNSWfvhUBrJhcWTcGR7yE5uIoezVJFJyrkpT18SVwnTCv9UdLSzJWl\n A0ii6w4jwVIv83ZFmX9dLuEPOWvKxB1TXNQw3D+lpNY7vy99rH74YB0t1O5o95+NXAsHF8ywUyv\n z5uMge/48FYxFeHuu7Q==","X-Authority-Analysis":"v=2.4 cv=VMrtWdPX c=1 sm=1 tr=0 ts=69e8284f cx=c_pps\n a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=PRS8Z04pAEUxk0G-eYAA:9\n a=CjuIK1q_8ugA:10 a=O8hF6Hzn-FEA:10 a=gYDTvv6II1OnSo0itH1n:22","X-Proofpoint-GUID":"FRPzwWjvq-P1z8iL0-fbkWozLhGywbyg","X-Proofpoint-ORIG-GUID":"FRPzwWjvq-P1z8iL0-fbkWozLhGywbyg","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 malwarescore=0\n spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220015"}}]